libvirt/src/vbox
Eric Blake 2387aa26c1 maint: fix missing spaces in message
I got an off-list report about a bad diagnostic:
Target network card mac 52:54:00:49:07:ccdoes not match source 52:54:00:49:07:b8

True to form, I've added a syntax check rule to prevent it
from recurring, and found several other offenders.

* cfg.mk (sc_require_whitespace_in_translation): New rule.
* src/conf/domain_conf.c (virDomainNetDefCheckABIStability): Add
space.
* src/esx/esx_util.c (esxUtil_ParseUri): Likewise.
* src/qemu/qemu_command.c (qemuCollectPCIAddress): Likewise.
* src/qemu/qemu_driver.c (qemuDomainSetMetadata)
(qemuDomainGetMetadata): Likewise.
* src/qemu/qemu_hotplug.c (qemuDomainChangeNetBridge): Likewise.
* src/rpc/virnettlscontext.c
(virNetTLSContextCheckCertDNWhitelist): Likewise.
* src/vmware/vmware_driver.c (vmwareDomainResume): Likewise.
* src/vbox/vbox_tmpl.c (vboxDomainGetXMLDesc, vboxAttachDrives):
Avoid false negatives.
* tools/virsh-domain.c (info_save_image_dumpxml): Reword.
Based on a report by Luwen Su.
2012-09-12 11:55:29 -06:00
..
README
vbox_CAPI_v2_2.h
vbox_CAPI_v3_0.h
vbox_CAPI_v3_1.h
vbox_CAPI_v3_2.h
vbox_CAPI_v4_0.h vbox: Add support for VirtualBox 4.0 2010-12-28 00:18:46 +01:00
vbox_CAPI_v4_1.h vbox: Add support for VirtualBox 4.1 2011-10-29 21:26:57 +02:00
vbox_driver.c build: fix PROBE() usage of intptr_t 2012-08-09 15:40:42 -06:00
vbox_driver.h
vbox_glue.c Desert the FSF address in copyright 2012-07-23 10:50:50 +08:00
vbox_glue.h Desert the FSF address in copyright 2012-07-23 10:50:50 +08:00
vbox_MSCOMGlue.c Desert the FSF address in copyright 2012-07-23 10:50:50 +08:00
vbox_MSCOMGlue.h Desert the FSF address in copyright 2012-07-23 10:50:50 +08:00
vbox_tmpl.c maint: fix missing spaces in message 2012-09-12 11:55:29 -06:00
vbox_V2_2.c
vbox_V3_0.c
vbox_V3_1.c
vbox_V3_2.c
vbox_V4_0.c vbox: Add support for VirtualBox 4.0 2010-12-28 00:18:46 +01:00
vbox_V4_1.c vbox: Add support for VirtualBox 4.1 2011-10-29 21:26:57 +02:00
vbox_XPCOMCGlue.c Define DYNLIB_NAME on OpenBSD. 2012-09-06 15:26:44 +08:00
vbox_XPCOMCGlue.h vbox: Add support for VirtualBox 4.0 2010-12-28 00:18:46 +01:00

    Explanation about the how multi-version support
    for VirtualBox libvirt driver is implemented.

Since VirtualBox adds multiple new features for each release, it is but
natural that the C API which VirtualBox exposes is volatile across
versions and thus needs a good mechanism to handle multiple versions
during runtime. The solution was something like this:

Firstly the file structure is as below:

vbox_CAPI_v2_2.h
vbox_XPCOMCGlue.h
vbox_XPCOMCGlue.c
These files are C API/glue code files directly taken from the
VirtualBox OSE source and is needed for C API to work as expected.

vbox_driver.h
vbox_driver.c
These files have the main logic for registering the virtualbox driver
with libvirt.

vbox_V2_2.c
The file which has version dependent changes and includes the template
file for given below for all of its functionality.

vbox_tmpl.c
The file where all the real driver implementation code exists.

Now there would be a vbox_V*.c file (for eg: vbox_V2_2.c for V2.2) for
each major virtualbox version which would do some preprocessor magic
and include the template file (vbox_tmpl.c) in it for the functionality
it offers.