mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-28 19:41:16 +00:00
Commit id 'f1f68ca33' added code to remove the directory paths for auto-generated sockets, but that code could be called before the paths were created resulting in generating error messages from virFileDeleteTree indicating that the file doesn't exist. Rather than "enforce" all callers to make the non-NULL and existence checks, modify the virFileDeleteTree API to silently ignore NULL on input and non-existent directory trees.
251 lines
6.1 KiB
C
251 lines
6.1 KiB
C
/*
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Osier Yang <jyang@redhat.com>
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "virscsi.h"
|
|
#include "testutils.h"
|
|
#include "virlog.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
#define VIR_SCSI_DATA "/virscsidata"
|
|
|
|
VIR_LOG_INIT("tests.scsitest");
|
|
|
|
static const char *abs_top_srcdir;
|
|
static char *virscsi_prefix;
|
|
|
|
static int
|
|
test1(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
char *name = NULL;
|
|
int ret = -1;
|
|
|
|
if (!(name = virSCSIDeviceGetDevName(virscsi_prefix,
|
|
"scsi_host1", 0, 0, 0)))
|
|
return -1;
|
|
|
|
if (STRNEQ(name, "sdh"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
VIR_FREE(name);
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* Two test devices are used, one has address "0:0:0:0", the
|
|
* other has address "1:0:0:0", see "virscsidata/" for more
|
|
* details.
|
|
*/
|
|
static int
|
|
test2(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
virSCSIDeviceListPtr list = NULL;
|
|
virSCSIDevicePtr dev = NULL;
|
|
virSCSIDevicePtr dev1 = NULL;
|
|
bool free_dev = true;
|
|
bool free_dev1 = true;
|
|
virSCSIDevicePtr tmp = NULL;
|
|
char *sgname = NULL;
|
|
int ret = -1;
|
|
|
|
sgname = virSCSIDeviceGetSgName(virscsi_prefix,
|
|
"scsi_host1", 0, 0, 0);
|
|
|
|
if (!sgname || STRNEQ(sgname, "sg8"))
|
|
goto cleanup;
|
|
|
|
if (!(dev = virSCSIDeviceNew(virscsi_prefix, "scsi_host1",
|
|
0, 0, 0, false, true)))
|
|
goto cleanup;
|
|
|
|
if (STRNEQ_NULLABLE(virSCSIDeviceGetName(dev), "1:0:0:0") ||
|
|
virSCSIDeviceGetAdapter(dev) != 1 ||
|
|
virSCSIDeviceGetBus(dev) != 0 ||
|
|
virSCSIDeviceGetTarget(dev) != 0 ||
|
|
virSCSIDeviceGetUnit(dev) != 0 ||
|
|
virSCSIDeviceGetReadonly(dev) ||
|
|
!virSCSIDeviceGetShareable(dev))
|
|
goto cleanup;
|
|
|
|
if (!virSCSIDeviceIsAvailable(dev))
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceSetUsedBy(dev, "QEMU", "fc18") < 0)
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceIsAvailable(dev))
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceSetUsedBy(dev, "QEMU", "fc20") < 0)
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceIsAvailable(dev))
|
|
goto cleanup;
|
|
|
|
if (!(list = virSCSIDeviceListNew()))
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceListAdd(list, dev) < 0)
|
|
goto cleanup;
|
|
|
|
/* virSCSIDeviceListDispose will take care of freeing
|
|
* the device.
|
|
*/
|
|
free_dev = false;
|
|
|
|
if (!virSCSIDeviceListFind(list, dev))
|
|
goto cleanup;
|
|
|
|
virSCSIDeviceListDel(list, dev, "QEMU", "fc20");
|
|
|
|
if (!virSCSIDeviceListFind(list, dev))
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceIsAvailable(dev))
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceListCount(list) != 1)
|
|
goto cleanup;
|
|
|
|
if (!(dev1 = virSCSIDeviceNew(virscsi_prefix, "scsi_host0",
|
|
0, 0, 0, true, false)))
|
|
goto cleanup;
|
|
|
|
if (virSCSIDeviceListAdd(list, dev1) < 0)
|
|
goto cleanup;
|
|
|
|
/* virSCSIDeviceListDispose will take care of freeing
|
|
* the device.
|
|
*/
|
|
free_dev1 = false;
|
|
|
|
if (virSCSIDeviceListCount(list) != 2)
|
|
goto cleanup;
|
|
|
|
if (!(tmp = virSCSIDeviceListSteal(list, dev1)))
|
|
goto cleanup;
|
|
virSCSIDeviceFree(tmp);
|
|
|
|
if (virSCSIDeviceListCount(list) != 1)
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
VIR_FREE(sgname);
|
|
if (free_dev)
|
|
virSCSIDeviceFree(dev);
|
|
if (free_dev1)
|
|
virSCSIDeviceFree(dev1);
|
|
virObjectUnref(list);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
create_symlink(const char *tmpdir, const char *src_name, const char *dst_name)
|
|
{
|
|
int ret = -1;
|
|
char *src_path = NULL;
|
|
char *dst_path = NULL;
|
|
|
|
if (virAsprintf(&src_path, "%s/%s", virscsi_prefix, src_name) < 0)
|
|
goto cleanup;
|
|
|
|
if (virAsprintf(&dst_path, "%s/%s", tmpdir, dst_name) < 0)
|
|
goto cleanup;
|
|
|
|
if (symlink(src_path, dst_path) < 0) {
|
|
VIR_WARN("Failed to create symlink '%s' to '%s'", src_path, dst_path);
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
VIR_FREE(src_path);
|
|
VIR_FREE(dst_path);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
char *tmpdir = NULL;
|
|
char template[] = "/tmp/libvirt_XXXXXX";
|
|
|
|
abs_top_srcdir = getenv("abs_top_srcdir");
|
|
if (!abs_top_srcdir)
|
|
abs_top_srcdir = abs_srcdir "/..";
|
|
|
|
if (virAsprintf(&virscsi_prefix, "%s" VIR_SCSI_DATA, abs_srcdir) < 0) {
|
|
ret = -1;
|
|
goto cleanup;
|
|
}
|
|
|
|
tmpdir = mkdtemp(template);
|
|
|
|
if (tmpdir == NULL) {
|
|
VIR_WARN("Failed to create temporary directory");
|
|
ret = -1;
|
|
goto cleanup;
|
|
}
|
|
|
|
#define CREATE_SYMLINK(src_name, dst_name) \
|
|
do { \
|
|
if (create_symlink(tmpdir, src_name, dst_name) < 0) { \
|
|
ret = -1; \
|
|
goto cleanup; \
|
|
} \
|
|
} while (0)
|
|
|
|
CREATE_SYMLINK("0-0-0-0", "0:0:0:0");
|
|
CREATE_SYMLINK("1-0-0-0", "1:0:0:0");
|
|
CREATE_SYMLINK("sg0", "sg0");
|
|
CREATE_SYMLINK("sg8", "sg8");
|
|
|
|
VIR_FREE(virscsi_prefix);
|
|
|
|
if (VIR_STRDUP(virscsi_prefix, tmpdir) < 0) {
|
|
ret = -1;
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virtTestRun("test1", test1, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test2", test2, NULL) < 0)
|
|
ret = -1;
|
|
|
|
cleanup:
|
|
if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL)
|
|
virFileDeleteTree(tmpdir);
|
|
VIR_FREE(virscsi_prefix);
|
|
return ret;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|