passt/test/shutdown/passt_in_ns

# SPDX-License-Identifier: AGPL-3.0-or-later
#
# PASST - Plug A Simple Socket Transport
#  for qemu/UNIX domain socket mode
#
# PASTA - Pack A Subtle Tap Abstraction
#  for network namespace/tap device mode
#
# test/shutdown/passt_in_ns - Shut down passt and check exit code (will detect
#                             valgrind errors amongst others)
#
# Copyright (c) 2022 Red Hat GmbH
# Author: Stefano Brivio <sbrivio@redhat.com>

test	shutdown: exit code

nsout	PASST_PID cat passt.pid
ns	kill __PASST_PID__
sleep	1

pout	EXIT echo $?
check	[ "__EXIT__" = "0" ]
test, seccomp, Makefile: Switch to valgrind runs for passt functional tests Pass to seccomp.sh a list of additional syscalls valgrind needs as EXTRA_SYSCALLS in a new 'valgrind' make target, and add corresponding support in seccomp.sh itself. In test setup functions, start passt with valgrind, but not for performance tests. Add tests checking that valgrind exits without errors after all the other tests in the group are done. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2022-03-15 19:16:13 +00:00			`# SPDX-License-Identifier: AGPL-3.0-or-later`
			`#`
			`# PASST - Plug A Simple Socket Transport`
			`# for qemu/UNIX domain socket mode`
			`#`
			`# PASTA - Pack A Subtle Tap Abstraction`
			`# for network namespace/tap device mode`
			`#`
test: Rename slightly misleading "valgrind" tests The "valgrind" test cases are designed to pick up errors reported when passt is running under valgrind. But what it actually does is just kill the passt process, then see if it had a non-zero exit code. That means it will equally well pick up any other problems which caused passt to exit with an error status: either something detected within passt or as a result of passt being killed by an unexpected signal. The fact that the "valgrind" test is actually responsible for shutting down the passt process is non-obvious and can lead to problems when selectively running tests during debugging. Rename the "valgrind" tests to "shutdown" tests and run it regardless of whether we're using valgrind or not. This allows us to remove an ugly speacial case in the passt_in_ns teardown code. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 2022-08-18 06:13:55 +00:00			`# test/shutdown/passt_in_ns - Shut down passt and check exit code (will detect`
			`# valgrind errors amongst others)`
test, seccomp, Makefile: Switch to valgrind runs for passt functional tests Pass to seccomp.sh a list of additional syscalls valgrind needs as EXTRA_SYSCALLS in a new 'valgrind' make target, and add corresponding support in seccomp.sh itself. In test setup functions, start passt with valgrind, but not for performance tests. Add tests checking that valgrind exits without errors after all the other tests in the group are done. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2022-03-15 19:16:13 +00:00			`#`
			`# Copyright (c) 2022 Red Hat GmbH`
			`# Author: Stefano Brivio <sbrivio@redhat.com>`

test: Rename slightly misleading "valgrind" tests The "valgrind" test cases are designed to pick up errors reported when passt is running under valgrind. But what it actually does is just kill the passt process, then see if it had a non-zero exit code. That means it will equally well pick up any other problems which caused passt to exit with an error status: either something detected within passt or as a result of passt being killed by an unexpected signal. The fact that the "valgrind" test is actually responsible for shutting down the passt process is non-obvious and can lead to problems when selectively running tests during debugging. Rename the "valgrind" tests to "shutdown" tests and run it regardless of whether we're using valgrind or not. This allows us to remove an ugly speacial case in the passt_in_ns teardown code. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 2022-08-18 06:13:55 +00:00			`test shutdown: exit code`
test, seccomp, Makefile: Switch to valgrind runs for passt functional tests Pass to seccomp.sh a list of additional syscalls valgrind needs as EXTRA_SYSCALLS in a new 'valgrind' make target, and add corresponding support in seccomp.sh itself. In test setup functions, start passt with valgrind, but not for performance tests. Add tests checking that valgrind exits without errors after all the other tests in the group are done. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2022-03-15 19:16:13 +00:00
			`nsout PASST_PID cat passt.pid`
			`ns kill __PASST_PID__`
			`sleep 1`

test: Rename slightly misleading "valgrind" tests The "valgrind" test cases are designed to pick up errors reported when passt is running under valgrind. But what it actually does is just kill the passt process, then see if it had a non-zero exit code. That means it will equally well pick up any other problems which caused passt to exit with an error status: either something detected within passt or as a result of passt being killed by an unexpected signal. The fact that the "valgrind" test is actually responsible for shutting down the passt process is non-obvious and can lead to problems when selectively running tests during debugging. Rename the "valgrind" tests to "shutdown" tests and run it regardless of whether we're using valgrind or not. This allows us to remove an ugly speacial case in the passt_in_ns teardown code. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 2022-08-18 06:13:55 +00:00			`pout EXIT echo $?`
			`check [ "__EXIT__" = "0" ]`