passt: Relicense to GPL 2.0, or any later version
In practical terms, passt doesn't benefit from the additional
protection offered by the AGPL over the GPL, because it's not
suitable to be executed over a computer network.
Further, restricting the distribution under the version 3 of the GPL
wouldn't provide any practical advantage either, as long as the passt
codebase is concerned, and might cause unnecessary compatibility
dilemmas.
Change licensing terms to the GNU General Public License Version 2,
or any later version, with written permission from all current and
past contributors, namely: myself, David Gibson, Laine Stump, Andrea
Bolognani, Paul Holzinger, Richard W.M. Jones, Chris Kuhn, Florian
Weimer, Giuseppe Scrivano, Stefan Hajnoczi, and Vasiliy Ulyanov.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2023-04-05 18:11:44 +00:00
|
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
2021-10-19 10:43:28 +00:00
|
|
|
#
|
|
|
|
|
# PASST - Plug A Simple Socket Transport
|
|
|
|
|
# for qemu/UNIX domain socket mode
|
|
|
|
|
#
|
|
|
|
|
# PASTA - Pack A Subtle Tap Abstraction
|
|
|
|
|
# for network namespace/tap device mode
|
|
|
|
|
#
|
|
|
|
|
# Copyright (c) 2021 Red Hat GmbH
|
|
|
|
|
# Author: Stefano Brivio <sbrivio@redhat.com>
|
|
|
|
|
|
2022-10-10 08:35:47 +00:00
|
|
|
VERSION ?= $(shell git describe --tags HEAD 2>/dev/null || echo "unknown\ version")
|
|
|
|
|
|
2022-11-17 05:59:06 +00:00
|
|
|
# Does the target platform allow IPv4 connections to be handled via
|
|
|
|
|
# the IPv6 socket API? (Linux does)
|
|
|
|
|
DUAL_STACK_SOCKETS := 1
|
|
|
|
|
|
2023-03-15 09:08:47 +00:00
|
|
|
TARGET ?= $(shell $(CC) -dumpmachine)
|
2022-02-28 15:18:44 +00:00
|
|
|
# Get 'uname -m'-like architecture description for target
|
2022-09-26 10:43:45 +00:00
|
|
|
TARGET_ARCH := $(shell echo $(TARGET) | cut -f1 -d- | tr [A-Z] [a-z])
|
2022-09-23 09:56:30 +00:00
|
|
|
TARGET_ARCH := $(shell echo $(TARGET_ARCH) | sed 's/powerpc/ppc/')
|
2022-02-28 15:18:44 +00:00
|
|
|
|
2024-08-29 14:16:03 +00:00
|
|
|
# On some systems enabling optimization also enables source fortification,
|
|
|
|
|
# automagically. Do not override it.
|
|
|
|
|
FORTIFY_FLAG :=
|
|
|
|
|
ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > /dev/null; echo $$?),1)
|
|
|
|
|
FORTIFY_FLAG := -D_FORTIFY_SOURCE=2
|
|
|
|
|
endif
|
|
|
|
|
|
2023-10-13 04:50:29 +00:00
|
|
|
FLAGS := -Wall -Wextra -Wno-format-zero-length
|
|
|
|
|
FLAGS += -pedantic -std=c11 -D_XOPEN_SOURCE=700 -D_GNU_SOURCE
|
2024-08-29 14:16:03 +00:00
|
|
|
FLAGS += $(FORTIFY_FLAG) -O2 -pie -fPIE
|
Makefile: Allow define overrides by prepending, not appending, CFLAGS
If we append CFLAGS to the ones passed via command line (if any),
-D options we append will override -D options passed on command line
(if any).
For example, OpenSUSE build flags include -D_FORTIFY_SOURCE=3, and we
want to have -D_FORTIFY_SOURCE=2, if and only if not overridden. The
current behaviour implies we redefine _FORTIFY_SOURCE as 2, though.
Instead of appending CFLAGS, prepend them by adding all the default
build flags to another variable, a simply expanded one (defined with
:=), named FLAGS, and pass that *before* CFLAGS in targets, so that
defines from command line can override default flags.
Reported-by: Dario Faggioli <dfaggioli@suse.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Dario Faggioli <dfaggioli@suse.com>
2022-09-14 13:34:28 +00:00
|
|
|
FLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE)
|
2022-10-10 08:35:47 +00:00
|
|
|
FLAGS += -DVERSION=\"$(VERSION)\"
|
2022-11-17 05:59:06 +00:00
|
|
|
FLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS)
|
2020-07-13 20:55:46 +00:00
|
|
|
|
2024-02-28 11:25:20 +00:00
|
|
|
PASST_SRCS = arch.c arp.c checksum.c conf.c dhcp.c dhcpv6.c flow.c fwd.c \
|
2024-03-06 05:58:33 +00:00
|
|
|
icmp.c igmp.c inany.c iov.c ip.c isolation.c lineread.c log.c mld.c \
|
|
|
|
|
ndp.c netlink.c packet.c passt.c pasta.c pcap.c pif.c tap.c tcp.c \
|
2024-08-02 16:10:36 +00:00
|
|
|
tcp_buf.c tcp_splice.c udp.c udp_flow.c util.c
|
2022-06-14 05:12:21 +00:00
|
|
|
QRAP_SRCS = qrap.c
|
|
|
|
|
SRCS = $(PASST_SRCS) $(QRAP_SRCS)
|
|
|
|
|
|
2022-06-14 05:12:22 +00:00
|
|
|
MANPAGES = passt.1 pasta.1 qrap.1
|
|
|
|
|
|
2024-02-28 11:25:20 +00:00
|
|
|
PASST_HEADERS = arch.h arp.h checksum.h conf.h dhcp.h dhcpv6.h flow.h fwd.h \
|
2024-02-29 04:15:32 +00:00
|
|
|
flow_table.h icmp.h icmp_flow.h inany.h iov.h ip.h isolation.h \
|
|
|
|
|
lineread.h log.h ndp.h netlink.h packet.h passt.h pasta.h pcap.h pif.h \
|
2024-06-13 12:36:49 +00:00
|
|
|
siphash.h tap.h tcp.h tcp_buf.h tcp_conn.h tcp_internal.h tcp_splice.h \
|
2024-07-18 05:26:46 +00:00
|
|
|
udp.h udp_flow.h util.h
|
2022-09-14 13:49:32 +00:00
|
|
|
HEADERS = $(PASST_HEADERS) seccomp.h
|
2022-06-14 05:12:21 +00:00
|
|
|
|
2022-01-25 18:55:54 +00:00
|
|
|
C := \#include <sys/random.h>\nint main(){int a=getrandom(0, 0, 0);}
|
|
|
|
|
ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0)
|
Makefile: Allow define overrides by prepending, not appending, CFLAGS
If we append CFLAGS to the ones passed via command line (if any),
-D options we append will override -D options passed on command line
(if any).
For example, OpenSUSE build flags include -D_FORTIFY_SOURCE=3, and we
want to have -D_FORTIFY_SOURCE=2, if and only if not overridden. The
current behaviour implies we redefine _FORTIFY_SOURCE as 2, though.
Instead of appending CFLAGS, prepend them by adding all the default
build flags to another variable, a simply expanded one (defined with
:=), named FLAGS, and pass that *before* CFLAGS in targets, so that
defines from command line can override default flags.
Reported-by: Dario Faggioli <dfaggioli@suse.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Dario Faggioli <dfaggioli@suse.com>
2022-09-14 13:34:28 +00:00
|
|
|
FLAGS += -DHAS_GETRANDOM
|
2022-01-25 18:55:54 +00:00
|
|
|
endif
|
|
|
|
|
|
2022-06-14 05:12:25 +00:00
|
|
|
ifeq ($(shell :|$(CC) -fstack-protector-strong -S -xc - -o - >/dev/null 2>&1; echo $$?),0)
|
Makefile: Allow define overrides by prepending, not appending, CFLAGS
If we append CFLAGS to the ones passed via command line (if any),
-D options we append will override -D options passed on command line
(if any).
For example, OpenSUSE build flags include -D_FORTIFY_SOURCE=3, and we
want to have -D_FORTIFY_SOURCE=2, if and only if not overridden. The
current behaviour implies we redefine _FORTIFY_SOURCE as 2, though.
Instead of appending CFLAGS, prepend them by adding all the default
build flags to another variable, a simply expanded one (defined with
:=), named FLAGS, and pass that *before* CFLAGS in targets, so that
defines from command line can override default flags.
Reported-by: Dario Faggioli <dfaggioli@suse.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Dario Faggioli <dfaggioli@suse.com>
2022-09-14 13:34:28 +00:00
|
|
|
FLAGS += -fstack-protector-strong
|
2022-03-15 17:14:53 +00:00
|
|
|
endif
|
|
|
|
|
|
2023-02-03 15:09:34 +00:00
|
|
|
C := \#define _GNU_SOURCE\n\#include <fcntl.h>\nint x = FALLOC_FL_COLLAPSE_RANGE;
|
2022-10-06 12:51:04 +00:00
|
|
|
ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0)
|
|
|
|
|
EXTRA_SYSCALLS += fallocate
|
|
|
|
|
endif
|
|
|
|
|
|
2022-08-21 09:23:54 +00:00
|
|
|
prefix ?= /usr/local
|
|
|
|
|
exec_prefix ?= $(prefix)
|
|
|
|
|
bindir ?= $(exec_prefix)/bin
|
|
|
|
|
datarootdir ?= $(prefix)/share
|
|
|
|
|
docdir ?= $(datarootdir)/doc/passt
|
|
|
|
|
mandir ?= $(datarootdir)/man
|
|
|
|
|
man1dir ?= $(mandir)/man1
|
2021-08-19 18:23:04 +00:00
|
|
|
|
2022-09-23 09:56:30 +00:00
|
|
|
ifeq ($(TARGET_ARCH),x86_64)
|
2022-02-28 15:18:44 +00:00
|
|
|
BIN := passt passt.avx2 pasta pasta.avx2 qrap
|
|
|
|
|
else
|
|
|
|
|
BIN := passt pasta qrap
|
|
|
|
|
endif
|
2021-07-26 05:18:50 +00:00
|
|
|
|
2023-07-10 04:33:44 +00:00
|
|
|
all: $(BIN) $(MANPAGES) docs
|
2022-06-14 05:12:22 +00:00
|
|
|
|
Makefile: Allow define overrides by prepending, not appending, CFLAGS
If we append CFLAGS to the ones passed via command line (if any),
-D options we append will override -D options passed on command line
(if any).
For example, OpenSUSE build flags include -D_FORTIFY_SOURCE=3, and we
want to have -D_FORTIFY_SOURCE=2, if and only if not overridden. The
current behaviour implies we redefine _FORTIFY_SOURCE as 2, though.
Instead of appending CFLAGS, prepend them by adding all the default
build flags to another variable, a simply expanded one (defined with
:=), named FLAGS, and pass that *before* CFLAGS in targets, so that
defines from command line can override default flags.
Reported-by: Dario Faggioli <dfaggioli@suse.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Dario Faggioli <dfaggioli@suse.com>
2022-09-14 13:34:28 +00:00
|
|
|
static: FLAGS += -static -DGLIBC_NO_STATIC_NSS
|
2023-07-10 04:33:44 +00:00
|
|
|
static: clean all
|
2021-07-26 05:18:50 +00:00
|
|
|
|
2022-09-28 04:33:33 +00:00
|
|
|
seccomp.h: seccomp.sh $(PASST_SRCS) $(PASST_HEADERS)
|
2023-02-27 23:53:01 +00:00
|
|
|
@ EXTRA_SYSCALLS="$(EXTRA_SYSCALLS)" ARCH="$(TARGET_ARCH)" CC="$(CC)" ./seccomp.sh $(PASST_SRCS) $(PASST_HEADERS)
|
2021-10-13 20:25:03 +00:00
|
|
|
|
2023-07-10 04:33:44 +00:00
|
|
|
passt: $(PASST_SRCS) $(HEADERS)
|
|
|
|
|
$(CC) $(FLAGS) $(CFLAGS) $(CPPFLAGS) $(PASST_SRCS) -o passt $(LDFLAGS)
|
2020-07-13 20:55:46 +00:00
|
|
|
|
2023-07-10 04:33:44 +00:00
|
|
|
passt.avx2: FLAGS += -Ofast -mavx2 -ftree-vectorize -funroll-loops
|
|
|
|
|
passt.avx2: $(PASST_SRCS) $(HEADERS)
|
|
|
|
|
$(CC) $(filter-out -O2,$(FLAGS)) $(CFLAGS) $(CPPFLAGS) \
|
|
|
|
|
$(PASST_SRCS) -o passt.avx2 $(LDFLAGS)
|
2022-02-28 15:18:44 +00:00
|
|
|
|
2023-07-10 04:33:44 +00:00
|
|
|
passt.avx2: passt
|
2022-02-28 15:18:44 +00:00
|
|
|
|
2022-06-14 05:12:23 +00:00
|
|
|
pasta.avx2 pasta.1 pasta: pasta%: passt%
|
2022-11-17 18:49:32 +00:00
|
|
|
ln -sf $< $@
|
passt: Add PASTA mode, major rework
PASTA (Pack A Subtle Tap Abstraction) provides quasi-native host
connectivity to an otherwise disconnected, unprivileged network
and user namespace, similarly to slirp4netns. Given that the
implementation is largely overlapping with PASST, no separate binary
is built: 'pasta' (and 'passt4netns' for clarity) both link to
'passt', and the mode of operation is selected depending on how the
binary is invoked. Usage example:
$ unshare -rUn
# echo $$
1871759
$ ./pasta 1871759 # From another terminal
# udhcpc -i pasta0 2>/dev/null
# ping -c1 pasta.pizza
PING pasta.pizza (64.190.62.111) 56(84) bytes of data.
64 bytes from 64.190.62.111 (64.190.62.111): icmp_seq=1 ttl=255 time=34.6 ms
--- pasta.pizza ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 34.575/34.575/34.575/0.000 ms
# ping -c1 spaghetti.pizza
PING spaghetti.pizza(2606:4700:3034::6815:147a (2606:4700:3034::6815:147a)) 56 data bytes
64 bytes from 2606:4700:3034::6815:147a (2606:4700:3034::6815:147a): icmp_seq=1 ttl=255 time=29.0 ms
--- spaghetti.pizza ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 28.967/28.967/28.967/0.000 ms
This entails a major rework, especially with regard to the storage of
tracked connections and to the semantics of epoll(7) references.
Indexing TCP and UDP bindings merely by socket proved to be
inflexible and unsuitable to handle different connection flows: pasta
also provides Layer-2 to Layer-2 socket mapping between init and a
separate namespace for local connections, using a pair of splice()
system calls for TCP, and a recvmmsg()/sendmmsg() pair for UDP local
bindings. For instance, building on the previous example:
# ip link set dev lo up
# iperf3 -s
$ iperf3 -c ::1 -Z -w 32M -l 1024k -P2 | tail -n4
[SUM] 0.00-10.00 sec 52.3 GBytes 44.9 Gbits/sec 283 sender
[SUM] 0.00-10.43 sec 52.3 GBytes 43.1 Gbits/sec receiver
iperf Done.
epoll(7) references now include a generic part in order to
demultiplex data to the relevant protocol handler, using 24
bits for the socket number, and an opaque portion reserved for
usage by the single protocol handlers, in order to track sockets
back to corresponding connections and bindings.
A number of fixes pertaining to TCP state machine and congestion
window handling are also included here.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2021-07-17 06:34:53 +00:00
|
|
|
|
2023-07-10 04:33:44 +00:00
|
|
|
qrap: $(QRAP_SRCS) passt.h
|
2024-11-05 23:25:25 +00:00
|
|
|
$(CC) $(FLAGS) $(CFLAGS) $(CPPFLAGS) -DARCH=\"$(TARGET_ARCH)\" $(QRAP_SRCS) -o qrap $(LDFLAGS)
|
2020-07-17 23:02:39 +00:00
|
|
|
|
2022-10-06 12:51:04 +00:00
|
|
|
valgrind: EXTRA_SYSCALLS += rt_sigprocmask rt_sigtimedwait rt_sigaction \
|
2024-07-18 05:26:49 +00:00
|
|
|
rt_sigreturn getpid gettid kill clock_gettime mmap \
|
treewide: Allow additional system calls for i386/i686
I haven't tested i386 for a long time (after playing with some
openSUSE i586 image a couple of years ago). It turns out that a number
of system calls we actually need were denied by the seccomp filter,
and not even basic functionality works.
Add some system calls that glibc started using with the 64-bit time
("t64") transition, see also:
https://wiki.debian.org/ReleaseGoals/64bit-time
that is: clock_gettime64, timerfd_gettime64, fcntl64, and
recvmmsg_time64.
Add further system calls that are needed regardless of time_t width,
that is, mmap2 (valgrind profile only), _llseek and sigreturn (common
outside x86_64), and socketcall (same as s390x).
I validated this against an almost full run of the test suite, with
just a few selected tests skipped. Fixes needed to run most tests on
i386/i686, and other assorted fixes for tests, are included in
upcoming patches.
Reported-by: Uroš Knupleš <uros@knuples.net>
Analysed-by: Faidon Liambotis <paravoid@debian.org>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078981
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
2024-08-19 21:42:30 +00:00
|
|
|
mmap2 munmap open unlink gettimeofday futex
|
2023-11-16 09:15:59 +00:00
|
|
|
valgrind: FLAGS += -g -DVALGRIND
|
2022-03-15 19:16:13 +00:00
|
|
|
valgrind: all
|
|
|
|
|
|
2020-07-13 20:55:46 +00:00
|
|
|
.PHONY: clean
|
|
|
|
|
clean:
|
2022-11-17 18:49:33 +00:00
|
|
|
$(RM) $(BIN) *~ *.o seccomp.h pasta.1 \
|
2022-07-06 07:29:02 +00:00
|
|
|
passt.tar passt.tar.gz *.deb *.rpm \
|
2022-08-09 22:21:09 +00:00
|
|
|
passt.pid README.plain.md
|
2021-08-19 18:23:04 +00:00
|
|
|
|
2022-08-09 22:21:09 +00:00
|
|
|
install: $(BIN) $(MANPAGES) docs
|
2022-08-21 09:23:54 +00:00
|
|
|
mkdir -p $(DESTDIR)$(bindir) $(DESTDIR)$(man1dir)
|
|
|
|
|
cp -d $(BIN) $(DESTDIR)$(bindir)
|
|
|
|
|
cp -d $(MANPAGES) $(DESTDIR)$(man1dir)
|
|
|
|
|
mkdir -p $(DESTDIR)$(docdir)
|
|
|
|
|
cp -d README.plain.md $(DESTDIR)$(docdir)/README.md
|
|
|
|
|
cp -d doc/demo.sh $(DESTDIR)$(docdir)
|
2021-08-19 18:23:04 +00:00
|
|
|
|
|
|
|
|
uninstall:
|
2022-06-14 05:12:24 +00:00
|
|
|
$(RM) $(BIN:%=$(DESTDIR)$(prefix)/bin/%)
|
2022-08-21 09:23:54 +00:00
|
|
|
$(RM) $(MANPAGES:%=$(DESTDIR)$(man1dir)/%)
|
|
|
|
|
$(RM) $(DESTDIR)$(docdir)/README.md
|
|
|
|
|
$(RM) $(DESTDIR)$(docdir)/demo.sh
|
|
|
|
|
-rmdir $(DESTDIR)$(docdir)
|
2021-08-19 23:11:57 +00:00
|
|
|
|
2022-03-01 20:41:22 +00:00
|
|
|
pkgs: static
|
2022-02-28 15:18:44 +00:00
|
|
|
tar cf passt.tar -P --xform 's//\/usr\/bin\//' $(BIN)
|
2021-08-19 23:11:57 +00:00
|
|
|
tar rf passt.tar -P --xform 's//\/usr\/share\/man\/man1\//' \
|
2022-06-14 05:12:22 +00:00
|
|
|
$(MANPAGES)
|
2021-08-19 23:11:57 +00:00
|
|
|
gzip passt.tar
|
|
|
|
|
EMAIL="sbrivio@redhat.com" fakeroot alien --to-deb \
|
|
|
|
|
--description="User-mode networking for VMs and namespaces" \
|
|
|
|
|
-k --version=$(shell git rev-parse --short HEAD) \
|
|
|
|
|
passt.tar.gz
|
|
|
|
|
fakeroot alien --to-rpm --target=$(shell uname -m) \
|
|
|
|
|
--description="User-mode networking for VMs and namespaces" \
|
|
|
|
|
-k --version=g$(shell git rev-parse --short HEAD) passt.tar.gz
|
2021-10-19 22:05:11 +00:00
|
|
|
|
2022-08-09 22:21:09 +00:00
|
|
|
# TODO: This hack makes a "plain" Markdown version of README.md that can be
|
|
|
|
|
# reasonably shipped as documentation file, while the current README.md is
|
|
|
|
|
# definitely intended for web browser consumption. It should probably work the
|
|
|
|
|
# other way around: the web version should be obtained by adding HTML and
|
|
|
|
|
# JavaScript portions to a plain Markdown, instead. However, cgit needs to use
|
|
|
|
|
# a file in the git tree. Find a better way around this.
|
2023-07-10 04:33:44 +00:00
|
|
|
docs: README.md
|
|
|
|
|
@( \
|
|
|
|
|
skip=0; \
|
|
|
|
|
while read l; do \
|
|
|
|
|
case $$l in \
|
|
|
|
|
"## Demo") exit 0 ;; \
|
|
|
|
|
"<!"*) ;; \
|
|
|
|
|
"</"*) skip=1 ;; \
|
|
|
|
|
"<"*) skip=2 ;; \
|
|
|
|
|
esac; \
|
|
|
|
|
\
|
|
|
|
|
[ $$skip -eq 0 ] && echo "$$l"; \
|
|
|
|
|
[ $$skip -eq 1 ] && skip=0; \
|
|
|
|
|
done < README.md; \
|
|
|
|
|
) > README.plain.md
|
2022-08-09 22:21:09 +00:00
|
|
|
|
Makefile: Simplify exclusion of qrap from static checks
There are things in qrap.c that clang-tidy complains about that aren't
worth fixing. So, we currently exclude it using $(filter-out). However,
we already have a make variable which has just the passt sources, excluding
qrap, so we can use that instead of the awkward filter-out expression.
Currently, we still include qrap.c for cppcheck, but there's not much
point doing so: it's, well, qrap, so we don't care that much about lints.
Exclude it from cppcheck as well, for consistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2024-11-05 23:25:18 +00:00
|
|
|
clang-tidy: $(PASST_SRCS) $(HEADERS)
|
2024-11-05 23:25:19 +00:00
|
|
|
clang-tidy $(PASST_SRCS) -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \
|
|
|
|
|
-DCLANG_TIDY_58992
|
2021-10-21 07:41:13 +00:00
|
|
|
|
2022-09-26 10:43:46 +00:00
|
|
|
SYSTEM_INCLUDES := /usr/include $(wildcard /usr/include/$(TARGET))
|
2021-10-21 07:41:13 +00:00
|
|
|
ifeq ($(shell $(CC) -v 2>&1 | grep -c "gcc version"),1)
|
|
|
|
|
VER := $(shell $(CC) -dumpversion)
|
2022-09-26 10:43:43 +00:00
|
|
|
SYSTEM_INCLUDES += /usr/lib/gcc/$(TARGET)/$(VER)/include
|
2021-10-21 07:41:13 +00:00
|
|
|
endif
|
Makefile: Simplify exclusion of qrap from static checks
There are things in qrap.c that clang-tidy complains about that aren't
worth fixing. So, we currently exclude it using $(filter-out). However,
we already have a make variable which has just the passt sources, excluding
qrap, so we can use that instead of the awkward filter-out expression.
Currently, we still include qrap.c for cppcheck, but there's not much
point doing so: it's, well, qrap, so we don't care that much about lints.
Exclude it from cppcheck as well, for consistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2024-11-05 23:25:18 +00:00
|
|
|
cppcheck: $(PASST_SRCS) $(HEADERS)
|
2024-02-27 16:02:27 +00:00
|
|
|
if cppcheck --check-level=exhaustive /dev/null > /dev/null 2>&1; then \
|
|
|
|
|
CPPCHECK_EXHAUSTIVE="--check-level=exhaustive"; \
|
|
|
|
|
else \
|
|
|
|
|
CPPCHECK_EXHAUSTIVE=; \
|
|
|
|
|
fi; \
|
2023-08-01 03:36:45 +00:00
|
|
|
cppcheck --std=c11 --error-exitcode=1 --enable=all --force \
|
2022-09-26 10:43:44 +00:00
|
|
|
--inconclusive --library=posix --quiet \
|
2024-02-27 16:02:27 +00:00
|
|
|
$${CPPCHECK_EXHAUSTIVE} \
|
2022-09-26 10:43:43 +00:00
|
|
|
$(SYSTEM_INCLUDES:%=-I%) \
|
|
|
|
|
$(SYSTEM_INCLUDES:%=--config-exclude=%) \
|
|
|
|
|
$(SYSTEM_INCLUDES:%=--suppress=*:%/*) \
|
|
|
|
|
$(SYSTEM_INCLUDES:%=--suppress=unmatchedSuppression:%/*) \
|
2022-09-28 04:33:18 +00:00
|
|
|
--inline-suppr \
|
2022-09-28 04:33:28 +00:00
|
|
|
--suppress=unusedStructMember \
|
2022-11-13 00:32:00 +00:00
|
|
|
$(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \
|
Makefile: Simplify exclusion of qrap from static checks
There are things in qrap.c that clang-tidy complains about that aren't
worth fixing. So, we currently exclude it using $(filter-out). However,
we already have a make variable which has just the passt sources, excluding
qrap, so we can use that instead of the awkward filter-out expression.
Currently, we still include qrap.c for cppcheck, but there's not much
point doing so: it's, well, qrap, so we don't care that much about lints.
Exclude it from cppcheck as well, for consistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2024-11-05 23:25:18 +00:00
|
|
|
$(PASST_SRCS) $(HEADERS)
|
