passt/icmp_flow.h

/* SPDX-License-Identifier: GPL-2.0-or-later
 * Copyright Red Hat
 * Author: David Gibson <david@gibson.dropbear.id.au>
 *
 * ICMP flow tracking data structures
 */
#ifndef ICMP_FLOW_H
#define ICMP_FLOW_H

/**
 * struct icmp_ping_flow - Descriptor for a flow of ping requests/replies
 * @f:		Generic flow information
 * @seq:	Last sequence number sent to tap, host order, -1: not sent yet
 * @sock:	"ping" socket
 * @ts:		Last associated activity from tap, seconds
 * @id:		ICMP id for the flow as seen by the guest
 */
struct icmp_ping_flow {
	/* Must be first element */
	struct flow_common f;

	int seq;
	int sock;
	time_t ts;
	uint16_t id;
};

bool icmp_ping_timer(const struct ctx *c, const struct icmp_ping_flow *pingf,
		     const struct timespec *now);

#endif /* ICMP_FLOW_H */
icmp: Store ping socket information in flow table Currently icmp_id_map[][] stores information about ping sockets in a bespoke structure. Move the same information into new types of flow in the flow table. To match that change, replace the existing ICMP timer with a flow-based timer for expiring ping sockets. This has the advantage that we only need to scan the active flows, not all possible ids. We convert icmp_id_map[][] to point to the flow table entries, rather than containing its own information. We do still use that array for locating the right ping flows, rather than using a "flow native" form of lookup for the time being. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> [sbrivio: Update id_sock description in comment to icmp_ping_new()] Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2024-02-29 04:15:32 +00:00			`/* SPDX-License-Identifier: GPL-2.0-or-later`
			`* Copyright Red Hat`
			`* Author: David Gibson <david@gibson.dropbear.id.au>`
			`*`
			`* ICMP flow tracking data structures`
			`*/`
			`#ifndef ICMP_FLOW_H`
			`#define ICMP_FLOW_H`

			`/**`
			`* struct icmp_ping_flow - Descriptor for a flow of ping requests/replies`
			`* @f: Generic flow information`
			`* @seq: Last sequence number sent to tap, host order, -1: not sent yet`
			`* @sock: "ping" socket`
			`* @ts: Last associated activity from tap, seconds`
			`* @id: ICMP id for the flow as seen by the guest`
			`*/`
			`struct icmp_ping_flow {`
			`/* Must be first element */`
			`struct flow_common f;`

			`int seq;`
			`int sock;`
			`time_t ts;`
			`uint16_t id;`
			`};`

flow: Properly type callbacks to protocol specific handlers The flow dispatches deferred and timer handling for flows centrally, but needs to call into protocol specific code for the handling of individual flows. Currently this passes a general union flow *. It makes more sense to pass the specific relevant flow type structure. That brings the check on the flow type adjacent to casting to the union variant which it tags. Arguably, this is a slight abstraction violation since it involves the generic flow code using protocol specific types. It's already calling into protocol specific functions, so I don't think this really makes any difference. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2024-05-21 05:57:03 +00:00			`bool icmp_ping_timer(const struct ctx c, const struct icmp_ping_flow pingf,`
icmp: Store ping socket information in flow table Currently icmp_id_map[][] stores information about ping sockets in a bespoke structure. Move the same information into new types of flow in the flow table. To match that change, replace the existing ICMP timer with a flow-based timer for expiring ping sockets. This has the advantage that we only need to scan the active flows, not all possible ids. We convert icmp_id_map[][] to point to the flow table entries, rather than containing its own information. We do still use that array for locating the right ping flows, rather than using a "flow native" form of lookup for the time being. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> [sbrivio: Update id_sock description in comment to icmp_ping_new()] Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2024-02-29 04:15:32 +00:00			`const struct timespec *now);`

			`#endif /* ICMP_FLOW_H */`