passt/test/valgrind.supp

# tcp_sock_consume() calls recv() with MSG_TRUNC and no buffer to discard data
{
   passt_recv_MSG_TRUNC_into_NULL_buffer
   Memcheck:Param
   socketcall.recvfrom(buf)
   ...
   fun:tcp_sock_consume
}
test, seccomp, Makefile: Switch to valgrind runs for passt functional tests Pass to seccomp.sh a list of additional syscalls valgrind needs as EXTRA_SYSCALLS in a new 'valgrind' make target, and add corresponding support in seccomp.sh itself. In test setup functions, start passt with valgrind, but not for performance tests. Add tests checking that valgrind exits without errors after all the other tests in the group are done. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2022-03-15 19:16:13 +00:00			`# tcp_sock_consume() calls recv() with MSG_TRUNC and no buffer to discard data`
			`{`
			`passt_recv_MSG_TRUNC_into_NULL_buffer`
			`Memcheck:Param`
			`socketcall.recvfrom(buf)`
			`...`
valgrind: Adjust suppression for MSG_TRUNC with NULL buffer valgrind complains if we pass a NULL buffer to recv(), even if we use MSG_TRUNC, in which case it's actually safe. For a long time we've had a valgrind suppression for this. It singles out the recv() in tcp_sock_consume(), the only place we use MSG_TRUNC. However, tcp_sock_consume() only has a single caller, which makes it a prime candidate for inlining. If inlined, it won't appear on the stack and valgrind won't match the correct suppression. It appears that certain compiler versions (for example gcc-13.2.1 in Fedora 39) will inline this function even with the -O0 we use for valgrind builds. This breaks the suppression leading to a spurious failure in the tests. There's not really any way to adjust the suppression itself without making it overly broad (we don't want to match other recv() calls). So, as a hack explicitly prevent inlining of this function when we're making a valgrind build. To accomplish this add an explicit -DVALGRIND when making such a build. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2023-11-16 09:15:58 +00:00			`fun:tcp_sock_consume`
test, seccomp, Makefile: Switch to valgrind runs for passt functional tests Pass to seccomp.sh a list of additional syscalls valgrind needs as EXTRA_SYSCALLS in a new 'valgrind' make target, and add corresponding support in seccomp.sh itself. In test setup functions, start passt with valgrind, but not for performance tests. Add tests checking that valgrind exits without errors after all the other tests in the group are done. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 2022-03-15 19:16:13 +00:00			`}`