From 45b8632dcc0edcc60e17a2d068b433eaf82fdf82 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Wed, 22 May 2024 16:54:03 +0200 Subject: [PATCH] conf: Don't lecture user about starting us as root libguestfs tools have a good reason to run as root: if the guest image is owned by root, it would be counterproductive to encourage users to invoke them as non-root, as it would require changing permissions or ownership of the image file. And if they run as root, we'll start as root, too. Warn users we'll switch to 'nobody', but don't tell them what to do. Reported-by: Richard W.M. Jones Signed-off-by: Stefano Brivio Reviewed-by: David Gibson Reviewed-by: Richard W.M. Jones --- conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf.c b/conf.c index 21d46fe..2e0d909 100644 --- a/conf.c +++ b/conf.c @@ -1093,7 +1093,7 @@ static void conf_ugid(char *runas, uid_t *uid, gid_t *gid) return; /* ...otherwise use nobody:nobody */ - warn("Don't run as root. Changing to nobody..."); + warn("Started as root. Changing to nobody..."); { #ifndef GLIBC_NO_STATIC_NSS const struct passwd *pw;