External/passt
1
0
Fork 0
mirror of https://passt.top/passt synced 2024-12-22 13:45:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

tcp_vu: Change 'dlen' to ssize_t in tcp_vu_data_from_sock()

Browse Source 
...to quickly suppress a false positive from Coverity, which assumes
that iov_size is 0 and 'dlen' might overflow as a result (with hdrlen
being 66). An ASSERT() in tcp_vu_sock_recv() already guarantees that
iov_size(iov, buf_cnt) here is anyway greater than 'hdrlen'.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
This commit is contained in:
Stefano Brivio 2024-11-27 15:37:01 +01:00
parent 00cc2303fd
commit 804a7ce94a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tcp_vu.c
View File

@ -463,7 +463,7 @@ int tcp_vu_data_from_sock(const struct ctx *c, struct tcp_tap_conn *conn)
for (i = 0, check = NULL; i < head_cnt; i++) { for (i = 0, check = NULL; i < head_cnt; i++) {
struct iovec *iov = &elem[head[i]].in_sg[0]; struct iovec *iov = &elem[head[i]].in_sg[0];
int buf_cnt = head[i + 1] - head[i]; int buf_cnt = head[i + 1] - head[i];
int dlen = iov_size(iov, buf_cnt) - hdrlen; ssize_t dlen = iov_size(iov, buf_cnt) - hdrlen;
vu_set_vnethdr(vdev, iov->iov_base, buf_cnt); vu_set_vnethdr(vdev, iov->iov_base, buf_cnt);