External/passt
1
0
Fork 0
mirror of https://passt.top/passt synced 2024-09-28 10:05:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

passt: Improper use of negative value (CWE-394)

Browse Source 
Reported by Coverity.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2022-04-05 08:15:29 +02:00
parent 0786b2e60a
commit bb76470090
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
passt.c
View File

@ -421,13 +421,22 @@ int main(int argc, char **argv)
pcap_init(&c);
if (!c.foreground)
if (!c.foreground) {
/* NOLINTNEXTLINE(android-cloexec-open): see __daemon() */
devnull_fd = open("/dev/null", O_RDWR);
if ((devnull_fd = open("/dev/null", O_RDWR)) < 0) {
perror("/dev/null open");
exit(EXIT_FAILURE);
}
}
if (*c.pid_file)
pidfile_fd = open(c.pid_file, O_CREAT | O_WRONLY | O_CLOEXEC,
S_IRUSR | S_IWUSR);
if (*c.pid_file) {
if ((pidfile_fd = open(c.pid_file,
O_CREAT | O_WRONLY | O_CLOEXEC,
S_IRUSR | S_IWUSR)) < 0) {
perror("PID file open");
exit(EXIT_FAILURE);
}
}
if (sandbox(&c)) {
err("Failed to sandbox process, exiting\n");