1
0
mirror of https://passt.top/passt synced 2024-11-05 20:31:11 +00:00
passt/arch.c
Stefano Brivio 0bf6adc886 arch: Pointer to local outside scope, CWE-562
Reported by Coverity: if we fail to run the AVX2 version, once
execve() fails, we had already replaced argv[0] with the new
stack-allocated path string, and that's then passed back to
main(). Use a static variable instead.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2022-04-07 11:44:35 +02:00

43 lines
985 B
C

// SPDX-License-Identifier: AGPL-3.0-or-later
/* PASST - Plug A Simple Socket Transport
* for qemu/UNIX domain socket mode
*
* PASTA - Pack A Subtle Tap Abstraction
* for network namespace/tap device mode
*
* arch.c - Architecture-specific implementations
*
* Copyright (c) 2022 Red Hat GmbH
* Author: Stefano Brivio <sbrivio@redhat.com>
*/
#include <limits.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>
/**
* arch_avx2_exec() - Run AVX2 build if supported, drop suffix from argv[0]
* @argv: Arguments from command line
*/
#ifdef __x86_64__
static char avx2_path[PATH_MAX];
void arch_avx2_exec(char **argv)
{
char *p = strstr(argv[0], ".avx2");
if (p) {
*p = 0;
} else if (__builtin_cpu_supports("avx2")) {
snprintf(avx2_path, PATH_MAX, "%s.avx2", argv[0]);
argv[0] = avx2_path;
execve(avx2_path, argv, environ);
perror("Can't run AVX2 build, using non-AVX2 version");
}
}
#else
void arch_avx2_exec(char **argv) { (void)argv; }
#endif