mirror of
https://passt.top/passt
synced 2024-06-27 13:32:41 +00:00
3e2eb4337b
Even if CAP_NET_BIND_SERVICE is granted, we'll lose the capability in the target user namespace as we isolate the process, which means we're unable to bind to low ports at that point. Bind inbound ports, and only those, before isolate_user(). Keep the handling of outbound ports (for pasta mode only) after the setup of the namespace, because that's where we'll bind them. To this end, initialise the netlink socket for the init namespace before isolate_user() as well, as we actually need to know the addresses of the upstream interface before binding ports, in case they're not explicitly passed by the user. As we now call nl_sock_init() twice, checking its return code from conf() twice looks a bit heavy: make it exit(), instead, as we can't do much if we don't have netlink sockets. While at it: - move the v4_only && v6_only options check just after the first option processing loop, as this is more strictly related to option parsing proper - update the man page, explaining that CAP_NET_BIND_SERVICE is *not* the preferred way to bind ports, because passt and pasta can be abused to allow other processes to make effective usage of it. Add a note about the recommended sysctl instead - simplify nl_sock_init_do() now that it's called once for each case Reported-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
17 lines
527 B
C
17 lines
527 B
C
/* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
* Copyright (c) 2021 Red Hat GmbH
|
|
* Author: Stefano Brivio <sbrivio@redhat.com>
|
|
*/
|
|
|
|
#ifndef NETLINK_H
|
|
#define NETLINK_H
|
|
|
|
void nl_sock_init(const struct ctx *c, bool ns);
|
|
unsigned int nl_get_ext_if(sa_family_t af);
|
|
void nl_route(int ns, unsigned int ifi, sa_family_t af, void *gw);
|
|
void nl_addr(int ns, unsigned int ifi, sa_family_t af,
|
|
void *addr, int *prefix_len, void *addr_l);
|
|
void nl_link(int ns, unsigned int ifi, void *mac, int up, int mtu);
|
|
|
|
#endif /* NETLINK_H */
|