From 17a810d9c0989eccf3d27f51c27b78a3d2539265 Mon Sep 17 00:00:00 2001
From: Lukas Greve <please@refre.ch>
Date: Thu, 18 Sep 2025 20:35:33 +0200
Subject: [PATCH] make domain name definition a function of the vm name

---
 multiple/shared_modules/network.tf   |  2 +-
 multiple/shared_modules/variables.tf | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/multiple/shared_modules/network.tf b/multiple/shared_modules/network.tf
index 4c2089d..da2ad65 100644
--- a/multiple/shared_modules/network.tf
+++ b/multiple/shared_modules/network.tf
@@ -1,7 +1,7 @@
 resource "libvirt_network" "tf_libvirt_network" {
   name = "${var.vm_name}-network"
   mode = var.network_mode
-  domain = var.network_domain
+  domain = local.computed_network_domain
   addresses = var.network_addresses
   
   dns {
diff --git a/multiple/shared_modules/variables.tf b/multiple/shared_modules/variables.tf
index 9dcf592..0a64f30 100644
--- a/multiple/shared_modules/variables.tf
+++ b/multiple/shared_modules/variables.tf
@@ -73,12 +73,6 @@ variable "vcpu" {
   default     = 1
 }
 
-variable "network_name" {
-  description = "Name of the network"
-  type        = string
-  default     = "tf"
-}
-
 variable "network_mode" {
   description = "Network mode (nat, none, route, open, bridge)"
   type        = string
@@ -86,9 +80,10 @@ variable "network_mode" {
 }
 
 variable "network_domain" {
-  description = "Domain name for the network"
+  description = "Domain name for the network (derived from vm_name)"
   type        = string
-  default     = "tf.local"
+  # Default dynamically based on vm_name
+  default = ""
 }
 
 variable "network_addresses" {
@@ -137,4 +132,9 @@ variable "uefi_nvram_file_suffix" {
   EOT
   type        = string
   default     = ""
+}
+
+# Computed variable for network domain (derived from vm_name)
+locals {
+  computed_network_domain = var.network_domain != "" ? var.network_domain : "${var.vm_name}.local"
 }
\ No newline at end of file