release 2.3.1

Signed-off-by: Rui Chen <rui@chenrui.dev>

.gitignore

@@ -2,3 +2,4 @@ __tests__/runner/*
 # actions requires a node_modules dir https://github.com/actions/toolkit/blob/master/docs/javascript-action.md#publish-a-releasesv1-action
 # but its recommended not to check these in https://github.com/actions/toolkit/blob/master/docs/action-versioning.md#recommendations
 node_modules
+coverage

.tool-versions

@@ -1 +1 @@
-nodejs 20.15.1
+nodejs 24.2.0

CHANGELOG.md

@@ -1,3 +1,16 @@
+## 2.3.1
+
+### Bug fixes 🐛
+
+* fix: fix file closing issue by @WailGree in https://github.com/softprops/action-gh-release/pull/629
+
+## 2.3.0
+
+* Migrate from jest to vitest
+* Replace `mime` with `mime-types`
+* Bump to use node 24
+* Dependency updates
+
 ## 2.2.2
 
 ## What's Changed

__tests__/github.test.ts

@@ -7,6 +7,8 @@ import {
   findTagFromReleases,
 } from "../src/github";
 
+import { describe, it } from "vitest";
+
 describe("github", () => {
   describe("mimeOrDefault", () => {
     it("returns a specific mime for common path", async () => {

__tests__/util.test.ts

@@ -10,6 +10,8 @@ import {
 } from "../src/util";
 import * as assert from "assert";
 
+import { describe, it, expect } from "vitest";
+
 describe("util", () => {
   describe("uploadUrl", () => {
     it("strips template", () => {

jest.config.ts

@@ -1,16 +0,0 @@
-import type { JestConfigWithTsJest } from 'ts-jest';
-
-const config: JestConfigWithTsJest = {
-  preset: 'ts-jest/presets/default-esm',
-  clearMocks: true,
-  moduleFileExtensions: ['js', 'ts'],
-  testEnvironment: 'node',
-  testMatch: ['**/*.test.ts'],
-  testRunner: 'jest-circus/runner',
-  transform: {
-    '^.+\\.ts$': 'ts-jest',
-  },
-  verbose: true,
-};
-
-export default config;

package.json

@@ -1,13 +1,14 @@
 {
   "name": "action-gh-release",
-  "version": "2.2.2",
+  "version": "2.3.1",
   "private": true,
   "description": "GitHub Action for creating GitHub Releases",
   "main": "lib/main.js",
   "scripts": {
-    "build": "ncc build src/main.ts --minify",
+    "build": "ncc build src/main.ts --minify --target es2022",
     "build-debug": "ncc build src/main.ts --v8-cache --source-map",
-    "test": "jest",
+    "typecheck": "tsc --noEmit",
+    "test": "vitest --coverage",
     "fmt": "prettier --write \"src/**/*.ts\" \"__tests__/**/*.ts\"",
     "fmtcheck": "prettier --check \"src/**/*.ts\" \"__tests__/**/*.ts\"",
     "updatetag": "git tag -d v2 && git push origin :v2 && git tag -a v2 -m '' && git push origin v2"
@@ -22,24 +23,22 @@
   "author": "softprops",
   "dependencies": {
     "@actions/core": "^1.11.1",
-    "@actions/github": "^6.0.0",
-    "@octokit/plugin-retry": "^7.2.1",
-    "@octokit/plugin-throttling": "^10.0.0",
-    "glob": "^11.0.1",
-    "mime": "^3.0.0"
+    "@actions/github": "^6.0.1",
+    "@octokit/plugin-retry": "^8.0.1",
+    "@octokit/plugin-throttling": "^11.0.1",
+    "glob": "^11.0.2",
+    "mime-types": "^3.0.1"
   },
   "devDependencies": {
     "@types/glob": "^8.1.0",
-    "@types/jest": "^29.5.14",
-    "@types/mime": "^3.0.1",
-    "@types/node": "^22.14.1",
+    "@types/mime-types": "^3.0.1",
+    "@types/node": "^22.15.21",
     "@vercel/ncc": "^0.38.3",
-    "jest": "^29.3.1",
-    "jest-circus": "^29.3.1",
+    "@vitest/coverage-v8": "^3.1.4",
     "prettier": "3.5.3",
-    "ts-jest": "^29.3.2",
     "ts-node": "^10.9.2",
     "typescript": "^5.8.3",
-    "typescript-formatter": "^7.2.2"
+    "typescript-formatter": "^7.2.2",
+    "vitest": "^3.1.4"
   }
 }

src/github.ts

@@ -2,7 +2,7 @@ import { GitHub } from "@actions/github/lib/utils";
 import { Config, isTag, releaseBody, alignAssetName } from "./util";
 import { statSync } from "fs";
 import { open } from "fs/promises";
-import { getType } from "mime";
+import { lookup } from "mime-types";
 import { basename } from "path";
 
 type GitHub = InstanceType<typeof GitHub>;
@@ -149,7 +149,7 @@ export const asset = (path: string): ReleaseAsset => {
 };
 
 export const mimeOrDefault = (path: string): string => {
-  return getType(path) || "application/octet-stream";
+  return lookup(path) || "application/octet-stream";
 };
 
 export const upload = async (
@@ -180,6 +180,7 @@ export const upload = async (
   endpoint.searchParams.append("name", name);
   const fh = await open(path);
   try {
+    const stream = fh.readableWebStream();
     const resp = await github.request({
       method: "POST",
       url: endpoint.toString(),
@@ -188,7 +189,7 @@ export const upload = async (
         "content-type": mime,
         authorization: `token ${config.github_token}`,
       },
-      data: fh.readableWebStream({ type: "bytes" }),
+      data: stream,
     });
     const json = resp.data;
     if (resp.status !== 201) {
@@ -201,7 +202,7 @@ export const upload = async (
     console.log(`✅ Uploaded ${name}`);
     return json;
   } finally {
-    await fh.close();
+    await fh.close().catch(() => {});
   }
 };
 

src/util.ts

@@ -91,7 +91,10 @@ const parseMakeLatest = (
 export const paths = (patterns: string[]): string[] => {
   return patterns.reduce((acc: string[], pattern: string): string[] => {
     return acc.concat(
-      glob.sync(pattern).filter((path) => statSync(path).isFile()),
+      glob
+        .sync(pattern)
+        .filter((path) => statSync(path).isFile())
+        .map((path) => path.replace(/\\/g, "/")),
     );
   }, []);
 };

tsconfig.json

@@ -3,8 +3,8 @@
     "useUnknownInCatchVariables": false,
     /* Basic Options */
     // "incremental": true,                   /* Enable incremental compilation */
-    "target": "es6",                          /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
-    "module": "commonjs",                     /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
+    "target": "es2022",
+    "module": "NodeNext",
     // "allowJs": true,                       /* Allow javascript files to be compiled. */
     // "checkJs": true,                       /* Report errors in .js files. */
     // "jsx": "preserve",                     /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
@@ -25,6 +25,7 @@
     /* Strict Type-Checking Options */
     "strict": true,                           /* Enable all strict type-checking options. */
     "noImplicitAny": false,                 /* Raise error on expressions and declarations with an implied 'any' type. */
+    "skipLibCheck": true,
     // "strictNullChecks": true,              /* Enable strict null checks. */
     // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
     // "strictBindCallApply": true,           /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
@@ -44,7 +45,7 @@
     // "paths": {},                           /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
     // "rootDirs": [],                        /* List of root folders whose combined content represents the structure of the project at runtime. */
     // "typeRoots": [],                       /* List of folders to include type definitions from. */
-    // "types": [],                           /* Type declaration files to be included in compilation. */
+    "types": ["vitest/globals"],
     // "allowSyntheticDefaultImports": true,  /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
     "esModuleInterop": true                   /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
     // "preserveSymlinks": true,              /* Do not resolve the real path of symlinks. */
@@ -60,5 +61,5 @@
     // "experimentalDecorators": true,        /* Enables experimental support for ES7 decorators. */
     // "emitDecoratorMetadata": true,         /* Enables experimental support for emitting type metadata for decorators. */
   },
-  "exclude": ["node_modules", "**/*.test.ts", "jest.config.ts"]
+  "exclude": ["node_modules", "**/*.test.ts", "vitest.config.ts"]
 }

vitest.config.ts

@@ -0,0 +1,11 @@
+import { defineConfig } from 'vitest/config';
+
+export default defineConfig({
+  test: {
+    environment: 'node',
+    coverage: {
+      reporter: ['text', 'lcov'],
+    },
+    include: ['__tests__/**/*.ts'],
+  },
+});