External/libmks
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libmks.git synced 2024-12-22 05:35:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

dmabuf: Only create a new texture when needed

Browse Source 
If the widget gets resized, snapshot would end up being called
and we will try to re-create the same texture again which can
cause some artifacts
This commit is contained in:
Bilal Elmoussaoui 2023-08-23 09:54:53 +02:00
parent 9334cd4ee9
commit 035d9b7ac2
1 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/mks-dmabuf-paintable.c
View File

@ -48,6 +48,7 @@ struct _MksDmabufPaintable
GdkGLTextureBuilder *builder; GdkGLTextureBuilder *builder;
guint width; guint width;
guint height; guint height;
guint dmabuf_updated : 1;
}; };
static MksDmabufTextureData * static MksDmabufTextureData *
@ -115,17 +116,27 @@ mks_dmabuf_paintable_snapshot (GdkPaintable *paintable,
g_assert (MKS_IS_DMABUF_PAINTABLE (self)); g_assert (MKS_IS_DMABUF_PAINTABLE (self));
g_assert (GDK_IS_SNAPSHOT (snapshot)); g_assert (GDK_IS_SNAPSHOT (snapshot));
texture_id = gdk_gl_texture_builder_get_id (self->builder); /**
gl_context = gdk_gl_texture_builder_get_context (self->builder); * If the widget gets resized, snapshot would be called even
* if we didn't receive a new DMABufUpdate call.
* So only create a new GLTexture when that happens
*/
if (self->dmabuf_updated)
{
texture_id = gdk_gl_texture_builder_get_id (self->builder);
gl_context = gdk_gl_texture_builder_get_context (self->builder);
gdk_gl_texture_builder_set_update_texture (self->builder, self->texture);
texture = gdk_gl_texture_builder_build (self->builder, gdk_gl_texture_builder_set_update_texture (self->builder, self->texture);
mks_dmabuf_texture_data_free, texture = gdk_gl_texture_builder_build (self->builder,
mks_dmabuf_texture_data_new (gl_context, mks_dmabuf_texture_data_free,
texture_id)); mks_dmabuf_texture_data_new (gl_context,
// Clear up the update region to not union it with the next UpdateDMABuf call texture_id));
gdk_gl_texture_builder_set_update_region (self->builder, NULL); // Clear up the update region to not union it with the next UpdateDMABuf call
g_set_object (&self->texture, texture); gdk_gl_texture_builder_set_update_region (self->builder, NULL);
g_set_object (&self->texture, texture);
self->dmabuf_updated = FALSE;
}
area = GRAPHENE_RECT_INIT (0, 0, width, height); area = GRAPHENE_RECT_INIT (0, 0, width, height);
gtk_snapshot_append_texture (snapshot, self->texture, &area); gtk_snapshot_append_texture (snapshot, self->texture, &area);
@ -246,6 +257,7 @@ mks_dmabuf_paintable_import (MksDmabufPaintable *self,
accumulated_damages); accumulated_damages);
g_clear_pointer (&accumulated_damages, cairo_region_destroy); g_clear_pointer (&accumulated_damages, cairo_region_destroy);
self->dmabuf_updated = TRUE;
gdk_paintable_invalidate_contents (GDK_PAINTABLE (self)); gdk_paintable_invalidate_contents (GDK_PAINTABLE (self));
return TRUE; return TRUE;
} }
@ -257,6 +269,7 @@ mks_dmabuf_paintable_new (void)
g_autoptr(MksDmabufPaintable) self = NULL; g_autoptr(MksDmabufPaintable) self = NULL;
self = g_object_new (MKS_TYPE_DMABUF_PAINTABLE, NULL); self = g_object_new (MKS_TYPE_DMABUF_PAINTABLE, NULL);
self->dmabuf_updated = FALSE;
self->width = 0; self->width = 0;
self->height = 0; self->height = 0;
return g_steal_pointer (&self); return g_steal_pointer (&self);