Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# -*-Makefile-*-
|
|
|
|
# This Makefile fragment tries to be general-purpose enough to be
|
|
|
|
# used by many projects via the gnulib maintainer-makefile module.
|
|
|
|
|
|
|
|
## Copyright (C) 2001-2009 Free Software Foundation, Inc.
|
|
|
|
##
|
|
|
|
## This program is free software: you can redistribute it and/or modify
|
|
|
|
## it under the terms of the GNU General Public License as published by
|
|
|
|
## the Free Software Foundation, either version 3 of the License, or
|
|
|
|
## (at your option) any later version.
|
|
|
|
##
|
|
|
|
## This program is distributed in the hope that it will be useful,
|
|
|
|
## but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
## GNU General Public License for more details.
|
|
|
|
##
|
|
|
|
## You should have received a copy of the GNU General Public License
|
|
|
|
## along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# This is reported not to work with make-3.79.1
|
|
|
|
# ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
|
|
|
|
ME := Makefile.maint
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# Override this in cfg.mk if you use a non-standard build-aux directory.
|
|
|
|
build_aux ?= $(srcdir)/build-aux
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Do not save the original name or timestamp in the .tar.gz file.
|
|
|
|
# Use --rsyncable if available.
|
|
|
|
gzip_rsyncable := \
|
|
|
|
$(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null && echo --rsyncable)
|
|
|
|
GZIP_ENV = '--no-name --best $(gzip_rsyncable)'
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# cfg.mk must define the gpg_key_ID used by this package.
|
|
|
|
GIT = git
|
|
|
|
VC = $(GIT)
|
|
|
|
VC-tag = git tag -s -m '$(VERSION)' -u '$(gpg_key_ID)'
|
2008-01-29 17:42:39 +00:00
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
VC_LIST = $(build_aux)/vc-list-files -C $(srcdir)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
VC_LIST_EXCEPT = \
|
|
|
|
$(VC_LIST) | if test -f $(srcdir)/.x-$@; then grep -vEf $(srcdir)/.x-$@; else grep -v ChangeLog; fi
|
|
|
|
|
|
|
|
ifeq ($(origin prev_version_file), undefined)
|
|
|
|
prev_version_file = $(srcdir)/.prev-version
|
|
|
|
endif
|
|
|
|
|
|
|
|
PREV_VERSION := $(shell cat $(prev_version_file))
|
|
|
|
VERSION_REGEXP = $(subst .,\.,$(VERSION))
|
|
|
|
PREV_VERSION_REGEXP = $(subst .,\.,$(PREV_VERSION))
|
|
|
|
|
|
|
|
ifeq ($(VC),$(GIT))
|
|
|
|
this-vc-tag = v$(VERSION)
|
|
|
|
this-vc-tag-regexp = v$(VERSION_REGEXP)
|
|
|
|
else
|
|
|
|
tag-package = $(shell echo "$(PACKAGE)" | tr '[:lower:]' '[:upper:]')
|
|
|
|
tag-this-version = $(subst .,_,$(VERSION))
|
|
|
|
this-vc-tag = $(tag-package)-$(tag-this-version)
|
|
|
|
this-vc-tag-regexp = $(this-vc-tag)
|
|
|
|
endif
|
|
|
|
my_distdir = $(PACKAGE)-$(VERSION)
|
|
|
|
|
|
|
|
# Old releases are stored here.
|
|
|
|
release_archive_dir ?= ../release
|
2009-01-20 20:19:55 +00:00
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Prevent programs like 'sort' from considering distinct strings to be equal.
|
|
|
|
# Doing it here saves us from having to set LC_ALL elsewhere in this file.
|
|
|
|
export LC_ALL = C
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
## --------------- ##
|
|
|
|
## Sanity checks. ##
|
|
|
|
## --------------- ##
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Collect the names of rules starting with `sc_'.
|
2008-03-24 10:20:15 +00:00
|
|
|
syntax-check-rules := $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
$(srcdir)/$(ME) $(srcdir)/cfg.mk)
|
2008-01-29 17:42:39 +00:00
|
|
|
.PHONY: $(syntax-check-rules)
|
|
|
|
|
|
|
|
local-checks-available = \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
$(syntax-check-rules)
|
2008-01-29 17:42:39 +00:00
|
|
|
.PHONY: $(local-checks-available)
|
|
|
|
|
2009-01-29 18:06:19 +00:00
|
|
|
# Arrange to print the name of each syntax-checking rule just before running it.
|
|
|
|
$(syntax-check-rules): %: %.m
|
|
|
|
$(patsubst %, %.m, $(syntax-check-rules)):
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@echo $(patsubst sc_%.m, %, $@)
|
2009-01-29 18:06:19 +00:00
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
local-check := $(filter-out $(local-checks-to-skip), $(local-checks-available))
|
|
|
|
|
|
|
|
syntax-check: $(local-check)
|
2008-03-24 10:20:15 +00:00
|
|
|
# @grep -nE '# *include <(limits|std(def|arg|bool))\.h>' \
|
|
|
|
# $$(find -type f -name '*.[chly]') && \
|
|
|
|
# { echo '$(ME): found conditional include' 1>&2; \
|
|
|
|
# exit 1; } || :
|
2008-01-29 17:42:39 +00:00
|
|
|
|
2008-03-24 10:20:15 +00:00
|
|
|
# grep -nE '^# *include <(string|stdlib)\.h>' \
|
|
|
|
# $(srcdir)/{lib,src}/*.[chy] && \
|
|
|
|
# { echo '$(ME): FIXME' 1>&2; \
|
|
|
|
# exit 1; } || :
|
|
|
|
# FIXME: don't allow `#include .strings\.h' anywhere
|
2008-01-29 17:42:39 +00:00
|
|
|
|
2009-01-29 18:06:19 +00:00
|
|
|
# By default, _prohibit_regexp does not ignore case.
|
|
|
|
export ignore_case =
|
|
|
|
_ignore_case = $$(test -n "$$ignore_case" && echo -i || :)
|
|
|
|
|
2009-01-29 12:11:28 +00:00
|
|
|
# There are many rules below that prohibit constructs in this package.
|
|
|
|
# If the offending construct can be matched with a grep-E-style regexp,
|
|
|
|
# use this macro. The shell variables "re" and "msg" must be defined.
|
|
|
|
define _prohibit_regexp
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
dummy=; : so we do not need a semicolon before each use; \
|
2009-01-29 12:11:28 +00:00
|
|
|
test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; }; \
|
|
|
|
test "x$$msg" != x || { echo '$(ME): msg not defined' 1>&2; exit 1; };\
|
2009-01-29 18:06:19 +00:00
|
|
|
grep $(_ignore_case) -nE "$$re" $$($(VC_LIST_EXCEPT)) && \
|
2009-01-29 12:11:28 +00:00
|
|
|
{ echo '$(ME): '"$$msg" 1>&2; exit 1; } || :
|
|
|
|
endef
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
sc_avoid_if_before_free:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@$(build_aux)/useless-if-before-free \
|
2008-02-07 16:49:29 +00:00
|
|
|
$(useless_free_options) \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
$$($(VC_LIST_EXCEPT) | grep -v useless-if-before-free) && \
|
2008-01-29 17:42:39 +00:00
|
|
|
{ echo '$(ME): found useless "if" before "free" above' 1>&2; \
|
|
|
|
exit 1; } || :
|
|
|
|
|
|
|
|
sc_cast_of_argument_to_free:
|
2009-01-29 12:11:28 +00:00
|
|
|
@re='\<free *\( *\(' msg='don'\''t cast free argument' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
sc_cast_of_x_alloc_return_value:
|
2009-01-29 12:11:28 +00:00
|
|
|
@re='\*\) *x(m|c|re)alloc\>' \
|
|
|
|
msg='don'\''t cast x*alloc return value' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
sc_cast_of_alloca_return_value:
|
2009-01-29 12:11:28 +00:00
|
|
|
@re='\*\) *alloca\>' msg='don'\''t cast alloca return value' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
sc_space_tab:
|
2009-01-29 12:11:28 +00:00
|
|
|
@re='[ ] ' msg='found SPACE-TAB sequence; remove the SPACE' \
|
|
|
|
$(_prohibit_regexp)
|
2008-12-15 10:24:54 +00:00
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Don't use *scanf or the old ato* functions in `real' code.
|
|
|
|
# They provide no error checking mechanism.
|
|
|
|
# Instead, use strto* functions.
|
|
|
|
sc_prohibit_atoi_atof:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@re='\<([fs]?scanf|ato([filq]|ll)) *\(' \
|
2009-01-29 12:11:28 +00:00
|
|
|
msg='do not use *scan''f, ato''f, ato''i, ato''l, ato''ll or ato''q' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
# Use STREQ rather than comparing strcmp == 0, or != 0.
|
|
|
|
sc_prohibit_strcmp:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@grep -nE '! *str''cmp *\(|\<str''cmp *\([^)]+\) *==' \
|
2009-01-05 13:17:34 +00:00
|
|
|
$$($(VC_LIST_EXCEPT)) \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
| grep -vE ':# *define STREQ\(' && \
|
|
|
|
{ echo '$(ME): use STREQ in place of the above uses of str''cmp' \
|
2008-01-29 17:42:39 +00:00
|
|
|
1>&2; exit 1; } || :
|
|
|
|
|
|
|
|
# Using EXIT_SUCCESS as the first argument to error is misleading,
|
|
|
|
# since when that parameter is 0, error does not exit. Use `0' instead.
|
|
|
|
sc_error_exit_success:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@grep -nE 'error \(EXIT_SUCCESS,' \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep -E '\.[chly]$$') && \
|
|
|
|
{ echo '$(ME): found error (EXIT_SUCCESS' 1>&2; exit 1; } || :
|
|
|
|
|
|
|
|
# `FATAL:' should be fully upper-cased in error messages
|
|
|
|
# `WARNING:' should be fully upper-cased, or fully lower-cased
|
|
|
|
sc_error_message_warn_fatal:
|
|
|
|
@grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT)) \
|
|
|
|
| grep -E '"Warning|"Fatal|"fatal' && \
|
|
|
|
{ echo '$(ME): use FATAL, WARNING or warning' 1>&2; \
|
|
|
|
exit 1; } || :
|
|
|
|
|
|
|
|
# Error messages should not start with a capital letter
|
|
|
|
sc_error_message_uppercase:
|
|
|
|
@grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT)) \
|
|
|
|
| grep -E '"[A-Z]' \
|
|
|
|
| grep -vE '"FATAL|"WARNING|"Java|"C#|PRIuMAX' && \
|
|
|
|
{ echo '$(ME): found capitalized error message' 1>&2; \
|
|
|
|
exit 1; } || :
|
|
|
|
|
|
|
|
# Error messages should not end with a period
|
|
|
|
sc_error_message_period:
|
|
|
|
@grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT)) \
|
|
|
|
| grep -E '[^."]\."' && \
|
|
|
|
{ echo '$(ME): found error message ending in period' 1>&2; \
|
2008-01-29 17:42:39 +00:00
|
|
|
exit 1; } || :
|
|
|
|
|
|
|
|
sc_file_system:
|
2009-01-29 18:06:19 +00:00
|
|
|
@re=file''system ignore_case=1 \
|
|
|
|
msg='found use of "file''system"; spell it "file system"' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
2009-01-05 13:17:34 +00:00
|
|
|
# Don't use cpp tests of this symbol. All code assumes config.h is included.
|
2009-01-29 18:06:19 +00:00
|
|
|
sc_prohibit_have_config_h:
|
2008-03-24 10:20:15 +00:00
|
|
|
@grep -n '^# *if.*HAVE''_CONFIG_H' $$($(VC_LIST_EXCEPT)) && \
|
2008-01-29 17:42:39 +00:00
|
|
|
{ echo '$(ME): found use of HAVE''_CONFIG_H; remove' \
|
|
|
|
1>&2; exit 1; } || :
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# Nearly all .c files must include <config.h>. However, we also permit this
|
|
|
|
# via inclusion of a package-specific header, if cfg.mk specified one.
|
|
|
|
# config_h_header must be suitable for grep -E.
|
|
|
|
config_h_header ?= <config\.h>
|
2008-01-29 17:42:39 +00:00
|
|
|
sc_require_config_h:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \
|
|
|
|
grep -EL '^# *include $(config_h_header)' \
|
2008-03-24 10:20:15 +00:00
|
|
|
$$($(VC_LIST_EXCEPT) | grep '\.c$$') \
|
2008-01-29 17:42:39 +00:00
|
|
|
| grep . && \
|
|
|
|
{ echo '$(ME): the above files do not include <config.h>' \
|
|
|
|
1>&2; exit 1; } || :; \
|
|
|
|
else :; \
|
|
|
|
fi
|
|
|
|
|
2008-12-17 17:23:21 +00:00
|
|
|
# You must include <config.h> before including any other header file.
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# This can possibly be via a package-specific header, if given by cfg.mk.
|
2008-12-17 17:23:21 +00:00
|
|
|
sc_require_config_h_first:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \
|
2008-12-17 17:23:21 +00:00
|
|
|
fail=0; \
|
|
|
|
for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do \
|
|
|
|
grep '^# *include\>' $$i | sed 1q \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
| grep -E '^# *include $(config_h_header)' > /dev/null \
|
2008-12-17 17:23:21 +00:00
|
|
|
|| { echo $$i; fail=1; }; \
|
|
|
|
done; \
|
|
|
|
test $$fail = 1 && \
|
|
|
|
{ echo '$(ME): the above files include some other header' \
|
|
|
|
'before <config.h>' 1>&2; exit 1; } || :; \
|
|
|
|
else :; \
|
|
|
|
fi
|
|
|
|
|
2009-01-29 18:06:19 +00:00
|
|
|
sc_prohibit_HAVE_MBRTOWC:
|
|
|
|
@re='\bHAVE_MBRTOWC\b' msg="do not use $$re; it is always defined" \
|
|
|
|
$(_prohibit_regexp)
|
|
|
|
|
2008-03-24 10:20:15 +00:00
|
|
|
# To use this "command" macro, you must first define two shell variables:
|
|
|
|
# h: the header, enclosed in <> or ""
|
|
|
|
# re: a regular expression that matches IFF something provided by $h is used.
|
|
|
|
define _header_without_use
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
h_esc=`echo "$$h"|sed 's/\./\\./g'`; \
|
|
|
|
if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \
|
2008-03-24 10:20:15 +00:00
|
|
|
files=$$(grep -l '^# *include '"$$h_esc" \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep '\.c$$')) && \
|
|
|
|
grep -LE "$$re" $$files | grep . && \
|
|
|
|
{ echo "$(ME): the above files include $$h but don't use it" \
|
|
|
|
1>&2; exit 1; } || :; \
|
|
|
|
else :; \
|
|
|
|
fi
|
|
|
|
endef
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Prohibit the inclusion of assert.h without an actual use of assert.
|
|
|
|
sc_prohibit_assert_without_use:
|
2008-03-24 10:20:15 +00:00
|
|
|
@h='<assert.h>' re='\<assert *\(' $(_header_without_use)
|
|
|
|
|
|
|
|
# Prohibit the inclusion of getopt.h without an actual use.
|
|
|
|
sc_prohibit_getopt_without_use:
|
|
|
|
@h='<getopt.h>' re='\<getopt(_long)? *\(' $(_header_without_use)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
# Don't include quotearg.h unless you use one of its functions.
|
|
|
|
sc_prohibit_quotearg_without_use:
|
2008-03-24 10:20:15 +00:00
|
|
|
@h='"quotearg.h"' re='\<quotearg(_[^ ]+)? *\(' $(_header_without_use)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
# Don't include quote.h unless you use one of its functions.
|
|
|
|
sc_prohibit_quote_without_use:
|
2008-03-24 10:20:15 +00:00
|
|
|
@h='"quote.h"' re='\<quote(_n)? *\(' $(_header_without_use)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
2009-01-29 18:06:19 +00:00
|
|
|
# Don't include this header unless you use one of its functions.
|
|
|
|
sc_prohibit_long_options_without_use:
|
|
|
|
@h='"long-options.h"' re='\<parse_long_options *\(' \
|
|
|
|
$(_header_without_use)
|
|
|
|
|
|
|
|
# Don't include this header unless you use one of its functions.
|
|
|
|
sc_prohibit_inttostr_without_use:
|
|
|
|
@h='"inttostr.h"' re='\<(off|[iu]max|uint)tostr *\(' \
|
|
|
|
$(_header_without_use)
|
|
|
|
|
|
|
|
# Don't include this header unless you use one of its functions.
|
|
|
|
sc_prohibit_error_without_use:
|
|
|
|
@h='"error.h"' \
|
|
|
|
re='\<error(_at_line|_print_progname|_one_per_line|_message_count)? *\('\
|
|
|
|
$(_header_without_use)
|
|
|
|
|
|
|
|
sc_prohibit_safe_read_without_use:
|
|
|
|
@h='"safe-read.h"' re='(\<SAFE_READ_ERROR\>|\<safe_read *\()' \
|
|
|
|
$(_header_without_use)
|
|
|
|
|
|
|
|
sc_prohibit_argmatch_without_use:
|
|
|
|
@h='"argmatch.h"' \
|
|
|
|
re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid) *\()' \
|
|
|
|
$(_header_without_use)
|
|
|
|
|
|
|
|
sc_prohibit_root_dev_ino_without_use:
|
|
|
|
@h='"root-dev-ino.h"' \
|
|
|
|
re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \
|
|
|
|
$(_header_without_use)
|
|
|
|
|
2008-05-09 13:50:14 +00:00
|
|
|
# Prohibit the inclusion of c-ctype.h without an actual use.
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
|
|
|
|
|isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
|
2008-05-09 13:50:14 +00:00
|
|
|
sc_prohibit_c_ctype_without_use:
|
|
|
|
@h='[<"]c-ctype.h[">]' re='\<c_($(ctype_re)) *\(' $(_header_without_use)
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
_empty =
|
|
|
|
_sp = $(_empty) $(_empty)
|
|
|
|
# The following list was generated by running:
|
|
|
|
# man signal.h|col -b|perl -ne '/bsd_signal.*;/.../sigwaitinfo.*;/ and print' \
|
|
|
|
# | perl -lne '/^\s+(?:int|void).*?(\w+).*/ and print $1' | fmt
|
|
|
|
_sig_functions = \
|
|
|
|
bsd_signal kill killpg pthread_kill pthread_sigmask raise sigaction \
|
|
|
|
sigaddset sigaltstack sigdelset sigemptyset sigfillset sighold sigignore \
|
|
|
|
siginterrupt sigismember signal sigpause sigpending sigprocmask sigqueue \
|
|
|
|
sigrelse sigset sigsuspend sigtimedwait sigwait sigwaitinfo
|
|
|
|
_sig_function_re = $(subst $(_sp),|,$(strip $(_sig_functions)))
|
|
|
|
# The following were extracted from "man signal.h" manually.
|
|
|
|
_sig_types_and_consts = \
|
|
|
|
MINSIGSTKSZ SA_NOCLDSTOP SA_NOCLDWAIT SA_NODEFER SA_ONSTACK \
|
|
|
|
SA_RESETHAND SA_RESTART SA_SIGINFO SIGEV_NONE SIGEV_SIGNAL \
|
|
|
|
SIGEV_THREAD SIGSTKSZ SIG_BLOCK SIG_SETMASK SIG_UNBLOCK SS_DISABLE \
|
|
|
|
SS_ONSTACK mcontext_t pid_t sig_atomic_t sigevent siginfo_t sigset_t \
|
|
|
|
sigstack sigval stack_t ucontext_t
|
|
|
|
# generated via this:
|
|
|
|
# perl -lne '/^#ifdef (SIG\w+)/ and print $1' lib/sig2str.c|sort -u|fmt -70
|
|
|
|
_sig_names = \
|
|
|
|
SIGABRT SIGALRM SIGALRM1 SIGBUS SIGCANCEL SIGCHLD SIGCLD SIGCONT \
|
|
|
|
SIGDANGER SIGDIL SIGEMT SIGFPE SIGFREEZE SIGGRANT SIGHUP SIGILL \
|
|
|
|
SIGINFO SIGINT SIGIO SIGIOT SIGKAP SIGKILL SIGKILLTHR SIGLOST SIGLWP \
|
|
|
|
SIGMIGRATE SIGMSG SIGPHONE SIGPIPE SIGPOLL SIGPRE SIGPROF SIGPWR \
|
|
|
|
SIGQUIT SIGRETRACT SIGSAK SIGSEGV SIGSOUND SIGSTKFLT SIGSTOP SIGSYS \
|
|
|
|
SIGTERM SIGTHAW SIGTRAP SIGTSTP SIGTTIN SIGTTOU SIGURG SIGUSR1 \
|
|
|
|
SIGUSR2 SIGVIRT SIGVTALRM SIGWAITING SIGWINCH SIGWIND SIGWINDOW \
|
|
|
|
SIGXCPU SIGXFSZ
|
|
|
|
_sig_syms_re = $(subst $(_sp),|,$(strip $(_sig_names) $(_sig_types_and_consts)))
|
|
|
|
|
|
|
|
# Prohibit the inclusion of signal.h without an actual use.
|
|
|
|
sc_prohibit_signal_without_use:
|
|
|
|
@h='<signal.h>' \
|
|
|
|
re='\<($(_sig_function_re)) *\(|\<($(_sig_syms_re))\>' \
|
|
|
|
$(_header_without_use)
|
2008-05-09 13:50:14 +00:00
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
sc_obsolete_symbols:
|
2009-01-29 18:06:19 +00:00
|
|
|
@re='\<(HAVE''_FCNTL_H|O''_NDELAY)\>' \
|
|
|
|
msg='do not use HAVE''_FCNTL_H or O'_NDELAY \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
# FIXME: warn about definitions of EXIT_FAILURE, EXIT_SUCCESS, STREQ
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# Each nonempty ChangeLog line must start with a year number, or a TAB.
|
2008-01-29 17:42:39 +00:00
|
|
|
sc_changelog:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@if $(VC_LIST_EXCEPT) | grep -l '^ChangeLog$$' >/dev/null; then \
|
|
|
|
grep -n '^[^12 ]' \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep '^ChangeLog$$') && \
|
2008-01-29 17:42:39 +00:00
|
|
|
{ echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2; \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
exit 1; } || :; \
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Ensure that each .c file containing a "main" function also
|
|
|
|
# calls set_program_name.
|
|
|
|
sc_program_name:
|
|
|
|
@if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \
|
|
|
|
files=$$(grep -l '^main *(' $$($(VC_LIST_EXCEPT) | grep '\.c$$')); \
|
|
|
|
grep -LE 'set_program_name *\(m?argv\[0\]\);' $$files \
|
|
|
|
| grep . && \
|
|
|
|
{ echo '$(ME): the above files do not call set_program_name' \
|
|
|
|
1>&2; exit 1; } || :; \
|
|
|
|
else :; \
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Require that the final line of each test-lib.sh-using test be this one:
|
|
|
|
# Exit $fail
|
|
|
|
# Note: this test requires GNU grep's --label= option.
|
|
|
|
Exit_witness_file ?= tests/test-lib.sh
|
|
|
|
Exit_base := $(notdir $(Exit_witness_file))
|
|
|
|
sc_require_test_exit_idiom:
|
|
|
|
@if test -f $(srcdir)/$(Exit_witness_file); then \
|
|
|
|
die=0; \
|
|
|
|
for i in $$(grep -l -F 'srcdir/$(Exit_base)' \
|
|
|
|
$$($(VC_LIST) tests)); do \
|
|
|
|
tail -n1 $$i | grep '^Exit .' > /dev/null \
|
|
|
|
&& : || { die=1; echo $$i; } \
|
|
|
|
done; \
|
|
|
|
test $$die = 1 && \
|
|
|
|
{ echo 1>&2 '$(ME): the final line in each of the above is not:'; \
|
|
|
|
echo 1>&2 'Exit something'; \
|
|
|
|
exit 1; } || :; \
|
|
|
|
fi
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
sc_the_the:
|
2009-01-29 18:06:19 +00:00
|
|
|
@re='\<the ''the\>' \
|
|
|
|
ignore_case=1 msg='found use of "the ''the";' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
sc_trailing_blank:
|
2009-01-29 18:06:19 +00:00
|
|
|
@re='[ ]$$' \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
msg='found trailing blank(s)' \
|
2009-01-29 18:06:19 +00:00
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
# Match lines like the following, but where there is only one space
|
|
|
|
# between the options and the description:
|
|
|
|
# -D, --all-repeated[=delimit-method] print all duplicate lines\n
|
|
|
|
longopt_re = --[a-z][0-9A-Za-z-]*(\[?=[0-9A-Za-z-]*\]?)?
|
|
|
|
sc_two_space_separator_in_usage:
|
|
|
|
@grep -nE '^ *(-[A-Za-z],)? $(longopt_re) [^ ].*\\$$' \
|
2008-03-24 10:20:15 +00:00
|
|
|
$$($(VC_LIST_EXCEPT)) && \
|
2008-01-29 17:42:39 +00:00
|
|
|
{ echo "$(ME): help2man requires at least two spaces between"; \
|
2009-01-29 12:11:28 +00:00
|
|
|
echo "$(ME): an option and its description"; \
|
2008-01-29 17:42:39 +00:00
|
|
|
1>&2; exit 1; } || :
|
|
|
|
|
|
|
|
# Look for diagnostics that aren't marked for translation.
|
|
|
|
# This won't find any for which error's format string is on a separate line.
|
|
|
|
sc_unmarked_diagnostics:
|
|
|
|
@grep -nE \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
'\<error \([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT)) \
|
2008-01-29 17:42:39 +00:00
|
|
|
| grep -v '_''(' && \
|
|
|
|
{ echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
|
|
|
|
exit 1; } || :
|
2008-12-11 15:14:03 +00:00
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Avoid useless parentheses like those in this example:
|
|
|
|
# #if defined (SYMBOL) || defined (SYM2)
|
|
|
|
sc_useless_cpp_parens:
|
2008-03-24 10:20:15 +00:00
|
|
|
@grep -n '^# *if .*defined *(' $$($(VC_LIST_EXCEPT)) && \
|
2008-01-29 17:42:39 +00:00
|
|
|
{ echo '$(ME): found useless parentheses in cpp directive' \
|
|
|
|
1>&2; exit 1; } || :
|
|
|
|
|
|
|
|
# Require the latest GPL.
|
|
|
|
sc_GPL_version:
|
2009-01-29 18:06:19 +00:00
|
|
|
@re='either ''version [^3]' msg='GPL vN, N!=3' \
|
|
|
|
$(_prohibit_regexp)
|
2008-01-29 17:42:39 +00:00
|
|
|
|
2009-01-29 12:11:28 +00:00
|
|
|
cvs_keywords = \
|
|
|
|
Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State
|
|
|
|
|
|
|
|
sc_prohibit_cvs_keyword:
|
|
|
|
@re='\$$($(cvs_keywords))\$$' \
|
|
|
|
msg='do not use CVS keyword expansion' \
|
|
|
|
$(_prohibit_regexp)
|
|
|
|
|
|
|
|
# Make sure we don't use st_blocks. Use ST_NBLOCKS instead.
|
|
|
|
# This is a bit of a kludge, since it prevents use of the string
|
|
|
|
# even in comments, but for now it does the job with no false positives.
|
|
|
|
sc_prohibit_stat_st_blocks:
|
|
|
|
@re='[.>]st_blocks' msg='do not use st_blocks; use ST_NBLOCKS' \
|
|
|
|
$(_prohibit_regexp)
|
|
|
|
|
|
|
|
# Make sure we don't define any S_IS* macros in src/*.c files.
|
|
|
|
# They're already defined via gnulib's sys/stat.h replacement.
|
|
|
|
sc_prohibit_S_IS_definition:
|
|
|
|
@re='^ *# *define *S_IS' \
|
|
|
|
msg='do not define S_IS* macros; include <sys/stat.h>' \
|
|
|
|
$(_prohibit_regexp)
|
|
|
|
|
|
|
|
# Each program that uses proper_name_utf8 must link with
|
|
|
|
# one of the ICONV libraries.
|
|
|
|
sc_proper_name_utf8_requires_ICONV:
|
|
|
|
@progs=$$(grep -l 'proper_name_utf8 ''("' $$($(VC_LIST_EXCEPT)));\
|
|
|
|
if test "x$$progs" != x; then \
|
|
|
|
fail=0; \
|
|
|
|
for p in $$progs; do \
|
|
|
|
dir=$$(dirname "$$p"); \
|
|
|
|
base=$$(basename "$$p" .c); \
|
|
|
|
grep "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \
|
|
|
|
|| { fail=1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \
|
|
|
|
done; \
|
|
|
|
test $$fail = 1 && \
|
|
|
|
{ echo 1>&2 '$(ME): the above do not link with any ICONV library'; \
|
|
|
|
exit 1; } || :; \
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Warn about "c0nst struct Foo const foo[]",
|
|
|
|
# but not about "char const *const foo" or "#define const const".
|
|
|
|
sc_redundant_const:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@re='\bconst\b[[:space:][:alnum:]]{2,}\bconst\b' \
|
|
|
|
msg='redundant "const" in declarations' \
|
|
|
|
$(_prohibit_regexp)
|
2009-01-29 12:11:28 +00:00
|
|
|
|
|
|
|
sc_const_long_option:
|
|
|
|
@grep '^ *static.*struct option ' $$($(VC_LIST_EXCEPT)) \
|
|
|
|
| grep -Ev 'const struct option|struct option const' && { \
|
|
|
|
echo 1>&2 '$(ME): add "const" to the above declarations'; \
|
|
|
|
exit 1; } || :
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
NEWS_hash = \
|
|
|
|
$$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \
|
|
|
|
$(srcdir)/NEWS \
|
|
|
|
| grep -v '^Copyright .*Free Software' \
|
|
|
|
| md5sum - \
|
|
|
|
| sed 's/ .*//')
|
2009-01-29 12:11:28 +00:00
|
|
|
|
|
|
|
# Ensure that we don't accidentally insert an entry into an old NEWS block.
|
|
|
|
sc_immutable_NEWS:
|
|
|
|
@if test -f $(srcdir)/NEWS; then \
|
|
|
|
test "$(NEWS_hash)" = '$(old_NEWS_hash)' && : || \
|
|
|
|
{ echo '$(ME): you have modified old NEWS' 1>&2; exit 1; }; \
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Update the hash stored above. Do this after each release and
|
|
|
|
# for any corrections to old entries.
|
|
|
|
update-NEWS-hash: NEWS
|
|
|
|
perl -pi -e 's/^(old_NEWS_hash = ).*/$${1}'"$(NEWS_hash)/" \
|
|
|
|
$(srcdir)/cfg.mk
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Ensure that we use only the standard $(VAR) notation,
|
|
|
|
# not @...@ in Makefile.am, now that we can rely on automake
|
|
|
|
# to emit a definition for each substituted variable.
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# We use perl rather than "grep -nE ..." to exempt a single
|
|
|
|
# use of an @...@-delimited variable name in src/Makefile.am.
|
|
|
|
sc_makefile_check:
|
|
|
|
@perl -ne '/\@[A-Z_0-9]+\@/ && !/^cu_install_program =/' \
|
|
|
|
-e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}' \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$') \
|
|
|
|
&& { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || :
|
2008-01-29 17:42:39 +00:00
|
|
|
|
|
|
|
news-date-check: NEWS
|
|
|
|
today=`date +%Y-%m-%d`; \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
if head $(srcdir)/NEWS | grep '^\*.* $(VERSION_REGEXP) ('$$today')' \
|
2008-01-29 17:42:39 +00:00
|
|
|
>/dev/null; then \
|
|
|
|
:; \
|
|
|
|
else \
|
|
|
|
echo "version or today's date is not in NEWS" 1>&2; \
|
|
|
|
exit 1; \
|
|
|
|
fi
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
sc_makefile_TAB_only_indentation:
|
|
|
|
@grep -nE '^ [ ]{8}' \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep -E 'akefile|\.mk$$') \
|
|
|
|
&& { echo '$(ME): found TAB-8-space indentation' 1>&2; \
|
|
|
|
exit 1; } || :
|
2008-01-29 17:42:39 +00:00
|
|
|
|
2009-01-29 12:11:28 +00:00
|
|
|
sc_m4_quote_check:
|
|
|
|
@grep -nE '(AC_DEFINE(_UNQUOTED)?|AC_DEFUN)\([^[]' \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep -E '(^configure\.ac|\.m4)$$') \
|
|
|
|
&& { echo '$(ME): quote the first arg to AC_DEF*' 1>&2; \
|
2008-01-29 17:42:39 +00:00
|
|
|
exit 1; } || :
|
|
|
|
|
2008-10-16 17:18:48 +00:00
|
|
|
fix_po_file_diag = \
|
|
|
|
'you have changed the set of files with translatable diagnostics;\n\
|
|
|
|
apply the above patch\n'
|
|
|
|
|
2008-01-29 17:42:39 +00:00
|
|
|
# Verify that all source files using _() are listed in po/POTFILES.in.
|
2008-10-16 17:18:48 +00:00
|
|
|
po_file = po/POTFILES.in
|
2009-01-29 12:11:28 +00:00
|
|
|
sc_po_check:
|
2009-01-05 13:17:34 +00:00
|
|
|
@if test -f $(po_file); then \
|
|
|
|
grep -E -v '^(#|$$)' $(po_file) \
|
2008-01-29 17:42:39 +00:00
|
|
|
| grep -v '^src/false\.c$$' | sort > $@-1; \
|
|
|
|
files=; \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
for file in $$($(VC_LIST_EXCEPT)) lib/*.[ch]; do \
|
|
|
|
test -r $$file || continue; \
|
2008-03-24 10:20:15 +00:00
|
|
|
case $$file in \
|
2009-01-05 13:17:34 +00:00
|
|
|
*.?|*.??) ;; \
|
|
|
|
*) continue;; \
|
2008-03-24 10:20:15 +00:00
|
|
|
esac; \
|
2008-01-29 17:42:39 +00:00
|
|
|
case $$file in \
|
|
|
|
*.[ch]) \
|
|
|
|
base=`expr " $$file" : ' \(.*\)\..'`; \
|
|
|
|
{ test -f $$base.l || test -f $$base.y; } && continue;; \
|
|
|
|
esac; \
|
|
|
|
files="$$files $$file"; \
|
|
|
|
done; \
|
|
|
|
grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files \
|
|
|
|
| sort -u > $@-2; \
|
2008-10-16 17:18:48 +00:00
|
|
|
diff -u -L $(po_file) -L $(po_file) $@-1 $@-2 \
|
|
|
|
|| { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; }; \
|
2008-01-29 17:42:39 +00:00
|
|
|
rm -f $@-1 $@-2; \
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Sometimes it is useful to change the PATH environment variable
|
|
|
|
# in Makefiles. When doing so, it's better not to use the Unix-centric
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
# path separator of `:', but rather the automake-provided `$(PATH_SEPARATOR)'.
|
|
|
|
msg = '$(ME): Do not use `:'\'' above; use $$(PATH_SEPARATOR) instead'
|
2009-01-29 12:11:28 +00:00
|
|
|
sc_makefile_path_separator_check:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
@grep -nE 'PATH[=].*:' \
|
|
|
|
$$($(VC_LIST_EXCEPT) | grep -E 'akefile|\.mk$$') \
|
2008-01-29 17:42:39 +00:00
|
|
|
&& { echo $(msg) 1>&2; exit 1; } || :
|
|
|
|
|
|
|
|
# Check that `make alpha' will not fail at the end of the process.
|
|
|
|
writable-files:
|
|
|
|
if test -d $(release_archive_dir); then :; else \
|
2008-03-24 10:20:15 +00:00
|
|
|
for file in $(distdir).tar.gz \
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
$(release_archive_dir)/$(distdir).tar.gz; do \
|
2008-03-24 10:20:15 +00:00
|
|
|
test -e $$file || continue; \
|
|
|
|
test -w $$file \
|
|
|
|
|| { echo ERROR: $$file is not writable; fail=1; }; \
|
|
|
|
done; \
|
2009-01-05 13:17:34 +00:00
|
|
|
test "$$fail" && exit 1 || : ; \
|
2008-01-29 17:42:39 +00:00
|
|
|
fi
|
|
|
|
|
|
|
|
v_etc_file = lib/version-etc.c
|
|
|
|
sample-test = tests/sample-test
|
|
|
|
texi = doc/$(PACKAGE).texi
|
|
|
|
# Make sure that the copyright date in $(v_etc_file) is up to date.
|
|
|
|
# Do the same for the $(sample-test) and the main doc/.texi file.
|
2009-01-29 12:11:28 +00:00
|
|
|
sc_copyright_check:
|
|
|
|
@if test -f $(v_etc_file); then \
|
2008-01-29 17:42:39 +00:00
|
|
|
grep 'enum { COPYRIGHT_YEAR = '$$(date +%Y)' };' $(v_etc_file) \
|
2009-01-29 12:11:28 +00:00
|
|
|
>/dev/null \
|
2008-01-29 17:42:39 +00:00
|
|
|
|| { echo 'out of date copyright in $(v_etc_file); update it' 1>&2; \
|
2009-01-29 12:11:28 +00:00
|
|
|
exit 1; }; \
|
2008-01-29 17:42:39 +00:00
|
|
|
fi
|
2009-01-29 12:11:28 +00:00
|
|
|
@if test -f $(sample-test); then \
|
|
|
|
grep '# Copyright (C) '$$(date +%Y)' Free' $(sample-test) \
|
|
|
|
>/dev/null \
|
2008-01-29 17:42:39 +00:00
|
|
|
|| { echo 'out of date copyright in $(sample-test); update it' 1>&2; \
|
2009-01-29 12:11:28 +00:00
|
|
|
exit 1; }; \
|
2008-01-29 17:42:39 +00:00
|
|
|
fi
|
2009-01-29 12:11:28 +00:00
|
|
|
@if test -f $(texi); then \
|
|
|
|
grep 'Copyright @copyright{} .*'$$(date +%Y)' Free' $(texi) \
|
|
|
|
>/dev/null \
|
|
|
|
|| { echo 'out of date copyright in $(texi); update it' 1>&2; \
|
|
|
|
exit 1; }; \
|
2008-01-29 17:42:39 +00:00
|
|
|
fi
|
|
|
|
|
|
|
|
vc-diff-check:
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
(unset CDPATH; cd $(srcdir) && $(VC) diff) > vc-diffs || :
|
2008-01-29 17:42:39 +00:00
|
|
|
if test -s vc-diffs; then \
|
|
|
|
cat vc-diffs; \
|
|
|
|
echo "Some files are locally modified:" 1>&2; \
|
|
|
|
exit 1; \
|
|
|
|
else \
|
|
|
|
rm vc-diffs; \
|
|
|
|
fi
|
|
|
|
|
|
|
|
cvs-check: vc-diff-check
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
ALL_RECURSIVE_TARGETS += maintainer-distcheck
|
2008-01-29 17:42:39 +00:00
|
|
|
maintainer-distcheck:
|
|
|
|
$(MAKE) distcheck
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
$(MAKE) taint-distcheck
|
2008-01-29 17:42:39 +00:00
|
|
|
$(MAKE) my-distcheck
|
|
|
|
|
2009-01-29 12:11:28 +00:00
|
|
|
|
|
|
|
# Don't make a distribution if checks fail.
|
|
|
|
# Also, make sure the NEWS file is up-to-date.
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
ALL_RECURSIVE_TARGETS += vc-dist
|
2009-01-29 12:11:28 +00:00
|
|
|
vc-dist: $(local-check) cvs-check maintainer-distcheck
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
XZ_OPT=-9ev $(MAKE) dist
|
2009-01-29 12:11:28 +00:00
|
|
|
|
|
|
|
# Use this to make sure we don't run these programs when building
|
|
|
|
# from a virgin tgz file, below.
|
|
|
|
null_AM_MAKEFLAGS = \
|
|
|
|
ACLOCAL=false \
|
|
|
|
AUTOCONF=false \
|
|
|
|
AUTOMAKE=false \
|
|
|
|
AUTOHEADER=false \
|
|
|
|
MAKEINFO=false
|
|
|
|
|
|
|
|
built_programs = $$(cd src && MAKEFLAGS= $(MAKE) -s built_programs.list)
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
rel-files = $(DIST_ARCHIVES)
|
|
|
|
|
|
|
|
gnulib_dir ?= $(srcdir)/gnulib
|
|
|
|
gnulib-version = $$(cd $(gnulib_dir) && git describe)
|
|
|
|
bootstrap-tools ?= autoconf,automake,gnulib
|
|
|
|
|
|
|
|
announcement: NEWS ChangeLog $(rel-files)
|
|
|
|
@$(build_aux)/announce-gen \
|
|
|
|
--release-type=$(RELEASE_TYPE) \
|
|
|
|
--package=$(PACKAGE) \
|
|
|
|
--prev=$(PREV_VERSION) \
|
|
|
|
--curr=$(VERSION) \
|
|
|
|
--gpg-key-id=$(gpg_key_ID) \
|
|
|
|
--news=NEWS \
|
|
|
|
--bootstrap-tools=$(bootstrap-tools) \
|
|
|
|
--gnulib-version=$(gnulib-version) \
|
|
|
|
--no-print-checksums \
|
|
|
|
$(addprefix --url-dir=, $(url_dir_list))
|
|
|
|
|
|
|
|
## ---------------- ##
|
|
|
|
## Updating files. ##
|
|
|
|
## ---------------- ##
|
|
|
|
|
|
|
|
ftp-gnu = ftp://ftp.gnu.org/gnu
|
|
|
|
www-gnu = http://www.gnu.org
|
|
|
|
|
|
|
|
emit_upload_commands:
|
|
|
|
@echo =====================================
|
|
|
|
@echo =====================================
|
|
|
|
@echo "$(build_aux)/gnupload $(GNUPLOADFLAGS) \\"
|
|
|
|
@echo " --to $(gnu_rel_host):$(PACKAGE) \\"
|
|
|
|
@echo " $(rel-files)"
|
|
|
|
@echo '# send the /tmp/announcement e-mail'
|
|
|
|
@echo =====================================
|
|
|
|
@echo =====================================
|
|
|
|
|
|
|
|
noteworthy = * Noteworthy changes in release ?.? (????-??-??) [?]
|
|
|
|
define emit-commit-log
|
|
|
|
printf '%s\n' 'post-release administrivia' '' \
|
|
|
|
'* NEWS: Add header line for next release.' \
|
|
|
|
'* .prev-version: Record previous version.' \
|
|
|
|
'* cfg.mk (old_NEWS_hash): Auto-update.'
|
2009-01-29 12:11:28 +00:00
|
|
|
endef
|
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
.PHONY: no-submodule-changes
|
|
|
|
no-submodule-changes:
|
|
|
|
if test -d $(srcdir)/.git; then \
|
|
|
|
diff=$$(cd $(srcdir) && git submodule -q foreach \
|
|
|
|
git diff-index --name-only HEAD) \
|
|
|
|
|| exit 1; \
|
|
|
|
case $$diff in '') ;; \
|
|
|
|
*) echo '$(ME): submodule files are locally modified:'; \
|
|
|
|
echo "$$diff"; exit 1;; esac; \
|
|
|
|
else \
|
|
|
|
: ; \
|
|
|
|
fi
|
2009-01-29 12:11:28 +00:00
|
|
|
|
Prepare to use maint.mk from gnulib
Since Makefile.maint will soon come from gnulib's maint.mk,
sync Makefile.maint to have the same contents (modulo minor
things). In syncing it, we have to remove some libvirt-specific
rules. Since we want to keep them (of course), put those in cfg.mk.
* Makefile.maint: Merge from gnulib's maint.mk.
* cfg.mk (sc_avoid_write): New rule. From Makefile.cfg.
(sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
(sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
(sc_prohibit_nonreentrant): Likewise.
(sc_prohibit_ctype_h): Likewise.
(sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
(sc_prohibit_virBufferAdd_with_string_literal): Likewise.
(sc_prohibit_gethostby): Likewise.
(sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the
rule, inserting "_libvirt", since this rule is a specialization of
the one in gnulib.
* GNUmakefile: Include cfg.mk, not Makefile.cfg
* .x-sc_prohibit_strcmp_and_strncmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
2009-07-06 16:28:10 +00:00
|
|
|
.PHONY: alpha beta major
|
|
|
|
ALL_RECURSIVE_TARGETS += alpha beta major
|
|
|
|
alpha beta major: $(local-check) writable-files no-submodule-changes
|
|
|
|
test $@ = major \
|
|
|
|
&& { echo $(VERSION) | grep -E '^[0-9]+(\.[0-9]+)+$$' \
|
|
|
|
|| { echo "invalid version string: $(VERSION)" 1>&2; exit 1;};}\
|
|
|
|
|| :
|
|
|
|
$(MAKE) vc-dist
|
|
|
|
$(MAKE) news-date-check
|
|
|
|
$(MAKE) -s announcement RELEASE_TYPE=$@ > /tmp/announce-$(my_distdir)
|
|
|
|
if test -d $(release_archive_dir); then \
|
|
|
|
ln $(rel-files) $(release_archive_dir); \
|
|
|
|
chmod a-w $(rel-files); \
|
|
|
|
fi
|
|
|
|
$(MAKE) -s emit_upload_commands RELEASE_TYPE=$@
|
|
|
|
echo $(VERSION) > $(prev_version_file)
|
|
|
|
$(MAKE) update-NEWS-hash
|
|
|
|
perl -pi -e '$$. == 3 and print "$(noteworthy)\n\n\n"' NEWS
|
|
|
|
$(emit-commit-log) > .ci-msg
|
|
|
|
$(VC) commit -F .ci-msg -a
|
|
|
|
|
|
|
|
.PHONY: web-manual
|
|
|
|
web-manual:
|
|
|
|
@test -z "$(manual_title)" \
|
|
|
|
&& { echo define manual_title in cfg.mk 1>&2; exit 1; } || :
|
|
|
|
@cd '$(srcdir)/doc'; \
|
|
|
|
$(SHELL) ../build-aux/gendocs.sh -o '$(abs_builddir)/doc/manual' \
|
|
|
|
--email $(PACKAGE_BUGREPORT) $(PACKAGE) \
|
|
|
|
"$(PACKAGE_NAME) - $(manual_title)"
|
|
|
|
@echo " *** Upload the doc/manual directory to web-cvs."
|
|
|
|
|
|
|
|
# Code Coverage
|
|
|
|
|
|
|
|
init-coverage:
|
|
|
|
$(MAKE) $(AM_MAKEFLAGS) clean
|
|
|
|
lcov --directory . --zerocounters
|
|
|
|
|
|
|
|
COVERAGE_CCOPTS ?= "-g --coverage"
|
|
|
|
COVERAGE_OUT ?= doc/coverage
|
|
|
|
|
|
|
|
build-coverage:
|
|
|
|
$(MAKE) $(AM_MAKEFLAGS) CFLAGS=$(COVERAGE_CCOPTS) CXXFLAGS=$(COVERAGE_CCOPTS)
|
|
|
|
$(MAKE) $(AM_MAKEFLAGS) CFLAGS=$(COVERAGE_CCOPTS) CXXFLAGS=$(COVERAGE_CCOPTS) check
|
|
|
|
mkdir -p $(COVERAGE_OUT)
|
|
|
|
lcov --directory . --output-file $(COVERAGE_OUT)/$(PACKAGE).info \
|
|
|
|
--capture
|
|
|
|
|
|
|
|
gen-coverage:
|
|
|
|
genhtml --output-directory $(COVERAGE_OUT) \
|
|
|
|
$(COVERAGE_OUT)/$(PACKAGE).info \
|
|
|
|
--highlight --frames --legend \
|
|
|
|
--title "$(PACKAGE_NAME)"
|
|
|
|
|
|
|
|
coverage: init-coverage build-coverage gen-coverage
|
|
|
|
|
|
|
|
# Update gettext files.
|
|
|
|
PACKAGE ?= $(shell basename $(PWD))
|
|
|
|
PO_DOMAIN ?= $(PACKAGE)
|
|
|
|
POURL = http://translationproject.org/latest/$(PO_DOMAIN)/
|
|
|
|
PODIR ?= po
|
|
|
|
refresh-po:
|
|
|
|
rm -f $(PODIR)/*.po && \
|
|
|
|
echo "$(ME): getting translations into po (please ignore the robots.txt ERROR 404)..." && \
|
|
|
|
wget --no-verbose --directory-prefix $(PODIR) --no-directories --recursive --level 1 --accept .po --accept .po.1 $(POURL) && \
|
|
|
|
echo 'en@boldquot' > $(PODIR)/LINGUAS && \
|
|
|
|
echo 'en@quot' >> $(PODIR)/LINGUAS && \
|
|
|
|
ls $(PODIR)/*.po | sed 's/\.po//' | sed 's,$(PODIR)/,,' | sort >> $(PODIR)/LINGUAS
|
|
|
|
|
|
|
|
INDENT_SOURCES ?= $(C_SOURCES)
|
|
|
|
.PHONY: indent
|
|
|
|
indent:
|
|
|
|
indent $(INDENT_SOURCES)
|