2005-11-02 13:19:10 +00:00
|
|
|
/*
|
|
|
|
* internal.h: internal definitions just used by code from the library
|
2013-05-14 23:42:12 +00:00
|
|
|
*
|
2013-12-20 14:02:49 +00:00
|
|
|
* Copyright (C) 2006-2014 Red Hat, Inc.
|
2013-05-14 23:42:12 +00:00
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library. If not, see
|
|
|
|
* <http://www.gnu.org/licenses/>.
|
2005-11-02 13:19:10 +00:00
|
|
|
*/
|
|
|
|
|
2019-06-07 20:20:27 +00:00
|
|
|
#pragma once
|
|
|
|
|
|
|
|
#include <errno.h>
|
|
|
|
#include <limits.h>
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <string.h>
|
2019-10-03 14:51:30 +00:00
|
|
|
#include <stdlib.h>
|
2019-12-24 15:25:40 +00:00
|
|
|
#include "glibcompat.h"
|
2019-06-07 20:20:27 +00:00
|
|
|
|
2020-11-16 09:57:56 +00:00
|
|
|
#if defined __clang_analyzer__ || defined __COVERITY__
|
|
|
|
# define STATIC_ANALYSIS 1
|
|
|
|
#endif
|
|
|
|
|
2019-06-07 20:20:27 +00:00
|
|
|
#if STATIC_ANALYSIS
|
|
|
|
# undef NDEBUG /* Don't let a prior NDEBUG definition cause trouble. */
|
|
|
|
# include <assert.h>
|
|
|
|
# define sa_assert(expr) assert (expr)
|
|
|
|
#else
|
|
|
|
# define sa_assert(expr) /* empty */
|
|
|
|
#endif
|
2010-04-07 14:13:17 +00:00
|
|
|
|
2020-01-14 15:59:35 +00:00
|
|
|
#define VIR_INT_MULTIPLY_OVERFLOW(a,b) (G_UNLIKELY ((b) > 0 && (a) > G_MAXINT / (b)))
|
|
|
|
|
2008-05-23 08:32:08 +00:00
|
|
|
/* The library itself is allowed to use deprecated functions /
|
|
|
|
* variables, so effectively undefine the deprecated attribute
|
|
|
|
* which would otherwise be defined in libvirt.h.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#undef VIR_DEPRECATED
|
|
|
|
#define VIR_DEPRECATED /*empty*/
|
2008-05-23 08:32:08 +00:00
|
|
|
|
2012-01-20 18:43:28 +00:00
|
|
|
/* The library itself needs to know enum sizes. */
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_ENUM_SENTINELS
|
|
|
|
|
2020-09-01 11:27:44 +00:00
|
|
|
#ifdef WITH_LIBINTL_H
|
2019-06-07 20:20:27 +00:00
|
|
|
# define DEFAULT_TEXT_DOMAIN PACKAGE
|
|
|
|
# include <libintl.h>
|
|
|
|
# define _(str) dgettext(PACKAGE, str)
|
2020-09-01 11:27:44 +00:00
|
|
|
#else /* WITH_LIBINTL_H */
|
2019-06-07 20:20:27 +00:00
|
|
|
# define _(str) str
|
2020-09-01 11:27:44 +00:00
|
|
|
#endif /* WITH_LIBINTL_H */
|
2019-06-07 20:20:27 +00:00
|
|
|
#define N_(str) str
|
|
|
|
|
|
|
|
#include "libvirt/libvirt.h"
|
|
|
|
#include "libvirt/libvirt-lxc.h"
|
|
|
|
#include "libvirt/libvirt-qemu.h"
|
|
|
|
#include "libvirt/libvirt-admin.h"
|
|
|
|
#include "libvirt/virterror.h"
|
|
|
|
|
2019-10-03 15:25:45 +00:00
|
|
|
/* Merely casting to (void) is not sufficient since the
|
|
|
|
* introduction of the "warn_unused_result" attribute
|
|
|
|
*/
|
|
|
|
#define ignore_value(x) \
|
|
|
|
(__extension__ ({ __typeof__ (x) __x = (x); (void) __x; }))
|
|
|
|
|
2011-03-31 02:26:27 +00:00
|
|
|
|
2007-06-22 11:42:22 +00:00
|
|
|
/* String equality tests, suggested by Jim Meyering. */
|
2019-06-07 20:20:27 +00:00
|
|
|
#define STREQ(a, b) (strcmp(a, b) == 0)
|
2019-11-19 14:00:08 +00:00
|
|
|
#define STRCASEEQ(a, b) (g_ascii_strcasecmp(a, b) == 0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define STRNEQ(a, b) (strcmp(a, b) != 0)
|
2019-11-19 14:00:08 +00:00
|
|
|
#define STRCASENEQ(a, b) (g_ascii_strcasecmp(a, b) != 0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define STREQLEN(a, b, n) (strncmp(a, b, n) == 0)
|
2019-11-19 14:00:50 +00:00
|
|
|
#define STRCASEEQLEN(a, b, n) (g_ascii_strncasecmp(a, b, n) == 0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define STRNEQLEN(a, b, n) (strncmp(a, b, n) != 0)
|
2019-11-19 14:00:50 +00:00
|
|
|
#define STRCASENEQLEN(a, b, n) (g_ascii_strncasecmp(a, b, n) != 0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define STRPREFIX(a, b) (strncmp(a, b, strlen(b)) == 0)
|
2019-11-19 14:00:50 +00:00
|
|
|
#define STRCASEPREFIX(a, b) (g_ascii_strncasecmp(a, b, strlen(b)) == 0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define STRSKIP(a, b) (STRPREFIX(a, b) ? (a) + strlen(b) : NULL)
|
|
|
|
|
2019-10-24 14:06:19 +00:00
|
|
|
#define STREQ_NULLABLE(a, b) (g_strcmp0(a, b) == 0)
|
|
|
|
#define STRNEQ_NULLABLE(a, b) (g_strcmp0(a, b) != 0)
|
2010-03-22 18:44:58 +00:00
|
|
|
|
2019-06-07 20:20:27 +00:00
|
|
|
#define NUL_TERMINATE(buf) do { (buf)[sizeof(buf)-1] = '\0'; } while (0)
|
2008-04-25 20:46:13 +00:00
|
|
|
|
2020-01-22 11:44:16 +00:00
|
|
|
#ifdef WIN32
|
|
|
|
# ifndef O_CLOEXEC
|
|
|
|
# define O_CLOEXEC _O_NOINHERIT
|
|
|
|
# endif
|
|
|
|
#endif
|
|
|
|
|
2017-04-07 14:07:49 +00:00
|
|
|
/**
|
2019-10-15 11:24:34 +00:00
|
|
|
* G_GNUC_NO_INLINE:
|
2017-04-07 14:07:49 +00:00
|
|
|
*
|
2017-07-12 10:07:17 +00:00
|
|
|
* Force compiler not to inline a method. Should be used if
|
|
|
|
* the method need to be overridable by test mocks.
|
2019-10-15 11:24:34 +00:00
|
|
|
*
|
|
|
|
* TODO: Remove after upgrading to GLib >= 2.58
|
2017-04-07 14:07:49 +00:00
|
|
|
*/
|
2019-10-15 11:24:34 +00:00
|
|
|
#ifndef G_GNUC_NO_INLINE
|
|
|
|
# define G_GNUC_NO_INLINE __attribute__((__noinline__))
|
2019-06-07 20:20:27 +00:00
|
|
|
#endif
|
2017-04-07 14:07:49 +00:00
|
|
|
|
nwfilter: Support for learning a VM's IP address
This patch implements support for learning a VM's IP address. It uses
the pcap library to listen on the VM's backend network interface (tap)
or the physical ethernet device (macvtap) and tries to capture packets
with source or destination MAC address of the VM and learn from DHCP
Offers, ARP traffic, or first-sent IPv4 packet what the IP address of
the VM's interface is. This then allows to instantiate the network
traffic filtering rules without the user having to provide the IP
parameter somewhere in the filter description or in the interface
description as a parameter. This only supports to detect the parameter
IP, which is for the assumed single IPv4 address of a VM. There is not
support for interfaces that may have multiple IP addresses (IP
aliasing) or IPv6 that may then require more than one valid IP address
to be detected. A VM can have multiple independent interfaces that each
uses a different IP address and in that case it will be attempted to
detect each one of the address independently.
So, when for example an interface description in the domain XML has
looked like this up to now:
<interface type='bridge'>
<source bridge='mybridge'/>
<model type='virtio'/>
<filterref filter='clean-traffic'>
<parameter name='IP' value='10.2.3.4'/>
</filterref>
</interface>
you may omit the IP parameter:
<interface type='bridge'>
<source bridge='mybridge'/>
<model type='virtio'/>
<filterref filter='clean-traffic'/>
</interface>
Internally I am walking the 'tree' of a VM's referenced network filters
and determine with the given variables which variables are missing. Now,
the above IP parameter may be missing and this causes a libvirt-internal
thread to be started that uses the pcap library's API to listen to the
backend interface (in case of macvtap to the physical interface) in an
attempt to determine the missing IP parameter. If the backend interface
disappears the thread terminates assuming the VM was brought down. In
case of a macvtap device a timeout is being used to wait for packets
from the given VM (filtering by VM's interface MAC address). If the VM's
macvtap device disappeared the thread also terminates. In all other
cases it tries to determine the IP address of the VM and will then apply
the rules late on the given interface, which would have happened
immediately if the IP parameter had been explicitly given. In case an
error happens while the firewall rules are applied, the VM's backend
interface is 'down'ed preventing it to communicate. Reasons for failure
for applying the network firewall rules may that an ebtables/iptables
command failes or OOM errors. Essentially the same failure reasons may
occur as when the firewall rules are applied immediately on VM start,
except that due to the late application of the filtering rules the VM
now is already running and cannot be hindered anymore from starting.
Bringing down the whole VM would probably be considered too drastic.
While a VM's IP address is attempted to be determined only limited
updates to network filters are allowed. In particular it is prevented
that filters are modified in such a way that they would introduce new
variables.
A caveat: The algorithm does not know which one is the appropriate IP
address of a VM. If the VM spoofs an IP address in its first ARP traffic
or IPv4 packets its filtering rules will be instantiated for this IP
address, thus 'locking' it to the found IP address. So, it's still
'safer' to explicitly provide the IP address of a VM's interface in the
filter description if it is known beforehand.
* configure.ac: detect libpcap
* libvirt.spec.in: require libpcap[-devel] if qemu is built
* src/internal.h: add the new ATTRIBUTE_PACKED define
* src/Makefile.am src/libvirt_private.syms: add the new modules and symbols
* src/nwfilter/nwfilter_learnipaddr.[ch]: new module being added
* src/nwfilter/nwfilter_driver.c src/conf/nwfilter_conf.[ch]
src/nwfilter/nwfilter_ebiptables_driver.[ch]
src/nwfilter/nwfilter_gentech_driver.[ch]: plu the new functionality in
* tests/nwfilterxml2xmltest: extend testing
2010-04-07 21:02:18 +00:00
|
|
|
/**
|
|
|
|
* ATTRIBUTE_PACKED
|
|
|
|
*
|
|
|
|
* force a structure to be packed, i.e. not following architecture and
|
|
|
|
* compiler best alignments for its sub components. It's needed for example
|
|
|
|
* for the network filetering code when defining the content of raw
|
|
|
|
* ethernet packets.
|
|
|
|
* Others compiler than gcc may use something different e.g. #pragma pack(1)
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#ifndef ATTRIBUTE_PACKED
|
|
|
|
# define ATTRIBUTE_PACKED __attribute__((packed))
|
|
|
|
#endif
|
nwfilter: Support for learning a VM's IP address
This patch implements support for learning a VM's IP address. It uses
the pcap library to listen on the VM's backend network interface (tap)
or the physical ethernet device (macvtap) and tries to capture packets
with source or destination MAC address of the VM and learn from DHCP
Offers, ARP traffic, or first-sent IPv4 packet what the IP address of
the VM's interface is. This then allows to instantiate the network
traffic filtering rules without the user having to provide the IP
parameter somewhere in the filter description or in the interface
description as a parameter. This only supports to detect the parameter
IP, which is for the assumed single IPv4 address of a VM. There is not
support for interfaces that may have multiple IP addresses (IP
aliasing) or IPv6 that may then require more than one valid IP address
to be detected. A VM can have multiple independent interfaces that each
uses a different IP address and in that case it will be attempted to
detect each one of the address independently.
So, when for example an interface description in the domain XML has
looked like this up to now:
<interface type='bridge'>
<source bridge='mybridge'/>
<model type='virtio'/>
<filterref filter='clean-traffic'>
<parameter name='IP' value='10.2.3.4'/>
</filterref>
</interface>
you may omit the IP parameter:
<interface type='bridge'>
<source bridge='mybridge'/>
<model type='virtio'/>
<filterref filter='clean-traffic'/>
</interface>
Internally I am walking the 'tree' of a VM's referenced network filters
and determine with the given variables which variables are missing. Now,
the above IP parameter may be missing and this causes a libvirt-internal
thread to be started that uses the pcap library's API to listen to the
backend interface (in case of macvtap to the physical interface) in an
attempt to determine the missing IP parameter. If the backend interface
disappears the thread terminates assuming the VM was brought down. In
case of a macvtap device a timeout is being used to wait for packets
from the given VM (filtering by VM's interface MAC address). If the VM's
macvtap device disappeared the thread also terminates. In all other
cases it tries to determine the IP address of the VM and will then apply
the rules late on the given interface, which would have happened
immediately if the IP parameter had been explicitly given. In case an
error happens while the firewall rules are applied, the VM's backend
interface is 'down'ed preventing it to communicate. Reasons for failure
for applying the network firewall rules may that an ebtables/iptables
command failes or OOM errors. Essentially the same failure reasons may
occur as when the firewall rules are applied immediately on VM start,
except that due to the late application of the filtering rules the VM
now is already running and cannot be hindered anymore from starting.
Bringing down the whole VM would probably be considered too drastic.
While a VM's IP address is attempted to be determined only limited
updates to network filters are allowed. In particular it is prevented
that filters are modified in such a way that they would introduce new
variables.
A caveat: The algorithm does not know which one is the appropriate IP
address of a VM. If the VM spoofs an IP address in its first ARP traffic
or IPv4 packets its filtering rules will be instantiated for this IP
address, thus 'locking' it to the found IP address. So, it's still
'safer' to explicitly provide the IP address of a VM's interface in the
filter description if it is known beforehand.
* configure.ac: detect libpcap
* libvirt.spec.in: require libpcap[-devel] if qemu is built
* src/internal.h: add the new ATTRIBUTE_PACKED define
* src/Makefile.am src/libvirt_private.syms: add the new modules and symbols
* src/nwfilter/nwfilter_learnipaddr.[ch]: new module being added
* src/nwfilter/nwfilter_driver.c src/conf/nwfilter_conf.[ch]
src/nwfilter/nwfilter_ebiptables_driver.[ch]
src/nwfilter/nwfilter_gentech_driver.[ch]: plu the new functionality in
* tests/nwfilterxml2xmltest: extend testing
2010-04-07 21:02:18 +00:00
|
|
|
|
build: force correct gcc syntax for attribute_nonnull
Gcc lets you do:
int ATTRIBUTE_NONNULL(1) foo(void *param);
int foo(void *param) ATTRIBUTE_NONNULL(1);
int ATTRIBUTE_NONNULL(1) foo(void *param) { ... }
but chokes on:
int foo(void *param) ATTRIBUTE_NONNULL(1) { ... }
However, since commit eefb881, we have intentionally been disabling
ATTRIBUTE_NONNULL because of lame gcc handling of the attribute (that
is, gcc doesn't do decent warning reporting, then compiles code that
mysteriously fails if you break the contract of the attribute, which
is surprisingly easy to do), leaving it on only for Coverity (which
does a much better job of improved static analysis when the attribute
is present).
But completely eliding the macro makes it too easy to write code that
uses the fourth syntax option, if you aren't using Coverity. So this
patch forces us to avoid syntax errors, even when not using the
attribute under gcc. It also documents WHY we disable the warning
under gcc, rather than forcing you to find the commit log.
* src/internal.h (ATTRIBUTE_NONNULL): Expand to empty attribute,
rather than nothing, when on gcc.
2013-02-18 20:34:58 +00:00
|
|
|
/* gcc's handling of attribute nonnull is less than stellar - it does
|
|
|
|
* NOT improve diagnostics, and merely allows gcc to optimize away
|
|
|
|
* null code checks even when the caller manages to pass null in spite
|
|
|
|
* of the attribute, leading to weird crashes. Coverity, on the other
|
|
|
|
* hand, knows how to do better static analysis based on knowing
|
|
|
|
* whether a parameter is nonnull. Make this attribute conditional
|
|
|
|
* based on whether we are compiling for real or for analysis, while
|
|
|
|
* still requiring correct gcc syntax when it is turned off. See also
|
2020-08-25 22:44:00 +00:00
|
|
|
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=17308 */
|
2019-06-07 20:20:27 +00:00
|
|
|
#ifndef ATTRIBUTE_NONNULL
|
|
|
|
# if STATIC_ANALYSIS
|
|
|
|
# define ATTRIBUTE_NONNULL(m) __attribute__((__nonnull__(m)))
|
|
|
|
# else
|
|
|
|
# define ATTRIBUTE_NONNULL(m) __attribute__(())
|
2017-07-05 09:35:32 +00:00
|
|
|
# endif
|
2019-06-07 20:20:27 +00:00
|
|
|
#endif
|
2017-02-22 17:37:09 +00:00
|
|
|
|
2019-10-15 11:36:47 +00:00
|
|
|
/**
|
|
|
|
*
|
2019-10-15 11:38:21 +00:00
|
|
|
* G_GNUC_FALLTHROUGH
|
2019-10-15 11:36:47 +00:00
|
|
|
*
|
|
|
|
* silence the compiler warning when falling through a switch case
|
|
|
|
*
|
2019-10-15 11:38:21 +00:00
|
|
|
* TODO: Remove after upgrading to GLib >= 2.60
|
2019-10-15 11:36:47 +00:00
|
|
|
*/
|
2019-10-15 11:38:21 +00:00
|
|
|
#ifndef G_GNUC_FALLTHROUGH
|
2019-06-07 20:20:27 +00:00
|
|
|
# if __GNUC_PREREQ (7, 0)
|
2019-10-15 11:38:21 +00:00
|
|
|
# define G_GNUC_FALLTHROUGH __attribute__((fallthrough))
|
2019-06-07 20:20:27 +00:00
|
|
|
# else
|
2019-10-15 11:38:21 +00:00
|
|
|
# define G_GNUC_FALLTHROUGH do {} while(0)
|
2017-07-05 09:35:32 +00:00
|
|
|
# endif
|
2019-06-07 20:20:27 +00:00
|
|
|
#endif
|
2013-04-03 14:52:40 +00:00
|
|
|
|
2019-07-30 13:07:24 +00:00
|
|
|
#define VIR_WARNINGS_NO_CAST_ALIGN \
|
2013-04-03 14:52:40 +00:00
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wcast-align\"")
|
2015-01-16 14:45:08 +00:00
|
|
|
|
2019-07-30 13:07:24 +00:00
|
|
|
#define VIR_WARNINGS_NO_DEPRECATED \
|
2017-04-07 14:43:38 +00:00
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wdeprecated-declarations\"")
|
|
|
|
|
2020-01-17 12:33:37 +00:00
|
|
|
#define VIR_WARNINGS_NO_POINTER_SIGN \
|
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wpointer-sign\"")
|
|
|
|
|
2020-09-01 11:27:44 +00:00
|
|
|
#if WITH_SUGGEST_ATTRIBUTE_FORMAT
|
2019-07-30 13:07:24 +00:00
|
|
|
# define VIR_WARNINGS_NO_PRINTF \
|
2014-11-18 14:50:05 +00:00
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wsuggest-attribute=format\"")
|
2019-07-30 13:07:24 +00:00
|
|
|
#else
|
|
|
|
# define VIR_WARNINGS_NO_PRINTF \
|
2015-01-16 14:45:08 +00:00
|
|
|
_Pragma ("GCC diagnostic push")
|
2019-07-30 13:07:24 +00:00
|
|
|
#endif
|
2013-04-03 14:52:40 +00:00
|
|
|
|
wireshark: fix compilation errors
With meson introduction which is using the same CFLAGS for the whole
project some compilation errors were discovered. The wireshark plugin
library is the only one in tools directory that is not using AM_CFLAGS.
With the AM_CFLAGS we get these errors:
../../tools/wireshark/src/packet-libvirt.c: In function 'dissect_libvirt_fds':
../../tools/wireshark/src/packet-libvirt.c:348:31: error: unused parameter 'tvb' [-Werror=unused-parameter]
348 | dissect_libvirt_fds(tvbuff_t *tvb, gint start, gint32 nfds)
| ~~~~~~~~~~^~~
../../tools/wireshark/src/packet-libvirt.c:348:41: error: unused parameter 'start' [-Werror=unused-parameter]
348 | dissect_libvirt_fds(tvbuff_t *tvb, gint start, gint32 nfds)
| ~~~~~^~~~~
../../tools/wireshark/src/packet-libvirt.c:348:55: error: unused parameter 'nfds' [-Werror=unused-parameter]
348 | dissect_libvirt_fds(tvbuff_t *tvb, gint start, gint32 nfds)
| ~~~~~~~^~~~
At top level:
../../tools/wireshark/src/packet-libvirt.c:64:5: error: 'dissect_xdr_bool' defined but not used [-Werror=unused-function]
64 | dissect_xdr_##xtype(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf) \
| ^~~~~~~~~~~~
../../tools/wireshark/src/packet-libvirt.c:88:1: note: in expansion of macro 'XDR_PRIMITIVE_DISSECTOR'
88 | XDR_PRIMITIVE_DISSECTOR(bool, bool_t, boolean)
| ^~~~~~~~~~~~~~~~~~~~~~~
../../tools/wireshark/src/packet-libvirt.c:64:5: error: 'dissect_xdr_float' defined but not used [-Werror=unused-function]
64 | dissect_xdr_##xtype(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf) \
| ^~~~~~~~~~~~
../../tools/wireshark/src/packet-libvirt.c:86:1: note: in expansion of macro 'XDR_PRIMITIVE_DISSECTOR'
86 | XDR_PRIMITIVE_DISSECTOR(float, gfloat, float)
| ^~~~~~~~~~~~~~~~~~~~~~~
../../tools/wireshark/src/packet-libvirt.c:64:5: error: 'dissect_xdr_short' defined but not used [-Werror=unused-function]
64 | dissect_xdr_##xtype(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf) \
| ^~~~~~~~~~~~
../../tools/wireshark/src/packet-libvirt.c:80:1: note: in expansion of macro 'XDR_PRIMITIVE_DISSECTOR'
80 | XDR_PRIMITIVE_DISSECTOR(short, gint16, int)
| ^~~~~~~~~~~~~~~~~~~~~~~
../../tools/wireshark/src/packet-libvirt.c: In function 'dissect_libvirt_message':
../../tools/wireshark/src/packet-libvirt.c:423:34: error: null pointer dereference [-Werror=null-dereference]
423 | vir_xdr_dissector_t xd = find_payload_dissector(proc, type, get_program_data(prog, VIR_PROGRAM_DISSECTORS),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
424 | *(gsize *)get_program_data(prog, VIR_PROGRAM_DISSECTORS_LEN));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2020-05-20 20:52:05 +00:00
|
|
|
#define VIR_WARNINGS_NO_UNUSED_FUNCTION \
|
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wunused-function\"")
|
|
|
|
|
2016-04-10 16:22:20 +00:00
|
|
|
/* Workaround bogus GCC 6.0 for logical 'or' equal expression warnings.
|
|
|
|
* (GCC bz 69602) */
|
2019-07-30 13:07:24 +00:00
|
|
|
#if BROKEN_GCC_WLOGICALOP_EQUAL_EXPR
|
|
|
|
# define VIR_WARNINGS_NO_WLOGICALOP_EQUAL_EXPR \
|
2017-11-03 12:09:47 +00:00
|
|
|
_Pragma ("GCC diagnostic push") \
|
2016-04-10 16:22:20 +00:00
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wlogical-op\"")
|
2019-06-07 20:20:27 +00:00
|
|
|
#else
|
2019-07-30 13:07:24 +00:00
|
|
|
# define VIR_WARNINGS_NO_WLOGICALOP_EQUAL_EXPR \
|
|
|
|
_Pragma ("GCC diagnostic push")
|
2019-06-07 20:20:27 +00:00
|
|
|
#endif
|
2016-04-10 16:21:13 +00:00
|
|
|
|
2020-07-28 19:47:29 +00:00
|
|
|
/* Where ignore_value cannot be used because it's a statement */
|
|
|
|
#define VIR_WARNINGS_NO_UNUSED_VARIABLE \
|
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wunused-variable\"")
|
|
|
|
|
2020-08-03 15:31:32 +00:00
|
|
|
#define VIR_WARNINGS_NO_DECLARATION_AFTER_STATEMENT \
|
|
|
|
_Pragma ("GCC diagnostic push") \
|
|
|
|
_Pragma ("GCC diagnostic ignored \"-Wdeclaration-after-statement\"")
|
|
|
|
|
2019-07-30 13:07:24 +00:00
|
|
|
#define VIR_WARNINGS_RESET \
|
|
|
|
_Pragma ("GCC diagnostic pop")
|
2016-04-10 16:21:13 +00:00
|
|
|
|
2009-01-15 17:54:20 +00:00
|
|
|
/*
|
|
|
|
* Use this when passing possibly-NULL strings to printf-a-likes.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define NULLSTR(s) ((s) ? (s) : "<null>")
|
2009-01-15 17:54:20 +00:00
|
|
|
|
2019-02-12 16:01:09 +00:00
|
|
|
/*
|
|
|
|
* Turn a NULL string into an empty string
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define NULLSTR_EMPTY(s) ((s) ? (s) : "")
|
2019-02-12 16:01:09 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Turn a NULL string into a star
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define NULLSTR_STAR(s) ((s) ? (s) : "*")
|
2019-02-12 16:01:09 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Turn a NULL string into a minus sign
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define NULLSTR_MINUS(s) ((s) ? (s) : "-")
|
2019-02-12 16:01:09 +00:00
|
|
|
|
2014-06-06 16:09:01 +00:00
|
|
|
/**
|
|
|
|
* SWAP:
|
|
|
|
*
|
|
|
|
* In place exchange of two values
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define SWAP(a, b) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
(a) = (a) ^ (b); \
|
|
|
|
(b) = (a) ^ (b); \
|
|
|
|
(a) = (a) ^ (b); \
|
2014-06-06 16:09:01 +00:00
|
|
|
} while (0)
|
|
|
|
|
2020-11-04 18:41:27 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* VIR_IS_POW2:
|
|
|
|
*
|
|
|
|
* Returns true if given number is a power of two
|
|
|
|
*/
|
|
|
|
#define VIR_IS_POW2(x) \
|
|
|
|
((x) && !((x) & ((x) - 1)))
|
|
|
|
|
|
|
|
|
2010-04-13 13:48:04 +00:00
|
|
|
/**
|
|
|
|
* virCheckFlags:
|
|
|
|
* @supported: an OR'ed set of supported flags
|
|
|
|
* @retval: return value in case unsupported flags were passed
|
|
|
|
*
|
|
|
|
* To avoid memory leaks this macro has to be used before any non-trivial
|
|
|
|
* code which could possibly allocate some memory.
|
|
|
|
*
|
|
|
|
* Returns nothing. Exits the caller function if unsupported flags were
|
|
|
|
* passed to it.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckFlags(supported, retval) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
unsigned long __unsuppflags = flags & ~(supported); \
|
|
|
|
if (__unsuppflags) { \
|
|
|
|
virReportInvalidArg(flags, \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
_("unsupported flags (0x%lx) in function %s"), \
|
2017-11-03 12:09:47 +00:00
|
|
|
__unsuppflags, __FUNCTION__); \
|
|
|
|
return retval; \
|
|
|
|
} \
|
2010-04-13 13:48:04 +00:00
|
|
|
} while (0)
|
|
|
|
|
2012-08-03 09:27:07 +00:00
|
|
|
/**
|
|
|
|
* virCheckFlagsGoto:
|
|
|
|
* @supported: an OR'ed set of supported flags
|
|
|
|
* @label: label to jump to on error
|
|
|
|
*
|
|
|
|
* To avoid memory leaks this macro has to be used before any non-trivial
|
|
|
|
* code which could possibly allocate some memory.
|
|
|
|
*
|
|
|
|
* Returns nothing. Jumps to a label if unsupported flags were
|
|
|
|
* passed to it.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckFlagsGoto(supported, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
unsigned long __unsuppflags = flags & ~(supported); \
|
|
|
|
if (__unsuppflags) { \
|
|
|
|
virReportInvalidArg(flags, \
|
2012-08-03 09:27:07 +00:00
|
|
|
_("unsupported flags (0x%lx) in function %s"), \
|
2017-11-03 12:09:47 +00:00
|
|
|
__unsuppflags, __FUNCTION__); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
2012-08-03 09:27:07 +00:00
|
|
|
} while (0)
|
|
|
|
|
2015-03-20 14:38:59 +00:00
|
|
|
/* Macros to help dealing with mutually exclusive flags. */
|
|
|
|
|
|
|
|
/**
|
|
|
|
* VIR_EXCLUSIVE_FLAGS_RET:
|
|
|
|
*
|
|
|
|
* @FLAG1: First flag to be checked.
|
|
|
|
* @FLAG2: Second flag to be checked.
|
|
|
|
* @RET: Return value.
|
|
|
|
*
|
|
|
|
* Reject mutually exclusive API flags. The checked flags are compared
|
|
|
|
* with flags variable.
|
|
|
|
*
|
|
|
|
* This helper does an early return and therefore it has to be called
|
|
|
|
* before anything that would require cleanup.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_EXCLUSIVE_FLAGS_RET(FLAG1, FLAG2, RET) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if ((flags & FLAG1) && (flags & FLAG2)) { \
|
|
|
|
virReportInvalidArg(ctl, \
|
|
|
|
_("Flags '%s' and '%s' are mutually " \
|
|
|
|
"exclusive"), \
|
|
|
|
#FLAG1, #FLAG2); \
|
|
|
|
return RET; \
|
|
|
|
} \
|
2015-03-20 14:38:59 +00:00
|
|
|
} while (0)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* VIR_EXCLUSIVE_FLAGS_GOTO:
|
|
|
|
*
|
|
|
|
* @FLAG1: First flag to be checked.
|
|
|
|
* @FLAG2: Second flag to be checked.
|
|
|
|
* @LABEL: Label to jump to.
|
|
|
|
*
|
|
|
|
* Reject mutually exclusive API flags. The checked flags are compared
|
|
|
|
* with flags variable.
|
|
|
|
*
|
|
|
|
* Returns nothing. Jumps to a label if unsupported flags were
|
|
|
|
* passed to it.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_EXCLUSIVE_FLAGS_GOTO(FLAG1, FLAG2, LABEL) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if ((flags & FLAG1) && (flags & FLAG2)) { \
|
|
|
|
virReportInvalidArg(ctl, \
|
|
|
|
_("Flags '%s' and '%s' are mutually " \
|
|
|
|
"exclusive"), \
|
|
|
|
#FLAG1, #FLAG2); \
|
|
|
|
goto LABEL; \
|
|
|
|
} \
|
2015-03-25 12:11:38 +00:00
|
|
|
} while (0)
|
|
|
|
|
|
|
|
/* Macros to help dealing with flag requirements. */
|
|
|
|
|
|
|
|
/**
|
|
|
|
* VIR_REQUIRE_FLAG_RET:
|
|
|
|
*
|
|
|
|
* @FLAG1: First flag to be checked.
|
|
|
|
* @FLAG2: Second flag that is required by first flag.
|
|
|
|
* @RET: Return value.
|
|
|
|
*
|
|
|
|
* Check whether required flag is set. The checked flags are compared
|
|
|
|
* with flags variable.
|
|
|
|
*
|
|
|
|
* This helper does an early return and therefore it has to be called
|
|
|
|
* before anything that would require cleanup.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_REQUIRE_FLAG_RET(FLAG1, FLAG2, RET) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if ((flags & FLAG1) && !(flags & FLAG2)) { \
|
|
|
|
virReportInvalidArg(ctl, \
|
|
|
|
_("Flag '%s' is required by flag '%s'"), \
|
|
|
|
#FLAG2, #FLAG1); \
|
|
|
|
return RET; \
|
|
|
|
} \
|
2015-03-25 12:11:38 +00:00
|
|
|
} while (0)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* VIR_REQUIRE_FLAG_GOTO:
|
|
|
|
*
|
|
|
|
* @FLAG1: First flag to be checked.
|
|
|
|
* @FLAG2: Second flag that is required by first flag.
|
|
|
|
* @LABEL: Label to jump to.
|
|
|
|
*
|
|
|
|
* Check whether required flag is set. The checked flags are compared
|
|
|
|
* with flags variable.
|
|
|
|
*
|
|
|
|
* Returns nothing. Jumps to a label if required flag is not set.
|
|
|
|
*/
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_REQUIRE_FLAG_GOTO(FLAG1, FLAG2, LABEL) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if ((flags & FLAG1) && !(flags & FLAG2)) { \
|
|
|
|
virReportInvalidArg(ctl, \
|
|
|
|
_("Flag '%s' is required by flag '%s'"), \
|
|
|
|
#FLAG2, #FLAG1); \
|
|
|
|
goto LABEL; \
|
|
|
|
} \
|
2015-03-20 14:38:59 +00:00
|
|
|
} while (0)
|
|
|
|
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckNonNullArgReturn(argname, retval) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname == NULL) { \
|
|
|
|
virReportInvalidNonNullArg(argname); \
|
|
|
|
return retval; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckNullArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname != NULL) { \
|
|
|
|
virReportInvalidNullArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckNonNullArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname == NULL) { \
|
|
|
|
virReportInvalidNonNullArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckNonEmptyStringArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname == NULL) { \
|
|
|
|
virReportInvalidNonNullArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
|
|
|
if (*argname == '\0') { \
|
|
|
|
virReportInvalidEmptyStringArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
2015-06-23 15:35:16 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckPositiveArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname <= 0) { \
|
|
|
|
virReportInvalidPositiveArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckPositiveArgReturn(argname, retval) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname <= 0) { \
|
|
|
|
virReportInvalidPositiveArg(argname); \
|
|
|
|
return retval; \
|
|
|
|
} \
|
2017-05-18 06:27:27 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckNonZeroArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname == 0) { \
|
|
|
|
virReportInvalidNonZeroArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckZeroArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname != 0) { \
|
|
|
|
virReportInvalidNonZeroArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckNonNegativeArgGoto(argname, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if (argname < 0) { \
|
|
|
|
virReportInvalidNonNegativeArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
} while (0)
|
2019-06-07 20:20:27 +00:00
|
|
|
#define virCheckReadOnlyGoto(flags, label) \
|
2017-11-03 12:09:47 +00:00
|
|
|
do { \
|
|
|
|
if ((flags) & VIR_CONNECT_RO) { \
|
2013-12-20 14:02:49 +00:00
|
|
|
virReportRestrictedError(_("read only access prevents %s"), \
|
2017-11-03 12:09:47 +00:00
|
|
|
__FUNCTION__); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
2013-12-20 14:02:49 +00:00
|
|
|
} while (0)
|
|
|
|
|
2019-11-18 11:04:16 +00:00
|
|
|
/* This check is intended to be used with legacy APIs only which expect the
|
|
|
|
* caller to pre-allocate the target buffer.
|
|
|
|
* We want to allow callers pass NULL arrays if the size is declared as 0 and
|
|
|
|
* still succeed in calling the API.
|
|
|
|
*/
|
|
|
|
#define virCheckNonNullArrayArgGoto(argname, argsize, label) \
|
|
|
|
do { \
|
|
|
|
if (!argname && argsize > 0) { \
|
|
|
|
virReportInvalidNonNullArg(argname); \
|
|
|
|
goto label; \
|
|
|
|
} \
|
|
|
|
} while (0)
|
|
|
|
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
|
2019-10-03 14:51:30 +00:00
|
|
|
/* Count leading zeros in an unsigned int.
|
|
|
|
*
|
|
|
|
* Wrapper needed as __builtin_clz is undefined if value is zero
|
|
|
|
*/
|
|
|
|
#define VIR_CLZ(value) \
|
|
|
|
(value ? __builtin_clz(value) : (8 * sizeof(unsigned)))
|
Santize the reporting of VIR_ERR_INVALID_ERROR
To ensure consistent error reporting of invalid arguments,
provide a number of predefined helper methods & macros.
- An arg which must not be NULL:
virCheckNonNullArgReturn(argname, retvalue)
virCheckNonNullArgGoto(argname, label)
- An arg which must be NULL
virCheckNullArgGoto(argname, label)
- An arg which must be positive (ie 1 or greater)
virCheckPositiveArgGoto(argname, label)
- An arg which must not be 0
virCheckNonZeroArgGoto(argname, label)
- An arg which must be zero
virCheckZeroArgGoto(argname, label)
- An arg which must not be negative (ie 0 or greater)
virCheckNonNegativeArgGoto(argname, label)
* src/libvirt.c, src/libvirt-qemu.c,
src/nodeinfo.c, src/datatypes.c: Update to use
virCheckXXXX macros
* po/POTFILES.in: Add libvirt-qemu.c and virterror_internal.h
* src/internal.h: Define macros for checking invalid args
* src/util/virterror_internal.h: Define macros for reporting
invalid args
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-05-25 17:41:07 +00:00
|
|
|
|
2011-01-28 21:03:24 +00:00
|
|
|
/* divide value by size, rounding up */
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_DIV_UP(value, size) (((value) + (size) - 1) / (size))
|
2011-01-28 21:03:24 +00:00
|
|
|
|
2013-05-14 13:48:21 +00:00
|
|
|
/* round up value to the closest multiple of size */
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_ROUND_UP(value, size) (VIR_DIV_UP(value, size) * (size))
|
2013-05-14 13:48:21 +00:00
|
|
|
|
2014-11-18 16:13:38 +00:00
|
|
|
/* Round up to the next closest power of 2. It will return rounded number or 0
|
|
|
|
* for 0 or number more than 2^31 (for 32bit unsigned int). */
|
2019-06-07 20:20:27 +00:00
|
|
|
#define VIR_ROUND_UP_POWER_OF_TWO(value) \
|
2017-11-03 12:09:47 +00:00
|
|
|
((value) > 0 && (value) <= 1U << (sizeof(unsigned int) * 8 - 1) ? \
|
2019-10-03 14:51:30 +00:00
|
|
|
1U << (sizeof(unsigned int) * 8 - VIR_CLZ((value) - 1)) : 0)
|
2014-11-18 16:13:38 +00:00
|
|
|
|
Rewrite all the DTrace/SystemTAP probing
The libvirtd daemon had a few crude system tap probes. Some of
these were broken during the RPC rewrite. The new modular RPC
code is structured in a way that allows much more effective
tracing. Instead of trying to hook up the original probes,
define a new set of probes for the RPC and event code.
The master probes file is now src/probes.d. This contains
probes for virNetServerClientPtr, virNetClientPtr, virSocketPtr
virNetTLSContextPtr and virNetTLSSessionPtr modules. Also add
probes for the poll event loop.
The src/dtrace2systemtap.pl script can convert the probes.d
file into a libvirt_probes.stp file to make use from systemtap
much simpler.
The src/rpc/gensystemtap.pl script can generate a set of
systemtap functions for translating RPC enum values into
printable strings. This works for all RPC header enums (program,
type, status, procedure) and also the authentication enum
The PROBE macro will automatically generate a VIR_DEBUG
statement, so any place with a PROBE can remove any existing
manual DEBUG statements.
* daemon/libvirtd.stp, daemon/probes.d: Remove obsolete probing
* daemon/libvirtd.h: Remove probe macros
* daemon/Makefile.am: Remove all probe buildings/install
* daemon/remote.c: Update authentication probes
* src/dtrace2systemtap.pl, src/rpc/gensystemtap.pl: Scripts
to generate STP files
* src/internal.h: Add probe macros
* src/probes.d: Master list of probes
* src/rpc/virnetclient.c, src/rpc/virnetserverclient.c,
src/rpc/virnetsocket.c, src/rpc/virnettlscontext.c,
src/util/event_poll.c: Insert probe points, removing any
DEBUG statements that duplicate the info
2011-09-30 13:40:23 +00:00
|
|
|
|
2014-02-19 01:06:50 +00:00
|
|
|
/* Specific error values for use in forwarding programs such as
|
|
|
|
* virt-login-shell; these values match what GNU env does. */
|
|
|
|
enum {
|
|
|
|
EXIT_CANCELED = 125, /* Failed before attempting exec */
|
|
|
|
EXIT_CANNOT_INVOKE = 126, /* Exists but couldn't exec */
|
|
|
|
EXIT_ENOENT = 127, /* Could not find program to exec */
|
|
|
|
};
|
Rewrite all the DTrace/SystemTAP probing
The libvirtd daemon had a few crude system tap probes. Some of
these were broken during the RPC rewrite. The new modular RPC
code is structured in a way that allows much more effective
tracing. Instead of trying to hook up the original probes,
define a new set of probes for the RPC and event code.
The master probes file is now src/probes.d. This contains
probes for virNetServerClientPtr, virNetClientPtr, virSocketPtr
virNetTLSContextPtr and virNetTLSSessionPtr modules. Also add
probes for the poll event loop.
The src/dtrace2systemtap.pl script can convert the probes.d
file into a libvirt_probes.stp file to make use from systemtap
much simpler.
The src/rpc/gensystemtap.pl script can generate a set of
systemtap functions for translating RPC enum values into
printable strings. This works for all RPC header enums (program,
type, status, procedure) and also the authentication enum
The PROBE macro will automatically generate a VIR_DEBUG
statement, so any place with a PROBE can remove any existing
manual DEBUG statements.
* daemon/libvirtd.stp, daemon/probes.d: Remove obsolete probing
* daemon/libvirtd.h: Remove probe macros
* daemon/Makefile.am: Remove all probe buildings/install
* daemon/remote.c: Update authentication probes
* src/dtrace2systemtap.pl, src/rpc/gensystemtap.pl: Scripts
to generate STP files
* src/internal.h: Add probe macros
* src/probes.d: Master list of probes
* src/rpc/virnetclient.c, src/rpc/virnetserverclient.c,
src/rpc/virnetsocket.c, src/rpc/virnettlscontext.c,
src/util/event_poll.c: Insert probe points, removing any
DEBUG statements that duplicate the info
2011-09-30 13:40:23 +00:00
|
|
|
|
2019-06-07 20:20:27 +00:00
|
|
|
#ifndef ENODATA
|
|
|
|
# define ENODATA EIO
|
|
|
|
#endif
|
2020-01-24 18:22:47 +00:00
|
|
|
|
|
|
|
#ifdef WIN32
|
|
|
|
# ifndef ENOMSG
|
|
|
|
# define ENOMSG 122
|
|
|
|
# endif
|
|
|
|
#endif
|
2020-01-27 13:58:51 +00:00
|
|
|
|
|
|
|
/* Ideally callers would use the g_*printf
|
2020-07-09 04:42:21 +00:00
|
|
|
* functions directly but there are a lot to
|
2020-01-27 13:58:51 +00:00
|
|
|
* convert, so until then...
|
|
|
|
*/
|
|
|
|
#ifndef VIR_NO_GLIB_STDIO
|
|
|
|
|
|
|
|
# undef printf
|
|
|
|
# define printf(...) g_printf(__VA_ARGS__)
|
|
|
|
|
|
|
|
# undef fprintf
|
|
|
|
# define fprintf(fh, ...) g_fprintf(fh, __VA_ARGS__)
|
|
|
|
|
|
|
|
#endif /* VIR_NO_GLIB_STDIO */
|