External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 01:45:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "logical: Only raw volumes are supported"

Browse Source 
This reverts commit 6682d6219d4595b51f06867e0c30e7efd745f682.

The "if (vol->target.format != VIR_STORAGE_FILE_RAW)" check in the
createVol backend. This check is bogus because virStorageVolDefParseXML()
in conf/storage_conf.c sets target.format only if volOptions in
virStoragePoolTypeInfo has formatFromString set, and that's not the
case the logical backend.

So the check always fails and breaks volume creation.
This commit is contained in:
Roman Bogorodskiy 2016-03-27 10:59:22 -04:00 committed by John Ferlan
parent 420eff8f26
commit 139a319794
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/storage/storage_backend_logical.c
View File

@ -912,12 +912,6 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn,
struct stat sb;
bool created = false;
if (vol->target.format != VIR_STORAGE_FILE_RAW) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("only RAW volumes are supported by this storage pool"));
return -1;
}
if (vol->target.encryption != NULL) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
"%s", _("storage pool does not support encrypted "