External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 01:45:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

xenParseXMDisk: Use automatic memory clearing and remove 'ret' variable

Browse Source 
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-08-03 15:08:54 +02:00
parent a31864e60a
commit 18e65eef04
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/libxl/xen_xm.c
View File

@ -238,9 +238,9 @@ xenParseXMDisk(char *entry, int hvm)
static int static int
xenParseXMDiskList(virConf *conf, virDomainDef *def) xenParseXMDiskList(virConf *conf, virDomainDef *def)
{ {
char **disks = NULL, **entries; g_auto(GStrv) disks = NULL;
GStrv entries;
int hvm = def->os.type == VIR_DOMAIN_OSTYPE_HVM; int hvm = def->os.type == VIR_DOMAIN_OSTYPE_HVM;
int ret = -1;
int rc; int rc;
rc = virConfGetValueStringList(conf, "disk", false, &disks); rc = virConfGetValueStringList(conf, "disk", false, &disks);
@ -258,10 +258,7 @@ xenParseXMDiskList(virConf *conf, virDomainDef *def)
VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk); VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk);
} }
ret = 0; return 0;
g_strfreev(disks);
return ret;
} }