External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not access the domain definition in qemuMonitorFindBalloonObjectPath

Browse Source 
The monitor code does not hold the virDomainObjPtr lock and should
not access the defitinion.
This commit is contained in:
Ján Tomko 2015-06-03 17:19:06 +02:00
parent 084ad13774
commit 19c633c678
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/qemu/qemu_monitor.c
View File

@ -1091,7 +1091,6 @@ qemuMonitorFindBalloonObjectPath(qemuMonitorPtr mon)
int ret = -1;
char *path = NULL;
qemuMonitorJSONListPathPtr *bprops = NULL;
virDomainObjPtr vm = mon->vm;
if (mon->balloonpath) {
return 0;
@ -1101,15 +1100,6 @@ qemuMonitorFindBalloonObjectPath(qemuMonitorPtr mon)
return -1;
}
/* Not supported */
if (!vm->def->memballoon ||
vm->def->memballoon->model != VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Memory balloon model must be virtio to "
"get memballoon path"));
return -1;
}
if (qemuMonitorJSONFindLinkPath(mon, "virtio-balloon-pci", &path) < 0)
return -1;