External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virfirewall: Remove OOM checks from virFirewallStartTransaction

Browse Source 
Neither virFirewallGroupNew nor VIR_EXPAND_N can fail.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-23 17:36:36 +01:00
parent b8aa25f560
commit 1a1a926804
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/util/virfirewall.c
View File

@ -517,18 +517,11 @@ void virFirewallStartTransaction(virFirewallPtr firewall,
VIR_FIREWALL_RETURN_IF_ERROR(firewall); VIR_FIREWALL_RETURN_IF_ERROR(firewall);
if (!(group = virFirewallGroupNew())) { group = virFirewallGroupNew();
firewall->err = ENOMEM;
return;
}
group->actionFlags = flags; group->actionFlags = flags;
if (VIR_EXPAND_N(firewall->groups, ignore_value(VIR_EXPAND_N(firewall->groups,
firewall->ngroups, 1) < 0) { firewall->ngroups, 1));
firewall->err = ENOMEM;
virFirewallGroupFree(group);
return;
}
firewall->groups[firewall->ngroups - 1] = group; firewall->groups[firewall->ngroups - 1] = group;
firewall->currentGroup = firewall->ngroups - 1; firewall->currentGroup = firewall->ngroups - 1;
} }