External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-23 21:15:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing OOM check in qemuParseCommandLine when splitting strings

Browse Source 
The qemuParseCommandLine method did not check the return value of
virStringSplit to see if OOM had occurred. This lead to dereference
of a NULL pointer on OOM.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-09-23 14:18:04 +01:00
parent 5923ea67b1
commit 5dd3b5e32a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_command.c
View File

@ -11387,7 +11387,8 @@ qemuParseCommandLine(virCapsPtr qemuCaps,
* Set os.machine only if first parameter lacks '=' or * Set os.machine only if first parameter lacks '=' or
* contains explicit type='...' */ * contains explicit type='...' */
WANT_VALUE(); WANT_VALUE();
list = virStringSplit(val, ",", 0); if (!(list = virStringSplit(val, ",", 0)))
goto error;
param = list[0]; param = list[0];
if (STRPREFIX(param, "type=")) if (STRPREFIX(param, "type="))