External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

meson: Adjust -fstack-protector use

Browse Source 
Back in 2014, -fstack-protector was reported not to work on
aarch64, so fe881ae086 disabled it on that target. OS-wise,
its use is currently limited to just Linux, FreeBSD and Windows.

Looking at the situation today, it seems that whatever issue was
affecting aarch64 a decade ago has been resolved; moreover,
macOS can also use the feature these days.

I haven't checked any of the other BSDs, but since the feature
works on FreeBSD it's pretty safe to assume that they can use
it too. If we get reports that it's not the case, we can always
further restrict its usage accordingly.

Best viewed with 'git show -w'.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Andrea Bolognani 2024-01-20 17:06:38 +01:00
parent 1678e633cf
commit 7284b4cf8b
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
meson.build
View File

@ -442,22 +442,17 @@ supported_cc_flags = []
if get_option('warning_level') == '2' if get_option('warning_level') == '2'
supported_cc_flags = cc.get_supported_arguments(cc_flags) supported_cc_flags = cc.get_supported_arguments(cc_flags)
# on aarch64 error: -fstack-protector not supported for this target # we prefer -fstack-protector-strong but fallback to -fstack-protector-all
if host_machine.cpu_family() != 'aarch64' fstack_cflags = cc.first_supported_argument([
if host_machine.system() in [ 'linux', 'freebsd', 'windows' ] '-fstack-protector-strong',
# we prefer -fstack-protector-strong but fallback to -fstack-protector-all '-fstack-protector-all',
fstack_cflags = cc.first_supported_argument([ ])
'-fstack-protector-strong', supported_cc_flags += fstack_cflags
'-fstack-protector-all',
])
supported_cc_flags += fstack_cflags
# When building with mingw using -fstack-protector requires libssp library # When building with mingw using -fstack-protector requires libssp library
# which is included by using -fstack-protector with linker. # which is included by using -fstack-protector with linker.
if fstack_cflags.length() == 1 and host_machine.system() == 'windows' if fstack_cflags.length() == 1 and host_machine.system() == 'windows'
add_project_link_arguments(fstack_cflags, language: 'c') add_project_link_arguments(fstack_cflags, language: 'c')
endif
endif
endif endif
if supported_cc_flags.contains('-Wlogical-op') if supported_cc_flags.contains('-Wlogical-op')