mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-14 03:35:05 +00:00
qemu: domain: Fix logic bug in qemuDomainStorageSourceAccessAllow
In commit 76b9aba2ba
I tried to refactor qemuDomainStorageSourceAccessAllow
but used wrong operators for adding bitwise flags.
This way the flags would result in 0 if any of them would be applied.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
10e12c4009
commit
9961e7799a
@ -9491,10 +9491,10 @@ qemuDomainStorageSourceAccessAllow(virQEMUDriverPtr driver,
|
|||||||
qemuDomainStorageSourceAccessFlags flags = QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_SKIP_REVOKE;
|
qemuDomainStorageSourceAccessFlags flags = QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_SKIP_REVOKE;
|
||||||
|
|
||||||
if (readonly)
|
if (readonly)
|
||||||
flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY;
|
flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY;
|
||||||
|
|
||||||
if (!newSource)
|
if (!newSource)
|
||||||
flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS;
|
flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS;
|
||||||
|
|
||||||
return qemuDomainStorageSourceAccessModify(driver, vm, elem, flags);
|
return qemuDomainStorageSourceAccessModify(driver, vm, elem, flags);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user