External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-04 20:15:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

client rpc: Improve debug messages in virNetClientIO

Browse Source 
When analyzing our debug log, I'm always confused about what each of the
pointers mean. Let's be explicit.
(cherry picked from commit 71689f95ce)
This commit is contained in:
Jiri Denemark 2012-06-08 13:41:25 +02:00 committed by Cole Robinson
parent 6f42946997
commit b1dcd198fa
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/rpc/virnetclient.c
View File

@ -1555,7 +1555,8 @@ static int virNetClientIO(virNetClientPtr client,
return -1; return -1;
} }
VIR_DEBUG("Going to sleep %p %p", client->waitDispatch, thiscall); VIR_DEBUG("Going to sleep head=%p call=%p",
client->waitDispatch, thiscall);
/* Go to sleep while other thread is working... */ /* Go to sleep while other thread is working... */
if (virCondWait(&thiscall->cond, &client->lock) < 0) { if (virCondWait(&thiscall->cond, &client->lock) < 0) {
virNetClientCallRemove(&client->waitDispatch, thiscall); virNetClientCallRemove(&client->waitDispatch, thiscall);
@ -1564,7 +1565,8 @@ static int virNetClientIO(virNetClientPtr client,
return -1; return -1;
} }
VIR_DEBUG("Wokeup from sleep %p %p", client->waitDispatch, thiscall); VIR_DEBUG("Woken up from sleep head=%p call=%p",
client->waitDispatch, thiscall);
/* Three reasons we can be woken up /* Three reasons we can be woken up
* 1. Other thread has got our reply ready for us * 1. Other thread has got our reply ready for us
* 2. Other thread is all done, and it is our turn to * 2. Other thread is all done, and it is our turn to
@ -1596,7 +1598,8 @@ static int virNetClientIO(virNetClientPtr client,
client->haveTheBuck = true; client->haveTheBuck = true;
} }
VIR_DEBUG("We have the buck %p %p", client->waitDispatch, thiscall); VIR_DEBUG("We have the buck head=%p call=%p",
client->waitDispatch, thiscall);
/* /*
* The buck stops here! * The buck stops here!
@ -1625,7 +1628,8 @@ static int virNetClientIO(virNetClientPtr client,
rv = -1; rv = -1;
cleanup: cleanup:
VIR_DEBUG("All done with our call %p %p %d", client->waitDispatch, thiscall, rv); VIR_DEBUG("All done with our call head=%p call=%p rv=%d",
client->waitDispatch, thiscall, rv);
return rv; return rv;
} }