External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

virterror: Misleading error message when name is missing

Browse Source 
[forwarding this here from RH bug #796732]

When creating a network (virsh net-create) with an erroneous XML
containing an empty <name> element, the error message is misleading:

error: Failed to create network from foo.xml
error: missing domain name information

It took me a bit of time to figure out that it was the *network* name
that was missing (I generate this xml and didn't look at it, first).

I realized that the same message is used for missing name when creating
a domain, network, or device node.
This commit is contained in:
Benjamin Cama 2012-02-23 17:37:30 +01:00 committed by Eric Blake
parent 751fec3557
commit cff5573da2
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -222,6 +222,7 @@ Patches have also been contributed by:
Kyle Mestery <kmestery@cisco.com>
Lincoln Myers <lincoln_myers@yahoo.com>
Peter Robinson <pbrobinson@gmail.com>
Benjamin Cama <benoar@dolka.fr>
[....send patches to get your name here....]

4
src/util/virterror.c
View File

@ -880,9 +880,9 @@ virErrorMsg(virErrorNumber error, const char *info)
break;
case VIR_ERR_NO_NAME:
if (info == NULL)
errmsg = _("missing domain name information");
errmsg = _("missing name information");
else
errmsg = _("missing domain name information in %s");
errmsg = _("missing name information in %s");
break;
case VIR_ERR_NO_OS:
if (info == NULL)