mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-18 10:35:20 +00:00
virterror: Misleading error message when name is missing
[forwarding this here from RH bug #796732] When creating a network (virsh net-create) with an erroneous XML containing an empty <name> element, the error message is misleading: error: Failed to create network from foo.xml error: missing domain name information It took me a bit of time to figure out that it was the *network* name that was missing (I generate this xml and didn't look at it, first). I realized that the same message is used for missing name when creating a domain, network, or device node.
This commit is contained in:
parent
751fec3557
commit
cff5573da2
1
AUTHORS
1
AUTHORS
@ -222,6 +222,7 @@ Patches have also been contributed by:
|
|||||||
Kyle Mestery <kmestery@cisco.com>
|
Kyle Mestery <kmestery@cisco.com>
|
||||||
Lincoln Myers <lincoln_myers@yahoo.com>
|
Lincoln Myers <lincoln_myers@yahoo.com>
|
||||||
Peter Robinson <pbrobinson@gmail.com>
|
Peter Robinson <pbrobinson@gmail.com>
|
||||||
|
Benjamin Cama <benoar@dolka.fr>
|
||||||
|
|
||||||
[....send patches to get your name here....]
|
[....send patches to get your name here....]
|
||||||
|
|
||||||
|
@ -880,9 +880,9 @@ virErrorMsg(virErrorNumber error, const char *info)
|
|||||||
break;
|
break;
|
||||||
case VIR_ERR_NO_NAME:
|
case VIR_ERR_NO_NAME:
|
||||||
if (info == NULL)
|
if (info == NULL)
|
||||||
errmsg = _("missing domain name information");
|
errmsg = _("missing name information");
|
||||||
else
|
else
|
||||||
errmsg = _("missing domain name information in %s");
|
errmsg = _("missing name information in %s");
|
||||||
break;
|
break;
|
||||||
case VIR_ERR_NO_OS:
|
case VIR_ERR_NO_OS:
|
||||||
if (info == NULL)
|
if (info == NULL)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user