Daniel P. Berrange
f92e9f599b
Fix empty declaration in enum declaration
2009-01-30 21:52:22 +00:00
Jim Meyering
a119a98081
fix qemud version reporting when qemu is not installed
...
* src/qemu_conf.c (uname_normalize): New function, factored out of...
(qemudBuildCommandLine): ...here. Use the new function.
(qemudExtractVersion): Use it here, rather than hard-coding "i686".
2009-01-30 19:57:20 +00:00
Daniel P. Berrange
a6ef2e0055
Fix ifname= passing to QEMU for type=ethernet network config
2009-01-30 17:17:58 +00:00
Daniel P. Berrange
67e7416119
Support disk caching mode config
2009-01-30 17:15:39 +00:00
Daniel P. Berrange
3cb55cb51f
Fix crash using bogus arch in QEMU
2009-01-30 17:12:28 +00:00
Daniel P. Berrange
896761e5c7
Fix numerous bugs in QEMU domain startup
2009-01-30 17:07:29 +00:00
Daniel P. Berrange
05436ab7ff
Fix valgrind crash in LXC & avoid probing unneccessarily
2009-01-30 16:51:33 +00:00
Daniel P. Berrange
d8637214a4
Fix leak of storage vols when freeing pool
2009-01-30 16:48:52 +00:00
John Levon
745c249a61
Fix yet another printf("%s", NULL) case
...
Fix getpwuid_r() usage
Fix virsh migrateuri handling
2009-01-30 15:43:05 +00:00
Daniel P. Berrange
1c64dc76c1
Misc xen driver bug/crash fixes
2009-01-29 23:01:37 +00:00
John Levon
3a8d93ab36
Fix xend XML generation when CPU pinning is used
2009-01-29 18:40:32 +00:00
Daniel P. Berrange
3801794908
Support VNC password setting in QEMU driver
2009-01-29 17:50:00 +00:00
Daniel P. Berrange
4f4bfbc79e
Fix save/restore migrate syntax for new KVM releases
2009-01-29 17:27:54 +00:00
John Levon
e96d88ff3d
fix another printf("%s", NULL) case
2009-01-29 17:18:24 +00:00
John Levon
a10aa7a96b
correctly enable floppies for HVM guests.
2009-01-29 17:05:49 +00:00
John Levon
3463c34e33
fix VNC port reporting when vncunused is set
2009-01-29 17:02:00 +00:00
Jim Meyering
bc18a91f91
error-reporting calls using VIR_ERR_NO_MEMORY: use virReportOOMError instead
...
* src/uml_conf.c (VIR_FROM_THIS): Define to VIR_FROM_UML.
* src/xs_internal.c (VIR_FROM_THIS): Define to VIR_FROM_XEN.
* src/xml.c (VIR_FROM_THIS): Define to VIR_FROM_XML.
* src/stats_linux.c (VIR_FROM_THIS): Define to VIR_FROM_STATS_LINUX.
* src/datatypes.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/lxc_conf.c (VIR_FROM_THIS): Define to VIR_FROM_LXC.
* src/libvirt.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/node_device_conf.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/openvz_conf.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/openvz_driver.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/conf.c (VIR_FROM_THIS): Define to VIR_FROM_CONF.
Note: this loses config_filename:config_lineno diagnostics,
but that's ok.
* src/node_device.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/sexpr.c (VIR_FROM_THIS): Define to VIR_FROM_SEXPR.
* po/POTFILES.in: remove src/sexpr.c and src/lxc_conf.c
2009-01-29 12:10:32 +00:00
Guido Günther
a99e5ccba4
don't abort if setlocale() fails
2009-01-29 11:49:33 +00:00
Daniel P. Berrange
94d6177982
Fix typo & tweak variable decl
2009-01-28 22:07:36 +00:00
Daniel P. Berrange
46d1324e47
Stopping reading off wire after 1 complete RPC message is received
2009-01-28 22:00:32 +00:00
Jim Meyering
e730de6fd8
remote_internal.c: fix typo that would mistakenly report OOM
...
* src/remote_internal.c (addrToString): Report VIR_ERR_UNKNOWN_HOST,
not VIR_ERR_NO_MEMORY.
2009-01-28 16:14:24 +00:00
Jim Meyering
8cc2bbe33c
qparams.c: Use virReportOOMError(NULL), not qparam_report_oom()
...
* src/qparams.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
(qparam_report_oom): Remove definition.
Replace all uses.
2009-01-28 16:13:46 +00:00
John Levon
499189694a
fix mis-use of PF_UNIX as a protocol
2009-01-28 14:36:23 +00:00
Daniel P. Berrange
489fde7680
Add support for copy-on-write storage volumes
2009-01-27 18:30:03 +00:00
Jim Meyering
f03d3439cd
virterror.c: don't read beyond end of buffer upon OOM
...
* src/virterror.c (virReportSystemErrorFull): Fix typo in
my previous change. Patch by Daniel P. Berrange.
2009-01-27 12:26:53 +00:00
Mark McLoughlin
b4f62abbf1
kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
...
IFF_VNET_HDR is a tun/tap flag that allows you to send and receive
large (i.e. GSO) packets and packets with partial checksums. Setting
the flag means that every packet is proceeded by the same header which
virtio uses to communicate GSO/csum metadata.
By enabling this flag on the tap fds we create, we greatly increase
the achievable throughput with virtio_net.
However, we need to be careful to only set the flag when a) QEMU has
support for this ABI and b) the value of the flag is queryable using
the TUNGETIFF ioctl.
It's nearly five months since kvm-74 - the first KVM release with this
feature - was released. Up until now, we've not added libvirt support
because there is no clean way to detect support for this in QEMU at
runtime. A brief attempt to add a "info capabilities" monitor command
to QEMU floundered. Perfect is the enemy of good enough. Probing the
KVM version will suffice for now.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
2009-01-27 11:12:05 +00:00
Jim Meyering
e15147c141
fix errors in virReportSystemErrorFull
...
* src/virterror.c (virStrerror): New function.
(virReportSystemErrorFull): Don't leak "combined".
In fact, don't even attempt allocation.
Do include the result of formatted print in final diagnostic.
2009-01-27 10:57:18 +00:00
Jim Meyering
339cc9d992
build: avoid format warnings
...
* src/proxy_internal.c (xenProxyCommand): Mark a diagnostic.
* src/xen_unified.c (xenUnifiedOpen, xenUnifiedAddDomainInfo):
Fix unmarked diagnostics by removing the diagnostic altogether:
replace each xenUnifiedError(...,VIR_ERR_NO_MEMORY call with a
call to virReportOOMError.
2009-01-27 08:50:03 +00:00
Jim Meyering
69d947eb80
* src/virterror.c (virErrorMsg): Correct indentation.
2009-01-27 08:49:15 +00:00
John Levon
39e49ad7c9
fix recursive lock hang in xenstore driver
2009-01-23 19:18:24 +00:00
Daniel P. Berrange
ad70b32414
Support QEMU disk format specification in XML
2009-01-23 16:22:20 +00:00
Jim Meyering
727d4fdc6e
fix comment typo: s/contains/continues/
...
* src/libvirt.c (virStorageVolFree): Correct typo in comment.
2009-01-23 14:18:43 +00:00
Jim Meyering
6278bb191a
maint: update list of error function names and adapt
...
* Makefile.maint (msg_gen_function): Update list.
Remove some now-unused names, add some new ones.
* src/hash.c (virHashError): Remove unused definition.
* src/openvz_conf.h (openvzLog): Likewise.
* src/xen_unified.c: Mark newly-exposed diagnostics for translation.
2009-01-23 12:29:29 +00:00
John Levon
e80f10064e
parse IP address for bridge interfaces
2009-01-23 01:48:47 +00:00
Daniel P. Berrange
c4985e9419
use the gnulib random_r function
2009-01-22 20:27:01 +00:00
Daniel P. Berrange
1b745219c7
Remove use of non-reentrant POSIX apis
2009-01-22 19:41:48 +00:00
Jim Meyering
d0eab955c2
xm_internal.c: fix locking bug: s/Lock/Unlock/
...
* src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
try to acquire it) upon failure, just before returning.
2009-01-22 19:18:24 +00:00
John Levon
7420fec81b
Remove non-existent symbol from linker script
2009-01-22 18:33:13 +00:00
John Levon
fb4ec82358
Support script for bridge interface type
2009-01-22 18:29:13 +00:00
John Levon
2b29698352
Least privilege support for Solaris
2009-01-22 17:49:41 +00:00
Daniel P. Berrange
e52d74e536
Make xen driver threadsafe
2009-01-21 18:11:14 +00:00
Daniel P. Berrange
e3672d9695
Allow storage driver to handle daemon restarts
2009-01-20 22:43:07 +00:00
Daniel P. Berrange
23a090ab92
Allow virtual networks to survive daemon restart
2009-01-20 22:36:10 +00:00
Daniel P. Berrange
a964a6dad6
Support ac97 soundcard model
2009-01-20 22:15:55 +00:00
Daniel Veillard
5fb1e29c7e
* src/logging.c: fix openlog() ident lifetime for Solaris
...
daniel
2009-01-20 21:34:44 +00:00
Daniel P. Berrange
a888b22cf9
Support domain events in test driver
2009-01-20 20:23:53 +00:00
Jim Meyering
3548e9aae8
don't ignore write failure
...
* src/network_driver.c (networkEnableIpForwarding): This function
would always return 1 (success). Now it returns 0 upon write or
close failure, being careful to preserve any errno from a write failure.
Add comments.
2009-01-20 19:29:08 +00:00
Daniel P. Berrange
f61341173b
Allow concurrent processing of RPC calls in daemon
2009-01-20 19:25:15 +00:00
Daniel P. Berrange
84ef468ba8
Fix some misleading comments in XM driver
2009-01-20 18:20:09 +00:00
Daniel P. Berrange
2c7be88d15
Remove a use of strerror() in error reporting in remote driver
2009-01-20 17:47:13 +00:00
Daniel P. Berrange
788bedd904
Remove use of static data in Xen XM driver
2009-01-20 17:34:56 +00:00
Daniel P. Berrange
e428a69e6f
Remove use of static data in Xen inotify driver
2009-01-20 17:19:23 +00:00
Daniel P. Berrange
437ac354fc
Make error reporting threadsafe by avoiding strerror
2009-01-20 17:13:33 +00:00
Daniel Veillard
25415eb104
* src/qemu_driver.c: remove a warning when printing a file offset
...
daniel
2009-01-20 16:39:35 +00:00
Daniel P. Berrange
61674cc17d
Make RPC call dispatch threaded
2009-01-20 16:36:34 +00:00
Daniel Veillard
458a673cb7
remove stdout_fd, stderr_fd from virDomainObj
...
* src/domain_conf.h src/lxc_driver.c src/uml_driver.c: virDomainObj
doesn't need stdout and stderr fields anymore, patch from
Guido Günther
daniel
2009-01-20 16:10:20 +00:00
Daniel Veillard
6d004d3f8a
* src/domain_conf.h src/qemu_driver.c: use monitor fd for QEmu/KVM
...
domain shutdown and read saved vm status on libvirtd startup,
last 2 patches from Guido Günther finishing up the surviving the
libvirt daemon restart
daniel
2009-01-20 15:52:11 +00:00
Jim Meyering
45062390a6
fix "make syntax-check" failures
...
* ChangeLog: Start with TAB, not 8 spaces.
* src/virterror.c: Remove trailing spaces.
2009-01-20 13:51:52 +00:00
Daniel P. Berrange
a776fad370
Add public APIs for ref counting on public objects
2009-01-20 12:14:03 +00:00
Daniel P. Berrange
ead04dcbe8
Thread local error reporting
2009-01-20 12:01:45 +00:00
Daniel P. Berrange
c790f6d25e
Avoid bogus event loop wakeups in remote driver when doing RPC call
2009-01-20 11:45:09 +00:00
Daniel P. Berrange
ed493909f7
Add locking to the remote driver
2009-01-20 11:41:24 +00:00
Guido Günther
8dfbfe3145
daemonize qemu processes
2009-01-19 21:55:54 +00:00
Guido Günther
5d99a309e6
save domstate as string in status file
2009-01-19 21:06:26 +00:00
Daniel Veillard
9a969b86a9
* src/xen_internal.c src/xend_internal.c: Relax NUMA checking
...
for RHEL-5 and change the detection stategy for default Xen
accesses, patch by Markus Armbruster
daniel
2009-01-19 20:16:10 +00:00
Daniel Veillard
b751b46bc5
Fix PVFB version check for RHEL-5
...
* src/xend_internal.c src/xm_internal.c: fix paravirt framebuffer
handling since it was backoprted for RHEL-5, patch by Markus
Armbruster
daniel
2009-01-19 19:49:30 +00:00
Daniel Veillard
e676a699e8
* src/xend_internal.c src/xm_internal.c: fix fully virt network
...
device configuration for Xen on RHEL-5, patch by Markus Armbruster
daniel
2009-01-19 18:12:00 +00:00
Daniel Veillard
99ed5b4bee
Two bug fixes coming from RHEL and Markus being added to AUTHORS
...
* src/xm_internal.c: two bug fixes coming from RHEL package
posted by Markus Armbruster
* AUTHORS: adding Markus
daniel
2009-01-19 15:24:41 +00:00
Cole Robinson
46d4a5e047
Fix segfault with console device back compat.
2009-01-16 16:50:11 +00:00
Daniel P. Berrange
dd9b3fb594
Fix bug when fork isn't available (Win32) in remote driver
2009-01-15 20:13:12 +00:00
Daniel P. Berrange
2be79b1d5e
Reduce exit paths in remote driver APIs
2009-01-15 20:07:10 +00:00
Daniel P. Berrange
19d1bf2562
Remove use of macros in remote driver private data access
2009-01-15 20:04:44 +00:00
Daniel P. Berrange
0cd119e7b8
Fix incorrect use of private data field in remote driver
2009-01-15 20:03:10 +00:00
Daniel P. Berrange
4dac0a1105
Generic internal threads API
2009-01-15 19:56:05 +00:00
Daniel P. Berrange
52e51d278e
Implement virKill for Win32 platform
2009-01-15 19:40:21 +00:00
John Levon
4d713eabf5
Avoid passing NULL to printf %s specifier
2009-01-15 17:54:20 +00:00
John Levon
c7095a4b4c
Improve xend_get error message
2009-01-15 15:17:53 +00:00
John Levon
443698d2b2
implement capabilities parsing for Solaris
2009-01-15 01:35:17 +00:00
John Levon
406c05f2e7
Fix xs_unwatch() to correctly pass the token
2009-01-15 01:23:32 +00:00
John Levon
c8070bf632
Fix activeDomainList handling
2009-01-15 01:21:36 +00:00
John Levon
65316d7940
Fix ref-counting for Xen driver event registration
2009-01-15 01:18:37 +00:00
John Levon
5b6c39f51f
Mark Xen PV CD-ROM devices as such
2009-01-14 16:21:12 +00:00
Jim Meyering
6954d44e53
diagnose "libvirtd --config=no-such-file"
...
* qemud/qemud.c (remoteReadConfigFile): Don't return 0 (success)
when the config file is unreadable or nonexistent
Return -1, not 0, upon virConfReadFile failure.
(main): If remote_config_file is not specified via --config(-f),
use the default config file only if it exists. Otherwise,
use /dev/null.
* src/conf.c (virConfReadFile): Don't diagnose virFileReadAll
failure, since it already does that.
2009-01-12 18:22:32 +00:00
Guido Günther
8af87ea251
don't emulate snprintf
2009-01-11 11:21:29 +00:00
Guido Günther
4275be68fb
split out opening of the qemu logfile
2009-01-11 11:18:31 +00:00
John Levon
261c3a8fd0
src/logging.h: fix non-debug compile
2009-01-09 19:22:02 +00:00
Guido Günther
d6bd288da2
add missing flags argument
2009-01-08 19:52:15 +00:00
Guido Günther
46971d5ed7
pass flags argument to all virDomain*DefParse* functions
2009-01-08 13:54:20 +00:00
Daniel Veillard
c7cbbfa43b
* src/domain_conf.c src/qemu_conf.c: implement PCI passthrough
...
for recent KVM versions in a similar way to USB, patch by
Jason Krieg. Some cleanups and reformating too.
daniel
2009-01-07 12:56:13 +00:00
Daniel Veillard
d6eceb568f
* src/openvz_driver.c: fix the mac addresses generation for OpenVZ veth
...
devices, patch by Evgeniy Sokolov
* docs/apps.html: regenerated fixing a typo
Daniel
2009-01-07 10:55:54 +00:00
Daniel Veillard
fbba4423e9
* src/libvirt_private.syms src/qemu_driver.c src/test.c
...
src/uml_driver.c src/util.c src/util.h src/xen_unified.c:
unify hostname lookup using virGetHostname convenience function,
patch by David Lutterkort
daniel
2009-01-07 10:43:16 +00:00
Daniel P. Berrange
37e72aa542
Fix misc mingw portability problems
2009-01-06 18:32:03 +00:00
Guido Günther
83467de3ed
add virKillProcess
2009-01-06 17:46:46 +00:00
Guido Günther
ffafc252dd
trivial cleanups
2009-01-06 17:20:27 +00:00
Jim Meyering
2ad1ca3f6c
fix "make dist" (from scratch) failure
...
* src/Makefile.am (EXTRA_DIST): Don't distribute libvirt_sym.version,
now that it's been removed. Spotted by Daniel Veillard.
2009-01-06 15:22:57 +00:00
Jim Meyering
950c8b3916
dist: distribute all libvirt_*.syms files, ...
...
* src/Makefile.am (EXTRA_DIST): Distribute all libvirt_*.syms files,
not just those that happen to be selected at configure time.
2009-01-06 15:16:43 +00:00
Daniel Veillard
0dbcac6598
* src/storage_backend_fs.c: Make mntent.h specific to the FS storage
...
backend, patch by John Levon
daniel
2009-01-06 08:43:44 +00:00
Jim Meyering
34ac4c1fe7
Remove storage backend symbols from version script
...
* src/libvirt_private.syms: Remove virStorageBackend* symbol names.
They're linked into qemud, not libvirt.
Author: John Levon
2009-01-05 14:10:40 +00:00
Jim Meyering
b0119de82f
migrate linux-specific symbol names into their own sym file
...
* configure.in (WITH_LINUX): New automake conditional.
* src/Makefile.am (PRIVSYMFILES) [WITH_LINUX]: Append libvirt_linux.syms.
* src/libvirt_private.syms: Move two symbol names into...
* src/libvirt_linux.syms: ...this new file.
Author: John Levon
2009-01-05 14:08:26 +00:00
Jim Meyering
83dfc25c02
Move bridge symbols into a separate syms file
...
* configure.in: Provide a new --with-bridge option.
* src/Makefile.am (PRIVSYMFILES) [WITH_BRIDGE]: Append libvirt_bridge.syms.
* src/bridge.c: Test WITH_BRIDGE rather than particular drivers.
* src/libvirt_private.syms: Move bridge-related symbols into...
* src/libvirt_bridge.syms: ...this new file.
Author: John Levon
2009-01-05 14:07:31 +00:00