Mark McLoughlin
3d3c8ac4c4
src/iptables.c: Create directory for saving iptables rules
2008-02-07 10:17:24 +00:00
Mark McLoughlin
f90cd4c3f4
src/xm_internal.[ch]: Move static function prototype from header
2008-02-07 10:14:43 +00:00
Daniel Veillard
ecaf98fcc5
Python bindings return values fixes
...
* python/libvir.c: apply patch from Cole Robinson to provide
return values for manulally written python bindings.
Daniel
2008-02-07 09:49:13 +00:00
Daniel Veillard
232d4f157a
Oops forgot >>>>, Daniel
2008-02-07 09:37:41 +00:00
Daniel Veillard
b33f740e1f
* src/libvirt.c: fix bug in xenUnifiedDomainSuspend() patch provided
...
by Marcus Meissner
Daniel
2008-02-07 09:37:10 +00:00
Daniel Veillard
594af3eb22
add/change/delete a Disk/NIC of an inactive domains
...
* src/xm_internal.[ch]: applied patch from Shigeki Sakamoto to
add/change/delete a Disk/NIC of an inactive domains
Daniel
2008-02-06 17:57:10 +00:00
Daniel Veillard
eecd68364a
QEmu config error handling fixes
...
* src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid
crashes when reading the config file
Daniel
2008-02-06 16:24:28 +00:00
Jim Meyering
5419d0b44d
Fix new "make distcheck" failures.
...
* src/xml.c (virDomainParseXMLOSDescHVM): Mark a diagnostic.
2008-02-05 22:07:31 +00:00
Jim Meyering
e04912a9f0
Remove all trailing blanks; turn on the rule to detect them.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_trailing_blank.
* .x-sc_trailing_blank: New file, to exempt the few binary files.
2008-02-05 19:27:37 +00:00
Daniel P. Berrange
e87e3f86bf
Added support for booting off kenrel+initrd with HVM guests
2008-02-05 16:21:25 +00:00
Jim Meyering
fb66d5ab92
Eliminate all uses of virBufferAdd with string literals.
...
* Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
New rule.
* src/buf.h (virBufferAddLit): Define.
* src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
of virBufferAdd everywhere possible.
(virConfSaveEntry): Likewise.
* src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
* src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
* src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
* src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
(xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
* src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
* src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
(virDomainParseXMLGraphicsDescImage): Likewise.
(virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
(virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
(virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
2008-02-05 14:22:28 +00:00
Jim Meyering
ecaa696250
Enable more checks for unmarked messages; fix violators.
...
* Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
* src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
* src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
* src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
(xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
(xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
* src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
(virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
(virDomainParseXMLOSDescHVM): Likewise.
* src/xmlrpc.c (xmlRpcValueNew): Likewise.
(xmlRpcValueUnmarshalDictElement): Likewise.
2008-02-04 19:31:30 +00:00
Jim Meyering
e99570fc77
Mark a string for translation.
...
* src/virsh.c: Add a "%s" and wrap with _(...).
2008-02-04 14:58:47 +00:00
Jim Meyering
70400346d2
Enable the sc_unmarked_diagnostics test and correct all violations
...
involving the "error" function.
* Makefile.cfg (local-checks-to-skip): Remove from skip list.
* src/remote_internal.c: Mark translatable strings.
2008-02-04 14:58:05 +00:00
Jim Meyering
aa290a3ece
Pull vc-list-files from gnulib, and update.
...
* bootstrap (gnulib_tool): Add the vc-list-files module.
2008-02-01 19:47:07 +00:00
Jim Meyering
b5433aaa6f
Avoid compilation failure when building --without-xen.
...
* tests/statstest.c (testDevice) [!WITH_XEN]: #ifdef-out.
(main) [!WITH_XEN]: #ifdef-out the body.
Committer: Jim Meyering <meyering@redhat.com>
Author: Guido Guenther <agx@sigxcpu.org>
2008-01-31 21:49:47 +00:00
Jim Meyering
f5f530f33f
Avoid virsh leaks due to missing virDomainFree(dom) calls
...
* src/virsh.c (cmdDomuuid): Add missing virDomainFree call.
(cmdAttachDevice): Likewise.
(cmdDetachDevice): Likewise.
2008-01-30 19:58:59 +00:00
Jim Meyering
a1d2d2b21c
src/virsh.c (cmdCapabilities): Plug a small leak.
2008-01-30 19:57:54 +00:00
Jim Meyering
34dff95bfd
src/test.c (testLoadDomain): Avoid leaks upon failure.
2008-01-30 19:57:13 +00:00
Jim Meyering
1217e5d516
Avoid used-uninitialized errors in test driver.
...
* src/test.c (testOpenFromFile): Initialize "privconn".
2008-01-30 19:54:29 +00:00
Jim Meyering
6997b1920f
src/libvirt.c (do_open): Avoid double-free upon failure.
2008-01-30 19:53:10 +00:00
Jim Meyering
218f866f86
Avoid segfault upon malloc failure, and plug a leak.
...
* src/test.c (testDomainSave): Detect testDomainDumpXML failure. Free "xml".
2008-01-30 19:52:16 +00:00
Jim Meyering
5561e9125f
Plug test-related leaks.
...
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
2008-01-30 19:50:14 +00:00
Daniel P. Berrange
17ef6faa7f
Remove double mutex lock()
2008-01-30 18:21:13 +00:00
Daniel P. Berrange
03003499e7
Fix XML generation for Xen USB devices
2008-01-30 16:38:18 +00:00
Jim Meyering
51dd1d9e38
Arrange for "make syntax-check" to pass.
...
* .x-sc_avoid_if_before_free: Exempt ChangeLog.
* tests/statstest.c: Include <config.h>, not "config.h".
2008-01-30 06:55:56 +00:00
Daniel P. Berrange
21416a4746
Fix device name -> number conversion for block stats
2008-01-29 18:36:00 +00:00
Jim Meyering
2367caa327
Also detect and remove unnecessary if-before-xmlXPathFreeContext.
...
* build-aux/find-unnecessary-if-before-free: Update regexp.
* src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
* src/qemu_conf.c: Likewise.
* src/virsh.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/xmlrpctest.c: Likewise.
2008-01-29 18:23:43 +00:00
Jim Meyering
1be2c8c814
Enable two more tests.
...
* Makefile.cfg (local-checks-to-skip)
[sc_cast_of_x_alloc_return_value, sc_cast_of_argument_to_free]: Enable.
2008-01-29 18:21:00 +00:00
Jim Meyering
2c72562374
Enable the <assert.h>-checking test; fix violations.
...
* Makefile.cfg (local-checks-to-skip)
[sc_prohibit_assert_without_use]: Enable.
* qemud/mdns.c: Don't include <assert.h>; no uses of assert here.
* qemud/qemud.c: Likewise.
* qemud/remote.c: Likewise.
2008-01-29 18:20:25 +00:00
Jim Meyering
05ae9d8bc4
Enable the po-check test; fix violations.
...
* Makefile.cfg (local-checks-to-skip) [po-check]: Enable.
* po/POTFILES.in: Add three file names. Sort.
2008-01-29 18:19:46 +00:00
Jim Meyering
bc48db5758
Update from gnulib
...
* lib/poll.c: Update.
* lib/string.in.h: Update.
* m4/string_h.m4: Update.
* tests/test-getaddrinfo.c: Update.
* lib/Makefile.am: Regenerate.
2008-01-29 18:17:47 +00:00
Jim Meyering
a378188194
Enable the <config.h>-requiring test; fix violations
...
Use <config.h>, not "config.h", per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
2008-01-29 18:15:54 +00:00
Jim Meyering
9e4c8fcb3a
Enable the duplicate-"the" test; fix violations
...
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
* docs/virsh.pod: Remove a duplicate "the".
* libvirt.spec.in: Likewise.
* virsh.1: Likewise.
2008-01-29 17:43:28 +00:00
Jim Meyering
cc337da21f
Add framework for code style- and syntax-checking rules.
...
Almost all tests are initially disabled via the list in Makefile.cfg.
* Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
Omit names of files that automake includes automatically.
* .x-sc_avoid_if_before_free: New file.
* build-aux/vc-list-files: Likewise.
* build-aux/find-unnecessary-if-before-free: Likewise.
* GNUmakefile, Makefile.cfg, Makefile.maint: New files.
2008-01-29 17:42:39 +00:00
Jim Meyering
acff2d11ac
Given code like if (foo) free (foo); remove the useless "if (foo) " part.
...
Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
* proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
* python/generator.py: Likewise.
* qemud/qemud.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/libvirt.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* src/test.c: Likewise.
* src/virsh.c: Likewise.
* src/virterror.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xend_internal.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/testutils.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
2008-01-29 17:41:07 +00:00
Richard W.M. Jones
b17caa80d1
Clarify virsh documentation.
...
* docs/virsh.pod: Clarify virsh documentation on when you can
set memory and vCPUs.
2008-01-25 12:03:05 +00:00
Daniel Veillard
aab826d4cc
Fix VIR_DOMAIN_NONE into VIR_DOMAIN_NOSTATE
...
* src/xen_internal.c: fix an erronous use of VIR_DOMAIN_NONE instead
of VIR_DOMAIN_NOSTATE (both defined as 0, no regression)
Daniel
2008-01-25 09:47:51 +00:00
Daniel Veillard
3f9a94bec3
* src/libvirt.c: Jay Gagnon pointed out that virDomainGetXMLDesc
...
was failing with a non-zero flag value
Daniel
2008-01-24 17:09:56 +00:00
Richard W.M. Jones
7db9140126
Correct typos in the documentation (Atsushi SAKAI)
...
* README, libvirt.spec.in, docs/devhelp/html.xsl,
docs/devhelp/index.html: Correct typos in the documentation.
2008-01-24 10:15:13 +00:00
Daniel P. Berrange
38b2478b41
Fix enablement of SASL
2008-01-23 19:37:10 +00:00
Richard W.M. Jones
9cf2573c8a
Portability improvements for Mac OS X.
...
* configure.in: Use PortableXDR if available.
* qemud/internal.h: Use "socketcompat.h".
* qemud/qemud.c: Use <signal.h>.
* src/sexpr.c: Use <stdlib.h> instead of <malloc.h>.
* src/socketcompat.h: Include <sys/un.h> for Mac OS X.
2008-01-23 14:54:41 +00:00
Richard W.M. Jones
569200b6d4
Remove DOS line-endings.
...
* src/socketcompat.h: Remove DOS line-endings in this file.
2008-01-23 14:50:14 +00:00
Daniel P. Berrange
9d7661e415
Fix compat for old pkg-config and gnutls
2008-01-22 21:30:05 +00:00
Jim Meyering
63dffbf1d2
Avoid "may be used uninitialized" warning.
...
* tests/xmconfigtest.c (testCompareParseXML): Initialize "old_priv".
2008-01-21 17:06:47 +00:00
Daniel P. Berrange
97bed42f7a
Fix & refactor ref counting cleanup code
2008-01-21 16:29:10 +00:00
Daniel P. Berrange
c9b7eae903
Make python generator fail build on any missing APIs
2008-01-21 15:55:53 +00:00
Daniel P. Berrange
62094f72f6
Add missing vcpu/schedular APIs to python binding
2008-01-21 15:41:15 +00:00
Daniel P. Berrange
45738083a6
Use virFileReadAll in virsh.c
2008-01-21 15:27:14 +00:00
Daniel P. Berrange
53365f4c54
Remove no-op networking APIs from openvz driver
2008-01-21 15:19:46 +00:00