External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-04 20:31:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,775 Commits 67 Branches 626 Tags 845 MiB
3f3ec73d39
Commit Graph

1827 Commits

Author SHA1 Message Date
Daniel P. Berrange
c0d74ed43b Support networking in UML driver 2009-06-03 11:13:33 +00:00
Daniel P. Berrange
7cce4768ae Misc User Mode Linux startup/shutdown bugs 2009-06-03 10:55:33 +00:00
Daniel Veillard
81d0ffbc3b NPIV implementation for node device create and destroy 
* src/Makefile.am src/node_device.[ch] src/node_device_conf.[ch]
  src/node_device_hal.[ch] src/node_device_hal_linux.c
  src/qemu_driver.c src/remote_internal.c src/storage_backend.c
  src/virsh.c src/xen_unified.c tests/nodedevxml2xmltest.c
  po/POTFILES.in: implementation for node device create and destroy
  in NPIV support, patch by David Allan
Daniel
 2009-06-02 15:12:53 +00:00
Daniel Veillard
66220e3e61 release of libvirt-0.6.4 
* configure.in libvirt.spec.in NEWS docs/* po/*: release of
  libvirt-0.6.4
* src/libvirt.c src/virterror.c: some comments cleanups
Daniel
 2009-05-29 16:51:15 +00:00
Daniel P. Berrange
8a1a2ac558 Fix Win32 portability problems with 'inteface' symbol clash 2009-05-29 14:29:22 +00:00
Daniel Veillard
43692df590 portability fix 
* src/lxc_container.c: fix a portability issue if PR_CAPBSET_DROP is
  not defined.
Daniel
 2009-05-29 14:27:04 +00:00
Cole Robinson
b121c7871f network driver: Fix regression defining colliding networks at daemon startup. 
If two virtual networks have the same hardcoded bridge device (which
prevents them from being active simultaneously) we still want to define
them at daemon startup, so the user has a fighting chance of correcting
the XML error.

Add an extra flag to SetBridge to avoid reporting an error if there is
a bridge collision, and use this when loading network configs at startup.

This regressed via commit 4c3f3b4d.
 2009-05-29 14:18:57 +00:00
Cole Robinson
545c815c4c networkDestroy: Report error if network is inactive 
This follows the same convention as domain drivers.
 2009-05-29 14:14:32 +00:00
Cole Robinson
34497fdb37 qemu_driver: Fix another domain startup error reporting race. 
Parse the command line output a bit earlier so we have a better chance
of reporting the full error output on failure.

I hit this when QEMU would try to boot an invalid kernel (virtinst bug).
 2009-05-29 14:12:50 +00:00
Cole Robinson
4ff19ced3a qemuDomainLookupByUUID: print correct UUID string on failed lookup. 
Currently we print the raw UUID which isn't very useful in ascii format.
 2009-05-29 14:01:55 +00:00
Cole Robinson
58c73c1789 virsh: Use consistent spacing for net-list 
There is different spacing when listing active vs. inactive networks. Ex:

Name                 State      Autostart
-----------------------------------------
default              active     yes
xxxxxx               inactive no
 2009-05-29 14:00:41 +00:00
Daniel Veillard
525c3d40a9 PPC Qemu Machine Type update 
* src/qemu_conf.c docs/schemas/domain.rng
  tests/capabilityschemadata/caps-qemu-kvm.xml: PPC Qemu Machine Type
  changed from g3bw to g3beige some time ago, patch by Thomas Baker
Daniel
 2009-05-29 13:32:06 +00:00
Daniel P. Berrange
8c13e4fef0 Fix missing break in network parsing code 2009-05-29 13:26:45 +00:00
Daniel P. Berrange
c31300e69f Fix misc bugs in ARGV -> XML convertor 2009-05-28 13:21:19 +00:00
Daniel P. Berrange
2afc3bfd8b Avoid broken networking with new QEMU/KVM >= 86 2009-05-28 13:15:57 +00:00
Daniel P. Berrange
ee8553e156 Fix misc syntax problems with open nebula driver 2009-05-28 13:11:22 +00:00
Daniel P. Berrange
dcd9865385 Include function/line nr at all logging levels 2009-05-28 12:54:07 +00:00
Daniel P. Berrange
fb828ed21d Fix error location logging 2009-05-27 12:10:47 +00:00
Daniel Veillard
b811851b8d Include the OpenNebula driver 
* src/opennebula/one_conf.[ch] src/opennebula/one_driver.[ch]:
  the OpenNebula driver
* configure.in include/libvirt/virterror.h qemud/Makefile.am
  qemud/qemud.c src/Makefile.am src/domain_conf.[ch] src/driver.h
  src/libvirt.c src/virterror.c: integration of the OpenNebula
  driver in the libvirt infrastructure
* AUTHORS: add Abel Miguez Rodriguez
daniel
 2009-05-25 11:56:00 +00:00
Daniel P. Berrange
3d4a0ccbc6 QEMU domain XML conversion from QEMU argv 2009-05-21 14:16:55 +00:00
Daniel P. Berrange
7828b5ccb0 Fix typo s/ES97/AC97/ 2009-05-21 14:16:06 +00:00
Daniel P. Berrange
d8dbd61107 Basic domain XML conversions for Xen/QEMU drivers 2009-05-21 14:14:01 +00:00
Daniel P. Berrange
60d4777190 Remote protocol support for domain XML conversion APIs 2009-05-21 13:50:56 +00:00
Daniel P. Berrange
4d5383fd36 public API for domain XML conversions 2009-05-21 13:46:35 +00:00
Daniel Veillard
73bc011483 Add the Interface config APIs 
* configure.in include/libvirt/libvirt.h[.in]
  include/libvirt/virterror.h qemud/remote.c
  qemud/remote_dispatch_args.h qemud/remote_dispatch_prototypes.h
  qemud/remote_dispatch_ret.h qemud/remote_dispatch_table.h
  qemud/remote_protocol.[chx] src/Makefile.am src/datatypes.c
  src/datatypes.h src/driver.h src/libvirt.c src/remote_internal.c
  src/virterror.c src/libvirt_private.syms src/libvirt_public.syms:
  Add the Interface config APIs and remote stubs for those, patch
  by Laine Stump
* AUTHORS: add Laine
daniel
 2009-05-20 14:26:49 +00:00
Daniel Veillard
e8da987570 cleanup of some direct stderr logging 
* qemud/qemud.c src/console.c src/network_driver.c
  src/node_device_conf.c src/node_device_hal.c src/storage_conf.c
  src/util.c: cleanup of some direct stderr logging
daniel
 2009-05-20 13:37:30 +00:00
Daniel Veillard
d879d360eb * src/pci.c: small portability patch 
daniel
 2009-05-20 13:34:15 +00:00
Daniel Veillard
6a140adb78 * src/lxc_driver.c: fix a couple of error code, patch by Amy Griffis 
daniel
 2009-05-20 07:12:00 +00:00
Cole Robinson
2d1de285b3 VolumeCreateXMLFrom FS storage backend implementation. 
Add an extra 'inputvol' parameter to the file volume building routines. This
allows us to easily reuse the duplicate functionality.
 2009-05-19 13:43:48 +00:00
Cole Robinson
4aa0959d60 Storage driver implementation for CreateXMLFrom 
There is some funkiness here, since we are either dealing with 2 different
pools (which means validation x 2) or the same pool, where we have to be
careful not to deadlock.
 2009-05-19 13:37:51 +00:00
Cole Robinson
5f99a7fd23 Fix node device media insert/eject detection. 
We were correctly registering a callback , but weren't telling hal to
actually notify us of any property changes.
 2009-05-19 13:35:57 +00:00
Cole Robinson
6244c173ba Fix a possible deadlock in HAL nodedev driver. 
The cap_lost and prop_modified callbacks could deadlock if an existing
device needed to be refreshed, since dev_create expects the driver to
be unlocked.
 2009-05-19 13:26:14 +00:00
Cole Robinson
adf4384501 Use virAsprintf, rather than VIR_ALLOC + strcpy + strcat 2009-05-19 13:15:50 +00:00
Cole Robinson
bb175dfc53 Don't validate disk type in virsh attach-disk 
Let the underlying driver tell us what it supports. At the moment
we are at least erroneously denying floppy eject/insert.
 2009-05-19 13:04:46 +00:00
Daniel P. Berrange
de658ab4e4 Fix misc locking bugs identified by lock checker 2009-05-19 11:06:25 +00:00
Daniel P. Berrange
6962a2dd7e Added an optional OCaml+CIL test program for mutex lock validation 2009-05-19 10:17:17 +00:00
Daniel P. Berrange
3ce55d22e4 Declare support for QEMU migration in capabilities 2009-05-18 15:10:51 +00:00
Daniel Veillard
67cc35ade9 Finish hostonly networks support in vbox 
* src/vbox/vbox_driver.c src/vbox/vbox_tmpl.c: last patch for
  hostonly networks support in vbox driver, patch by Pritesh Kothari
daniel
 2009-05-15 14:00:50 +00:00
Daniel Veillard
37623bf49a * src/vbox/vbox_tmpl.c: implement vbox vrdp/sdl/gui support, 
patches by Pritesh Kothari
daniel
 2009-05-15 13:45:40 +00:00
Daniel Veillard
cd223d93da generic support for RDP and desktop graphic extensions 
* docs/schemas/domain.rng src/domain_conf.[ch] src/qemu_driver.c:
  extend the generic code for the RDP and desktop extensions of
  the graphic tag needed for vbox, patch by Pritesh Kothari
Daniel
 2009-05-15 09:43:51 +00:00
Daniel Veillard
fa1ceca232 * src/xend_internal.c: remove [] around cpumaps for recent xend 
patch by Tatsuro Enokura
daniel
 2009-05-14 10:31:11 +00:00
Cole Robinson
ee0d7552e2 Fix a few 'used uninitialized' warnings. 2009-05-13 17:43:47 +00:00
Daniel Veillard
7afe94e7e2 * src/buf.c: avoid an XML attribute escaping bug #499791 
daniel
 2009-05-13 16:19:59 +00:00
Daniel P. Berrange
0d11a25e6d Replace sys/capability.h with linux/capability.h 2009-05-13 11:37:16 +00:00
Cole Robinson
be9e5185b4 Break out FS volume build routines to their own functions. 
Improves readability, particularly wrt the pending CreateFromXML changes.
This will also help implementing File->Block volume creation in the future,
since some of this code will need to be moved to a backend agnostic file.
 2009-05-12 20:27:17 +00:00
Cole Robinson
6852c88fc7 Virsh commands vol-clone and vol-create-from 
vol-clone is a convenience function, requiring only a volume to clone and a
new name.

vol-create-from is a direct mapping to the public API, which allows cloning
across pools, converting between formats, etc, but requires an xml file to be
passed
 2009-05-12 20:17:21 +00:00
Cole Robinson
3804161eb6 Test driver implementation of virStorageVolCreateXMLFrom 2009-05-12 20:15:56 +00:00
Cole Robinson
885de7f8cf Remote driver plumbing for virStorageVolCreateXMLFrom 2009-05-12 20:13:52 +00:00
Cole Robinson
5b31c7d08a Add public API stubs for virStorageVolCreateXMLFrom 
Also checkin regenerated docs due to API change.
 2009-05-12 20:10:50 +00:00
Cole Robinson
52c5f7adc8 Fix error squashing when refreshing file volumes 2009-05-12 19:59:46 +00:00
Daniel P. Berrange
1a60d6bcd6 Improve driver open URI handling 2009-05-12 15:35:18 +00:00
Daniel Veillard
e978774ec6 * src/network_driver.c: enable bridges which are not up 
without an IP address, patch by Ludwig Nussel
Daniel
 2009-05-12 15:31:22 +00:00
Daniel P. Berrange
6582d5872d Make hash destructors call internal unref methods to free objects 2009-05-11 15:27:37 +00:00
Daniel P. Berrange
65ecb4b434 Fix unused variable warning in LXC driver 2009-05-11 15:26:23 +00:00
Daniel P. Berrange
426f9772b8 Fix QEMU ARGV detection with kvm >= 85 2009-05-11 15:14:24 +00:00
Daniel P. Berrange
9927ca6274 Report detailed error if initial connection open attempt fails 2009-05-11 14:55:52 +00:00
Daniel Veillard
9959a1dd9d drop CAP_SYS_BOOT capability from LXC containers 
* src/lxc_container.c: drop LXC CAP_SYS_BOOT capability to avoid
  reboot from inside containers, patch by Ryota Ozaki
Daniel
 2009-05-11 14:05:27 +00:00
Cole Robinson
0c8a9d2d51 Check that QEMU is still alive while reading startup output. 
By checking the pid every retry period, we can quickly determine if
the process crashed at startup, rather than make the user wait for
the entire timeout (3 seconds).
 2009-05-11 13:52:31 +00:00
Cole Robinson
a331653dad Add pidfile argument to __virExec 
virExec will write out the pid of the daemonized process only. Use this
in the QEMU driver, rather than QEMU's pidfile, so we can catch errors we
might miss if the emulator bails early.
 2009-05-11 13:50:38 +00:00
Cole Robinson
27d72bd517 Report qemu log data if we fail to daemonize the process. 
This ensures the user will actually see 'hook' function error output.
 2009-05-11 13:37:19 +00:00
Cole Robinson
79d9d2432f Add helper function virExecDaemonize 
Wraps __virExec with the VIR_EXEC_DAEMON flag. Waits on the intermediate
process to ensure we don't end up with any zombies, and differentiates between
original process errors and intermediate process errors.
 2009-05-11 13:34:37 +00:00
Daniel Veillard
2e878906e4 "Host only" and "Internal" network support for vbox 
* src/vbox/vbox_tmpl.c: "Host only" and "Internal" network support
  for vbox, patch by Pritesh Kothari
daniel
 2009-05-11 09:56:04 +00:00
Daniel Veillard
070c1c82b0 Support for 'internal' network 
* src/domain_conf.[ch] docs/schemas/domain.rng: add support
  for internal network in the generic part of the code, and
  update the Relax-NG grammar accordingly, patch by Pritesh Kothari
daniel
 2009-05-11 09:50:27 +00:00
Daniel P. Berrange
b81c7c0892 Create cgroups mode 755, not 655 (Ryota Ozaki) 2009-05-08 10:24:11 +00:00
Daniel P. Berrange
328eac61cd Fix /dev/ population to use char devices (Ryota Ozaki) 2009-05-08 10:22:46 +00:00
Guido Günther
6059354da6 return VIR_DRV_OPEN_DECLINED instead of VIR_DRV_OPEN_ERROR when vbox can't be 
found so other hypervisors can be probed. Patch by Pritesh Kothari.
 2009-05-08 10:18:26 +00:00
Guido Günther
67e2804ecb fix crash when init fails early (i.e. due to vbox not being installed) 2009-05-08 10:14:30 +00:00
Daniel P. Berrange
54ebbde1e1 Improve name & UUID uniqueness checking in QEMU driver 2009-05-08 10:11:14 +00:00
Daniel P. Berrange
88e22e4e8c Enable save/restore/migrate for QEMU >= 0.10.0 2009-05-08 10:07:15 +00:00
Daniel P. Berrange
0fb9066aaf Log dlopen() errors more verbosely 2009-05-08 10:05:56 +00:00
Daniel P. Berrange
7022759b7e Add new VIR_ERR_OPERATION_INVALID error code & use it in Xen & QEMU drivers 2009-05-08 09:58:46 +00:00
Guido Günther
1dfc35677e check for NULL pointers in pidfile functions 2009-05-07 07:29:51 +00:00
Daniel Veillard
7ee54d8356 Changes needed for multiple graphics adapters 
* src/domain_conf.c src/domain_conf.h: parse and save multiple
  graphics elements instead of one, patch by Pritesh Kothari
* src/qemu_conf.c src/qemu_driver.c: adapt the qemu/kvm driver for
  the new structures, patch by Pritesh Kothari
* src/xend_internal.c src/xm_internal.c: same thing for Xen drivers
Daniel
 2009-05-07 07:27:49 +00:00
Guido Günther
9f9ce6130d don't crash when called without arguments 2009-05-07 07:17:25 +00:00
Mark McLoughlin
1d6c713b18 Fix qemu driver's interpretation of <hostdev managed='yes'/> 
This change:

  Tue Mar  3 08:55:13 GMT 2009 Daniel P. Berrange <berrange@redhat.com>

       Don't try to detach & reset PCI devices while running test
       suite for XML-> ARGV conversion.
       * src/qemu_driver.c: Add qemuPrepareHostDevices() helper to
       detach and reset PCI devices.
       * src/qemu_conf.c: Don't detach & reset PCI devices while
       building the command line argv

accidentally did this:

-            if (hostdev->managed) {
+        if (!hostdev->managed) {

Which results in managed='yes' not causing the device to be
detached when the guest is starting.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
 2009-05-06 15:56:20 +00:00
Cole Robinson
4f10759024 Refresh QEMU driver capabilities for each getCapabilities call. 
Also fix up a couple issues where caps are accessed without locking
the driver structure.
 2009-05-06 14:20:34 +00:00
Daniel Veillard
5432ec8ded VirtualBox version improvement and cleanups 
* src/vbox/vbox_driver.c src/vbox/vbox_tmpl.c: changes in
  VirtualBox driver version detection and move informations
  from a global variable into a driver structure, patch by Pritesh
  Kothari.
Daniel
 2009-05-06 13:51:19 +00:00
Daniel Veillard
9ccdbb5d61 * src/vbox/vbox_XPCOMCGlue.[ch]: improve VirtualBox path detection 
patch by Pritesh Kothari
Daniel
 2009-05-06 13:23:44 +00:00
Cole Robinson
840955ff7c Don't throw away StartVM errors when migrating/restoring in qemu driver. 2009-05-05 14:26:02 +00:00
Cole Robinson
03f3736511 Small cleanups in test driver VolCreateXML 2009-05-05 14:19:59 +00:00
Cole Robinson
2a9ca74164 Remove some debug code from storage_driver.c 2009-05-05 14:18:51 +00:00
Cole Robinson
48e9d6862a Use proper error code in virStorageVolCreateXML 2009-05-05 14:17:50 +00:00
Cole Robinson
3f24e6c21c Fix a comment typo in storage_backend_fs.c 2009-05-04 15:44:44 +00:00
Cole Robinson
5314dffc85 virExec: Delay daemonizing as long as possible. 
This way the caller can catch more errors (e.g. from a hook callback) from
the intermediate process.
 2009-05-04 15:43:25 +00:00
Cole Robinson
a4d0a3fd50 Add some documentation to __virExec and virExec 2009-05-04 15:41:46 +00:00
Daniel P. Berrange
cb4a6614fa Fix check for -Wformat-security which depends on -Wformat 2009-04-28 10:55:45 +00:00
Daniel Veillard
9cae1d5ed6 release of 0.6.3 
* NEWS configure.in libvirt.spec.in docs/*: release of 0.6.3
* po/*: regenerated
* src/libvirt.c src/virterror.c: fixed some function comments
Daniel
 2009-04-24 14:04:54 +00:00
Daniel P. Berrange
62aa1b56d6 Add virNodeDeviceCreateXML / virNodeDeviceDestroy boilerplate public API and remote protocol impl 2009-04-24 13:11:23 +00:00
Daniel P. Berrange
1aac8114ae Fix Xen dlopen module missing export 2009-04-24 12:19:00 +00:00
Daniel P. Berrange
1fbee8dadf Fix XM driver VIF config creation 2009-04-24 12:17:50 +00:00
Daniel P. Berrange
d83ded2dba Avoid compile warnings about assignment/conditional/truthvalue 2009-04-22 14:28:25 +00:00
Daniel P. Berrange
220bcb0535 Use a private /dev/pts instance in containers if kernel is new enough 2009-04-22 14:26:50 +00:00
Daniel P. Berrange
9c19a898f9 Remove stale QEMU pidfiles 2009-04-21 19:14:50 +00:00
Daniel P. Berrange
7a367cca30 Ensure VirtualBox domain IDs start from 1 instead of 0 2009-04-21 19:13:23 +00:00
Daniel Veillard
4c3f3b4d46 * src/network_conf.c src/network_conf.h: add dynamic bridge names 
support, patch by Soren Hansen
* AUTHORS: add Soren
daniel
 2009-04-21 19:00:06 +00:00
Daniel Veillard
ec4e379125 * src/xend_internal.c: let xend try vcpu pinning operation even 
if the domain is not running, patch by Takahashi Tomohiro
daniel
 2009-04-21 15:10:23 +00:00
Daniel Veillard
5237c2b847 * docs/drvvbox.html[.in]: tiny fixes to VirtualBox docs 
Daniel
 2009-04-21 13:39:40 +00:00
Daniel Veillard
bfc48afa14 cope with kernels where CLONE_NEWUSER is not supported 
* src/lxc_container.c src/lxc_container.h: cope with kernels
  where CLONE_NEWUSER is not supported, patch by Serge Hallyn
daniel
 2009-04-20 12:27:12 +00:00
Daniel Veillard
943a2f2b60 * src/bridge.c: fix a compilation breakage raised by Anton Protopopov 
daniel
 2009-04-20 09:18:26 +00:00
Daniel P. Berrange
89626e8d69 Add another vbox file to EXTRA_DIST 2009-04-19 16:36:22 +00:00
Daniel P. Berrange
ac6797b28c Add missing break in error code 2009-04-19 15:49:00 +00:00
Daniel P. Berrange
cfa30de3b8 Improve error reporting for lookup failures on inactive domains 2009-04-19 15:30:50 +00:00
Daniel P. Berrange
c881b32215 Fix 2 domain ID handling bugs in remote driver 2009-04-19 15:21:54 +00:00
Daniel P. Berrange
cb43623acd Switch over todo domain lookup based on UUID in virDomainAssignDef 2009-04-19 15:16:43 +00:00
Daniel P. Berrange
001390a684 Add 2 missing vbox files to EXTRA_DIST 2009-04-19 15:12:01 +00:00
Daniel P. Berrange
9a15c48d2d Switch to using virDomainDefPtr for building command line in QEMU driver 2009-04-19 14:50:01 +00:00
Daniel Veillard
2cd9b2d8ee drop the pool lock when allocating fs volumes 
* src/libvirt_private.syms src/storage_backend.h
  src/storage_backend_fs.c src/storage_conf.h src/storage_driver.c:
  drop the pool lock when allocating fs volumes, patch by Cole Robinson
daniel
 2009-04-17 19:12:37 +00:00
Daniel Veillard
10d1650843 integration of the VirtualBox support 
* configure.in include/libvirt/virterror.h src/Makefile.am
  src/domain_conf.[ch] src/driver.h src/virterror.c src/vbox/README
  src/vbox/vbox_CAPI_v2_2.h src/vbox/vbox_V2_2.c
  src/vbox/vbox_XPCOMCGlue.[ch] src/vbox/vbox_driver.[ch]
  src/vbox/vbox_tmpl.c: integration of the VirtualBox support
  patches by Pritesh Kothari
Daniel
 2009-04-17 16:09:07 +00:00
Daniel Veillard
81e6a22192 Small doc fixes 
* src/libvirt.c: fix the doc of virNodeGetFreeMemory to say bytes
* docs/drvlxc.html.in docs/drvlxc.html: fix command used in examples
daniel
 2009-04-17 15:34:53 +00:00
Guido Günther
5caa1e0eb0 Don't log monitor output to domain log file. 
It's logged via the logging system already. Prefix monitor debug output with vm
name.
 2009-04-16 15:56:27 +00:00
Mark McLoughlin
9fa79000ec qemu -drive takes format= not fmt= 
Seems like a simple typo - it has been "format=" since the flag
was introduced, but we added it as "fmt=".

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
 2009-04-16 14:21:35 +00:00
Mark McLoughlin
169afbe9aa Fix lxc syntax-check failure 
Fixes:

 CHECK: avoid_if_before_free
 src/lxc_container.c: if (oldroot) VIR_FREE(oldroot)
 src/lxc_container.c: if (newroot) VIR_FREE(newroot)
 Makefile.maint: found useless "if" before "free" above

and:

 src/lxc_container.c:317:
 Makefile.maint: found trailing blank(s)

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
 2009-04-16 13:08:03 +00:00
Daniel Veillard
f61208bde9 * src/virsh.c: fix for virsh ttyconsole return value bug #495954 
daniel
 2009-04-15 20:09:09 +00:00
Daniel Veillard
14687aad81 * src/xm_internal.c: fix a crash on vcpupin to inactive Xen domains, 
as raised by Takahashi Tomohiro
daniel
 2009-04-15 09:53:34 +00:00
Daniel Veillard
cab9eed62e * src/lxc_driver.c: adds the getHostname method to the lxc driver 
patch by Dan Smith
daniel
 2009-04-15 09:34:56 +00:00
Dan Smith
06e43a8f2c Commit patches by Serge Hallyn from 6-Apr and 7-Apr 2009-04-14 17:51:12 +00:00
Daniel Veillard
b2df3510b7 * src/storage_backend_scsi.[ch]: add SCSI storage rescan support, 
patch by David Allan
daniel
 2009-04-07 12:50:17 +00:00
Cole Robinson
6d910c9fd4 Don't lose file format info on volume refresh. 2009-04-03 14:17:57 +00:00
Cole Robinson
766b2250e1 Refresh volume alloc/capacity when dumping XML. 2009-04-03 14:15:30 +00:00
Cole Robinson
a843f44c51 Fix test driver domain restore return value. 2009-04-03 14:14:05 +00:00
Cole Robinson
e807e4d9e9 Fix sparse volume allocation reporting. 2009-04-03 14:13:02 +00:00
Daniel P. Berrange
9ec1a56923 Fix crash in svirt verification, and incorrect cleanup in VM failure paths 2009-04-03 14:10:17 +00:00
Daniel P. Berrange
f0817018b1 Allow autoconnect to virsh console in create/start. Refuse to connect to remote consoles 2009-04-03 14:03:38 +00:00
Daniel P. Berrange
92ff72b52c Misc NUMA related fixes 2009-04-03 12:45:05 +00:00
Daniel P. Berrange
e4073623a6 Support PCI passthrough for Xen 2009-04-03 12:38:52 +00:00
Daniel P. Berrange
11b0ed46c5 Improve security label error reporting & verification (Dan Walsh) 2009-04-03 10:55:51 +00:00
Daniel P. Berrange
d9ec9c6937 Fix mingw32 portability 2009-04-02 18:42:33 +00:00
Daniel P. Berrange
55ae53d971 SCSI HBA storage pool implementation (Dave Allan) 2009-04-01 16:03:22 +00:00
Daniel P. Berrange
b02c0455d1 Fix localtime handling for newer XenD 2009-04-01 10:36:52 +00:00
Daniel P. Berrange
e4c65831e3 Misc fixes uncovered by OOM testing 2009-04-01 10:31:01 +00:00
Daniel P. Berrange
dab6391f2d Sanitize symlink resolution 2009-04-01 10:26:22 +00:00
Daniel P. Berrange
9a47149559 Fix misc memory handling bugs 2009-04-01 10:21:34 +00:00
Daniel P. Berrange
83a618f807 Add support for vifname= in XM config files 2009-04-01 10:16:05 +00:00
Daniel P. Berrange
3ad8a273b5 Improve error reporting in Xen driver SEXPR generation 2009-04-01 10:01:23 +00:00
Daniel P. Berrange
b2f5ba21b8 Fix error message in node device lookup 2009-04-01 09:55:32 +00:00
Daniel P. Berrange
461afc2200 Fix URI check in QEMU migration 2009-04-01 09:54:20 +00:00
Daniel P. Berrange
45707d5631 Add treeview to node device listing in virsh 2009-04-01 09:52:59 +00:00
Chris Lalancette
4d3d0039e5 Convert all drivers to use old-style struct initializers; this makes a handy 
built-in TODO list for each driver.  Also rip out the internal getURI method;
it is never used by any of the drivers, and was buggy to boot.
 2009-03-31 15:47:16 +00:00
Daniel Veillard
b7071653fa * src/util.c: fix virRun() to prevent zombies on pipe errors, 
patch by Ryota Ozaki
daniel
 2009-03-31 12:26:54 +00:00
Daniel P. Berrange
3b97f7db53 DOn't try to query memory balloon if guest isn't active 2009-03-27 14:57:51 +00:00
Daniel P. Berrange
cb7593bd19 Support memory ballooning in QEMU 2009-03-27 11:44:29 +00:00
Daniel P. Berrange
97230f6a35 Default to native arch, and check domain type when auto-filling guest arch (Soren Hansen) 2009-03-24 11:16:29 +00:00
Daniel P. Berrange
60623a7ce0 Add support for a non-template filesystem root. (Florian Vichot) 2009-03-24 10:59:13 +00:00
Daniel Veillard
aac6018a35 fix missing authentication on virsh shell commands 
* src/virsh.c: fix missing authentication when command are issued
  from the shell, patch by Matthias Bolte
Daniel
 2009-03-23 16:36:32 +00:00
Daniel Veillard
de4950b200 * src/util.c: flag unused parameters, by Maximilian Wilhelm 
daniel
 2009-03-20 20:46:07 +00:00
Daniel Veillard
c29d092905 use posix_fallocate() to allocate diskspace faster 
* src/libvirt_private.syms src/storage_backend_fs.c src/util.c
  src/util.h: use posix_fallocate() on supported systems to
  allocate diskspace faster, patches by Amit Shah
Daniel
 2009-03-20 12:17:56 +00:00
Daniel P. Berrange
b75a469852 More flexible setup of QEMU capabilities/emulators 2009-03-20 11:20:26 +00:00
Daniel P. Berrange
c86afc85ee Fix labelling of shared/readonly devices (Dan Walsh) 2009-03-17 11:35:40 +00:00
Daniel Veillard
df59fdce06 * src/remote_internal.c: remove file descriptors leak 
daniel
 2009-03-17 11:00:56 +00:00
Cole Robinson
b68a19be0f Don't allow readonly connections to dump secure xml. 2009-03-16 17:21:12 +00:00
Cole Robinson
2068f2f5a3 Initialize security driver after config parsing 2009-03-16 17:16:04 +00:00
Cole Robinson
d2c77e06c7 Fix test driver 'save' deadlock 2009-03-16 17:14:34 +00:00
Daniel P. Berrange
b44af714d3 Support SASL auth for VNC server. 2009-03-16 13:54:26 +00:00
Daniel P. Berrange
8fa62166c4 Avoid deadlock setting vcpus in QEMU driver 2009-03-16 11:44:46 +00:00
Daniel P. Berrange
35625e5aa8 Fix subsystem lookup for older HAL releases 2009-03-16 10:56:01 +00:00
Daniel Veillard
aa08419ca8 Avoid some potential FILE * leaks 
* qemud/qemud.c src/cgroup.c src/uml_driver.c src/util.c: close
  some potential FILE * leaks
Daniel
 2009-03-16 10:41:37 +00:00
Daniel P. Berrange
2567fac4a7 Don't free storage volume in cleanup path, since it may still be referenced 2009-03-16 10:31:38 +00:00
Daniel P. Berrange
aad6873175 Don't try to close NULL virConnectPtr object 2009-03-16 10:30:04 +00:00
Daniel Veillard
a3262d812b * src/storage_conf.c: fix storage pool mode parsing, and refactoring 
patch by Ryota Ozaki
Daniel
 2009-03-12 20:15:32 +00:00
Daniel Veillard
bdd6894713 * src/xs_internal.c: fix xen events handling problem (Dan Berrange) 
Daniel
 2009-03-11 13:43:24 +00:00
Daniel Veillard
27a63a76af * src/xend_internal.c: fix an allocation problem in xenDaemonDomainLookupByName_ids 
Daniel
 2009-03-10 11:13:32 +00:00
Daniel P. Berrange
4dfb7e8b2e Fix Xen block detach with newer Xend (Cole RobinSon / Tomohiro Takahashi) 2009-03-10 10:32:24 +00:00
Daniel Veillard
7f39e2e5e5 * src/cgroup.c src/cgroup.h src/lxc_driver.c: allows to get 
CPU usage of a lxc using cpuacct subsystem of cgroups, patch
  by Ryota Ozaki
Daniel
 2009-03-06 14:44:04 +00:00
Daniel P. Berrange
4ebe4c108d Fix misc failures in test suite & make test cases more robust to future changes 2009-03-04 13:04:06 +00:00
Daniel P. Berrange
b9739b4709 Add missing locking calls in remote driver 2009-03-03 19:33:34 +00:00
Daniel P. Berrange
3aed672836 Use lseek+saferead/write for pci.c & dont link to qemu driver for nodedevxml2xmltest 2009-03-03 17:00:18 +00:00
Daniel P. Berrange
61796bdb4b Explicitly track static declared vs dynamically generated security labels 2009-03-03 16:53:13 +00:00
Daniel P. Berrange
e4818895c1 Misc sVirt bug fixes 2009-03-03 15:18:24 +00:00
Jim Meyering
efa5832b0a config: fix a typo 
* src/qemu_conf.c (CHECK_TYPE): Fix typo:
s/security_river/security_driver/
 2009-03-03 15:12:30 +00:00
Daniel P. Berrange
d0aa10fdd6 QEMU security driver usage for sVirt support (James Morris, Dan Walsh, Daniel Berrange) 2009-03-03 12:03:44 +00:00
Daniel P. Berrange
b756b005ec Replace use of qemudLog with logging.h APIs/macros 2009-03-03 11:40:08 +00:00
Jim Meyering
10e3148f0a avoid file descriptor leak when fd == 0 
* src/pci.c (pciGetDevice): Initialize dev->fd to -1, not 0.
(pciFreeDevice): Close fd also when it is 0.
 2009-03-03 11:25:52 +00:00
Jim Meyering
8343dcb893 don't leak a file descriptor on failed pciGetDevice call 
* src/pci.c (pciIterDevices): Always close dir handle.
 2009-03-03 11:25:35 +00:00
Daniel P. Berrange
41ed6eb327 SELinux security driver for sVirt support (James Morris, Dan Walsh & Daniel Berrange) 2009-03-03 10:06:49 +00:00
Daniel P. Berrange
aa2c97263d virsh additions for sVirt support (James Morris & Dan Walsh) 2009-03-03 09:59:02 +00:00
Daniel P. Berrange
8bd1604cb7 Core internal driver stub for sVirt support (Jams Morris & Dan Walsh) 2009-03-03 09:44:41 +00:00
Daniel P. Berrange
a8cd24b346 Remote protocol / RPC API for sVirt support (James Morris & Dan Walsh) 2009-03-03 09:27:02 +00:00
Daniel P. Berrange
8d13558ae6 Internal driver API for sVirt support (James Morris & Dan Walsh) 2009-03-03 09:14:28 +00:00
Daniel P. Berrange
0b7860ecdd Public API for sVirt support (James Morris & Dan Walsh) 2009-03-03 09:09:00 +00:00
Daniel P. Berrange
8f1912c58d Don't try to detach & reset PCI devices while running test suite for XML-> ARGV conversion. 2009-03-03 08:59:45 +00:00
Daniel P. Berrange
72652e9dbb Always reset PCI devices 2009-03-02 20:22:35 +00:00
Daniel P. Berrange
644b41a94d Export virUnrefConnect & virCapabilitiesGenerateMac to driver code 2009-03-02 20:19:13 +00:00
Jim Meyering
9883bec50d virsh: tweak a format string to avoid emitting trailing space 
* src/virsh.c (cmdNetworkList): Change format not to right-pad
with spaces, as that would have required a trailing blank in
an expected output file.
 2009-03-02 18:39:36 +00:00
Cole Robinson
aedf57db70 Fix bridge generation loop counter (spotted by Jim Meyering) 2009-03-02 17:56:50 +00:00
Cole Robinson
f9cbf065ad Recognize ejectable media in hostdev hal driver. 2009-03-02 17:41:13 +00:00
Cole Robinson
4837725f37 Better error reporting from qemu AttachDevice 2009-03-02 17:39:43 +00:00
Cole Robinson
1f11e3bb61 Generate network bridge names if none passed at define/create time. 2009-03-02 17:37:03 +00:00
Cole Robinson
adecc8fc9e Remove redundant monitor watch variable (s/monitor_watch/monitorWatch/) 2009-03-02 17:33:39 +00:00
Cole Robinson
895247b76b Mark 'defined' networks as persistent. 2009-03-02 17:29:44 +00:00
Daniel Veillard
09fb8845a7 adds a new <hostdev managed='(yes|no)'> property to host devices in domains 
* docs/schemas/domain.rng src/domain_conf.c src/domain_conf.h
  src/qemu_conf.c
  tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
  tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
  tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.xml:
  adds a new <hostdev managed='(yes|no)'> property
  to host devices indicating whether or not we should
  automatically dettach/reset, patch by Mark McLoughlin
daniel
 2009-03-02 16:40:30 +00:00
Daniel Veillard
34d23b0b01 * src/qemu_driver.c: add qemu dettach/reattach/reset implementation 
patch by Mark McLoughlin.
Daniel
 2009-03-02 16:32:52 +00:00
Daniel Veillard
0231102863 Implement node attach/reattach/reset in the remote driver 
* qemud/remote.c qemud/remote_dispatch_args.h
  qemud/remote_dispatch_prototypes.h qemud/remote_dispatch_table.h
  qemud/remote_protocol.c qemud/remote_protocol.h
  qemud/remote_protocol.x src/remote_internal.c: Implement
  attach/reattach/reset in the remote driver, patch by Mark
  McLoughlin.
Daniel
 2009-03-02 16:30:59 +00:00
Daniel Veillard
6427091ffe * src/virsh.c: add 3 new commands for node device detach, reattach and reset, 
patch by Mark McLoughlin.
Daniel
 2009-03-02 16:28:17 +00:00
Daniel Veillard
737af2ea04 Adds the APIs for virNodeDeviceDettach , ReAttach and Reset 
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in
  src/driver.h src/libvirt.c src/libvirt_public.syms
  src/lxc_driver.c src/openvz_driver.c src/qemu_driver.c
  src/test.c src/uml_driver.c: add the public APIs for
  virNodeDeviceDettach virNodeDeviceReAttach and virNodeDeviceReset
  and extends the driver structure accordingly.
Daniel
 2009-03-02 16:25:13 +00:00
Daniel Veillard
d217641314 implements dettach, reattach and reset for PCI devices 
* configure.in po/POTFILES.in src/Makefile.am src/libvirt_private.syms
  src/pci.c src/pci.h: Add implementations of dettach, reattach and
  reset for PCI devices, patch by Mark McLoughlin
Daniel
 2009-03-02 16:18:11 +00:00
Daniel Veillard
a3ce3b1c71 * qemud/qemud.c src/node_device_hal.c: activate DBus multithreading 
to avoid random crashes in the daemon, patch by Daniel Berrange
Daniel
 2009-03-02 11:13:37 +00:00
Jim Meyering
14dfe93965 correct a typo in a diagnostic 
* src/storage_conf.c (virStorageVolDefParsePerms): Correct a typo:
s/owner/group/.  Patch by Ryota Ozaki.
 2009-03-02 10:27:20 +00:00
Jim Meyering
0fe3340ed9 plug two config-parsing leaks 
* src/storage_conf.c (virStoragePoolDefParsePerms): Free mode string.
(virStorageVolDefParsePerms): Likewise.
* AUTHORS: Update.
Patch by Ryota Ozaki.
 2009-03-02 10:26:37 +00:00
Jim Meyering
07696eb347 don't dereference uninitialized pointer 
* src/storage_conf.c (virStoragePoolDefParsePerms): Initialize
"ptr" to NULL.
 2009-03-02 10:07:55 +00:00
Chris Lalancette
014bb5cf7e If there is a failure during Qemu offline migrate, make sure to resume the 
guest.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
 2009-02-27 16:18:50 +00:00
Daniel P. Berrange
2e187bcbca Add support for a exec callback in virExecWithHook 2009-02-26 16:27:51 +00:00
Daniel Veillard
372d5b3088 * src/remote_internal.c: fix autostart of session daemon, patch 
by Dan Berrange
Daniel
 2009-02-26 15:06:06 +00:00
Daniel Veillard
299aefebf2 * src/storage_backend_fs.c: fix compile-error when configured without qemu-img 
daniel
 2009-02-26 14:36:30 +00:00
Mark McLoughlin
c4c5e9dbbb Add virNodeDeviceDefParseString() 
Add support for parsing node device XML descriptions.

This will be used by PCI passthrough related functions to
obtain the PCI device address for a given node device.
 2009-02-24 14:55:45 +00:00
Mark McLoughlin
ee197521c5 Add virXPathULongLong() 
Add a variant of virXPathULong() which can handle long longs.

Needed for parsing storage device capacities.
 2009-02-24 14:54:30 +00:00
Mark McLoughlin
c56b4bcbf3 Add virXPathLongHex() and virXPathULongHex() 
Add new functions to allow parsing integers with base 16

This will be used to e.g. parse PCI vendor IDs.
 2009-02-24 14:53:30 +00:00
Mark McLoughlin
761f5a52dc networkEnableIpForwarding() now returns zero for success 2009-02-22 11:19:54 +00:00
Guido Günther
4cbe86fcb8 (s)size_t type cleanup 2009-02-19 08:18:31 +00:00
Cole Robinson
7e8ad2036a Remove the _actually_ incorrect ATTRIBUTE_UNUSED (Patch by Maximilian Wilhelm) 2009-02-18 01:37:47 +00:00
Cole Robinson
cf47347312 Remove incorrect ATTRIBUTE_UNUSED usage. 2009-02-17 14:38:22 +00:00
Jim Meyering
73619269ae Build fix for 'driver.c' when building with loadable modules 
The 'asprintf' -> 'virAsprintf' transition made in
[043d702f] "use virAsprintf instead of asprintf" introducted
a build error for 'driver.c' as 'util.h' has to be included.

Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
 2009-02-17 10:43:26 +00:00
Jim Meyering
64b72210ad Work around 'virGetVersion' build problem 
The 'getVer' fix introducted in d88d459d [Allow remote://hostname/
style URIs for automatic driver probe...] breaks compiling libvirt
with loadable module support.  Work around this to get it building again.

Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
 2009-02-17 10:33:41 +00:00
Jim Meyering
cedc15019e avoid compiler warning about unused parameter 
* src/bridge.c (brProbeVnetHdr)
[IFF_VNET_HDR && TUNGETFEATURES && TUNGETIFF]: Use a "(void)" case
to mark the parameter as unused.  Reported by Maximilian Wilhelm in
http://thread.gmane.org/gmane.comp.emulators.libvirt/11918/focus=11917
 2009-02-17 10:26:43 +00:00
Jim Meyering
bdd5094d8f accommodate configuring --without-lxc --without-qemu 
* configure.in: Enable internal WITH_BRIDGE support not just for LXC or
QEMU, but also for --with-network.  Russell Haering reported that
compilation failed when configured with --without-lxc --without-qemu.
Details: http://thread.gmane.org/gmane.comp.emulators.libvirt/11928
* src/bridge.h: Use #if WITH_BRIDGE, rather than currently-equivalent
"#if defined(WITH_QEMU) || defined(WITH_LXC)"
 2009-02-17 10:23:19 +00:00
Daniel P. Berrange
4dce547640 Fix I/O errors in libvirtd daemon, and hang/crash in remote client upon I/O error 2009-02-17 09:44:18 +00:00
Cole Robinson
3a53ab7913 Unbreak virsh *-edit commands: Don't pass unexpected flags to DumpXML 2009-02-16 22:51:31 +00:00
Cole Robinson
c482439232 Remove erroneous lvm volume format check for backing store. 2009-02-16 22:47:19 +00:00
Mark McLoughlin
0bb6f816e3 Add virFileWriteStr() 
Re-factor the code from networkEnableIpForwarding() into a
utility function in preparation for code which writes to
sysfs files.
 2009-02-13 19:13:06 +00:00
Mark McLoughlin
f6a5e8f785 Fix some error strings in xml.c 
Just some copy-and-paste mixups.
 2009-02-13 19:12:45 +00:00
Mark McLoughlin
c4602255c7 virXPathInt() and virXPathUInt() don't exist 
It looks like these functions have never existed.
 2009-02-13 19:12:20 +00:00
Mark McLoughlin
9fec27be49 Fix bridge.c warnings with gcc-4.4 
bridge.c: In function 'brSetInetAddr':
 bridge.c:665: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
 bridge.c:665: note: initialized from here
 bridge.c:666: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
 bridge.c:666: note: initialized from here

Fix qemud.c warnings with gcc-4.4

 qemud.c: In function ‘remoteListenTCP’:
 qemud.c:675: error: dereferencing pointer ‘sa.72’ does break strict-aliasing rules
 qemud.c:675: note: initialized from here
 qemud.c:678: error: dereferencing pointer ‘sa.73’ does break strict-aliasing rules
 qemud.c:678: note: initialized from here
 2009-02-13 19:10:55 +00:00
John Levon
7d2b7ad520 Fix migrate for Xen 3.3 2009-02-13 18:23:23 +00:00
Jim Meyering
f98b9e05d8 test:///default driver: don't dereference NULL "def" 
* src/test.c (testNetworkCreate, testNetworkDefine): Since "def" is
set to NULL immediately after any vir*AssignDef call (to indicate we
no longer own it and to ensure no clean-up path mistakenly frees it),
dereference via net->def->, not def->.
 2009-02-13 18:11:03 +00:00
Guido Günther
6efe591e66 usleep to wait for domain logfile to fill up 2009-02-13 11:35:16 +00:00
Guido Günther
e9c920ba67 fix return status when domain didn't show up 2009-02-11 20:33:11 +00:00
John Levon
f84c166013 Improve error reporting in virsh 2009-02-09 14:24:06 +00:00
John Levon
fa7f51b813 introduce virSaveLastError(), virFreeError() 2009-02-09 14:16:23 +00:00
Daniel P. Berrange
1290b28f59 Limit virsh history entries to 500 (Jim Paris) 2009-02-09 10:24:27 +00:00
Guido Günther
0437e75291 Don't ignore errors to save domain status 2009-02-07 21:36:06 +00:00
John Levon
31135bff29 src/domain_conf.c: Check the last error, not the last 
connection error, which may not have been set.
 2009-02-05 19:29:37 +00:00
John Levon
003f354917 xenstore: Use virMacAddrCompare() for case-insensitive comparison 2009-02-05 18:14:00 +00:00
John Levon
b8b4fd4c7d report error for some xend operations on shutdown domain 2009-02-05 17:24:51 +00:00
John Levon
bc68ae8060 robustify sexpr parser for NICs 2009-02-05 17:17:33 +00:00
Jim Meyering
bafd7389e4 remove remainder of offending strerror uses 
* qemud/qemud.c (GET_CONF_STR): Use virStrerror, not strerror.
* qemud/remote.c (remoteDispatchDomainBlockPeek): Likewise.
(remoteDispatchDomainMemoryPeek, remoteDispatchAuthSaslInit): Likewise.
(remoteDispatchAuthPolkit): Likewise.
* src/lxc_container.c (lxcContainerAvailable): Likewise.
* src/network_driver.c (networkStartNetworkDaemon): Likewise.
(networkShutdownNetworkDaemon): Likewise.
* src/qemu_conf.c (qemudExtractVersion, qemudNetworkIfaceConnect):
* src/storage_conf.c (virStoragePoolLoadAllConfigs): Likewise.
* src/storage_driver.c (storagePoolUndefine): Likewise.
* src/uml_driver.c (umlStartup, umlStartVMDaemon): Likewise.
* src/util.c (virFileReadAll): Likewise.
* src/uuid.c (virUUIDGenerate): Likewise.
* src/xen_internal.c (get_cpu_flags): Likewise.
 2009-02-05 16:28:30 +00:00
Jim Meyering
d22a844b46 don't include raw errno in diagnostics 
* src/uml_driver.c (umlStartVMDaemon): Don't print raw errno value.
* qemud/remote.c (remoteDispatchAuthSaslInit): Likewise.
 2009-02-05 16:28:15 +00:00
Jim Meyering
1e31bfb055 iptables.c: Use virStrerror, not strerror. 
* src/iptables.c: Include "virterror_internal.h".
Use virStrerror, not strerror.
* src/iptables.c (notifyRulesUpdated): Use %s rather than
string-concatenation that made sc_unmarked_diagnostics report
a false-positive.
 2009-02-05 16:27:51 +00:00
Jim Meyering
dcfa920aff use virReportOOMError rather than more verbose equivalent 
* src/qemu_driver.c (qemudDomainSave, qemudDomainRestore)
(qemudDomainAttachPciDiskDevice)
(qemudDomainAttachUsbMassstorageDevice):
 2009-02-05 16:27:40 +00:00
Jim Meyering
e60430be53 qemu_driver.c: s/strerror/virStrerror.../ 
Perform most changs automatically, with this:
perl -pi -e 's/\bstrerror *\((.+?)\)/virStrerror($1, ebuf, sizeof ebuf)/'
Then, declare ebuf, as needed
 2009-02-05 16:27:28 +00:00
Jim Meyering
b0d49913d5 remove duplicate *SetCloseExec and *SetNonBlock functions 
* src/qemu_driver.c: Use virSetCloseExec and virSetNonBlock,
rather than qemuSet* functions.  Suggested by Daniel P. Berrange.
* src/util.c (virSetCloseExec): Publicize.
* src/util.h (virSetCloseExec): Declare
* src/libvirt_private.syms: Add virSetCloseExec.
 2009-02-05 16:27:17 +00:00
Jim Meyering
caea9c00e3 qemu_driver.c: use virReportSystemError in place of some qemudLog uses 
...thus eliminating many uses of strerror.
(kvmGetMaxVCPUs): Rather than merely warning, diagnose an error
and return -1 upon failure to open KVM_DEVICE.  Suggested by
Daniel P. Berrange.
 2009-02-05 16:11:25 +00:00
Jim Meyering
7bc569dda9 publicize virStrerror 
* src/virterror.c (virStrerror): Remove "static".
* src/virterror_internal.h (virStrerror): Declare it.
* src/libvirt_private.syms: Add virStrerror;
 2009-02-05 16:10:07 +00:00
Jim Meyering
a9aa76bad5 remove useless code 
* src/bridge.c (brAddTap): Remove redundant errno=ENOMEM assignment
after failed strdup.
* src/cgroup.c (virCgroupFree): Remove redundant *group=NULL assignment
after VIR_FREE(*group).
* src/lxc_driver.c (lxcShutdown): Likewise.
* src/xen_unified.c (xenUnifiedClose): Likewise.
* src/xm_internal.c (xenXMDomainConfigFormat): Rewrite disk-
and net-config-setting code to be clearer.
 2009-02-05 16:03:11 +00:00
Jim Meyering
7faa50d1db lxc_container: Don't dereference NULL upon failure 
* src/lxc_container.c (lxcContainerPivotRoot): Free and zero
oldroot *after* printing the diagnostic, both for virFileMakePath
and pivot_root failure.
 2009-02-05 15:28:19 +00:00
Jim Meyering
6778ad0f07 avoid a format-related warning 
* src/qemu_driver.c (qemudStartVMDaemon): Use "%s".
 2009-02-03 13:09:18 +00:00
Jim Meyering
dff2114795 build: enable redundant-const check 
* Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const.
* src/lxc_controller.c: Remove redundant "const"(s).
* src/storage_backend_fs.c: Likewise.
* src/util.h: Likewise.
* src/xen_internal.c: Likewise.
* tests/qparamtest.c: Likewise.
 2009-02-03 13:08:59 +00:00
Jim Meyering
c18ccff446 cleanup: remove useless if-before-VIR_FREE 
* Makefile.cfg (useless_free_options): Also check for VIR_FREE.
* src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE.
* src/remote_internal.c (remoteAuthSASL): Likewise.
* src/test.c (testOpenFromFile): Likewise.
 2009-02-03 13:08:07 +00:00
John Levon
66929686c4 fix more printf("%s", NULL) cases 2009-02-02 18:41:56 +00:00
Guido Günther
e69b20d616 Don't hardcode ssh port 22, use VIR_FREE, initialize pointers to NULL not 0. 2009-01-31 13:49:11 +00:00
Daniel P. Berrange
f92e9f599b Fix empty declaration in enum declaration 2009-01-30 21:52:22 +00:00
Jim Meyering
a119a98081 fix qemud version reporting when qemu is not installed 
* src/qemu_conf.c (uname_normalize): New function, factored out of...
(qemudBuildCommandLine): ...here.  Use the new function.
(qemudExtractVersion): Use it here, rather than hard-coding "i686".
 2009-01-30 19:57:20 +00:00