Jim Meyering
6997b1920f
src/libvirt.c (do_open): Avoid double-free upon failure.
2008-01-30 19:53:10 +00:00
Jim Meyering
218f866f86
Avoid segfault upon malloc failure, and plug a leak.
...
* src/test.c (testDomainSave): Detect testDomainDumpXML failure. Free "xml".
2008-01-30 19:52:16 +00:00
Jim Meyering
5561e9125f
Plug test-related leaks.
...
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
2008-01-30 19:50:14 +00:00
Daniel P. Berrange
17ef6faa7f
Remove double mutex lock()
2008-01-30 18:21:13 +00:00
Daniel P. Berrange
03003499e7
Fix XML generation for Xen USB devices
2008-01-30 16:38:18 +00:00
Jim Meyering
51dd1d9e38
Arrange for "make syntax-check" to pass.
...
* .x-sc_avoid_if_before_free: Exempt ChangeLog.
* tests/statstest.c: Include <config.h>, not "config.h".
2008-01-30 06:55:56 +00:00
Daniel P. Berrange
21416a4746
Fix device name -> number conversion for block stats
2008-01-29 18:36:00 +00:00
Jim Meyering
2367caa327
Also detect and remove unnecessary if-before-xmlXPathFreeContext.
...
* build-aux/find-unnecessary-if-before-free: Update regexp.
* src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
* src/qemu_conf.c: Likewise.
* src/virsh.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/xmlrpctest.c: Likewise.
2008-01-29 18:23:43 +00:00
Jim Meyering
1be2c8c814
Enable two more tests.
...
* Makefile.cfg (local-checks-to-skip)
[sc_cast_of_x_alloc_return_value, sc_cast_of_argument_to_free]: Enable.
2008-01-29 18:21:00 +00:00
Jim Meyering
2c72562374
Enable the <assert.h>-checking test; fix violations.
...
* Makefile.cfg (local-checks-to-skip)
[sc_prohibit_assert_without_use]: Enable.
* qemud/mdns.c: Don't include <assert.h>; no uses of assert here.
* qemud/qemud.c: Likewise.
* qemud/remote.c: Likewise.
2008-01-29 18:20:25 +00:00
Jim Meyering
05ae9d8bc4
Enable the po-check test; fix violations.
...
* Makefile.cfg (local-checks-to-skip) [po-check]: Enable.
* po/POTFILES.in: Add three file names. Sort.
2008-01-29 18:19:46 +00:00
Jim Meyering
bc48db5758
Update from gnulib
...
* lib/poll.c: Update.
* lib/string.in.h: Update.
* m4/string_h.m4: Update.
* tests/test-getaddrinfo.c: Update.
* lib/Makefile.am: Regenerate.
2008-01-29 18:17:47 +00:00
Jim Meyering
a378188194
Enable the <config.h>-requiring test; fix violations
...
Use <config.h>, not "config.h", per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
2008-01-29 18:15:54 +00:00
Jim Meyering
9e4c8fcb3a
Enable the duplicate-"the" test; fix violations
...
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
* docs/virsh.pod: Remove a duplicate "the".
* libvirt.spec.in: Likewise.
* virsh.1: Likewise.
2008-01-29 17:43:28 +00:00
Jim Meyering
cc337da21f
Add framework for code style- and syntax-checking rules.
...
Almost all tests are initially disabled via the list in Makefile.cfg.
* Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
Omit names of files that automake includes automatically.
* .x-sc_avoid_if_before_free: New file.
* build-aux/vc-list-files: Likewise.
* build-aux/find-unnecessary-if-before-free: Likewise.
* GNUmakefile, Makefile.cfg, Makefile.maint: New files.
2008-01-29 17:42:39 +00:00
Jim Meyering
acff2d11ac
Given code like if (foo) free (foo); remove the useless "if (foo) " part.
...
Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
* proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
* python/generator.py: Likewise.
* qemud/qemud.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/libvirt.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* src/test.c: Likewise.
* src/virsh.c: Likewise.
* src/virterror.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xend_internal.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/testutils.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
2008-01-29 17:41:07 +00:00
Richard W.M. Jones
b17caa80d1
Clarify virsh documentation.
...
* docs/virsh.pod: Clarify virsh documentation on when you can
set memory and vCPUs.
2008-01-25 12:03:05 +00:00
Daniel Veillard
aab826d4cc
Fix VIR_DOMAIN_NONE into VIR_DOMAIN_NOSTATE
...
* src/xen_internal.c: fix an erronous use of VIR_DOMAIN_NONE instead
of VIR_DOMAIN_NOSTATE (both defined as 0, no regression)
Daniel
2008-01-25 09:47:51 +00:00
Daniel Veillard
3f9a94bec3
* src/libvirt.c: Jay Gagnon pointed out that virDomainGetXMLDesc
...
was failing with a non-zero flag value
Daniel
2008-01-24 17:09:56 +00:00
Richard W.M. Jones
7db9140126
Correct typos in the documentation (Atsushi SAKAI)
...
* README, libvirt.spec.in, docs/devhelp/html.xsl,
docs/devhelp/index.html: Correct typos in the documentation.
2008-01-24 10:15:13 +00:00
Daniel P. Berrange
38b2478b41
Fix enablement of SASL
2008-01-23 19:37:10 +00:00
Richard W.M. Jones
9cf2573c8a
Portability improvements for Mac OS X.
...
* configure.in: Use PortableXDR if available.
* qemud/internal.h: Use "socketcompat.h".
* qemud/qemud.c: Use <signal.h>.
* src/sexpr.c: Use <stdlib.h> instead of <malloc.h>.
* src/socketcompat.h: Include <sys/un.h> for Mac OS X.
2008-01-23 14:54:41 +00:00
Richard W.M. Jones
569200b6d4
Remove DOS line-endings.
...
* src/socketcompat.h: Remove DOS line-endings in this file.
2008-01-23 14:50:14 +00:00
Daniel P. Berrange
9d7661e415
Fix compat for old pkg-config and gnutls
2008-01-22 21:30:05 +00:00
Jim Meyering
63dffbf1d2
Avoid "may be used uninitialized" warning.
...
* tests/xmconfigtest.c (testCompareParseXML): Initialize "old_priv".
2008-01-21 17:06:47 +00:00
Daniel P. Berrange
97bed42f7a
Fix & refactor ref counting cleanup code
2008-01-21 16:29:10 +00:00
Daniel P. Berrange
c9b7eae903
Make python generator fail build on any missing APIs
2008-01-21 15:55:53 +00:00
Daniel P. Berrange
62094f72f6
Add missing vcpu/schedular APIs to python binding
2008-01-21 15:41:15 +00:00
Daniel P. Berrange
45738083a6
Use virFileReadAll in virsh.c
2008-01-21 15:27:14 +00:00
Daniel P. Berrange
53365f4c54
Remove no-op networking APIs from openvz driver
2008-01-21 15:19:46 +00:00
Jim Meyering
64b3019d69
Adjust sexpr-related interfaces to be const-correct.
...
* src/sexpr.c (sexpr_cons, append, sexpr_append, sexpr2string)
(sexpr_lookup_key, sexpr_lookup, sexpr_node, sexpr_fmt_node):
Add "const" attribute where appropriate.
* src/xend_internal.c (sexpr_int, sexpr_float, sexpr_u64)
(sexpr_uuid, sexpr_to_xend_domain_info, sexpr_to_xend_node_info)
(sexpr_to_xend_topology_xml, sexpr_to_domain): Likewise.
* src/sexpr.h: Adjust prototypes.
2008-01-21 14:22:15 +00:00
Jim Meyering
a430f22be4
Don't access line[-1] for a zero-length "line" from fgets.
...
A NUL byte at beginning of input, or just after a newline
would provoke an invalid buf[-1] access (possible segfault).
* src/libvirt.c (virConnectAuthCallbackDefault):
2008-01-21 14:09:51 +00:00
Daniel Veillard
5912e7c233
Preserve vif order
...
* src/xml-internal.c: apply patch from Hiroyuki Kaguchi to
preserve the vif list order.
Daniel
2008-01-21 08:27:12 +00:00
Daniel Veillard
d3043afe5c
Remove docs/API*.html
...
* docs/API* docs/api.xsl docs/site.xsl docs/Makefile.am: remove the
generation of the API*.html files as it's not really useful here
Daniel
2008-01-21 08:08:33 +00:00
Daniel P. Berrange
d56aff5255
Added xstrtol_ll and xstrtol_ull convenience functions
2008-01-20 16:11:25 +00:00
Daniel P. Berrange
e05a879022
Fix nodeinfo compat for Xen 3.2.0
2008-01-20 15:56:49 +00:00
Daniel P. Berrange
e8d690aeb5
Enable debug by default, but only if LIBVIRT_DEBUG=1. Use generic macro for debug output
2008-01-19 18:36:01 +00:00
Jim Meyering
df7bf130ae
docs/examples/examples.xml: Regenerate, now that *.c file names are sorted.
2008-01-15 15:27:31 +00:00
Daniel P. Berrange
f6ba6e9eb7
Support VNC keymap option with QEMU (Daniel Hokka Zakrisson)
2008-01-15 15:18:33 +00:00
Daniel P. Berrange
045d32a8e8
Fix off-by-one in SSH argv checking. Fix format string warning
2008-01-15 14:23:52 +00:00
Jim Meyering
32d4aeb162
Update from gnulib.
2008-01-14 14:07:25 +00:00
Jim Meyering
2edab512a0
Clean up the global name space.
...
* src/qemu_conf.c: Add "static" and "const" attributes to some globals.
* src/qemu_conf.h: Update a declaration.
* src/qemu_driver.c (qemud_driver): Declare static.
Author: Jim Meyering <meyering@redhat.com>
2008-01-14 14:05:25 +00:00
Jim Meyering
f510a6128b
Clean up global name space in examples and tests.
...
* docs/examples/suspend.c: Declare global "conn" to be static.
* tests/qemuxml2argvtest.c: Declare global "driver" to be static.
* tests/qemuxml2xmltest.c: Likewise.
Author: Jim Meyering <meyering@redhat.com>
2008-01-14 14:04:33 +00:00
Daniel P. Berrange
6aae9a9efb
Re-factor auth code to make clearer (Jim Meyering)
2008-01-14 04:05:23 +00:00
Daniel P. Berrange
b2083ea907
Fix crash when no auth callback
2008-01-14 04:00:34 +00:00
Mark McLoughlin
4c50142381
fix an unused variable warning
2008-01-10 14:41:39 +00:00
Mark McLoughlin
73ab4e0845
add iptablesSaveRules(), and don't save the rules to disk
...
and run lokkit each time a new rule is added.
2008-01-10 14:01:00 +00:00
Mark McLoughlin
2d2e410818
now that we only use built-in iptables chains, we don't
...
need to add or delete them
2008-01-10 13:58:59 +00:00
Mark McLoughlin
9b29b2a2a5
Like --with-iptables-prefix, --with-iptables-dir is no
...
longer useful, so let's remove it.
2008-01-10 13:57:48 +00:00
Mark McLoughlin
f8e0674ad5
--with-iptables-prefix was added to integrate with
...
a proposed system for letting iptables know how to
reload our rules. The proposed system wasn't accepted
so, although there might be some other theoretical
use for this, let's just remove it.
2008-01-10 13:56:22 +00:00