Jim Meyering
260082321c
update .gitignore and .hgignore files
2009-03-03 11:25:00 +00:00
Daniel P. Berrange
41ed6eb327
SELinux security driver for sVirt support (James Morris, Dan Walsh & Daniel Berrange)
2009-03-03 10:06:49 +00:00
Daniel P. Berrange
aa2c97263d
virsh additions for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:59:02 +00:00
Daniel P. Berrange
8bd1604cb7
Core internal driver stub for sVirt support (Jams Morris & Dan Walsh)
2009-03-03 09:44:41 +00:00
Daniel P. Berrange
a8cd24b346
Remote protocol / RPC API for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:27:02 +00:00
Daniel P. Berrange
8d13558ae6
Internal driver API for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:14:28 +00:00
Daniel P. Berrange
0b7860ecdd
Public API for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:09:00 +00:00
Daniel P. Berrange
8f1912c58d
Don't try to detach & reset PCI devices while running test suite for XML-> ARGV conversion.
2009-03-03 08:59:45 +00:00
Daniel Veillard
1ca2bd7912
* qemud/qemud.c: fix qemu+tls handshake negotiation, patch by
...
Chris Lalancette
Daniel
2009-03-03 08:25:50 +00:00
Daniel P. Berrange
1d1748b63e
Ignore some generated autotools files in example app
2009-03-02 20:24:46 +00:00
Daniel P. Berrange
72652e9dbb
Always reset PCI devices
2009-03-02 20:22:35 +00:00
Daniel P. Berrange
644b41a94d
Export virUnrefConnect & virCapabilitiesGenerateMac to driver code
2009-03-02 20:19:13 +00:00
Jim Meyering
0c85c384fa
tests: further isolate a test that runs libvirtd
...
* tests/daemon-conf: Specify a non-default socket directory.
Specify test-specific log directory and pid file, too.
2009-03-02 20:01:26 +00:00
Jim Meyering
d15549aee0
add two tests
...
* tests/libvirtd-pool: New file.
Exercise the new unix_sock_dir option
* tests/libvirtd-fail: New file.
* tests/Makefile.am (test_scripts): Add libvirtd-fail and libvirtd-pool.
2009-03-02 20:01:05 +00:00
Jim Meyering
0bfa7cbb29
tests: fix an error that made us skip the daemon-conf test
...
* tests/Makefile.am (CONFIG_HEADER): Correct definition.
2009-03-02 19:03:49 +00:00
Jim Meyering
7fad73685e
tests: test for a recent fix
...
* tests/libvirtd-net-persist: New file. Test for today's
"Mark 'defined' networks as persistent" fix.
* tests/Makefile.am (test_scripts): Add it.
2009-03-02 18:41:00 +00:00
Jim Meyering
9883bec50d
virsh: tweak a format string to avoid emitting trailing space
...
* src/virsh.c (cmdNetworkList): Change format not to right-pad
with spaces, as that would have required a trailing blank in
an expected output file.
2009-03-02 18:39:36 +00:00
Cole Robinson
aedf57db70
Fix bridge generation loop counter (spotted by Jim Meyering)
2009-03-02 17:56:50 +00:00
Cole Robinson
4837725f37
Better error reporting from qemu AttachDevice
2009-03-02 17:39:43 +00:00
Cole Robinson
1f11e3bb61
Generate network bridge names if none passed at define/create time.
2009-03-02 17:37:03 +00:00
Cole Robinson
adecc8fc9e
Remove redundant monitor watch variable (s/monitor_watch/monitorWatch/)
2009-03-02 17:33:39 +00:00
Cole Robinson
895247b76b
Mark 'defined' networks as persistent.
2009-03-02 17:29:44 +00:00
Daniel Veillard
09fb8845a7
adds a new <hostdev managed='(yes|no)'> property to host devices in domains
...
* docs/schemas/domain.rng src/domain_conf.c src/domain_conf.h
src/qemu_conf.c
tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.xml:
adds a new <hostdev managed='(yes|no)'> property
to host devices indicating whether or not we should
automatically dettach/reset, patch by Mark McLoughlin
daniel
2009-03-02 16:40:30 +00:00
Daniel Veillard
34d23b0b01
* src/qemu_driver.c: add qemu dettach/reattach/reset implementation
...
patch by Mark McLoughlin.
Daniel
2009-03-02 16:32:52 +00:00
Daniel Veillard
0231102863
Implement node attach/reattach/reset in the remote driver
...
* qemud/remote.c qemud/remote_dispatch_args.h
qemud/remote_dispatch_prototypes.h qemud/remote_dispatch_table.h
qemud/remote_protocol.c qemud/remote_protocol.h
qemud/remote_protocol.x src/remote_internal.c: Implement
attach/reattach/reset in the remote driver, patch by Mark
McLoughlin.
Daniel
2009-03-02 16:30:59 +00:00
Daniel Veillard
6427091ffe
* src/virsh.c: add 3 new commands for node device detach, reattach and reset,
...
patch by Mark McLoughlin.
Daniel
2009-03-02 16:28:17 +00:00
Daniel Veillard
737af2ea04
Adds the APIs for virNodeDeviceDettach , ReAttach and Reset
...
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in
src/driver.h src/libvirt.c src/libvirt_public.syms
src/lxc_driver.c src/openvz_driver.c src/qemu_driver.c
src/test.c src/uml_driver.c: add the public APIs for
virNodeDeviceDettach virNodeDeviceReAttach and virNodeDeviceReset
and extends the driver structure accordingly.
Daniel
2009-03-02 16:25:13 +00:00
Daniel Veillard
d217641314
implements dettach, reattach and reset for PCI devices
...
* configure.in po/POTFILES.in src/Makefile.am src/libvirt_private.syms
src/pci.c src/pci.h: Add implementations of dettach, reattach and
reset for PCI devices, patch by Mark McLoughlin
Daniel
2009-03-02 16:18:11 +00:00
Daniel Veillard
a3ce3b1c71
* qemud/qemud.c src/node_device_hal.c: activate DBus multithreading
...
to avoid random crashes in the daemon, patch by Daniel Berrange
Daniel
2009-03-02 11:13:37 +00:00
Jim Meyering
14dfe93965
correct a typo in a diagnostic
...
* src/storage_conf.c (virStorageVolDefParsePerms): Correct a typo:
s/owner/group/. Patch by Ryota Ozaki.
2009-03-02 10:27:20 +00:00
Jim Meyering
0fe3340ed9
plug two config-parsing leaks
...
* src/storage_conf.c (virStoragePoolDefParsePerms): Free mode string.
(virStorageVolDefParsePerms): Likewise.
* AUTHORS: Update.
Patch by Ryota Ozaki.
2009-03-02 10:26:37 +00:00
Jim Meyering
07696eb347
don't dereference uninitialized pointer
...
* src/storage_conf.c (virStoragePoolDefParsePerms): Initialize
"ptr" to NULL.
2009-03-02 10:07:55 +00:00
Chris Lalancette
014bb5cf7e
If there is a failure during Qemu offline migrate, make sure to resume the
...
guest.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2009-02-27 16:18:50 +00:00
Daniel Veillard
9bceeca83c
* docs/libvirt-api.xml docs/libvirt-refs.xml
...
docs/devhelp/libvirt-virterror.html docs/html/libvirt-virterror.html:
regenerated the APIs and documentation.
* po/*: updated the polish translation, regenerated.
daniel
2009-02-27 14:30:51 +00:00
Daniel P. Berrange
2e187bcbca
Add support for a exec callback in virExecWithHook
2009-02-26 16:27:51 +00:00
Daniel Veillard
66780313c2
New example program
...
* Makefile.am configure.in examples/hellolibvirt/Makefile.am
examples/hellolibvirt/hellolibvirt.c: new trivial example program
by David Allan
Daniel
2009-02-26 16:14:50 +00:00
Daniel Veillard
372d5b3088
* src/remote_internal.c: fix autostart of session daemon, patch
...
by Dan Berrange
Daniel
2009-02-26 15:06:06 +00:00
Daniel Veillard
299aefebf2
* src/storage_backend_fs.c: fix compile-error when configured without qemu-img
...
daniel
2009-02-26 14:36:30 +00:00
Daniel Veillard
a7868e0131
* python/Makefile.am: avoid a parallel make issue #472702
...
provided by Michael Marineau
Daniel
2009-02-26 13:58:35 +00:00
Daniel Veillard
44811e8a2a
documenting static host IP assignments
...
* docs/formatnetwork.html docs/formatnetwork.html.in: patch from
Charles Duffy documenting static host IP assignments.
daniel
2009-02-25 20:02:14 +00:00
Mark McLoughlin
da61daa2e6
Add nodedevxml2xml test
...
Add a test to check node device XML parsing by first parsing
the XML, then re-formatting as XML and finally comparing the
resulting XML to the original XML.
2009-02-24 14:58:32 +00:00
Mark McLoughlin
c4c5e9dbbb
Add virNodeDeviceDefParseString()
...
Add support for parsing node device XML descriptions.
This will be used by PCI passthrough related functions to
obtain the PCI device address for a given node device.
2009-02-24 14:55:45 +00:00
Mark McLoughlin
ee197521c5
Add virXPathULongLong()
...
Add a variant of virXPathULong() which can handle long longs.
Needed for parsing storage device capacities.
2009-02-24 14:54:30 +00:00
Mark McLoughlin
c56b4bcbf3
Add virXPathLongHex() and virXPathULongHex()
...
Add new functions to allow parsing integers with base 16
This will be used to e.g. parse PCI vendor IDs.
2009-02-24 14:53:30 +00:00
Mark McLoughlin
14480f699d
Fix a typo in hostdev docs
...
It's:
<address bus='0x06' slot='0x02' function='0x0'/>
not:
<address>bus='0x06' slot='0x02' function='0x0'</address>
2009-02-24 14:52:33 +00:00
Mark McLoughlin
761f5a52dc
networkEnableIpForwarding() now returns zero for success
2009-02-22 11:19:54 +00:00
Mark McLoughlin
6a4da4657b
docs: commit auto-generated change
...
Commit auto-generated change as a result of earlier s/clock sync/clock offset/
2009-02-22 11:17:38 +00:00
Guido Günther
4cbe86fcb8
(s)size_t type cleanup
2009-02-19 08:18:31 +00:00
Cole Robinson
7e8ad2036a
Remove the _actually_ incorrect ATTRIBUTE_UNUSED (Patch by Maximilian Wilhelm)
2009-02-18 01:37:47 +00:00
Jim Meyering
f1b4ca52ff
fix build failure due to invalid generated Makefile
...
* qemud/Makefile.am (libvirtd_LDADD): Unindent "if HAVE_*" directives.
Reported by Daniel Schwager.
2009-02-17 14:46:21 +00:00
Cole Robinson
125980cb76
Fix daemon TCP listen cleanup
2009-02-17 14:40:24 +00:00
Cole Robinson
cf47347312
Remove incorrect ATTRIBUTE_UNUSED usage.
2009-02-17 14:38:22 +00:00
Jim Meyering
73619269ae
Build fix for 'driver.c' when building with loadable modules
...
The 'asprintf' -> 'virAsprintf' transition made in
[043d702f
] "use virAsprintf instead of asprintf" introducted
a build error for 'driver.c' as 'util.h' has to be included.
Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
2009-02-17 10:43:26 +00:00
Jim Meyering
81ba67b2b6
Avoid link failure when configured --with-driver-modules
...
* qemud/Makefile.am (WITH_DRIVER_MODULES): Link with libvirt_driver.la
and libvirt_util.la. Indent for readability.
2009-02-17 10:34:30 +00:00
Jim Meyering
64b72210ad
Work around 'virGetVersion' build problem
...
The 'getVer' fix introducted in d88d459d
[Allow remote://hostname/
style URIs for automatic driver probe...] breaks compiling libvirt
with loadable module support. Work around this to get it building again.
Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
2009-02-17 10:33:41 +00:00
Jim Meyering
cedc15019e
avoid compiler warning about unused parameter
...
* src/bridge.c (brProbeVnetHdr)
[IFF_VNET_HDR && TUNGETFEATURES && TUNGETIFF]: Use a "(void)" case
to mark the parameter as unused. Reported by Maximilian Wilhelm in
http://thread.gmane.org/gmane.comp.emulators.libvirt/11918/focus=11917
2009-02-17 10:26:43 +00:00
Jim Meyering
6b4b4eb29c
don't fail daemon-conf test when configured --without-qemu
...
* tests/Makefile.am (TESTS_ENVIRONMENT): Define CONFIG_HEADER.
* tests/daemon-conf: Use test-lib.sh.
Skip this test when configured --without-qemu.
2009-02-17 10:23:48 +00:00
Jim Meyering
bdd5094d8f
accommodate configuring --without-lxc --without-qemu
...
* configure.in: Enable internal WITH_BRIDGE support not just for LXC or
QEMU, but also for --with-network. Russell Haering reported that
compilation failed when configured with --without-lxc --without-qemu.
Details: http://thread.gmane.org/gmane.comp.emulators.libvirt/11928
* src/bridge.h: Use #if WITH_BRIDGE, rather than currently-equivalent
"#if defined(WITH_QEMU) || defined(WITH_LXC)"
2009-02-17 10:23:19 +00:00
Jim Meyering
a16ee2c83b
doc: fix typo in formatdomain's clock offset specification
...
* docs/formatdomain.html.in: s/clock sync/clock offset/
Patch by Jesse Lauren Farinacci <jieryn@gmail.com>.
2009-02-17 10:19:40 +00:00
Daniel P. Berrange
4dce547640
Fix I/O errors in libvirtd daemon, and hang/crash in remote client upon I/O error
2009-02-17 09:44:18 +00:00
Cole Robinson
3a53ab7913
Unbreak virsh *-edit commands: Don't pass unexpected flags to DumpXML
2009-02-16 22:51:31 +00:00
Cole Robinson
c482439232
Remove erroneous lvm volume format check for backing store.
2009-02-16 22:47:19 +00:00
Cole Robinson
a3d1fb9cf3
Fix building python bindings: Skip bindings for virSaveLastError and
...
virFreeError
2009-02-16 22:44:49 +00:00
Mark McLoughlin
0bb6f816e3
Add virFileWriteStr()
...
Re-factor the code from networkEnableIpForwarding() into a
utility function in preparation for code which writes to
sysfs files.
2009-02-13 19:13:06 +00:00
Mark McLoughlin
f6a5e8f785
Fix some error strings in xml.c
...
Just some copy-and-paste mixups.
2009-02-13 19:12:45 +00:00
Mark McLoughlin
c4602255c7
virXPathInt() and virXPathUInt() don't exist
...
It looks like these functions have never existed.
2009-02-13 19:12:20 +00:00
Mark McLoughlin
62e45f57b4
Fix bugzilla link in virsh man page
...
Note, I haven't generated a new virsh.1 because Pod::Man 2.16
gives a bunch of warnings even with the existing version.
2009-02-13 19:11:59 +00:00
Mark McLoughlin
6d69d5eac3
Fix libvirt_proxy.c warnings from gcc-4.4
...
libvirt_proxy.c: In function 'proxyReadClientSocket':
libvirt_proxy.c:659: error: dereferencing pointer 'req' does break strict-aliasing rules
libvirt_proxy.c:657: error: dereferencing pointer 'req' does break strict-aliasing rules
libvirt_proxy.c:655: error: dereferencing pointer 'req' does break strict-aliasing rules
...
2009-02-13 19:11:37 +00:00
Mark McLoughlin
9fec27be49
Fix bridge.c warnings with gcc-4.4
...
bridge.c: In function 'brSetInetAddr':
bridge.c:665: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
bridge.c:665: note: initialized from here
bridge.c:666: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
bridge.c:666: note: initialized from here
Fix qemud.c warnings with gcc-4.4
qemud.c: In function ‘remoteListenTCP’:
qemud.c:675: error: dereferencing pointer ‘sa.72’ does break strict-aliasing rules
qemud.c:675: note: initialized from here
qemud.c:678: error: dereferencing pointer ‘sa.73’ does break strict-aliasing rules
qemud.c:678: note: initialized from here
2009-02-13 19:10:55 +00:00
John Levon
7d2b7ad520
Fix migrate for Xen 3.3
2009-02-13 18:23:23 +00:00
Jim Meyering
f98b9e05d8
test:///default driver: don't dereference NULL "def"
...
* src/test.c (testNetworkCreate, testNetworkDefine): Since "def" is
set to NULL immediately after any vir*AssignDef call (to indicate we
no longer own it and to ensure no clean-up path mistakenly frees it),
dereference via net->def->, not def->.
2009-02-13 18:11:03 +00:00
Guido Günther
6efe591e66
usleep to wait for domain logfile to fill up
2009-02-13 11:35:16 +00:00
Guido Günther
e9c920ba67
fix return status when domain didn't show up
2009-02-11 20:33:11 +00:00
Jim Meyering
98352a103b
libvirtd: new config-file option: unix_sock_dir
...
Before this change, the unix socket directory was hard-coded
to be e.g., /var/run/libvirt for euid==0 and ~/.libvirt otherwise.
With this change, you may now specify that directory in libvirtd's
config file via a line like this: unix_sock_dir = "/var/run/libvirt".
This is essential for running tests that do not impinge on any
existing libvirtd process, and in running tests in parallel.
* qemud/libvirtd.conf (unix_sock_dir): Add comment and example.
* qemud/qemud.h (struct qemud_server) [logDir]: Change type
from char[PATH_MAX] to char*.
* qemud/qemud.c (unix_sock_dir): New global
(remoteReadConfigFile): Set the global.
(qemudInitPaths): Use the global, unix_sock_dir, if non-NULL.
One minor improvement: unlink both sockets or none, never
just one of them.
(qemudCleanup): Free logDir.
(main): Use the new global rather than hard-coding "/run/libvirt".
* qemud/libvirtd.aug (sock_acl_entry): Add "unix_sock_dir".
2009-02-09 17:52:38 +00:00
Jim Meyering
3557096d44
don't print uninitialized in debug diagnostic
...
* qemud/mdns.c (libvirtd_mdns_timeout_new): Don't use local, t,
uninitialized.
2009-02-09 15:38:06 +00:00
Jim Meyering
b92d7e761c
avoid two test failures induced by today's error-reporting changes
...
* tests/cpuset: Adjust expected diagnostic to match new behavior.
* tests/undefine: Likewise.
2009-02-09 15:31:34 +00:00
John Levon
f84c166013
Improve error reporting in virsh
2009-02-09 14:24:06 +00:00
John Levon
fa7f51b813
introduce virSaveLastError(), virFreeError()
2009-02-09 14:16:23 +00:00
Daniel P. Berrange
1290b28f59
Limit virsh history entries to 500 (Jim Paris)
2009-02-09 10:24:27 +00:00
Guido Günther
0437e75291
Don't ignore errors to save domain status
2009-02-07 21:36:06 +00:00
Daniel P. Berrange
9a86716446
Fix 100% libvirt CPU usage when --timeout is set
2009-02-06 14:43:52 +00:00
John Levon
31135bff29
src/domain_conf.c: Check the last error, not the last
...
connection error, which may not have been set.
2009-02-05 19:29:37 +00:00
John Levon
003f354917
xenstore: Use virMacAddrCompare() for case-insensitive comparison
2009-02-05 18:14:00 +00:00
John Levon
b8b4fd4c7d
report error for some xend operations on shutdown domain
2009-02-05 17:24:51 +00:00
John Levon
bc68ae8060
robustify sexpr parser for NICs
2009-02-05 17:17:33 +00:00
Jim Meyering
3909c7d3ed
syntax-check: enable prohibit_nonreentrant
...
* .x-sc_prohibit_nonreentrant: Add src/console.c and virterror.c.
* Makefile.cfg (local-checks-to-skip): Don't exempt
sc_prohibit_nonreentrant.
* Makefile.nonreentrant: Don't exempt strerror.
2009-02-05 16:28:41 +00:00
Jim Meyering
bafd7389e4
remove remainder of offending strerror uses
...
* qemud/qemud.c (GET_CONF_STR): Use virStrerror, not strerror.
* qemud/remote.c (remoteDispatchDomainBlockPeek): Likewise.
(remoteDispatchDomainMemoryPeek, remoteDispatchAuthSaslInit): Likewise.
(remoteDispatchAuthPolkit): Likewise.
* src/lxc_container.c (lxcContainerAvailable): Likewise.
* src/network_driver.c (networkStartNetworkDaemon): Likewise.
(networkShutdownNetworkDaemon): Likewise.
* src/qemu_conf.c (qemudExtractVersion, qemudNetworkIfaceConnect):
* src/storage_conf.c (virStoragePoolLoadAllConfigs): Likewise.
* src/storage_driver.c (storagePoolUndefine): Likewise.
* src/uml_driver.c (umlStartup, umlStartVMDaemon): Likewise.
* src/util.c (virFileReadAll): Likewise.
* src/uuid.c (virUUIDGenerate): Likewise.
* src/xen_internal.c (get_cpu_flags): Likewise.
2009-02-05 16:28:30 +00:00
Jim Meyering
d22a844b46
don't include raw errno in diagnostics
...
* src/uml_driver.c (umlStartVMDaemon): Don't print raw errno value.
* qemud/remote.c (remoteDispatchAuthSaslInit): Likewise.
2009-02-05 16:28:15 +00:00
Jim Meyering
d2758fa13e
qemud.c: use virStrerror, not strerror
2009-02-05 16:28:03 +00:00
Jim Meyering
1e31bfb055
iptables.c: Use virStrerror, not strerror.
...
* src/iptables.c: Include "virterror_internal.h".
Use virStrerror, not strerror.
* src/iptables.c (notifyRulesUpdated): Use %s rather than
string-concatenation that made sc_unmarked_diagnostics report
a false-positive.
2009-02-05 16:27:51 +00:00
Jim Meyering
dcfa920aff
use virReportOOMError rather than more verbose equivalent
...
* src/qemu_driver.c (qemudDomainSave, qemudDomainRestore)
(qemudDomainAttachPciDiskDevice)
(qemudDomainAttachUsbMassstorageDevice):
2009-02-05 16:27:40 +00:00
Jim Meyering
e60430be53
qemu_driver.c: s/strerror/virStrerror.../
...
Perform most changs automatically, with this:
perl -pi -e 's/\bstrerror *\((.+?)\)/virStrerror($1, ebuf, sizeof ebuf)/'
Then, declare ebuf, as needed
2009-02-05 16:27:28 +00:00
Jim Meyering
b0d49913d5
remove duplicate *SetCloseExec and *SetNonBlock functions
...
* src/qemu_driver.c: Use virSetCloseExec and virSetNonBlock,
rather than qemuSet* functions. Suggested by Daniel P. Berrange.
* src/util.c (virSetCloseExec): Publicize.
* src/util.h (virSetCloseExec): Declare
* src/libvirt_private.syms: Add virSetCloseExec.
2009-02-05 16:27:17 +00:00
Jim Meyering
22c9bf6d8b
ChangeLog: correct date formats one last time
2009-02-05 16:25:32 +00:00
Jim Meyering
caea9c00e3
qemu_driver.c: use virReportSystemError in place of some qemudLog uses
...
...thus eliminating many uses of strerror.
(kvmGetMaxVCPUs): Rather than merely warning, diagnose an error
and return -1 upon failure to open KVM_DEVICE. Suggested by
Daniel P. Berrange.
2009-02-05 16:11:25 +00:00
Jim Meyering
7bc569dda9
publicize virStrerror
...
* src/virterror.c (virStrerror): Remove "static".
* src/virterror_internal.h (virStrerror): Declare it.
* src/libvirt_private.syms: Add virStrerror;
2009-02-05 16:10:07 +00:00
Jim Meyering
a9aa76bad5
remove useless code
...
* src/bridge.c (brAddTap): Remove redundant errno=ENOMEM assignment
after failed strdup.
* src/cgroup.c (virCgroupFree): Remove redundant *group=NULL assignment
after VIR_FREE(*group).
* src/lxc_driver.c (lxcShutdown): Likewise.
* src/xen_unified.c (xenUnifiedClose): Likewise.
* src/xm_internal.c (xenXMDomainConfigFormat): Rewrite disk-
and net-config-setting code to be clearer.
2009-02-05 16:03:11 +00:00
Jim Meyering
7faa50d1db
lxc_container: Don't dereference NULL upon failure
...
* src/lxc_container.c (lxcContainerPivotRoot): Free and zero
oldroot *after* printing the diagnostic, both for virFileMakePath
and pivot_root failure.
2009-02-05 15:28:19 +00:00
Jim Meyering
41549b3888
ChangeLog: reformat recent date/name/email lines
2009-02-03 21:12:22 +00:00
Jim Meyering
6778ad0f07
avoid a format-related warning
...
* src/qemu_driver.c (qemudStartVMDaemon): Use "%s".
2009-02-03 13:09:18 +00:00
Jim Meyering
dff2114795
build: enable redundant-const check
...
* Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const.
* src/lxc_controller.c: Remove redundant "const"(s).
* src/storage_backend_fs.c: Likewise.
* src/util.h: Likewise.
* src/xen_internal.c: Likewise.
* tests/qparamtest.c: Likewise.
2009-02-03 13:08:59 +00:00
Jim Meyering
08f87e3d03
syntax-check: enable more checks
...
* Makefile.cfg (local-checks-to-skip): Don't skip sc_m4_quote_check.
Don't skip sc_prohibit_nonreentrant.
* Makefile.nonreentrant (NON_REENTRANT): Comment out until we've
remove all remaining uses of strerror.
2009-02-03 13:08:36 +00:00
Jim Meyering
c18ccff446
cleanup: remove useless if-before-VIR_FREE
...
* Makefile.cfg (useless_free_options): Also check for VIR_FREE.
* src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE.
* src/remote_internal.c (remoteAuthSASL): Likewise.
* src/test.c (testOpenFromFile): Likewise.
2009-02-03 13:08:07 +00:00
Jim Meyering
d26c3387df
tests: diagnose more open failures
...
* tests/qemuxml2argvtest.c: Revert the change,
"tests: diagnose open failure" of 2009-01-30.
* tests/testutils.c (virtTestLoadFile): Diagnose failure here.
2009-02-02 20:35:14 +00:00
John Levon
66929686c4
fix more printf("%s", NULL) cases
2009-02-02 18:41:56 +00:00
Guido Günther
e69b20d616
Don't hardcode ssh port 22, use VIR_FREE, initialize pointers to NULL not 0.
2009-01-31 13:49:11 +00:00
Daniel Veillard
4a5dfb847b
Release of 0.6.0
...
* configure.in docs/* NEWS: release of 0.6.0
* po/*: regenerated and updated brazilian and polish localizations
daniel
2009-01-31 11:46:29 +00:00
Daniel Veillard
42fea976df
* docs/news.html*: update with infos for 0.6.0
...
* docs/*: regenerated some data too
daniel
2009-01-31 09:14:58 +00:00
Jim Meyering
cf1b0f868b
tests: diagnose open failure
...
* tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Diagnose
failure to open an input file.
2009-01-30 21:59:35 +00:00
Daniel P. Berrange
f92e9f599b
Fix empty declaration in enum declaration
2009-01-30 21:52:22 +00:00
Daniel P. Berrange
f34ba729ff
Added missing shared disk test case
2009-01-30 21:49:12 +00:00
Jim Meyering
a119a98081
fix qemud version reporting when qemu is not installed
...
* src/qemu_conf.c (uname_normalize): New function, factored out of...
(qemudBuildCommandLine): ...here. Use the new function.
(qemudExtractVersion): Use it here, rather than hard-coding "i686".
2009-01-30 19:57:20 +00:00
Daniel P. Berrange
a6ef2e0055
Fix ifname= passing to QEMU for type=ethernet network config
2009-01-30 17:17:58 +00:00
Daniel P. Berrange
67e7416119
Support disk caching mode config
2009-01-30 17:15:39 +00:00
Daniel P. Berrange
3cb55cb51f
Fix crash using bogus arch in QEMU
2009-01-30 17:12:28 +00:00
Daniel P. Berrange
896761e5c7
Fix numerous bugs in QEMU domain startup
2009-01-30 17:07:29 +00:00
Daniel P. Berrange
05436ab7ff
Fix valgrind crash in LXC & avoid probing unneccessarily
2009-01-30 16:51:33 +00:00
Daniel P. Berrange
d8637214a4
Fix leak of storage vols when freeing pool
2009-01-30 16:48:52 +00:00
Daniel P. Berrange
e2da806861
Fix leak in serializing error message from daemon to client
2009-01-30 16:48:02 +00:00
John Levon
745c249a61
Fix yet another printf("%s", NULL) case
...
Fix getpwuid_r() usage
Fix virsh migrateuri handling
2009-01-30 15:43:05 +00:00
Daniel P. Berrange
1c64dc76c1
Misc xen driver bug/crash fixes
2009-01-29 23:01:37 +00:00
John Levon
3a8d93ab36
Fix xend XML generation when CPU pinning is used
2009-01-29 18:40:32 +00:00
Jim Meyering
73da543e77
maint: sync from coreutils
...
* .x-sc_prohibit_have_config_h: Renamed from...
* .x-sc_no_have_config_h: ... this.
* .x-sc_prohibit_HAVE_MBRTOWC: New file.
2009-01-29 18:06:19 +00:00
Daniel P. Berrange
3801794908
Support VNC password setting in QEMU driver
2009-01-29 17:50:00 +00:00
Daniel P. Berrange
4f4bfbc79e
Fix save/restore migrate syntax for new KVM releases
2009-01-29 17:27:54 +00:00
John Levon
e96d88ff3d
fix another printf("%s", NULL) case
2009-01-29 17:18:24 +00:00
John Levon
a10aa7a96b
correctly enable floppies for HVM guests.
2009-01-29 17:05:49 +00:00
John Levon
3463c34e33
fix VNC port reporting when vncunused is set
2009-01-29 17:02:00 +00:00
Jim Meyering
a9f8c8f5f1
* Makefile.cfg: disable some new checks
2009-01-29 12:11:49 +00:00
Jim Meyering
3aaad2178c
* Makefile.maint: sync from coreutils
2009-01-29 12:11:28 +00:00
Jim Meyering
ecb2eb4554
prohibit new uses of VIR_ERR_NO_MEMORY
...
* Makefile.maint (sc_prohibit_VIR_ERR_NO_MEMORY): New rule.
* .x-sc_prohibit_VIR_ERR_NO_MEMORY: New file: exceptions.
2009-01-29 12:10:52 +00:00
Jim Meyering
bc18a91f91
error-reporting calls using VIR_ERR_NO_MEMORY: use virReportOOMError instead
...
* src/uml_conf.c (VIR_FROM_THIS): Define to VIR_FROM_UML.
* src/xs_internal.c (VIR_FROM_THIS): Define to VIR_FROM_XEN.
* src/xml.c (VIR_FROM_THIS): Define to VIR_FROM_XML.
* src/stats_linux.c (VIR_FROM_THIS): Define to VIR_FROM_STATS_LINUX.
* src/datatypes.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/lxc_conf.c (VIR_FROM_THIS): Define to VIR_FROM_LXC.
* src/libvirt.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/node_device_conf.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/openvz_conf.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/openvz_driver.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/conf.c (VIR_FROM_THIS): Define to VIR_FROM_CONF.
Note: this loses config_filename:config_lineno diagnostics,
but that's ok.
* src/node_device.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/sexpr.c (VIR_FROM_THIS): Define to VIR_FROM_SEXPR.
* po/POTFILES.in: remove src/sexpr.c and src/lxc_conf.c
2009-01-29 12:10:32 +00:00
Guido Günther
a99e5ccba4
don't abort if setlocale() fails
2009-01-29 11:49:33 +00:00
Daniel P. Berrange
94d6177982
Fix typo & tweak variable decl
2009-01-28 22:07:36 +00:00
Daniel P. Berrange
46d1324e47
Stopping reading off wire after 1 complete RPC message is received
2009-01-28 22:00:32 +00:00
Daniel P. Berrange
ca9af16aa7
Fix bogus valgrind memory leak warnings in test suite
2009-01-28 21:53:48 +00:00
Daniel P. Berrange
9322b2e861
Solaris portability for RPC code data types
2009-01-28 21:33:56 +00:00
Jim Meyering
e730de6fd8
remote_internal.c: fix typo that would mistakenly report OOM
...
* src/remote_internal.c (addrToString): Report VIR_ERR_UNKNOWN_HOST,
not VIR_ERR_NO_MEMORY.
2009-01-28 16:14:24 +00:00
Jim Meyering
8cc2bbe33c
qparams.c: Use virReportOOMError(NULL), not qparam_report_oom()
...
* src/qparams.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
(qparam_report_oom): Remove definition.
Replace all uses.
2009-01-28 16:13:46 +00:00
John Levon
499189694a
fix mis-use of PF_UNIX as a protocol
2009-01-28 14:36:23 +00:00
Jim Meyering
be33b189a5
libvirt_proxy: avoid potential buffer overflow
...
* proxy/libvirt_proxy.c (proxyReadClientSocket): Ensure that
we've read an entire virProxyPacket before dereferencing "req".
Analysis and patch by "Rasputin" <rasputin@email.ru>. Details in
<http://thread.gmane.org/gmane.comp.emulators.libvirt/11459 >.
2009-01-28 14:08:33 +00:00
Jim Meyering
eb0849f370
* po/POTFILES.in: Add src/lxc_conf.c
2009-01-28 13:59:56 +00:00
John Levon
c2102c60ea
remove reference to non-existent *.res
2009-01-28 13:45:50 +00:00
Jim Meyering
555de859cc
avoid printf format-mismatch warnings
...
* qemud/qemud.c (qemudClientReadBuf, qemudClientWriteBuf):
Use %lld and a (long long int) cast to print a ssize_t value.
2009-01-28 11:31:39 +00:00
Daniel P. Berrange
489fde7680
Add support for copy-on-write storage volumes
2009-01-27 18:30:03 +00:00
Jim Meyering
765bca14d1
* POTFILES.in: update: remove src/lxc_conf.c; Add src/bridge.c.
2009-01-27 15:37:34 +00:00
Daniel P. Berrange
2c22a68ce2
Added complete set of RNG schemas for all XML formats
2009-01-27 15:29:53 +00:00
Daniel P. Berrange
04b120e481
Added link to libvirt-qpid on front page, and docs on URI formats for each driver
2009-01-27 14:49:09 +00:00
Jim Meyering
f03d3439cd
virterror.c: don't read beyond end of buffer upon OOM
...
* src/virterror.c (virReportSystemErrorFull): Fix typo in
my previous change. Patch by Daniel P. Berrange.
2009-01-27 12:26:53 +00:00
Mark McLoughlin
b4f62abbf1
kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
...
IFF_VNET_HDR is a tun/tap flag that allows you to send and receive
large (i.e. GSO) packets and packets with partial checksums. Setting
the flag means that every packet is proceeded by the same header which
virtio uses to communicate GSO/csum metadata.
By enabling this flag on the tap fds we create, we greatly increase
the achievable throughput with virtio_net.
However, we need to be careful to only set the flag when a) QEMU has
support for this ABI and b) the value of the flag is queryable using
the TUNGETIFF ioctl.
It's nearly five months since kvm-74 - the first KVM release with this
feature - was released. Up until now, we've not added libvirt support
because there is no clean way to detect support for this in QEMU at
runtime. A brief attempt to add a "info capabilities" monitor command
to QEMU floundered. Perfect is the enemy of good enough. Probing the
KVM version will suffice for now.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
2009-01-27 11:12:05 +00:00