Jiri Denemark
7d2fd6ef01
Do not check return value of VIR_EXPAND_N
...
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
2021-03-22 12:44:18 +01:00
Jiri Denemark
244204eccd
Do not check return value of VIR_RESIZE_N
...
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
2021-03-22 12:44:18 +01:00
Peter Krempa
695d469238
hyperv: abort() failure of wsmc_fault_new()
...
The function just allocates a helper object. Reporting errors would be
pointless when we encounter OOM situation.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-03-02 09:50:19 +01:00
Cole Robinson
e074a89f4d
hyperv: Fix 32bit compilation
...
Example:
../src/hyperv/hyperv_driver.c:3007:54: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘size_t’ {aka ‘unsigned int’} [-Werror=format=]
3007 | virReportError(VIR_ERR_INTERNAL_ERROR, _("Could not attach serial port %lu"), i);
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-03-01 13:46:20 -05:00
Ján Tomko
634516262a
hyperv: check return value of virUUIDGenerate
...
Fixes: fa66bd8cad
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
2021-02-18 17:14:47 +01:00
Peter Krempa
9c9423a1e8
hypervFreeInvokeParams: Don't use VIR_DISPOSE_N for freeing 'params'
...
The struct doesn't contain any secrets to clear before freeing and even
if it did VIR_DISPOSE_N wouldn't help as the struct contains only
pointers thus the actual memory pointing to isn't sanitized.
Just free the params array pointer and then the struct itself.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
2021-02-03 13:07:12 +01:00
Matt Coleman
c45c912840
hyperv: provide a more detailed error message for WSMan faults
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
2d20589fbd
hyperv: implement domainScreenshot
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
6b82b0209a
hyperv: implement networkGetXMLDesc
...
Co-authored-by: Dawid Zamirski <dzamirski@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
15a9f829a0
hyperv: implement networkGetAutostart, networkIsActive, and networkIsPersistent
...
Co-authored-by: Dawid Zamirski <dzamirski@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
b0615df6bf
hyperv: implement connectNumOfDefinedNetworks and connectListDefinedNetworks
...
Co-authored-by: Dawid Zamirski <dzamirski@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
4c928220a1
hyperv: implement networkLookupByName and networkLookupByUUID
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
ee6172bc17
hyperv: implement connectListAllNetworks and connectNumOfNetworks
...
Co-authored-by: Dawid Zamirski <dzamirski@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
fa66bd8cad
hyperv: add support for creating network adapters
...
Co-authored-by: Sri Ramanujam <sramanujam@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
67e2786a0e
hyperv: XML parsing of Ethernet adapters
...
Co-authored-by: Sri Ramanujam <sramanujam@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
c0c6254eed
hyperv: add support for creating serial devices
...
Co-authored-by: Sri Ramanujam <sramanujam@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:35 +01:00
Matt Coleman
3550d11a79
hyperv: XML parsing of serial ports
...
Co-authored-by: Sri Ramanujam <sramanujam@datto.com>
Signed-off-by: Matt Coleman <matt@datto.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2021-02-02 09:36:27 +01:00
Matt Coleman
f29815668a
hyperv: use g_auto for WsXmlDocH in hypervDomainAttachCDROM
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
8d8a7e7db2
hyperv: use g_auto for WsXmlDocH in hypervDomainAttachVirtualDisk
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
cc7a4b0139
hyperv: use GLib auto-cleanup in hypervCreateInvokeXmlDoc
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
57d668447b
hyperv: use GLib auto-cleanup in hypervSerializeEmbeddedParam
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
ca2b404f21
hyperv: use GLib auto-cleanup in hypervEnumAndPull
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
e624dc7998
hyperv: use GLib auto-cleanup in hypervSerializeEprParam
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
efd26e9bdc
hyperv: use g_autoptr for WMI classes in hypervDomainAttachDeviceFlags
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:29 -05:00
Matt Coleman
5b53af6b20
hyperv: use GLib auto-cleanup in hypervDomainGetXMLDesc
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
59daea438e
hyperv: use g_autoptr for Win32_OperatingSystem in hypervNodeGetFreeMemory
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
00beda0ee2
hyperv: use g_autoptr for Win32_PerfRawData_HvStats_HyperVHypervisorVirtualProcessor in hypervDomainGetVcpus
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
7ddeafe083
hyperv: use GLib auto-cleanup in hypervMsvmVSMSAddResourceSettings and hypervMsvmVSMSModifyResourceSettings
...
Fixes a memory leak when hypervCreateInvokeParamsList() fails.
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
ba81dc6e2e
hyperv: use GLib auto-cleanup in hypervInvokeMsvmComputerSystemRequestStateChange
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
d68ef58963
hyperv: use GLib auto-cleanup in hypervInvokeMethod
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
e9a9707fa3
hyperv: use GLib auto-cleanup in hypervDomainSendKey
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
d9c015ec2c
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListAllDomains
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
97c558b5d7
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainManagedSaveRemove
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
54d96d7fde
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainHasManagedSaveImage
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:28 -05:00
Matt Coleman
92853b9025
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainManagedSave
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
acb9273074
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainIsActive
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
5997e1e218
hyperv: use g_autoptr for WMI classes in hypervDomainGetSchedulerParametersFlags
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
230140f59c
hyperv: use g_autoptr for Msvm_VirtualSystemSettingData in hypervDomainSetAutostart
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
c468080dce
hyperv: use g_autoptr for Msvm_VirtualSystemSettingData in hypervDomainGetAutostart
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
e593d4671e
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainCreateWithFlags
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
8a0c80ab23
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectNumOfDefinedDomains
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
81c9102256
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListDefinedDomains
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
917ed7592a
hyperv: use g_autoptr for WMI classes in hypervDomainGetVcpusFlags
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
f0f0a77ee2
hyperv: use g_autoptr for WMI classes in hypervDomainSetVcpusFlags
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:27 -05:00
Matt Coleman
bf965ede11
hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainGetState
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:26 -05:00
Matt Coleman
7d24512891
hyperv: use g_autoptr for WMI classes in hypervDomainGetInfo
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:26 -05:00
Matt Coleman
51080a21f5
hyperv: use g_autoptr for Msvm_DiskDrive in hypervDomainDefParsePhysicalDisk
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:26 -05:00
Matt Coleman
d6d523e6cf
hyperv: use g_autoptr for WMI classes in hypervDomainAttachStorage
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:26 -05:00
Matt Coleman
3836e11cec
hyperv: use g_autoptr for Msvm_ResourceAllocationSettingData in hypervDomainAttachPhysicalDisk
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:26 -05:00
Matt Coleman
e1e58cb122
hyperv: use g_autoptr for Win32_ComputerSystemProduct in hypervLookupHostSystemBiosUuid
...
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Laine Stump <laine@redhat.com>
2021-01-22 14:04:26 -05:00