mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
0cdc982995
Currently libvirt doesn't confirm whether the guest has responded to the disk removal request. In some cases this can leave the guest with continued access to the device while the mgmt layer believes that it has been removed. With a recent qemu monitor command[1] we can deterministically revoke a guests access to the disk (on the QEMU side) to ensure no futher access is permitted. This patch adds support for the drive_unplug() command and introduces it in the disk removal paths. There is some discussion to be had about how to handle the case where the guest is running in a QEMU without this command (and the fact that we currently don't have a way of detecting what monitor commands are available). Changes since v2: - use VIR_ERROR to report when unplug command not found Changes since v1: - return > 0 when command isn't present, < 0 on command failure - detect when drive_unplug command isn't present and log error instead of failing entire command Signed-off-by: Ryan Harper <ryanh@us.ibm.com> |
||
---|---|---|
.. | ||
conf | ||
cpu | ||
esx | ||
interface | ||
lxc | ||
network | ||
node_device | ||
nwfilter | ||
opennebula | ||
openvz | ||
phyp | ||
qemu | ||
remote | ||
secret | ||
security | ||
storage | ||
test | ||
uml | ||
util | ||
vbox | ||
xen | ||
xenapi | ||
.gitignore | ||
datatypes.c | ||
datatypes.h | ||
driver.c | ||
driver.h | ||
fdstream.c | ||
fdstream.h | ||
gnutls_1_0_compat.h | ||
internal.h | ||
libvirt_bridge.syms | ||
libvirt_daemon.syms | ||
libvirt_driver_modules.syms | ||
libvirt_internal.h | ||
libvirt_linux.syms | ||
libvirt_macvtap.syms | ||
libvirt_nwfilter.syms | ||
libvirt_private.syms | ||
libvirt_public.syms | ||
libvirt_qemu.syms | ||
libvirt-qemu.c | ||
libvirt.c | ||
Makefile.am | ||
nodeinfo.c | ||
nodeinfo.h | ||
README | ||
remote_protocol-structs |
libvirt library code README =========================== The directory provides the bulk of the libvirt codebase. Everything except for the libvirtd daemon and client tools. The build uses a large number of libtool convenience libraries - one for each child directory, and then links them together for the final libvirt.so, although some bits get linked directly to libvirtd daemon instead. The files directly in this directory are supporting the public API entry points & data structures. There are two core shared modules to be aware of: * util/ - a collection of shared APIs that can be used by any code. This directory is always in the include path for all things built * conf/ - APIs for parsing / manipulating all the official XML files used by the public API. This directory is only in the include path for driver implementation modules Then there are the hypervisor implementations: * esx/ - VMware ESX and GSX support using vSphere API over SOAP * lxc/ - Linux Native Containers * opennebula/ - Open Nebula using XMLRPC * openvz/ - OpenVZ containers using cli tools * phyp/ - IBM Power Hypervisor using CLI tools over SSH * qemu/ - QEMU / KVM using qemu CLI/monitor * remote/ - Generic libvirt native RPC client * test/ - A "mock" driver for testing * uml/ - User Mode Linux * vbox/ - Virtual Box using native API * xen/ - Xen using hypercalls, XenD SEXPR & XenStore Finally some secondary drivers that are shared for several HVs. Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers. The ESX, OpenNebula, Power Hypervisor, Remote, Test & VirtualBox drivers all implement the secondary drivers directly * interface/ - Host network interface management * network/ - Virtual NAT networking * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers * storage/ - Storage management drivers Since both the hypervisor and secondary drivers can be built as dlopen()able modules, it is *FORBIDDEN* to have build dependencies between these directories. Drivers are only allowed to depend on the public API, and the internal APIs in the util/ and conf/ directories