libvirt/src
Ryan Harper 0cdc982995 qemu: call drive_unplug in DetachPciDiskDevice
Currently libvirt doesn't confirm whether the guest has responded to the
disk removal request.  In some cases this can leave the guest with
continued access to the device while the mgmt layer believes that it has
been removed.  With a recent qemu monitor command[1] we can
deterministically revoke a guests access to the disk (on the QEMU side)
to ensure no futher access is permitted.

This patch adds support for the drive_unplug() command and introduces it
in the disk removal paths.  There is some discussion to be had about how
to handle the case where the guest is running in a QEMU without this
command (and the fact that we currently don't have a way of detecting
what monitor commands are available).

Changes since v2:
 - use VIR_ERROR to report when unplug command not found
Changes since v1:
 - return > 0 when command isn't present, < 0 on command failure
 - detect when drive_unplug command isn't present and log error
   instead of failing entire command

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
2010-12-08 11:03:02 -07:00
..
conf qemud: fix memory leak in io error events 2010-12-08 09:00:26 -07:00
cpu cpu: Add support for overriding path to CPU map XML file 2010-12-01 14:12:54 +01:00
esx Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
interface Implement forgotten backend of virInterfaceIsActive() 2010-04-14 10:38:18 -04:00
lxc Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
network Create file in virFileWriteStr() if it doesn't exist 2010-12-03 08:08:22 -07:00
node_device Create file in virFileWriteStr() if it doesn't exist 2010-12-03 08:08:22 -07:00
nwfilter nwfilter: re-order lock grabbed by IP addr. learn thread 2010-11-19 20:41:25 -05:00
opennebula Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
openvz openvz: avoid potential buffer overflow 2010-12-07 15:40:01 -07:00
phyp Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
qemu qemu: call drive_unplug in DetachPciDiskDevice 2010-12-08 11:03:02 -07:00
remote implement the remote protocol 2010-11-23 15:04:42 -07:00
secret maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
security security, storage: plug memory leaks for security_context_t 2010-11-24 15:23:43 -07:00
storage maint: update to latest gnulib 2010-12-07 19:51:34 -07:00
test Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
uml uml: convert to virCommand 2010-12-02 16:00:47 -07:00
util command: improve behavior on no output 2010-12-07 15:35:30 -07:00
vbox Fix memory leaks in audit & VirtualBox code 2010-11-29 15:17:16 +00:00
xen Fix host CPU counting on unusual NUMA topologies 2010-11-25 10:49:47 +01:00
xenapi Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
.gitignore util: add missing export 2010-10-12 09:42:18 -06:00
datatypes.c Always close drivers when a virConnectPtr is released 2010-11-24 22:48:36 +01:00
datatypes.h Snapshot API framework. 2010-04-05 10:24:34 -04:00
driver.c maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
driver.h Change return value of VIR_DRV_SUPPORTS_FEATURE to bool 2010-12-06 10:09:00 +01:00
fdstream.c Add a generic internal API for handling any FD based stream 2010-11-11 16:02:57 +00:00
fdstream.h Add a generic internal API for handling any FD based stream 2010-11-11 16:02:57 +00:00
gnutls_1_0_compat.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
internal.h maint: improve i18n on non-Linux 2010-11-17 10:12:57 -07:00
libvirt_bridge.syms
libvirt_daemon.syms Export conditional state driver symbols only when they are defined 2010-03-23 02:05:18 +01:00
libvirt_driver_modules.syms
libvirt_internal.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
libvirt_linux.syms
libvirt_macvtap.syms Fix undefined symbol errors when macvtap support is disabled 2010-12-01 17:08:08 +01:00
libvirt_nwfilter.syms Some NWFilter symbols are conditional and have to be exported conditional 2010-04-23 19:51:00 +02:00
libvirt_private.syms threads: add virThreadID for debugging use 2010-12-06 09:50:20 -07:00
libvirt_public.syms virDomainIsUpdated: define the new public API 2010-11-23 14:22:31 -07:00
libvirt_qemu.syms Qemu Monitor API entry point. 2010-07-23 17:30:14 -04:00
libvirt-qemu.c Qemu Monitor API entry point. 2010-07-23 17:30:14 -04:00
libvirt.c Change return value of VIR_DRV_SUPPORTS_FEATURE to bool 2010-12-06 10:09:00 +01:00
Makefile.am Introduce new APIs for spawning processes 2010-12-02 16:00:44 -07:00
nodeinfo.c Fix host CPU counting on unusual NUMA topologies 2010-11-25 10:49:47 +01:00
nodeinfo.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
README
remote_protocol-structs implement the remote protocol 2010-11-23 15:04:42 -07:00

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * lxc/          - Linux Native Containers
 * opennebula/   - Open Nebula using XMLRPC
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, OpenNebula, Power Hypervisor, Remote, Test & VirtualBox
drivers all implement the secondary drivers directly

 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories