libvirt/src
Daniel P. Berrangé 1e49132dde nwfilter: fix IP address learning
In a previous commit:

  commit d4bf8f4150
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Wed Feb 14 09:43:59 2018 +0000

    nwfilter: handle missing switch enum cases

    Ensure all enum cases are listed in switch statements, or cast away
    enum type in places where we don't wish to cover all cases.

    Reviewed-by: John Ferlan <jferlan@redhat.com>
    Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

we changed a switch in the nwfilter learning thread so that it had
explict cases for all enum entries. Unfortunately the parameters in the
method had been declared with incorrect type. The "howDetect" parameter
does *not* accept "enum howDetect" values, rather it accepts a bitmask
of "enum howDetect" values, so it should have been an "int" type.

The caller always passes DETECT_STATIC|DETECT_DHCP, so essentially the
IP addressing learning was completely broken by the above change, as it
never matched any switch case, hitting the default leading to EINVAL.

Stop using a typedef for the parameter name this this is a bitmask,
not a plain enum value. Also stop using switch() since that's misleading
with bitmasks too.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2018-06-07 16:58:33 +01:00
..
access access/: Remove spaces after casts 2018-05-03 22:31:36 +02:00
admin
bhyve bhyve: Add CPU topology support 2018-06-07 19:26:26 +04:00
conf Don't use enums in TPM struct fields 2018-06-06 17:46:31 +01:00
cpu cpu: Add optional list of allowed features to virCPUBaseline 2018-05-28 15:59:11 +02:00
esx esx: Use VIR_CRYPTO_HASH_SIZE_MD5 2018-05-14 14:05:21 +02:00
hyperv hyperv/: Remove spaces after casts 2018-05-03 22:31:36 +02:00
interface virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
keycodemapdb@16e5b07876
libxl libxl: fix leaking logfile fds 2018-06-04 16:07:39 -06:00
locking all: Replace virGetLastError with virGetLastErrorCode where we can 2018-06-05 18:44:05 +02:00
logging src: Drop most of #ifdef WITH_GNUTLS 2018-06-05 14:32:36 +02:00
lxc all: Replace virGetLastError with virGetLastErrorCode where we can 2018-06-05 18:44:05 +02:00
network util: Clean up consumers of virJSONValueArraySize 2018-05-10 14:59:15 -04:00
node_device virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
nwfilter nwfilter: fix IP address learning 2018-06-07 16:58:33 +01:00
openvz conf: Clean up object referencing for Add and Remove 2018-05-03 19:09:03 -04:00
phyp phyp/: Remove spaces after casts 2018-05-03 22:31:37 +02:00
qemu qemu_tpm: Drop needles include of cap-ng.h 2018-06-07 08:32:11 +02:00
remote all: Replace virGetLastError with virGetLastErrorCode where we can 2018-06-05 18:44:05 +02:00
rpc all: Replace virGetLastError with virGetLastErrorCode where we can 2018-06-05 18:44:05 +02:00
secret driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
security security: Label the external swtpm with SELinux labels 2018-06-06 10:48:41 -04:00
storage storage: fix crash in luks encrypted volume creation 2018-06-06 18:02:59 +02:00
test capabilities: Extend capabilities with iommu_support 2018-06-05 08:33:13 +02:00
uml conf: Clean up object referencing for Add and Remove 2018-05-03 19:09:03 -04:00
util fdstream: Report error from the I/O thread 2018-06-06 20:35:55 -04:00
vbox virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
vmware conf: Clean up object referencing for Add and Remove 2018-05-03 19:09:03 -04:00
vmx vmx: add VIR_DOMAIN_DEF_FEATURE_NO_BOOT_ORDER 2018-05-29 10:09:32 +02:00
vz cpu: Add optional list of allowed features to virCPUBaseline 2018-05-28 15:59:11 +02:00
xenapi driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
xenconfig xenconfig: xm: Fix checking for extra in parser 2018-05-14 17:07:30 -06:00
admin_protocol-structs
check-aclperms.pl
check-aclrules.pl acl: remove various left over Xen ACL whitelist entries 2018-04-16 10:29:36 +01:00
check-driverimpls.pl check scripts: handle unintialized driver vars in check-driverimpls.pl 2018-04-19 11:05:00 +03:00
check-drivername.pl perl: Don't hardcode interpreter path 2017-09-19 16:04:53 +02:00
check-symfile.pl
check-symsorting.pl
datatypes.c virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
datatypes.h src: Unify virObject member name 2018-04-18 10:04:55 +02:00
driver-hypervisor.h Introduce virConnectBaselineHypervisorCPU public API 2018-05-28 15:58:05 +02:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h
driver.c util: create new virmodule.{c,h} files for dlopen support code 2018-05-03 12:47:43 +01:00
driver.h util: create new virmodule.{c,h} files for dlopen support code 2018-05-03 12:47:43 +01:00
dtrace2systemtap.pl
internal.h po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
libvirt_admin_private.syms
libvirt_admin_public.syms
libvirt_atomic.syms
libvirt_driver_modules.syms util: create new virmodule.{c,h} files for dlopen support code 2018-05-03 12:47:43 +01:00
libvirt_esx.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms util: Implement and use virFileIsRegular() rather than d_type 2018-06-06 12:51:18 -04:00
libvirt_probes.d
libvirt_public.syms util: virerror: Introduce virGetLastError{Code,Domain} public APIs 2018-06-05 18:44:05 +02:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms src: Dissolve libvirt_gnutls.syms in libvirt_remote.syms 2018-06-05 14:32:30 +02:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenconfig.syms
libvirt-admin.c po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
libvirt-admin.conf
libvirt-domain-snapshot.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-domain.c Introduce virDomainDetachDeviceAlias API 2018-05-28 13:08:38 +02:00
libvirt-host.c Introduce virConnectBaselineHypervisorCPU public API 2018-05-28 15:58:05 +02:00
libvirt-interface.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-lxc.c
libvirt-lxc.pc.in
libvirt-network.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-nodedev.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-nwfilter.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-qemu.c
libvirt-qemu.pc.in
libvirt-secret.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-storage.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-stream.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt.c Deprecate GNUTLS_GCRYPT 2018-05-16 10:40:40 +02:00
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am src: Dissolve libvirt_gnutls.syms in libvirt_remote.syms 2018-06-05 14:32:30 +02:00
qemu_protocol-structs
README
remote_protocol-structs remote: Implement virConnectBaselineHypervisorCPU 2018-05-28 15:59:10 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories