mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-06 18:05:45 +00:00
e7ae82dcc5
Several libvirt functions are called from virt-host-validate. Some of these functions do report an error on failure. But reporting an error is coupled with freeing previous error (by calling virResetError()). But we've never called virErrorInitialize() and thus resetting error object frees some random pointer. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Fabiano Fidêncio <fabiano@fidencio.org>
157 lines
3.7 KiB
C
157 lines
3.7 KiB
C
/*
|
|
* virt-host-validate.c: Sanity check a hypervisor host
|
|
*
|
|
* Copyright (C) 2012 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#ifdef WITH_LIBINTL_H
|
|
# include <libintl.h>
|
|
#endif /* WITH_LIBINTL_H */
|
|
#include <getopt.h>
|
|
|
|
#include "internal.h"
|
|
#include "virerror.h"
|
|
#include "virgettext.h"
|
|
|
|
#include "virt-host-validate-common.h"
|
|
#if WITH_QEMU
|
|
# include "virt-host-validate-qemu.h"
|
|
#endif
|
|
#if WITH_LXC
|
|
# include "virt-host-validate-lxc.h"
|
|
#endif
|
|
#if WITH_BHYVE
|
|
# include "virt-host-validate-bhyve.h"
|
|
#endif
|
|
|
|
static void
|
|
show_help(FILE *out, const char *argv0)
|
|
{
|
|
fprintf(out,
|
|
_("\n"
|
|
"syntax: %s [OPTIONS] [HVTYPE]\n"
|
|
"\n"
|
|
" Hypervisor types:\n"
|
|
"\n"
|
|
" - qemu\n"
|
|
" - lxc\n"
|
|
" - bhyve\n"
|
|
"\n"
|
|
" Options:\n"
|
|
" -h, --help Display command line help\n"
|
|
" -v, --version Display command version\n"
|
|
" -q, --quiet Don't display progress information\n"
|
|
"\n"),
|
|
argv0);
|
|
}
|
|
|
|
static void
|
|
show_version(FILE *out, const char *argv0)
|
|
{
|
|
fprintf(out, "version: %s %s\n", argv0, VERSION);
|
|
}
|
|
|
|
static const struct option argOptions[] = {
|
|
{ "help", 0, NULL, 'h', },
|
|
{ "version", 0, NULL, 'v', },
|
|
{ "quiet", 0, NULL, 'q', },
|
|
{ NULL, 0, NULL, '\0', }
|
|
};
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
const char *hvname = NULL;
|
|
int c;
|
|
int ret = EXIT_SUCCESS;
|
|
bool quiet = false;
|
|
bool usedHvname = false;
|
|
|
|
if (virGettextInitialize() < 0 ||
|
|
virErrorInitialize() < 0) {
|
|
fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
while ((c = getopt_long(argc, argv, "hvq", argOptions, NULL)) != -1) {
|
|
switch (c) {
|
|
case 'v':
|
|
show_version(stdout, argv[0]);
|
|
return EXIT_SUCCESS;
|
|
|
|
case 'h':
|
|
show_help(stdout, argv[0]);
|
|
return EXIT_SUCCESS;
|
|
|
|
case 'q':
|
|
quiet = true;
|
|
break;
|
|
|
|
case '?':
|
|
default:
|
|
show_help(stderr, argv[0]);
|
|
return EXIT_FAILURE;
|
|
}
|
|
}
|
|
|
|
if ((argc-optind) > 2) {
|
|
fprintf(stderr, _("%s: too many command line arguments\n"), argv[0]);
|
|
show_help(stderr, argv[0]);
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
if (argc > 1)
|
|
hvname = argv[optind];
|
|
|
|
virHostMsgSetQuiet(quiet);
|
|
|
|
#if WITH_QEMU
|
|
if (!hvname || STREQ(hvname, "qemu")) {
|
|
usedHvname = true;
|
|
if (virHostValidateQEMU() < 0)
|
|
ret = EXIT_FAILURE;
|
|
}
|
|
#endif
|
|
|
|
#if WITH_LXC
|
|
if (!hvname || STREQ(hvname, "lxc")) {
|
|
usedHvname = true;
|
|
if (virHostValidateLXC() < 0)
|
|
ret = EXIT_FAILURE;
|
|
}
|
|
#endif
|
|
|
|
#if WITH_BHYVE
|
|
if (!hvname || STREQ(hvname, "bhyve")) {
|
|
usedHvname = true;
|
|
if (virHostValidateBhyve() < 0)
|
|
ret = EXIT_FAILURE;
|
|
}
|
|
#endif
|
|
|
|
if (hvname && !usedHvname) {
|
|
fprintf(stderr, _("%s: unsupported hypervisor name %s\n"),
|
|
argv[0], hvname);
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
return ret;
|
|
}
|