1
0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Michal Privoznik 3010a69226 qemu_command: Generate -mem-prealloc in one corner case more
When guest has NUMA nodes and QEMU is new enough to report
default RAM ID then ideally we would use -numa memdev= combined
with memory-backend-* combo becasue -mem-path/-mem-prealloc/-numa
mem are deprecated. Well, there is one problem - the .memdev=
attribute is machine type dependent (just look at arguments of
virQEMUCapsGetMachineNumaMemSupported()) and to ensure backwards
compatibility we prefer -numa mem= over -numa memdev=.

But there was one corner case when -mem-prealloc was requested
but not generated on the cmd line. It all starts with
qemuBuildMemCommandLine() which generates just '-m XXX' and
because it sees defaultRAMid and guest NUMA nodes greater than
zero it does nothing more.

Then, qemuBuildNumaCommandLine() sees that -numa mem= is still
supported for given machine type and nothing else set
@needBackend thus qemuBuildMemPathStr() is called which output
-mem-prealloc only in a few cases assuming it was outputted
earlier.

Reported-by: Jing Qi <jinqi@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-11-22 12:27:29 +01:00
..
2020-06-10 14:00:38 +02:00
2021-07-15 14:50:48 +02:00
2021-09-09 18:06:13 +02:00
2021-11-08 14:32:32 +01:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-10-21 17:34:04 +01:00
2021-09-09 18:06:13 +02:00
2019-10-15 11:25:25 +02:00
2020-07-10 09:40:58 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2019-10-15 11:25:25 +02:00
2021-09-09 18:06:13 +02:00
2021-10-21 17:34:04 +01:00
2021-11-08 14:32:32 +01:00
2021-09-09 18:06:13 +02:00
2019-10-15 11:25:25 +02:00
2019-10-15 11:25:25 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2020-11-27 16:28:31 +01:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-17 14:28:00 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-11-08 14:32:32 +01:00