External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-13 09:39:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
3f8b57a61f
libvirt/src/qemu
History
Laine Stump 3f8b57a61f qemu: save/restore original error when recovering from failed bridge attach 
Not only was the original error code destroyed in the case of
encountering an error during recovery from a failed attach to the
bridge (and then *that* error was destroyed by logging a *second*
error about the failure to recover - virNetDevBridgeAddPort() already
logs an error, so the one about failing to recover was redundant), but
if the recovery was successful, the function would then return success
to the caller even though it had failed.

Fixes: 2711ac8716
(overwritten errors were introduced along with this functionality)
Fixes: 6bde0a1a37
(the wrong return value was introduced by a refactor)

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2020-02-20 23:05:24 -05:00
..
EVENTHANDLERS.txt
libvirtd_qemu.aug qemu: rename gluster_debug_entry 2020-01-08 09:51:00 +01:00
Makefile.inc.am gnulib: delete all gnulib integration 2020-02-07 15:03:54 +00:00
MIGRATION.txt
qemu_agent.c virJSONValueNewArray: Use g_new0 to allocate and remove NULL checks from callers 2020-02-04 13:45:33 +01:00
qemu_agent.h qemu: don't access vmdef within qemu_agent.c 2020-01-16 16:35:47 +01:00
qemu_alias.c qemu: Use g_strdup_printf() instead of virAsprintf() 2019-11-12 16:15:58 +01:00
qemu_alias.h
qemu_backup.c virJSONValueNewArray: Use g_new0 to allocate and remove NULL checks from callers 2020-02-04 13:45:33 +01:00
qemu_backup.h qemu: process: Terminate backup job on VM destroy 2020-01-06 10:15:36 +01:00
qemu_block.c qemu: Add support for slices of type 'storage' 2020-02-14 16:32:21 +01:00
qemu_block.h qemu: Add support for slices of type 'storage' 2020-02-14 16:32:21 +01:00
qemu_blockjob.c qemu: Add support for slices of type 'storage' 2020-02-14 16:32:21 +01:00
qemu_blockjob.h qemu: blockjob: Store 'flags' for all the block job types 2020-02-04 13:45:33 +01:00
qemu_capabilities.c qemu: Add the QEMU_CAPS_CPU_KVM_NO_ADJVTIME capability 2020-02-14 12:09:02 +01:00
qemu_capabilities.h qemu: Add the QEMU_CAPS_CPU_KVM_NO_ADJVTIME capability 2020-02-14 12:09:02 +01:00
qemu_capspriv.h qemu: capabilities: Add accessor to qemu caps machine types presence 2020-01-27 14:55:03 +01:00
qemu_cgroup.c qemu: Don't use NULL path from qemuDomainGetHostdevPath 2020-01-10 09:12:57 +01:00
qemu_cgroup.h
qemu_checkpoint.c virJSONValueNewArray: Use g_new0 to allocate and remove NULL checks from callers 2020-02-04 13:45:33 +01:00
qemu_checkpoint.h qemu: checkpoint: Track and relabel images for bitmap merging 2020-02-04 13:45:32 +01:00
qemu_command.c qemu: Add support for slices of type 'storage' 2020-02-14 16:32:21 +01:00
qemu_command.h qemu: check iotune params same for all disk in group 2020-01-29 11:46:51 +01:00
qemu_conf.c src: remove sys/wait.h from many files 2020-02-04 14:00:44 +00:00
qemu_conf.h Add a space before ending a comment 2020-01-30 12:32:03 +01:00
qemu_dbus.c qemu: use g_strdup instead of VIR_STRDUP 2019-10-21 12:51:57 +02:00
qemu_dbus.h
qemu_domain_address.c qemu: Extend QEMU with tpm-spapr support 2020-02-05 19:57:10 +01:00
qemu_domain_address.h qemu_domain_address.c: turn qemuDomainFillDeviceIsolationGroup to void 2020-01-31 15:25:33 +01:00
qemu_domain.c qemu: Add support for slices of type 'storage' 2020-02-14 16:32:21 +01:00
qemu_domain.h qemu: support Panic Crashloaded event handling 2020-02-07 14:05:25 +00:00
qemu_driver.c qemuDomainGetStatsIOThread: Don't leak array with 0 iothreads 2020-02-19 10:24:31 +01:00
qemu_driver.h
qemu_extdevice.c qemu: eliminate ret in qemuExtDevicesStart 2020-01-28 13:32:27 +01:00
qemu_extdevice.h
qemu_firmware.c virJSONValueNewArray: Use g_new0 to allocate and remove NULL checks from callers 2020-02-04 13:45:33 +01:00
qemu_firmware.h src: replace verify(expr) with G_STATIC_ASSERT(expr) 2020-01-17 10:02:01 +00:00
qemu_hostdev.c qemu: remove unneeded labels 2020-01-07 16:40:41 +01:00
qemu_hostdev.h qemu_hotplug: Prepare NVMe disks on hotplug 2019-12-17 10:04:44 +01:00
qemu_hotplug.c qemu: save/restore original error when recovering from failed bridge attach 2020-02-20 23:05:24 -05:00
qemu_hotplug.h qemu_hotplug.c: adding qemuDomainGetUnplugTimeout 2019-11-13 15:03:40 -05:00
qemu_interface.c Add a space before ending a comment 2020-01-30 12:32:03 +01:00
qemu_interface.h
qemu_interop_config.c qemu: Don't check the output of virGetUserDirectory() 2019-12-20 09:38:43 +01:00
qemu_interop_config.h
qemu_migration_cookie.c qemuMigrationCookieAddNBD: Fix filling of 'capacity' when blockdev is used 2020-01-31 14:28:29 +01:00
qemu_migration_cookie.h qemuMigrationCookieNBD: Extract embedded struct 2020-01-31 14:28:28 +01:00
qemu_migration_params.c virJSONValueNewArray: Use g_new0 to allocate and remove NULL checks from callers 2020-02-04 13:45:33 +01:00
qemu_migration_params.h
qemu_migration_paramspriv.h
qemu_migration.c qemu_migration: Rearrange some checks in qemuMigrationSrcIsAllowed() 2020-02-20 12:57:24 +01:00
qemu_migration.h qemu: Implement VIR_MIGRATE_PARAM_TLS_DESTINATION 2019-12-09 10:11:58 +01:00
qemu_monitor_json.c qemuMonitorBlockdevAdd: Take double pointer argument 2020-02-10 17:26:27 +01:00
qemu_monitor_json.h qemuMonitorBlockdevAdd: Take double pointer argument 2020-02-10 17:26:27 +01:00
qemu_monitor_priv.h
qemu_monitor_text.c qemu: use g_autofree instead of VIR_FREE in qemuMonitorTextCreateSnapshot() 2019-12-17 10:49:30 -05:00
qemu_monitor_text.h
qemu_monitor.c qemu: drop support for monitor connections on PTYs 2020-02-13 12:52:07 +00:00
qemu_monitor.h qemuMonitorBlockdevAdd: Take double pointer argument 2020-02-10 17:26:27 +01:00
qemu_process.c qemu: Don't explicitly remove pidfile after virPidFileForceCleanupPath() 2020-02-20 12:57:19 +01:00
qemu_process.h
qemu_processpriv.h
qemu_qapi.c use g_ascii_isalpha instead of c_isalpha from gnulib 2019-12-10 13:49:24 +01:00
qemu_qapi.h
qemu_security.c
qemu_security.h
qemu_shim.c qemu_shim: Update temporary directory template 2020-01-27 17:57:43 +01:00
qemu_slirp.c qemu: Use g_strdup_printf() instead of virAsprintf() 2019-11-12 16:15:58 +01:00
qemu_slirp.h
qemu_tpm.c src: convert code to use virPipe APIs 2020-02-04 14:00:44 +00:00
qemu_tpm.h
qemu_vhost_user_gpu.c qemu: Don't explicitly remove pidfile after virPidFileForceCleanupPath() 2020-02-20 12:57:19 +01:00
qemu_vhost_user_gpu.h
qemu_vhost_user.c Drop needless ret variable 2019-10-24 08:10:37 +02:00
qemu_vhost_user.h
qemu.conf qemu: keep capabilities when running QEMU as root 2019-12-11 16:01:20 +00:00
test_libvirtd_qemu.aug.in qemu: keep capabilities when running QEMU as root 2019-12-11 16:01:20 +00:00
THREADS.txt qemu: remove qemuDomainObjBegin/EndJobWithAgent() 2020-01-16 16:35:47 +01:00
virtqemud.init.in configure: Provide OpenRC scripts for sub-daemons 2019-12-16 10:11:22 +01:00
virtqemud.service.in