mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-28 08:35:22 +00:00
51c8216594
On RHEL 5, compilation fails with:
storage/storage_backend.c: In function 'createRawFile':
storage/storage_backend.c:339: warning: implicit declaration of function 'fallocate'
storage/storage_backend.c:339: warning: nested extern declaration of 'fallocate' [-Wnested-externs]
But:
$ grep HAVE_FALLOCATE config.h
/* #undef HAVE_FALLOCATE */
Huh? It turns out that in kernels that old, fallocate() is not
implemented (config.h is correct), but <linux/fs.h> defines
HAVE_FALLOCATE as an empty witness macro for a completely
different purpose. Since storage_backend.c is including
<linux/fs.h> on RHEL 5, we are hosed by the kernel definition.
Newer kernels no longer pollute the namespace, and it's fairly
easy to convert to an expression that works with both the old
kernel witness and the new-style config.h (undefined or 1).
Problem introduced in commit
|
||
|---|---|---|
| .. | ||
| parthelper.c | ||
| storage_backend_disk.c | ||
| storage_backend_disk.h | ||
| storage_backend_fs.c | ||
| storage_backend_fs.h | ||
| storage_backend_iscsi.c | ||
| storage_backend_iscsi.h | ||
| storage_backend_logical.c | ||
| storage_backend_logical.h | ||
| storage_backend_mpath.c | ||
| storage_backend_mpath.h | ||
| storage_backend_rbd.c | ||
| storage_backend_rbd.h | ||
| storage_backend_scsi.c | ||
| storage_backend_scsi.h | ||
| storage_backend_sheepdog.c | ||
| storage_backend_sheepdog.h | ||
| storage_backend.c | ||
| storage_backend.h | ||
| storage_driver.c | ||
| storage_driver.h | ||