libvirt/src/vbox
Eric Blake 625e04a86e maint: use hanging curly braces
Our style overwhelmingly uses hanging braces (the open brace
hangs at the end of the compound condition, rather than on
its own line), with the primary exception of the top level function
body.  Fix the few remaining outliers, before adding a syntax
check in a later patch.

* src/interface/interface_backend_netcf.c (netcfStateReload)
(netcfInterfaceClose, netcf_to_vir_err): Correct use of { in
compound statement.
* src/conf/domain_conf.c (virDomainHostdevDefFormatSubsys)
(virDomainHostdevDefFormatCaps): Likewise.
* src/network/bridge_driver.c (networkAllocateActualDevice):
Likewise.
* src/util/virfile.c (virBuildPathInternal): Likewise.
* src/util/virnetdev.c (virNetDevGetVirtualFunctions): Likewise.
* src/util/virnetdevmacvlan.c
(virNetDevMacVLanVPortProfileCallback): Likewise.
* src/util/virtypedparam.c (virTypedParameterAssign): Likewise.
* src/util/virutil.c (virGetWin32DirectoryRoot)
(virFileWaitForDevices): Likewise.
* src/vbox/vbox_common.c (vboxDumpNetwork): Likewise.
* tests/seclabeltest.c (main): Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
2014-09-04 15:18:43 -06:00
..
README vbox: Introducing vboxCommonDriver 2014-08-15 09:25:13 +02:00
vbox_CAPI_v2_2.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v3_0.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v3_1.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v3_2.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v4_0.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v4_1.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v4_2_20.h vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_CAPI_v4_2.h Add support for VirtualBox 4.2 APIs 2013-06-07 14:47:45 +01:00
vbox_CAPI_v4_3_4.h vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_CAPI_v4_3.h vbox: import vbox_CAPI_v4_3.h from SDK 2013-11-25 13:25:12 +02:00
vbox_common.c maint: use hanging curly braces 2014-09-04 15:18:43 -06:00
vbox_common.h vbox: Rewrite vboxDomainScreenshot 2014-08-15 09:25:12 +02:00
vbox_driver.c vbox: Register per partes 2014-08-27 08:05:25 +02:00
vbox_driver.h vbox: Register per partes 2014-08-27 08:05:25 +02:00
vbox_glue.c Don't leave empty first line in C source files 2014-03-18 12:17:12 +01:00
vbox_glue.h Don't leave empty first line in C source files 2014-03-18 12:17:12 +01:00
vbox_install_api.h vbox: Begin to rewrite, vboxConnectOpen 2014-08-15 09:25:09 +02:00
vbox_MSCOMGlue.c Indent top-level labels by one space in src/vbox/ 2014-03-25 14:58:40 +01:00
vbox_MSCOMGlue.h Don't leave empty first line in C source files 2014-03-18 12:17:12 +01:00
vbox_snapshot_conf.c vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc' 2014-06-18 15:19:18 +02:00
vbox_snapshot_conf.h Add vbox_snapshot_conf struct 2014-06-10 15:07:36 +01:00
vbox_tmpl.c maint: use consistent if-else braces in lxc, vbox, phyp 2014-09-04 08:53:21 -06:00
vbox_uniformed_api.h vbox: Introducing vboxCommonDriver 2014-08-15 09:25:13 +02:00
vbox_V2_2.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V3_0.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V3_1.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V3_2.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_0.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_1.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_2_20.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_2.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_3_4.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_3.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_XPCOMCGlue.c Indent top-level labels by one space in src/vbox/ 2014-03-25 14:58:40 +01:00
vbox_XPCOMCGlue.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00

    Licensing

Note that much of the vbox in this directory is LGPLv2-only.  Thus, it
cannot be linked into any software that also wants to use GPLv3+ code.
This readme file is:

Copyright (C) 2009, 2013 Red Hat, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.  This file is offered as-is,
without warranty of any kind.

    Explanation about the how multi-version support
    for VirtualBox libvirt driver is implemented.

Since VirtualBox adds multiple new features for each release, it is but
natural that the C API which VirtualBox exposes is volatile across
versions and thus needs a good mechanism to handle multiple versions
during runtime. The solution was something like this:

Firstly the file structure is as below:

vbox_CAPI_v2_2.h
vbox_XPCOMCGlue.h
vbox_XPCOMCGlue.c
These files are C API/glue code files directly taken from the
VirtualBox OSE source and is needed for C API to work as expected.

vbox_driver.h
vbox_driver.c
These files have the main logic for registering the virtualbox driver
with libvirt.

vbox_V2_2.c
The file which has version dependent changes and includes the template
file for given below for all of its functionality.

vbox_tmpl.c
The file contains all version specified codes. It implements the
vboxUniformedAPI for each vbox version.

vbox_common.c
The file implement the common driver, with the uniformed api which
defined in vbox_uniformed_api.h and implemented in vbox_tmpl.c

Now there would be a vbox_V*.c file (for eg: vbox_V2_2.c for V2.2) for
each major virtualbox version which would do some preprocessor magic
and include the template file (vbox_tmpl.c) in it for the functionality
it offers.