External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-29 00:55:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
67e4c24ba1
libvirt/src/qemu
History
Michal Privoznik 67e4c24ba1 qemu_migration: Don't mangle NBD part of migration cookie 
In recent commit v6.8.0-135-g518be41aaa the formatting of NBD
into migration cookie was moved into a separate function and with
it it was switched from direct printing into the output buffer to
virXMLFormatElement(). But there was a typo. The
virXMLFormatElement() accepts two buffers on input, one for
element attributes and another for child elements. Well, the line
that was supposed to add NBD port into the attributes buffer
printed the attribute directly into the output buffer which
produced this mangled XML:

<qemu-migration>
   port='49153'<nbd>
    <disk target='vda' capacity='8589934592'/>
    <disk target='vdb' capacity='12746752000'/>
  </nbd>
</qemu-migration>

Changing the incriminated line to print into the attributes
buffer fixes the problem.

Fixes: 518be41aaa
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2020-10-26 13:08:57 +01:00
..
EVENTHANDLERS.txt
libvirt_qemu_probes.d meson: src: build libvirt_driver_qemu_impl.a static library 2020-08-03 09:27:04 +02:00
libvirtd_qemu.aug qemu: conf: Add configuration of TLS environment for NBD transport of pull-backups 2020-07-07 12:58:19 +02:00
meson.build qemu: Extract snapshot related code to a separate file 2020-08-24 16:42:29 +02:00
MIGRATION.txt
qemu_agent.c qemu: agent: fix array access 2020-10-20 15:53:52 +02:00
qemu_agent.h
qemu_alias.c conf, qemu, security, tests: introducing 'def->tpms' array 2020-06-23 17:27:50 +02:00
qemu_alias.h
qemu_backup.c qemu: block: Extract code for adding NBD exports to 'qemuBlockExportAddNBD' 2020-10-19 13:36:58 +02:00
qemu_backup.h qemu: backup: Rewrite backup bitmap handling to the new bitmap semantics 2020-06-22 16:04:30 +02:00
qemu_block.c Replace all instances of 'virHashCreate' with 'virHashNew' 2020-10-22 15:02:46 +02:00
qemu_block.h qemu: Add infrastructure for 'block-export-add' to export NBD 2020-10-19 13:36:58 +02:00
qemu_blockjob.c util: hash: Change type of hash table name/key to 'char' 2020-10-22 15:02:46 +02:00
qemu_blockjob.h qemu: blockjob: Remove 'disabledBitmapsBase' field from commit job private data 2020-06-22 16:04:31 +02:00
qemu_capabilities.c util: hash: Change type of hash table name/key to 'char' 2020-10-22 15:02:46 +02:00
qemu_capabilities.h qemu: add vhost-vdpa capability 2020-10-20 14:47:20 -04:00
qemu_capspriv.h qemu: Track default-ram-id machine attribute 2020-10-01 12:04:48 +02:00
qemu_cgroup.c qemu: use g_autoptr for virCgroup 2020-10-09 16:24:44 +02:00
qemu_cgroup.h
qemu_checkpoint.c util: hash: Change type of hash table name/key to 'char' 2020-10-22 15:02:46 +02:00
qemu_checkpoint.h qemu: checkpoint: Don't merge checkpoints during deletion 2020-06-22 16:04:30 +02:00
qemu_command.c qemu: fix potential resource leak 2020-10-23 18:39:20 -04:00
qemu_command.h qemu: stop passing -enable-fips to QEMU >= 5.2.0 2020-10-22 09:03:33 +02:00
qemu_conf.c qemu: use g_new0 2020-10-05 16:44:06 +02:00
qemu_conf.h lib: Prefer g_autoptr() declaration of virQEMUDriverConfigPtr 2020-09-07 10:47:54 +02:00
qemu_dbus.c qemu: pre-create the dbus directory in qemuStateInitialize 2020-07-22 09:40:15 +02:00
qemu_dbus.h qemu: pre-create the dbus directory in qemuStateInitialize 2020-07-22 09:40:15 +02:00
qemu_domain_address.c qemu: use g_new0 2020-10-05 16:44:06 +02:00
qemu_domain_address.h
qemu_domain.c qemu: Don't pass mode when opening domain log file for reading 2020-10-26 08:52:13 +01:00
qemu_domain.h util: hash: Change type of hash table name/key to 'char' 2020-10-22 15:02:46 +02:00
qemu_domainjob.c qemuProcessReconnect: clear 'oldjob' 2020-09-14 18:10:56 +02:00
qemu_domainjob.h qemuProcessReconnect: clear 'oldjob' 2020-09-14 18:10:56 +02:00
qemu_driver.c Replace all instances of 'virHashCreate' with 'virHashNew' 2020-10-22 15:02:46 +02:00
qemu_driver.h
qemu_extdevice.c conf, qemu, security, tests: introducing 'def->tpms' array 2020-06-23 17:27:50 +02:00
qemu_extdevice.h
qemu_firmware.c qemu: firmware: use g_new0 2020-10-05 16:44:06 +02:00
qemu_firmware.h
qemu_hostdev.c lib: Prefer g_autoptr() declaration of virQEMUDriverConfigPtr 2020-09-07 10:47:54 +02:00
qemu_hostdev.h
qemu_hotplug.c qemu: support hotplug of vdpa devices 2020-10-20 15:15:06 -04:00
qemu_hotplug.h src: add G_GNUC_NO_INLINE annotations for mocked symbols 2020-08-04 17:58:08 +01:00
qemu_interface.c qemu: add vdpa support 2020-10-20 14:48:02 -04:00
qemu_interface.h qemu: add vdpa support 2020-10-20 14:48:02 -04:00
qemu_interop_config.c util: hash: Remove virHashValueFree 2020-10-22 15:02:46 +02:00
qemu_interop_config.h
qemu_migration_cookie.c qemu_migration: Don't mangle NBD part of migration cookie 2020-10-26 13:08:57 +01:00
qemu_migration_cookie.h qemu: migration: Rename qemuMigrationEatCookie to qemuMigrationCookieParse 2020-10-01 10:01:05 +02:00
qemu_migration_params.c virBitmapNew: Don't check return value 2020-10-05 15:38:47 +02:00
qemu_migration_params.h qemu: Allow migration over UNIX socket 2020-09-05 07:55:45 +02:00
qemu_migration_paramspriv.h
qemu_migration.c qemu: Don't try to start NBD server twice 2020-10-26 13:08:47 +01:00
qemu_migration.h qemu: Allow NBD migration over UNIX socket 2020-09-04 10:20:49 +02:00
qemu_monitor_json.c qemu: combine conditionals 2020-10-23 18:39:30 -04:00
qemu_monitor_json.h qemu: add monitor functions for handling file descriptors 2020-10-20 15:14:37 -04:00
qemu_monitor_priv.h
qemu_monitor_text.c
qemu_monitor_text.h
qemu_monitor.c qemu: implement memory failure event 2020-10-23 09:42:00 +02:00
qemu_monitor.h qemu: implement memory failure event 2020-10-23 09:42:00 +02:00
qemu_namespace.c qemu: use g_new0 2020-10-05 16:44:06 +02:00
qemu_namespace.h qemuDomainBuildNamespace: Populate basic /dev from daemon's namespace 2020-08-03 19:40:36 +02:00
qemu_process.c qemu: implement memory failure event 2020-10-23 09:42:00 +02:00
qemu_process.h qemu: Prepare hostdev data which depends on the host state separately 2020-10-20 15:08:22 +02:00
qemu_processpriv.h
qemu_qapi.c Replace all instances of 'virHashCreate' with 'virHashNew' 2020-10-22 15:02:46 +02:00
qemu_qapi.h
qemu_saveimage.c qemu: use g_new0 2020-10-05 16:44:06 +02:00
qemu_saveimage.h qemu: Split of code related to handling of the save image file 2020-08-24 16:42:00 +02:00
qemu_security.c qemu: Separate out namespace handling code 2020-08-03 19:32:27 +02:00
qemu_security.h qemu_security: Complete renaming of virSecurityManagerSetAllLabel() argument 2020-07-10 14:21:35 +02:00
qemu_shim.c qemu: remove use of gettid() syscall 2020-08-07 13:51:16 +01:00
qemu_slirp.c virBitmapNew: Don't check return value 2020-10-05 15:38:47 +02:00
qemu_slirp.h
qemu_snapshot.c util: hash: Change type of hash table name/key to 'char' 2020-10-22 15:02:46 +02:00
qemu_snapshot.h qemu: snapshot: Introduce helpers for creating overlays on <transient/> disks 2020-10-01 09:55:02 +02:00
qemu_tpm.c conf, qemu, security, tests: introducing 'def->tpms' array 2020-06-23 17:27:50 +02:00
qemu_tpm.h
qemu_validate.c qemu: add vdpa support 2020-10-20 14:48:02 -04:00
qemu_validate.h
qemu_vhost_user_gpu.c
qemu_vhost_user_gpu.h
qemu_vhost_user.c qemu: use g_new0 2020-10-05 16:44:06 +02:00
qemu_vhost_user.h
qemu_virtiofs.c
qemu_virtiofs.h
qemu.conf qemu.conf: Re-word the description for *_tls_x509_verify 2020-10-09 10:18:45 +02:00
test_libvirtd_qemu.aug.in qemu: conf: Add configuration of TLS environment for NBD transport of pull-backups 2020-07-07 12:58:19 +02:00
THREADS.txt
virtqemud.init.in
virtqemud.service.in
virtqemud.sysconf