mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-17 15:17:17 +00:00

Libvirt provides a portable, long term stable C API for managing the virtualization technologies provided by many operating systems. It includes support for QEMU, KVM, Xen, LXC, bhyve, Virtuozzo, VMware vCenter and ESX, VMware Desktop, Hyper-V, VirtualBox and the POWER Hypervisor.

Go to file

Laine Stump 71345f91d7 util: fix erroneous requirement for phys_port_id to get ifname of a VF Commit `795e9e05c3` (libvirt-7.7.0) refactored the code in virpci.c and virnetdev.c that gathered lists of the Virtual Functions (VF) of an SRIOV Physical Function (PF) to simplify the code. Unfortunately the simplification made the assumption, in the new function virPCIGetVirtualFunctionsFull(), that a VF's netdev interface name should only be retrieved if the PF had a valid phys_port_id. That is an incorrect assumption - only a small handful of (now previous-generation) Mellanox SRIOV cards actually use phys_port_id (this is for an odd design where there are multiple physical network ports on a single PCI address); all other SRIOV cards (including new Mellanox cards) have a file in sysfs called phys_port_id, but it can't be read, and so the pfPhysPortID string is NULL. The result of this logic error is that virtual networks that are a pool of VFs to be used for macvtap connections will be unable to start, giving an errror like this: VF 0 of SRIOV PF enp130s0f0 couldn't be added to the interface pool because it isn't bound to a network driver - possibly in use elsewhere This error message is misinformed - the caller of virNetDevGetVirtualFunctionsFull() only thinks that the VF isn't bound to a network driver because it doesn't see a netdev name for the VF in the list. But that's only because virNetDevGetVirtualFunctionsFull() didn't even try to get the names! We do need a way for virPCIGetVirtualFunctionsFull() to sometimes retrieve the netdev names and sometimes not. One way of doing that would be to send down the netdev name of the PF whenever we also want to know the netdev names of the VFs, but send a NULL when we don't. This can conveniently be done by just replacing pfPhysPortID in the arglist with pfNetDevName - pfPhysPortID is determined by simply calling virNetDevGetPhysPortID(pfNetDevName) so we can just make that call down in virPCIGetVirtualFunctionsFull() (when needed). This solves the regression introduced by commit `795e9e05c3`, and also nicely sets us up to (in a subsequent commit) move the call to virNetDevGetPhysPortID() down one layer further to virPCIGetNetName(), where it really belongs! Resolves: https://bugzilla.redhat.com/2025432 Fixes: `795e9e05c3` Signed-off-by: Laine Stump <laine@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>		2021-12-06 13:04:28 -05:00
.ctags.d	maint: Add support for .ctags.d	2019-05-31 17:54:28 +02:00
.github/workflows	Switch to new GitHub repo-lockdown configuration	2021-10-20 14:27:20 +01:00
.gitlab/issue_templates	gitlab: Add disclaimer to the 'feature' issue template	2021-07-30 15:26:45 +02:00
build-aux	syntax-check: Fix regex for sc_require_attribute_cleanup_initialization	2021-11-05 15:00:53 +01:00
ci	ci: run a mingw64 job on stable Fedora	2021-11-23 16:44:18 +00:00
docs	conf: add TPM devices to domain capabilities	2021-12-01 12:14:03 +00:00
examples	lib: Drop needless one line labels	2021-11-22 12:39:59 +01:00
include	domain: add interface information to 'virDomainGetGuestInfo'	2021-11-05 13:38:40 +01:00
po	Translated using Weblate (Ukrainian)	2021-11-27 16:16:17 +01:00
scripts	scripts: Properly declare g_auto() stub for cocci	2021-11-03 14:46:54 +01:00
src	util: fix erroneous requirement for phys_port_id to get ifname of a VF	2021-12-06 13:04:28 -05:00
tests	lib: Use g_autoptr() for virDomainDef	2021-12-03 17:18:26 +01:00
tools	tools: fix iterating over argv when recovering xattr	2021-11-30 10:45:35 +00:00
.color_coded.in	gnulib: delete all gnulib integration	2020-02-07 15:03:54 +00:00
.ctags	ctags: Generate tags for headers, i.e. function prototypes	2018-09-18 14:21:33 +02:00
.dir-locals.el	build: avoid tabs that failed syntax-check	2012-09-06 09:43:46 -06:00
.editorconfig	Add .editorconfig	2019-09-06 12:47:46 +02:00
.gitignore	gitignore: Ignore __pycache__ directory	2021-03-22 12:05:11 +01:00
.gitlab-ci.yml	ci: display installed packages at start of build	2021-11-24 11:17:10 +00:00
.gitmodules	gnulib: delete all gnulib integration	2020-02-07 15:03:54 +00:00
.gitpublish	gitpublish: add a subject prefix	2020-01-16 13:04:11 +00:00
.mailmap	mailmap: consolidate my email addresses	2020-10-06 12:05:09 +02:00
.ycm_extra_conf.py.in	gnulib: delete all gnulib integration	2020-02-07 15:03:54 +00:00
AUTHORS.rst.in	AUTHORS: Add myself to the list of commiters	2021-07-14 14:51:19 +02:00
config.h	meson: Declare GLIB_VERSION_* macros at configure	2021-05-03 12:08:26 +02:00
configmake.h.in	meson: generate configmake.h	2020-08-03 09:26:48 +02:00
CONTRIBUTING.rst	meson: adjust our documentation to mention meson instead of autoconf	2020-08-03 09:27:09 +02:00
COPYING	maint: follow recommended practice for using LGPL	2013-05-20 14:15:21 -06:00
COPYING.LESSER	maint: Remove control characters from LGPL license file	2015-09-25 09:16:24 +02:00
gitdm.config	gitdm: add 'ibm' file	2019-10-18 17:32:52 +02:00
libvirt-admin.pc.in	Add libvirt-admin library	2015-06-16 13:46:20 +02:00
libvirt-lxc.pc.in	Add pkg-config files for libvirt-qemu & libvirt-lxc	2014-06-23 16:17:27 +01:00
libvirt-qemu.pc.in	Add pkg-config files for libvirt-qemu & libvirt-lxc	2014-06-23 16:17:27 +01:00
libvirt.pc.in	Add pkg-config files for libvirt-qemu & libvirt-lxc	2014-06-23 16:17:27 +01:00
libvirt.spec.in	spec: Explicitly provide locations for QEMU data	2021-11-18 15:49:02 +01:00
meson_options.txt	meson: Introduce qemu_datadir option	2021-11-18 15:48:59 +01:00
meson.build	meson: Improve network driver enablement logic	2021-12-06 11:13:51 +01:00
mingw-libvirt.spec.in	rpm: fix mingw obsoletes lines	2021-08-02 13:47:20 +01:00
NEWS.rst	Post-release version bump to 8.0.0	2021-12-01 10:53:20 +01:00
README.rst	README: drop Travis CI badge	2020-08-03 15:08:28 +02:00
run.in	run: detect daemons when run via wrapper commands	2021-12-01 12:14:03 +00:00

README.rst

Libvirt API for virtualization

For some of these hypervisors, it provides a stateful management daemon which runs on the virtualization host allowing access to the API both by non-privileged local users and remote users.

Layered packages provide bindings of the libvirt C API into other languages including Python, Perl, PHP, Go, Java, OCaml, as well as mappings into object systems such as GObject, CIM and SNMP.

Further information about the libvirt project can be found on the website:

https://libvirt.org

License

The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General Public License, version 2.0 (or later). See the files COPYING.LESSER and COPYING for full license terms & conditions.

Installation

Instructions on building and installing libvirt can be found on the website:

https://libvirt.org/compiling.html

Contributing

The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website:

https://libvirt.org/contribute.html

Contact

The libvirt project has two primary mailing lists:

libvirt-users@redhat.com (for user discussions)
libvir-list@redhat.com (for development only)

Further details on contacting the project are available on the website:

https://libvirt.org/contact.html