mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-03 11:35:19 +00:00
6e7e965dcd
The URI parser used by libvirt does not populate uri->path if the trailing slash is missing. The code virStorageSourceParseBackingURI would then not populate src->path. As only NBD network disks are allowed to have the 'name' field in the XML defining the disk source omitted we'd generate an invalid XML which we'd not parse again. Fix it by populating src->path with an empty string if the uri is lacking slash. As pointed out above NBD is special in this case since we actually allow it being NULL. The URI path is used as export name. Since an empty export does not make sense the new approach clears the src->path if the trailing slash is present but nothing else. Add test cases now to cover all the various cases for NBD and non-NBD uris as there was to time only 1 test abusing the quirk witout slash for NBD and all other URIs contained the slash or in case of NBD also the export name. Signed-off-by: Peter Krempa <pkrempa@redhat.com> |
||
|---|---|---|
| .. | ||
| access | ||
| admin | ||
| bhyve | ||
| conf | ||
| cpu | ||
| cpu_map | ||
| esx | ||
| hyperv | ||
| interface | ||
| keycodemapdb@16e5b07876 | ||
| libxl | ||
| locking | ||
| logging | ||
| lxc | ||
| network | ||
| node_device | ||
| nwfilter | ||
| openvz | ||
| phyp | ||
| qemu | ||
| remote | ||
| rpc | ||
| secret | ||
| security | ||
| storage | ||
| test | ||
| uml | ||
| util | ||
| vbox | ||
| vmware | ||
| vmx | ||
| vz | ||
| xenapi | ||
| xenconfig | ||
| admin_protocol-structs | ||
| check-aclperms.pl | ||
| check-aclrules.pl | ||
| check-driverimpls.pl | ||
| check-drivername.pl | ||
| check-symfile.pl | ||
| check-symsorting.pl | ||
| datatypes.c | ||
| datatypes.h | ||
| driver-hypervisor.h | ||
| driver-interface.h | ||
| driver-network.h | ||
| driver-nodedev.h | ||
| driver-nwfilter.h | ||
| driver-secret.h | ||
| driver-state.h | ||
| driver-storage.h | ||
| driver-stream.h | ||
| driver.c | ||
| driver.h | ||
| dtrace2systemtap.pl | ||
| internal.h | ||
| libvirt_admin_private.syms | ||
| libvirt_admin_public.syms | ||
| libvirt_atomic.syms | ||
| libvirt_driver_modules.syms | ||
| libvirt_esx.syms | ||
| libvirt_internal.h | ||
| libvirt_libssh2.syms | ||
| libvirt_libssh.syms | ||
| libvirt_linux.syms | ||
| libvirt_lxc.syms | ||
| libvirt_openvz.syms | ||
| libvirt_private.syms | ||
| libvirt_probes.d | ||
| libvirt_public.syms | ||
| libvirt_qemu_probes.d | ||
| libvirt_qemu.syms | ||
| libvirt_remote.syms | ||
| libvirt_sasl.syms | ||
| libvirt_vmware.syms | ||
| libvirt_vmx.syms | ||
| libvirt_xenconfig.syms | ||
| libvirt-admin.c | ||
| libvirt-admin.conf | ||
| libvirt-domain-snapshot.c | ||
| libvirt-domain.c | ||
| libvirt-host.c | ||
| libvirt-interface.c | ||
| libvirt-lxc.c | ||
| libvirt-lxc.pc.in | ||
| libvirt-network.c | ||
| libvirt-nodedev.c | ||
| libvirt-nwfilter.c | ||
| libvirt-qemu.c | ||
| libvirt-qemu.pc.in | ||
| libvirt-secret.c | ||
| libvirt-storage.c | ||
| libvirt-stream.c | ||
| libvirt.c | ||
| libvirt.conf | ||
| libvirt.pc.in | ||
| lock_protocol-structs | ||
| lxc_monitor_protocol-structs | ||
| lxc_protocol-structs | ||
| Makefile.am | ||
| qemu_protocol-structs | ||
| README | ||
| remote_protocol-structs | ||
| virkeepaliveprotocol-structs | ||
| virnetprotocol-structs | ||
libvirt library code README
===========================
The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.
The files directly in this directory are supporting the public API
entry points & data structures.
There are two core shared modules to be aware of:
* util/ - a collection of shared APIs that can be used by any
code. This directory is always in the include path
for all things built
* conf/ - APIs for parsing / manipulating all the official XML
files used by the public API. This directory is only
in the include path for driver implementation modules
* vmx/ - VMware VMX config handling (used by esx/ and vmware/)
Then there are the hypervisor implementations:
* bhyve - bhyve - The BSD Hypervisor
* esx/ - VMware ESX and GSX support using vSphere API over SOAP
* hyperv/ - Microsoft Hyper-V support using WinRM
* lxc/ - Linux Native Containers
* openvz/ - OpenVZ containers using cli tools
* phyp/ - IBM Power Hypervisor using CLI tools over SSH
* qemu/ - QEMU / KVM using qemu CLI/monitor
* remote/ - Generic libvirt native RPC client
* test/ - A "mock" driver for testing
* uml/ - User Mode Linux
* vbox/ - Virtual Box using native API
* vmware/ - VMware Workstation and Player using the vmrun tool
* xen/ - Xen using hypercalls, XenD SEXPR & XenStore
* xenapi/ - Xen using libxenserver
Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly
* cpu/ - CPU feature management
* interface/ - Host network interface management
* network/ - Virtual NAT networking
* nwfilter/ - Network traffic filtering rules
* node_device/ - Host device enumeration
* secret/ - Secret management
* security/ - Mandatory access control drivers
* storage/ - Storage management drivers
Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories