mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 22:25:25 +00:00
97af511b1a
The function 'xmlSaveFormatFileEnc' has a last option to set if you want to format dumped xml with whitespaces or not. Older libxml2, the one used in RHEL6, take this option as it is but newer libxml2 check this option if it's true or not. This small difference somehow makes things messy on RHEL6 and generated xml had extra new line and extra whitespaces. We should pass 1 instead if -1 because the -1 confuses the libxml2. Signed-off-by: Pavel Hrdina <phrdina@redhat.com> |
||
---|---|---|
.. | ||
README | ||
vbox_CAPI_v2_2.h | ||
vbox_CAPI_v3_0.h | ||
vbox_CAPI_v3_1.h | ||
vbox_CAPI_v3_2.h | ||
vbox_CAPI_v4_0.h | ||
vbox_CAPI_v4_1.h | ||
vbox_CAPI_v4_2_20.h | ||
vbox_CAPI_v4_2.h | ||
vbox_CAPI_v4_3_4.h | ||
vbox_CAPI_v4_3.h | ||
vbox_driver.c | ||
vbox_driver.h | ||
vbox_glue.c | ||
vbox_glue.h | ||
vbox_MSCOMGlue.c | ||
vbox_MSCOMGlue.h | ||
vbox_snapshot_conf.c | ||
vbox_snapshot_conf.h | ||
vbox_tmpl.c | ||
vbox_V2_2.c | ||
vbox_V3_0.c | ||
vbox_V3_1.c | ||
vbox_V3_2.c | ||
vbox_V4_0.c | ||
vbox_V4_1.c | ||
vbox_V4_2_20.c | ||
vbox_V4_2.c | ||
vbox_V4_3_4.c | ||
vbox_V4_3.c | ||
vbox_XPCOMCGlue.c | ||
vbox_XPCOMCGlue.h |
Licensing Note that much of the vbox in this directory is LGPLv2-only. Thus, it cannot be linked into any software that also wants to use GPLv3+ code. This readme file is: Copyright (C) 2009, 2013 Red Hat, Inc. Copying and distribution of this file, with or without modification, are permitted in any medium without royalty provided the copyright notice and this notice are preserved. This file is offered as-is, without warranty of any kind. Explanation about the how multi-version support for VirtualBox libvirt driver is implemented. Since VirtualBox adds multiple new features for each release, it is but natural that the C API which VirtualBox exposes is volatile across versions and thus needs a good mechanism to handle multiple versions during runtime. The solution was something like this: Firstly the file structure is as below: vbox_CAPI_v2_2.h vbox_XPCOMCGlue.h vbox_XPCOMCGlue.c These files are C API/glue code files directly taken from the VirtualBox OSE source and is needed for C API to work as expected. vbox_driver.h vbox_driver.c These files have the main logic for registering the virtualbox driver with libvirt. vbox_V2_2.c The file which has version dependent changes and includes the template file for given below for all of its functionality. vbox_tmpl.c The file where all the real driver implementation code exists. Now there would be a vbox_V*.c file (for eg: vbox_V2_2.c for V2.2) for each major virtualbox version which would do some preprocessor magic and include the template file (vbox_tmpl.c) in it for the functionality it offers.