mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-24 06:35:24 +00:00
4a86c2bb4b
Laszlo Ersek pointed out that in trying to convert a long to an unsigned int, we used: long long_val = ...; if ((unsigned int)long_val == long_val) According to C99 integer promotion rules, the if statement is equivalent to: (unsigned long)(unsigned int)long_val == (unsigned long)long_val since you get an unsigned comparison if at least one side is unsigned, using the largest rank of the two sides; but on 32-bit platforms, where unsigned long and unsigned int are the same size, this comparison is always true and ends up converting negative long_val into posigive unsigned int values, rather than rejecting the negative value as we had originally intended (python longs are unbounded size, and we don't want to do silent modulo arithmetic when converting to C code). Fix this by using direct comparisons, rather than casting. * python/typewrappers.c (libvirt_intUnwrap, libvirt_uintUnwrap) (libvirt_ulongUnwrap, libvirt_ulonglongUnwrap): Fix conversion checks. |
||
---|---|---|
.. | ||
tests | ||
generator.py | ||
libvirt-override-api.xml | ||
libvirt-override-virConnect.py | ||
libvirt-override-virStream.py | ||
libvirt-override.c | ||
libvirt-override.py | ||
libvirt-qemu-override-api.xml | ||
libvirt-qemu-override.c | ||
Makefile.am | ||
README | ||
TODO | ||
typewrappers.c | ||
typewrappers.h |
libvirt Python Bindings README ============================== Most of the libvirt python binding code is automatically generated using the script generator.py, and the API description from docs/libvirt-api.xml Manually written files: - libvirt-override.c: methods where the C binding needs to be hand crafted - libvirt-override.py: global methods where the C and python bindings have different args - libvirt-override-api.xml: methods where the auto-extracted API docs are not suitable for python auto-generator. Overriding this if the method is going into libvirt-override.c, but we still want auto-generated libvirt-override.py - libvirt-override-virConnect.py: virConnect class methods - typewrappers.h,.c: Python object wrappers for each libvirt C object Auto-generated files: - libvirt.py: The main python binding. Comprises auto-generated code, along with contents from libvirt-override.py and libvirt-override-virConnect.py - libvirt.c, libvirt.h: The C glue layer for the python binding. Comprises auto-generated code, along with libvirt-override.c - libvirt-export.c: List of auto-generated C methods, included into the libvirt-override.c method table