libvirt/src
Daniel P. Berrange b044210ed2 Fix race condition reconnecting to vms & loading configs
The following sequence

 1. Define a persistent QMEU guest
 2. Start the QEMU guest
 3. Stop libvirtd
 4. Kill the QEMU process
 5. Start libvirtd
 6. List persistent guests

At the last step, the previously running persistent guest
will be missing. This is because of a race condition in the
QEMU driver startup code. It does

 1. Load all VM state files
 2. Spawn thread to reconnect to each VM
 3. Load all VM config files

Only at the end of step 3, does the 'virDomainObjPtr' get
marked as "persistent". There is therefore a window where
the thread reconnecting to the VM will remove the persistent
VM from the list.

The easy fix is to simply switch the order of steps 2 & 3.

In addition to this though, we must only attempt to reconnect
to a VM which had a non-zero PID loaded from its state file.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit f26701f565)
2013-11-06 11:45:03 -05:00
..
access Add support for using 3-arg pkcheck syntax for process (CVE-2013-4311) 2013-09-18 15:13:42 +01:00
conf Don't update dom->persistent without lock held 2013-11-06 11:44:49 -05:00
cpu cpu: add function to get the models for an arch 2013-09-23 15:50:30 -06:00
esx Stop calling virAllocN directly from ESX code 2013-09-05 12:00:07 +01:00
hyperv Convert 'int i' to 'size_t i' in src/hyperv/ files 2013-07-10 17:55:16 +01:00
interface netcf driver: use a single netcf handle for all connections 2013-09-12 07:33:24 -04:00
libxl libxl: Compile regular expression where it is used 2013-09-05 10:55:17 -06:00
locking Remove (nearly) all use of getuid()/getgid() 2013-10-29 16:19:00 +00:00
lxc Remove (nearly) all use of getuid()/getgid() 2013-10-29 16:19:00 +00:00
network bridge driver: don't masquerade local subnet broadcast/multicast packets 2013-09-25 08:31:50 -04:00
node_device Stop free'ing 'const char *' strings 2013-09-05 11:28:01 +01:00
nwfilter Remove use of virConnectPtr from all remaining nwfilter code 2013-10-07 09:57:12 -04:00
openvz cleanup: Kill usage of access(PATH, F_OK) in favor of virFileExists() 2013-09-16 10:37:39 +02:00
parallels cleanup: Kill usage of access(PATH, F_OK) in favor of virFileExists() 2013-09-16 10:37:39 +02:00
phyp Convert 'int i' to 'size_t i' in src/phyp/ files 2013-07-10 17:55:15 +01:00
qemu Fix race condition reconnecting to vms & loading configs 2013-11-06 11:45:03 -05:00
remote Remove (nearly) all use of getuid()/getgid() 2013-10-29 16:19:00 +00:00
rpc Remove all direct use of getenv 2013-10-29 16:13:03 +00:00
secret Convert 'int i' to 'size_t i' in src/secret/ files 2013-07-10 17:40:14 +01:00
security AppArmorSetSecurityImageLabel: Avoid use of uninitialized variable 2013-09-04 08:47:00 +02:00
storage Remove (nearly) all use of getuid()/getgid() 2013-10-29 16:19:00 +00:00
test test: Allow specifying object runstate in driver XML 2013-09-25 13:30:36 -04:00
uml Remove use of virConnectPtr from all remaining nwfilter code 2013-10-07 09:57:12 -04:00
util Remove (nearly) all use of getuid()/getgid() 2013-10-29 16:19:00 +00:00
vbox Remove (nearly) all use of getuid()/getgid() 2013-10-29 16:19:00 +00:00
vmware Remove tab from previous commit 2013-09-30 00:09:59 +08:00
vmx Add missing check for OOM with virVMXEscapeHexPipe 2013-09-25 18:12:09 +01:00
xen Fix handling of OOM when getting Xen dom ID 2013-09-25 18:12:08 +01:00
xenapi Convert 'int i' to 'size_t i' in src/{xen,xenapi,xenxs} files 2013-07-10 17:40:13 +01:00
xenxs Fix double free of hostdev on OOM in xenParseSxprPCI 2013-09-25 18:12:08 +01:00
check-aclperms.pl Fix naming of permission for detecting storage pools 2013-09-12 17:20:07 +01:00
check-aclrules.pl
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c Fix crash if OOM occurs when creating virConnectPtr 2013-09-24 10:51:28 +01:00
datatypes.h
driver.c Remove all direct use of getenv 2013-10-29 16:13:03 +00:00
driver.h libvirt: add new public API virConnectGetCPUModelNames 2013-09-23 15:41:50 -06:00
dtrace2systemtap.pl
fdstream.c Always open files in binary mode in virFDStreamOpenFileInternal 2013-09-24 14:27:41 +02:00
fdstream.h
gnutls_1_0_compat.h
internal.h
libvirt_atomic.syms
libvirt_daemon.syms
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms Make virCommand env handling robust in setuid env 2013-10-29 16:10:47 +00:00
libvirt_probes.d
libvirt_public.syms libvirt: add new public API virConnectGetCPUModelNames 2013-09-23 15:41:50 -06:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_sasl.syms
libvirt_vmware.syms VMware: Make version parsing testable and add tests 2013-09-20 08:23:31 -05:00
libvirt_vmx.syms VMX: Create virVMXFormatDisk() from HD and CD-ROM 2013-09-01 23:11:50 -05:00
libvirt_xenxs.syms
libvirt-lxc.c Ensure LXC/QEMU APIs set the filename for errors 2013-08-02 15:32:26 +01:00
libvirt-qemu.c Ensure LXC/QEMU APIs set the filename for errors 2013-08-02 15:32:26 +01:00
libvirt.c Block all use of libvirt.so in setuid programs 2013-10-29 16:19:50 +00:00
libvirt.conf
lock_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_monitor_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_protocol-structs
Makefile.am build: fix linking virt-login-shell 2013-10-23 09:01:27 +01:00
nodeinfo.c virBitmapParse: Fix behavior in case of error and fix up callers 2013-08-22 11:38:36 +02:00
nodeinfo.h
qemu_protocol-structs
README
remote_protocol-structs virConnectGetCPUModelNames: implement the remote protocol 2013-09-23 15:50:35 -06:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories