Eric Blake b43efdaa13 maint: avoid 'const fooPtr' in hashes ...

'const fooPtr' is the same as 'foo * const' (the pointer won't
change, but it's contents can).  But in general, if an interface
is trying to be const-correct, it should be using 'const foo *'
(the pointer is to data that can't be changed).

Fix up virhash to provide a const-correct interface: all actions
that don't modify the table take a const table.  Note that in
one case (virHashSearch), we actually strip const away - we aren't
modifying the contents of the table, so much as associated data
for ensuring that the code uses the table correctly (if this were
C++, it would be a case for the 'mutable' keyword).

* src/util/virhash.h (virHashKeyComparator, virHashEqual): Use
intended type.
(virHashSize, virHashTableSize, virHashLookup, virHashSearch):
Make const-correct.
* src/util/virhash.c (virHashEqualData, virHashEqual)
(virHashLookup, virHashSize, virHashTableSize, virHashSearch)
(virHashComputeKey): Fix fallout.
* src/conf/nwfilter_params.c
(virNWFilterFormatParameterNameSorter): Likewise.
* src/nwfilter/nwfilter_ebiptables_driver.c
(ebiptablesFilterOrderSort): Likewise.
* tests/virhashtest.c (testHashGetItemsCompKey)
(testHashGetItemsCompValue): Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>

2013-10-14 11:40:24 -06:00

..

capabilityschemadata

qemu: Implement CPUs check against machine type's cpu-max

2013-07-01 14:30:42 +02:00

commanddata

build: clean up stray files found by 'make distcheck'

2013-05-06 14:01:08 -06:00

confdata

…

cputestdata

cpu: Add cpu test cases for PPC CPU driver.

2013-09-05 12:31:10 +01:00

domainschemadata

Add XML config for resource partitions

2013-04-15 17:35:31 +01:00

domainsnapshotxml2xmlin

…

domainsnapshotxml2xmlout

qemu: auto-add pci-root controller for pc machine types

2013-04-25 13:05:10 +02:00

fchostdata/fc_host

tests: Add tests for fc_host

2013-05-13 17:24:18 +08:00

interfaceschemadata

…

lxcxml2xmldata

LXC: Fix handling of RAM filesystem size units

2013-10-09 17:44:45 +02:00

lxcxml2xmloutdata

LXC: Fix handling of RAM filesystem size units

2013-10-09 17:44:45 +02:00

networkxml2confdata

Add forwarder attribute to <dns/> element

2013-09-17 17:47:33 -06:00

networkxml2xmlin

Add forwarder attribute to <dns/> element

2013-09-17 17:47:33 -06:00

networkxml2xmlout

Add forwarder attribute to <dns/> element

2013-09-17 17:47:33 -06:00

networkxml2xmlupdatein

Test network update XML parsing

2013-08-28 08:05:46 +02:00

networkxml2xmlupdateout

Test network update XML parsing

2013-08-28 08:05:46 +02:00

nodedevschemadata

nodedev: add iommuGroup to node device object

2013-06-26 14:10:56 -04:00

nodeinfodata

…

nwfilterxml2xmlin

…

nwfilterxml2xmlout

…

qemucapabilitiesdata

qemucapabilitiesdata: Add qemu-1.6.50 data

2013-10-03 15:52:06 +02:00

qemuhelpdata

qemu: Support setting the 'removable' flag for USB disks

2013-09-02 14:45:38 +02:00

qemuhotplugtestdata

qemuhotplugtest: Add tests for virtio SCSI disk hotplug

2013-08-26 16:09:56 +02:00

qemuxml2argvdata

tests: Add qemu test for multiple timers

2013-10-08 17:41:51 -04:00

qemuxml2xmloutdata

Add pcihole64 element to root PCI controllers

2013-08-27 17:42:29 +02:00

qemuxmlnsdata

qemu: Set QEMU_AUDIO_DRV=none with -nographic

2013-09-02 16:53:39 -04:00

securityselinuxlabeldata

selinux: enhance test to cover nfs label failure

2013-08-20 10:46:58 -06:00

sexpr2xmldata

…

storagepoolschemadata

schema: require target path in storage pool xml

2013-05-17 08:33:22 +02:00

storagepoolxml2xmlin

Make logical pools independent on target path

2013-07-16 12:16:37 +02:00

storagepoolxml2xmlout

Make logical pools independent on target path

2013-07-16 12:16:37 +02:00

storagevolschemadata

schema: make source optional in volume XML

2013-05-17 08:35:08 +02:00

storagevolxml2argvdata

Always specify qcow2 compat level on qemu-img command line

2013-08-27 12:45:58 +02:00

storagevolxml2xmlin

Move volume XMLs out of storagevolxml2argvdata

2013-07-25 13:26:41 +02:00

storagevolxml2xmlout

Move volume XMLs out of storagevolxml2argvdata

2013-07-25 13:26:41 +02:00

sysinfodata

Implement minimal sysinfo for ARM platforms

2013-04-04 11:07:31 +01:00

vmwareverdata

VMware: Add Fusion version test

2013-09-30 16:58:37 -05:00

vmx2xmldata

VMX: Add a VMWare Fusion 5 configuration for tests

2013-09-17 14:10:41 -05:00

xencapsdata

…

xmconfigdata

…

xml2sexprdata

…

xml2vmxdata

VMX: Add a VMWare Fusion 5 configuration for tests

2013-09-17 14:10:41 -05:00

.valgrind.supp

valgrind: Adjust filter for _dl_allocate_tls

2013-08-01 17:04:28 -04:00

capabilityschematest

…

commandhelper.c

testutils: Resolve Coverity issues

2013-07-11 14:18:11 -04:00

commandtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

cpuset

virBitmapParse: Fix behavior in case of error and fix up callers

2013-08-22 11:38:36 +02:00

cputest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

define-dev-segfault

…

domainschematest

LXC: Fix handling of RAM filesystem size units

2013-10-09 17:44:45 +02:00

domainsnapshotschematest

…

domainsnapshotxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

esxutilstest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

eventtest.c

Convert 'int i' to 'size_t i' in tests/ files

2013-07-10 17:40:13 +01:00

fchosttest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

fdstreamtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

int-overflow

…

interfaceschematest

…

interfacexml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

jsontest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

libvirtd-fail

…

libvirtd-pool

…

libvirtdconftest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

lxcxml2xmltest.c

LXC: Fix handling of RAM filesystem size units

2013-10-09 17:44:45 +02:00

Makefile.am

Fix flaw in detecting log format

2013-10-14 10:31:01 +01:00

metadatatest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

networkschematest

…

networkxml2conftest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

networkxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

networkxml2xmlupdatetest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

nodedevschematest

…

nodedevxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

nodeinfotest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

nwfilterschematest

…

nwfilterxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

object-locking.ml

Rename 'DeviceMonitor' to 'NodeDeviceDriver'

2013-04-24 10:59:53 +01:00

oomtrace.pl

…

openvzutilstest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

openvzutilstest.conf

…

pkix_asn1_tab.c

…

qemuagenttest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemuargv2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemucapabilitiestest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemuhelptest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemuhotplugtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemumonitorjsontest.c

qemumonitorjsontest: Test qemuMonitorJSONSendKey

2013-10-11 10:24:48 +02:00

qemumonitortest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemumonitortestutils.c

qemuMonitorTestFree: Join worker thread

2013-10-03 15:26:09 +02:00

qemumonitortestutils.h

tests: Learn qemuMonitorTestNew optional greeting

2013-10-01 10:48:47 +02:00

qemuxml2argvtest.c

qemu: Prefer VFIO for PCI device passthrough

2013-10-10 12:00:56 +02:00

qemuxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

qemuxmlnstest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

read-bufsiz

…

read-non-seekable

…

reconnect.c

test: Refactor setting of dummy error handlers

2013-09-17 16:45:53 +02:00

schematestutils.sh

tests: skip schema validation tests if xmllint is missing

2013-08-23 15:23:44 -06:00

seclabeltest.c

tests: uniformly report test failures

2013-02-25 17:38:11 -07:00

securityselinuxhelper.c

tests: avoid compile failure on linux kernels older than 2.6.19

2013-10-07 08:40:30 -06:00

securityselinuxlabeltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

securityselinuxtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

sexpr2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

shunloadhelper.c

shunloadtest: Resolve Coverity CHECKED_RETURN error

2013-05-21 09:22:21 -04:00

shunloadtest.c

build: fix shunloadtest breakage

2013-07-29 13:09:39 -06:00

sockettest.c

virsocket: Introduce virSocketAddrIsWildcard

2013-10-11 11:05:06 +02:00

ssh.c

build: fix shunloadtest breakage

2013-07-29 13:09:39 -06:00

start

…

statstest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

storagebackendsheepdogtest.c

Build breaker - requires VIR_FROM_THIS

2013-05-10 08:52:43 -04:00

storagepoolschematest

schema: require target path in storage pool xml

2013-05-17 08:33:22 +02:00

storagepoolxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

storagevolschematest

schema: make source optional in volume XML

2013-05-17 08:35:08 +02:00

storagevolxml2argvtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

storagevolxml2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

sysinfotest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

test_conf.c

viralloc: Report OOM error on failure

2013-07-10 11:07:31 +02:00

test_conf.sh

rename tests/conftest.c

2013-03-19 13:13:28 -06:00

test-lib.sh

test-lib: Make case skipping possible

2013-09-13 10:25:56 +02:00

testutils.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

testutils.h

Remove test case average timing

2013-10-08 12:39:30 +01:00

testutilslxc.c

virCaps: get rid of defaultConsoleTargetType callback

2013-04-04 22:42:39 +02:00

testutilslxc.h

…

testutilsqemu.c

qemu: Don't add default memballoon device on ARM

2013-09-02 16:53:39 -04:00

testutilsqemu.h

build: skip qemu in tests when !WITH_QEMU

2013-05-31 11:35:34 -06:00

testutilsxen.c

virCaps: get rid of defaultConsoleTargetType callback

2013-04-04 22:42:39 +02:00

testutilsxen.h

virCaps: get rid of defaultConsoleTargetType callback

2013-04-04 22:42:39 +02:00

utiltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

vcpupin

…

viratomictest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virauthconfigtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virbitmaptest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virbuftest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

vircgroupmock.c

Fix launching of VMs on when only logind part of systemd is present

2013-09-12 11:32:36 +01:00

vircgrouptest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virdbustest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virdrivermoduletest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virendiantest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virhashdata.h

…

virhashtest.c

maint: avoid 'const fooPtr' in hashes

2013-10-14 11:40:24 -06:00

viridentitytest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virkeycodetest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virkeyfiletest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virlockspacetest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virlogtest.c

Fix flaw in detecting log format

2013-10-14 10:31:01 +01:00

virnetmessagetest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virnetserverclientmock.c

Add test case for virNetServerClient object identity code

2013-09-24 09:37:26 +01:00

virnetserverclienttest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virnetsockettest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virnettlscontexttest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virnettlshelpers.c

Fix parallel runs of TLS test suites

2013-08-09 11:54:41 +01:00

virnettlshelpers.h

Fix parallel runs of TLS test suites

2013-08-09 11:54:41 +01:00

virnettlssessiontest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virportallocatortest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virsh-all

tests: Skip virsh-all test as expensive

2013-08-12 18:47:56 +02:00

virsh-optparse

…

virsh-schedinfo

Allow multiple parameters for schedinfo

2013-04-03 08:49:30 +02:00

virsh-synopsis

…

virsh-undefine

…

virsh-uriprecedence

tests: Don't test user config file if ran as root

2013-09-13 10:25:56 +02:00

virshtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virstoragetest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virstringtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virsystemdmock.c

Add checking of dbus_message_iter_append_basic return value

2013-09-20 12:38:24 +01:00

virsystemdtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

virt-aa-helper-test

add vnc unix sockets to apparmor policy

2012-12-11 14:32:39 -07:00

virtimetest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

viruritest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

vmwarevertest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

vmx2xmltest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

xencapstest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

xmconfigtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

xml2sexprtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00

xml2vmxtest.c

Remove test case average timing

2013-10-08 12:39:30 +01:00