libvirt/src
Dmitrii Shcherbakov 09cdd16a9b Ignore EPERM on implicit clearing of VF VLAN ID
SmartNIC DPUs may not expose some privileged eswitch operations
to the hypervisor hosts. For example, this happens with Bluefield
devices running in the ECPF (default) mode for security reasons. While
VF MAC address programming is possible via an RTM_SETLINK operation,
trying to set a VLAN ID in the same operation will fail with EPERM.

The equivalent ip link commands below provide an illustration:

1. This works:

sudo ip link set enp130s0f0 vf 2 mac de:ad:be:ef:ca:fe

2. Setting (or clearing) a VLAN fails with EPERM:

sudo ip link set enp130s0f0 vf 2 vlan 0
RTNETLINK answers: Operation not permitted

3. This is what Libvirt attempts to do today (when trying to clear a
   VF VLAN at the same time as programming a VF MAC).

sudo ip link set enp130s0f0 vf 2 vlan 0 mac de:ad:be:ef:ca:fe
RTNETLINK answers: Operation not permitted

If setting an explicit VLAN ID results in an EPERM, clearing a VLAN
(setting a VLAN ID to 0) can be handled gracefully by ignoring the
EPERM error with the rationale being that if we cannot set this state
in the first place, we cannot clear it either.

In order to keep explicit clearing of VLAN ID working as it used to
be passing a NULL pointer for VLAN ID is used.

Signed-off-by: Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2022-02-03 16:52:05 +01:00
..
access
admin util: Check for errors in virLogSetFromEnv 2022-01-05 14:08:40 +01:00
bhyve virParseVersionString: rename to virStringParseVersion 2022-02-03 14:10:03 +01:00
ch ch: virCHProcessSetupIOThreads: use correct type for return value 2022-02-03 14:15:04 +01:00
conf conf: support firmware ISA debug console 2022-02-03 10:59:03 +00:00
cpu lib: Almost eliminate use of virTristateBoolTypeFromString() 2022-01-21 16:42:13 +01:00
cpu_map
esx maint: remove unnecessary virutil.h includes 2022-02-03 14:10:04 +01:00
hyperv src: Use g_steal_pointer() more 2022-02-01 19:01:49 +01:00
hypervisor Allow VF vlanid to be passed as a pointer 2022-02-03 16:52:05 +01:00
interface meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
keycodemapdb@27acf0ef82
libxl meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
locking remove sysconfig files 2022-01-17 18:20:59 +01:00
logging remove sysconfig files 2022-01-17 18:20:59 +01:00
lxc virParseVersionString: rename to virStringParseVersion 2022-02-03 14:10:03 +01:00
network meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
node_device meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
nwfilter maint: remove unnecessary virutil.h includes 2022-02-03 14:10:04 +01:00
openvz maint: remove unnecessary virutil.h includes 2022-02-03 14:10:04 +01:00
qemu qemu: virtiofs: check whether the supplied binary exists 2022-02-03 14:15:04 +01:00
remote meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
rpc lib: Drop '&*' from '&*variable' 2022-01-31 13:47:46 +01:00
secret meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
security conf: Convert virDomainHostdevDefParseXMLSubsys() to virXMLProp*() 2022-01-21 16:42:14 +01:00
storage meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
storage_file storage_file: Declare virStorageSourceParseRBDColonString only in one header 2022-01-17 09:53:44 +01:00
test virnodedeviceobj: Don't unlock virNodeDeviceObj in virNodeDeviceObjListRemove() 2022-02-03 09:37:44 +01:00
util Ignore EPERM on implicit clearing of VF VLAN ID 2022-02-03 16:52:05 +01:00
vbox virParseVersionString: rename to virStringParseVersion 2022-02-03 14:10:03 +01:00
vmware maint: remove unnecessary virutil.h includes 2022-02-03 14:10:04 +01:00
vmx lib: Use g_autoptr() for virDomainDef 2021-12-03 17:18:26 +01:00
vz virParseVersionString: rename to virStringParseVersion 2022-02-03 14:10:03 +01:00
admin_protocol-structs
datatypes.c
datatypes.h
driver-hypervisor.h libvirt: Introduce virDomainSetLaunchSecurityState public API 2022-01-04 10:56:00 -07:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h
driver.c qemu: Remove unnecessary variables and labels 2021-11-23 18:14:01 +01:00
driver.h
internal.h internal: Add CONCAT macro 2022-02-01 17:19:05 +01:00
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_logging.syms logging: Build log manager only when RPC is available 2021-12-15 12:12:44 +01:00
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms Set VF MAC and VLAN ID in two different operations 2022-02-03 16:52:05 +01:00
libvirt_probes.d
libvirt_public.syms libvirt: Introduce virDomainSetLaunchSecurityState public API 2022-01-04 10:56:00 -07:00
libvirt_qemu.syms
libvirt_remote.syms rpc: Separate out socket code into another static lib 2021-12-15 12:12:43 +01:00
libvirt_sasl.syms
libvirt_socket.syms rpc: Separate out socket code into another static lib 2021-12-15 12:12:43 +01:00
libvirt_vmware.syms
libvirt_vmx.syms
libvirt-domain-checkpoint.c
libvirt-domain-snapshot.c domain_snapshot: update virDomainRevertToSnapshot description 2021-11-23 11:42:07 +01:00
libvirt-domain.c libvirt: Introduce virDomainSetLaunchSecurityState public API 2022-01-04 10:56:00 -07:00
libvirt-host.c
libvirt-interface.c
libvirt-lxc.c
libvirt-lxc.pc.in
libvirt-network.c
libvirt-nodedev.c
libvirt-nwfilter.c
libvirt-qemu.c
libvirt-qemu.pc.in
libvirt-secret.c
libvirt-storage.c
libvirt-stream.c libvirt-stream: Don't require RPC module 2021-12-15 12:12:43 +01:00
libvirt.c Dispatch error in virInitialize 2022-01-05 14:08:40 +01:00
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build meson: Add missing virt_install_dirs 2022-02-02 16:26:36 +01:00
qemu_protocol-structs
README
remote_protocol-structs remote: Add RPC support for the virDomainSetLaunchSecurityState API 2022-01-04 10:56:00 -07:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories