libvirt/src
John Ferlan c028c71930 conf: Add error checking to virDomainSnapshotDiskDefFormat
Commit id '43f2ccdc' called virDomainDiskSourceDefFormatInternal
rather than formatting the the disk source inline. However, it
did not handle the case where the helper failed. Over time the
helper has been renamed to virDomainDiskSourceFormat. Similar to
other consumers, if virDomainDiskSourceFormat fails, then the
formatting could be off, so it's better to fail than to continue
on with some possibly bad data. Alter the function and the caller
to check status and jump to error in that case.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
2018-04-19 14:23:39 -04:00
..
access virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
admin
bhyve virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
conf conf: Add error checking to virDomainSnapshotDiskDefFormat 2018-04-19 14:23:39 -04:00
cpu
esx driver: ensure URI path is non-NULL to simplify drivers 2018-04-12 16:52:02 +01:00
hyperv driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
interface virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
keycodemapdb@16e5b07876 keycodemapdb: Update submodule 2018-03-12 16:30:49 +01:00
libxl libxl: start using virDomainObjCheckActive 2018-04-18 10:22:07 +02:00
locking rpc: avoid duplicating config in virtlockd/virtlogd augeas tests 2018-03-23 10:44:48 +00:00
logging virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
lxc virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
network driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
node_device virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
nwfilter driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
openvz openvz: start using virDomainObjCheckActive 2018-04-18 10:22:07 +02:00
phyp driver: ensure URI path is non-NULL to simplify drivers 2018-04-12 16:52:02 +01:00
qemu qemu_capabilities: Separate out device props fetching 2018-04-19 18:11:56 +02:00
remote datatypes: Rename @parent to @parentName in virNodeDevice 2018-04-18 10:04:55 +02:00
rpc virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
secret driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
security virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
storage driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
test test: start using virDomainObjCheckActive 2018-04-18 10:22:07 +02:00
uml uml: start using virDomainObjCheckActive 2018-04-18 10:22:07 +02:00
util po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
vbox virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
vmware vmware: Failures in cache info init are non-fatal 2018-04-17 13:11:29 -04:00
vmx vmx: convert any amount of NICs 2018-04-01 12:43:42 +02:00
vz vz: build fix 2018-04-19 11:05:00 +03:00
xenapi driver: ensure NULL URI isn't passed to drivers with whitelisted URIs 2018-04-12 16:52:02 +01:00
xenconfig xenconfig: add CPUID handling to domXML <-> xl.cfg conversion 2018-04-17 21:15:27 -06:00
admin_protocol-structs
check-aclperms.pl
check-aclrules.pl acl: remove various left over Xen ACL whitelist entries 2018-04-16 10:29:36 +01:00
check-driverimpls.pl check scripts: handle unintialized driver vars in check-driverimpls.pl 2018-04-19 11:05:00 +03:00
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c virobject: Introduce VIR_CLASS_NEW() macro 2018-04-18 10:04:55 +02:00
datatypes.h src: Unify virObject member name 2018-04-18 10:04:55 +02:00
driver-hypervisor.h driver: introduce a driver method for probing default URIs 2018-04-12 16:52:02 +01:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h
driver.c
driver.h driver: declare supported URI schemes in virConnectDriver struct 2018-04-12 16:52:02 +01:00
dtrace2systemtap.pl
internal.h po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
libvirt_admin_private.syms
libvirt_admin_public.syms
libvirt_atomic.syms
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h driver: Add typedef for the anonymous enum used for driver features 2018-03-15 17:12:28 -04:00
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms Add function that raises error if domain is not active 2018-04-18 10:22:07 +02:00
libvirt_probes.d
libvirt_public.syms
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenconfig.syms
libvirt-admin.c po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
libvirt-admin.conf
libvirt-domain-snapshot.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-domain.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-host.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-interface.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-lxc.c
libvirt-lxc.pc.in
libvirt-network.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-nodedev.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-nwfilter.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-qemu.c
libvirt-qemu.pc.in
libvirt-secret.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-storage.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt-stream.c src: Unify virObject member name 2018-04-18 10:04:55 +02:00
libvirt.c po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am Remove the xend driver 2018-04-09 11:38:05 -06:00
qemu_protocol-structs
README
remote_protocol-structs datatypes: Rename @parent to @parentName in virNodeDevice 2018-04-18 10:04:55 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories