libvirt/src
Michal Privoznik c735ddf560 remoteClientCloseFunc: Don't mangle connection object refcount
Well, in 8ad126e6 we tried to fix a memory corruption problem.
However, the fix was not as good as it could be. I mean, the
commit has one line more than it should. I've noticed this output
just recently:

  # ./run valgrind --leak-check=full --show-reachable=yes ./tools/virsh domblklist gentoo
  ==17019== Memcheck, a memory error detector
  ==17019== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
  ==17019== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
  ==17019== Command: /home/zippy/work/libvirt/libvirt.git/tools/.libs/virsh domblklist gentoo
  ==17019==
  Target     Source
  ------------------------------------------------
  fda        /var/lib/libvirt/images/fd.img
  vda        /var/lib/libvirt/images/gentoo.qcow2
  hdc        /home/zippy/tmp/install-amd64-minimal-20150402.iso

  ==17019== Thread 2:
  ==17019== Invalid read of size 4
  ==17019==    at 0x4EFF5B4: virObjectUnref (virobject.c:258)
  ==17019==    by 0x5038CFF: remoteClientCloseFunc (remote_driver.c:552)
  ==17019==    by 0x5069D57: virNetClientCloseLocked (virnetclient.c:685)
  ==17019==    by 0x506C848: virNetClientIncomingEvent (virnetclient.c:1852)
  ==17019==    by 0x5082136: virNetSocketEventHandle (virnetsocket.c:1913)
  ==17019==    by 0x4ECD64E: virEventPollDispatchHandles (vireventpoll.c:509)
  ==17019==    by 0x4ECDE02: virEventPollRunOnce (vireventpoll.c:658)
  ==17019==    by 0x4ECBF00: virEventRunDefaultImpl (virevent.c:308)
  ==17019==    by 0x130386: vshEventLoop (vsh.c:1864)
  ==17019==    by 0x4F1EB07: virThreadHelper (virthread.c:206)
  ==17019==    by 0xA8462D3: start_thread (in /lib64/libpthread-2.20.so)
  ==17019==    by 0xAB441FC: clone (in /lib64/libc-2.20.so)
  ==17019==  Address 0x139023f4 is 4 bytes inside a block of size 240 free'd
  ==17019==    at 0x4C2B1F0: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  ==17019==    by 0x4EA8949: virFree (viralloc.c:582)
  ==17019==    by 0x4EFF6D0: virObjectUnref (virobject.c:273)
  ==17019==    by 0x4FE74D6: virConnectClose (libvirt.c:1390)
  ==17019==    by 0x13342A: virshDeinit (virsh.c:406)
  ==17019==    by 0x134A37: main (virsh.c:950)

The problem is, when registering remoteClientCloseFunc(), it's
conn->closeCallback which is ref'd. But in the function itself
it's conn->closeCallback->conn what is unref'd. This is causing
imbalance in reference counting. Moreover, there's no need for
the remote driver to increase/decrease conn refcount since it's
not used anywhere. It's just merely passed to client registered
callback. And for that purpose it's correctly ref'd in
virConnectRegisterCloseCallback() and then unref'd in
virConnectUnregisterCloseCallback().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit e689300770)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2015-09-03 17:45:42 +02:00
..
access event: filter global events by domain:getattr ACL [CVE-2014-0028] 2014-01-15 13:55:21 -07:00
conf domain_conf: fix domain deadlock 2014-10-01 11:10:15 -06:00
cpu cpu: x86: Add internal CPUID features support and KVM feature bits 2013-11-08 09:44:42 +01:00
esx src: Align make output 2013-12-04 09:41:33 +01:00
hyperv src: Align make output 2013-12-04 09:41:33 +01:00
interface interface: Take interface status into account when starting and destroying 2013-12-24 17:20:00 +01:00
libxl event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
locking Add Documentation fields to systemd service files 2014-01-09 09:32:55 +01:00
lxc CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC hotunplug code 2014-02-18 13:16:04 +00:00
network event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
node_device maint: fix comma style issues: remaining code 2013-11-20 09:14:55 -07:00
nwfilter Add a mutex to serialize updates to firewall 2014-03-10 11:57:52 +00:00
openvz Fix memory leak in openvz_conf.c 2014-01-15 11:11:34 +01:00
parallels Renamed virDomainEventState to virObjectEventState 2013-12-10 11:35:34 +00:00
phyp Fix possible memory leak in phyp_driver.c 2014-01-15 11:11:34 +01:00
qemu CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots 2015-01-22 11:09:24 -07:00
remote remoteClientCloseFunc: Don't mangle connection object refcount 2015-09-03 17:45:42 +02:00
rpc virNetClientSetTLSSession: Restore original signal mask 2014-03-19 14:34:04 -06:00
secret
security maint: improve VIR_ERR_NO_SUPPORT usage 2014-01-04 12:15:08 -07:00
storage storage: FS: Tweak some comments and fix typos 2014-01-13 21:24:03 +01:00
test event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
uml event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
util util: eliminate "use after free" in callers of virNetDevLinkDump 2014-11-12 14:55:40 -05:00
vbox event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
vmware vmware: os x support is broken 2014-01-03 11:13:43 -07:00
vmx Support transient attribute on vmware disks 2013-12-17 14:24:49 -07:00
xen event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
xenapi maint: fix comma style issues: xen 2013-11-20 09:14:54 -07:00
xenxs maint: fix comma style issues: xen 2013-11-20 09:14:54 -07:00
check-aclperms.pl Fix naming of permission for detecting storage pools 2013-09-12 17:20:07 +01:00
check-aclrules.pl event: move event filtering to daemon (regression fix) 2014-02-05 08:09:52 -07:00
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c maint: improve VIR_ERR_INVALID_DOMAIN usage 2014-01-07 14:38:12 -07:00
datatypes.h maint: improve VIR_ERR_INVALID_DOMAIN_SNAPSHOT usage 2014-01-09 14:47:02 -07:00
driver.c Remove all direct use of getenv 2013-10-21 14:03:52 +01:00
driver.h maint: Fix messy include of libvirt_internal.h 2014-01-07 10:03:14 +01:00
dtrace2systemtap.pl
fdstream.c Always open files in binary mode in virFDStreamOpenFileInternal 2013-09-24 14:27:41 +02:00
fdstream.h
gnutls_1_0_compat.h
internal.h maint: Fix messy include of libvirt_internal.h 2014-01-07 10:03:14 +01:00
libvirt_atomic.syms
libvirt_daemon.syms
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms Add helper for running code in separate namespaces 2014-02-18 13:15:41 +00:00
libvirt_probes.d
libvirt_public.syms Added Network events API and virNetworkEventLifecycle. 2013-12-11 13:10:41 +00:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms build: fix build --without-remote 2013-10-04 17:01:47 -06:00
libvirt_sasl.syms
libvirt_vmware.syms VMware: Make version parsing testable and add tests 2013-09-20 08:23:31 -05:00
libvirt_vmx.syms VMX: Create virVMXFormatDisk() from HD and CD-ROM 2013-09-01 23:11:50 -05:00
libvirt_xenxs.syms
libvirt-lxc.c maint: improve VIR_ERR_INVALID_DOMAIN usage 2014-01-07 14:38:12 -07:00
libvirt-qemu.c maint: improve VIR_ERR_INVALID_DOMAIN usage 2014-01-07 14:38:12 -07:00
libvirt.c CVE-2014-7823: dumpxml: security hole with migratable flag 2014-11-07 15:17:09 +01:00
libvirt.conf
lock_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_monitor_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_protocol-structs
Makefile.am Added Network events API and virNetworkEventLifecycle. 2013-12-11 13:10:41 +00:00
nodeinfo.c BSD: implement nodeGetMemoryStats 2014-01-07 06:26:33 -07:00
nodeinfo.h
qemu_protocol-structs
README
remote_protocol-structs event: wire up RPC for server-side network event filtering 2014-01-15 13:55:21 -07:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories