External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-12 14:41:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
libvirt/src/util
History
Michal Privoznik be1e745cd2 virfirewall: Fir a memleak in virFirewallParseXML() 
As a part of parsing XML, virFirewallParseXML() calls
virXMLNodeContentString() and then passes the return value
further. But virXMLNodeContentString() is documented so that it's
the caller's responsibility to free the returned string, which
virFirewallParseXML() never does. This leads to a memory leak:

  14,300 bytes in 220 blocks are definitely lost in loss record 1,879 of 1,891
     at 0x4841858: malloc (vg_replace_malloc.c:442)
     by 0x5491E3C: xmlBufCreateSize (in /usr/lib64/libxml2.so.2.12.6)
     by 0x54C2401: xmlNodeGetContent (in /usr/lib64/libxml2.so.2.12.6)
     by 0x49F7791: virXMLNodeContentString (virxml.c:354)
     by 0x4979F25: virFirewallParseXML (virfirewall.c:1134)
     by 0x4ABEB1E: virNetworkLoadState (virnetworkobj.c:938)
     by 0x4ABF35C: virNetworkObjLoadAllState (virnetworkobj.c:1072)
     by 0x4E9A25E: networkStateInitialize (bridge_driver.c:624)
     by 0x4CB1FA6: virStateInitialize (libvirt.c:665)
     by 0x15A6C6: daemonRunStateInit (remote_daemon.c:611)
     by 0x49E69F0: virThreadHelper (virthread.c:256)
     by 0x532B428: start_thread (in /lib64/libc.so.6)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
2024-06-19 16:31:23 +02:00
..
glibcompat.c
meson: Bump glib version to 2.58.0
2024-05-14 15:17:20 +02:00
glibcompat.h
meson: Bump glib version to 2.58.0
2024-05-14 15:17:20 +02:00
iohelper.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
meson.build
util/network: move viriptables.[ch] from util to network directory
2024-05-22 23:19:18 -04:00
viracpi.c
util: acpi: include unistd.h
2023-04-06 15:39:37 +02:00
viracpi.h
util: Introduce virAcpi module
2023-04-06 12:48:22 +02:00
viracpipriv.h
util: Introduce virAcpi module
2023-04-06 12:48:22 +02:00
viralloc.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
viralloc.h
…
virarch.c
Implement the method of getting host info for loongarch
2024-03-21 14:42:26 +01:00
virarch.h
Add loongarch cpu support
2024-03-21 14:42:20 +01:00
virarptable.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virarptable.h
…
viraudit.c
…
viraudit.h
…
virauth.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virauth.h
util: virauth: Export virAuthGetCredential
2023-01-23 16:32:26 +01:00
virauthconfig.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
virauthconfig.h
…
virbitmap.c
virbitmap: Introduce virBitmapParseUnlimitedAllowEmpty()
2024-05-06 15:26:58 +02:00
virbitmap.h
virbitmap: Introduce virBitmapParseUnlimitedAllowEmpty()
2024-05-06 15:26:58 +02:00
virbpf.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virbpf.h
…
virbuffer.c
…
virbuffer.h
…
virccw.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
virccw.h
…
vircgroup.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
vircgroup.h
…
vircgroupbackend.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
vircgroupbackend.h
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
vircgrouppriv.h
…
vircgroupv1.c
virCgroupV1GetBlkioIo(Device)Serviced: Refactor extraction of cgroup data
2023-04-14 15:20:14 +02:00
vircgroupv1.h
…
vircgroupv2.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
vircgroupv2.h
…
vircgroupv2devices.c
util: Move error messages onto a single line
2023-09-04 09:35:36 +02:00
vircgroupv2devices.h
…
vircommand.c
virGetGroupList: Refactor and fix callers
2024-05-23 14:32:24 +02:00
vircommand.h
util: make virCommandSetSendBuffer testable
2023-09-19 14:28:50 -05:00
vircommandpriv.h
util: make virCommandSetSendBuffer testable
2023-09-19 14:28:50 -05:00
virconf.c
src: Avoid needless checks before calling g_strdup()
2023-09-18 14:46:24 +02:00
virconf.h
…
vircrypto.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
vircrypto.h
…
virdaemon.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
virdaemon.h
…
virdevmapper.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virdevmapper.h
…
virdnsmasq.c
virStringParseVersion: Parse into 'unsigned long long'
2023-04-03 09:19:06 +02:00
virdnsmasq.h
…
virebtables.c
util/network: new virFirewallBackend enum
2024-05-22 23:19:18 -04:00
virebtables.h
…
virendian.h
…
virenum.c
…
virenum.h
…
virerror.c
Adding Public Get and Set APIs for Network Metadata
2023-08-25 12:36:37 +02:00
virerror.h
virerror: Make virReportEnumRangeError() check for type mismatch
2023-09-20 17:18:48 +02:00
virerrorpriv.h
…
virevent.c
…
virevent.h
…
vireventglib.c
…
vireventglib.h
…
vireventglibwatch.c
…
vireventglibwatch.h
…
vireventthread.c
util: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
vireventthread.h
…
virfcp.c
lib: Replace virBuildPath() with g_build_filename()
2023-10-17 08:32:13 +02:00
virfcp.h
…
virfdstream.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virfdstream.h
…
virfile.c
virFileOpenForked: Fix handling of return value from virSocketSendFD()
2024-05-23 14:32:24 +02:00
virfile.h
virfile: Introduce virFileReadValueBitmapAllowEmpty()
2024-05-06 15:29:36 +02:00
virfilecache.c
util: Allow virFileCache data to be any GObject
2023-09-19 14:28:49 -05:00
virfilecache.h
util: Allow virFileCache data to be any GObject
2023-09-19 14:28:49 -05:00
virfirewall.c
virfirewall: Fir a memleak in virFirewallParseXML()
2024-06-19 16:31:23 +02:00
virfirewall.h
network: introduce a "none" firewall backend type
2024-06-17 15:55:14 +01:00
virfirewalld.c
virfirewalld: Drop useless memset() in virFirewallDApplyRule()
2023-08-03 16:35:58 +02:00
virfirewalld.h
util: include virfirewall.h in virfirewalld.h
2023-05-10 14:41:53 +02:00
virfirewalldpriv.h
…
virfirmware.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virfirmware.h
…
virgdbus.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virgdbus.h
…
virgettext.c
…
virgettext.h
…
virgic.c
…
virgic.h
…
virglibutil.c
…
virglibutil.h
…
virhash.c
lib: Replace qsort() with g_qsort_with_data()
2023-11-24 09:53:14 +01:00
virhash.h
…
virhashcode.c
…
virhashcode.h
…
virhook.c
lib: Replace virBuildPath() with g_build_filename()
2023-10-17 08:32:13 +02:00
virhook.h
…
virhostcpu.c
virhostcpu: Introduce virHostCPUGetIsolated()
2024-05-06 15:36:17 +02:00
virhostcpu.h
virhostcpu: Introduce virHostCPUGetIsolated()
2024-05-06 15:36:17 +02:00
virhostcpupriv.h
…
virhostmem.c
virhostmem: Get total memory on macOS properly
2023-11-06 12:01:57 +01:00
virhostmem.h
…
virhostuptime.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virhostuptime.h
…
viridentity.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
viridentity.h
…
viridentitypriv.h
…
virinitctl.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virinitctl.h
…
viriscsi.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
viriscsi.h
…
virjson.c
util: json: Remove 'virJSONValueObjectReplaceValue'
2024-02-01 10:39:40 +01:00
virjson.h
util: json: Remove 'virJSONValueObjectReplaceValue'
2024-02-01 10:39:40 +01:00
virkeycode.c
…
virkeycode.h
…
virkmod.c
…
virkmod.h
…
virlease.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virlease.h
…
virlockspace.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virlockspace.h
…
virlog.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virlog.h
…
virmacaddr.c
conf: Generate MAC address instead of keeping all zeroes
2023-09-04 16:01:24 +02:00
virmacaddr.h
conf: Generate MAC address instead of keeping all zeroes
2023-09-04 16:01:24 +02:00
virmacmap.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virmacmap.h
…
virmdev.c
nodedev: reset active config data on udev remove event
2024-06-18 09:00:11 -05:00
virmdev.h
nodedev: reset active config data on udev remove event
2024-06-18 09:00:11 -05:00
virmodule.c
util: Update format strings in translated messages (part 2)
2023-04-01 11:40:35 +02:00
virmodule.h
…
virnetdev.c
util: Move error messages onto a single line
2023-09-04 09:35:36 +02:00
virnetdev.h
qemuxml2argvmock: Mock virNetDevSetMTU
2024-01-04 22:26:10 +01:00
virnetdevbandwidth.c
virnetdevbandwidth.c: Put a limit to "quantum"
2024-04-25 09:40:15 +02:00
virnetdevbandwidth.h
…
virnetdevbridge.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virnetdevbridge.h
…
virnetdevip.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virnetdevip.h
…
virnetdevmacvlan.c
Decrease scope of some variables
2023-08-03 16:35:11 +02:00
virnetdevmacvlan.h
virnetdevmacvlan: Drop G_GNUC_WARN_UNUSED_RESULT annotation for virNetDevMacVLanDeleteWithVPortProfile()
2023-02-01 15:44:20 +01:00
virnetdevmidonet.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virnetdevmidonet.h
…
virnetdevopenvswitch.c
virnetdevopenvswitch: Create OVS ports as transient
2024-04-24 13:13:07 +02:00
virnetdevopenvswitch.h
virnetdevopenvswitch: Drop @brname arg from virNetDevOpenvswitchRemovePort()
2024-04-12 20:45:00 +02:00
virnetdevpriv.h
…
virnetdevtap.c
virnetdevopenvswitch: Drop @brname arg from virNetDevOpenvswitchRemovePort()
2024-04-12 20:45:00 +02:00
virnetdevtap.h
…
virnetdevveth.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virnetdevveth.h
…
virnetdevvlan.c
…
virnetdevvlan.h
…
virnetdevvportprofile.c
virNetDevVPortProfileOp8021Qbh: Use proper type in virReportEnumRangeError()
2023-09-20 17:18:48 +02:00
virnetdevvportprofile.h
…
virnetlink.c
util: Move error messages onto a single line
2023-09-04 09:35:36 +02:00
virnetlink.h
…
virnodesuspend.c
util: add logging about node suspend availability
2023-07-20 11:01:08 +01:00
virnodesuspend.h
…
virnuma.c
virnuma: Avoid integer overflow in virNumaGetPages()
2023-11-24 16:35:19 +01:00
virnuma.h
qemuxml2argvmock: Drop virNuma* mocks
2023-03-15 12:46:36 +01:00
virnvme.c
util: use "stubDriverType" instead of just "stubDriver"
2023-08-24 23:36:18 -04:00
virnvme.h
…
virobject.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virobject.h
…
virpci.c
pci: Remove error reporting from PCI VPD parsing
2024-03-28 10:11:55 +01:00
virpci.h
pci: Remove error reporting from PCI VPD parsing
2024-03-28 10:11:55 +01:00
virpcivpd.c
virpcivpd: Revert error reporting from PCI VPD parser
2024-03-28 10:11:55 +01:00
virpcivpd.h
util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword
2024-01-31 17:24:07 +01:00
virpcivpdpriv.h
util: virpcivpd: Remove return value from virPCIVPDResourceCustomUpsertValue
2024-01-31 17:24:07 +01:00
virperf.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
virperf.h
…
virpidfile.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virpidfile.h
util: add quiet parameter to virPidFileAcquirePathFull
2023-03-08 12:16:56 +01:00
virpolkit.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virpolkit.h
…
virportallocator.c
util: virtportallocator: Add VIR_DEBUG statements for port allocations and release
2024-01-31 15:25:53 +01:00
virportallocator.h
…
virprobe.h
…
virprocess.c
virprocess: Debug affinity map in virProcessSetAffinity()
2024-06-17 12:30:39 +02:00
virprocess.h
virprocess: virProcessGetNamespaces() to void
2024-01-04 17:06:14 +01:00
virqemu.c
util: Move error messages onto a single line
2023-09-04 09:35:36 +02:00
virqemu.h
…
virrandom.c
virrandom: Accept "nodedev" driver in virRandomGenerateWWN()
2023-07-25 14:54:37 +02:00
virrandom.h
virrandommock: Drop virRandomGenerateWWN
2023-07-19 13:09:11 +02:00
virresctrl.c
lib: Replace qsort() with g_qsort_with_data()
2023-11-24 09:53:14 +01:00
virresctrl.h
…
virresctrlpriv.h
…
virrotatingfile.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virrotatingfile.h
…
virscsi.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virscsi.h
…
virscsihost.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virscsihost.h
…
virscsivhost.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virscsivhost.h
…
virseclabel.c
…
virseclabel.h
…
virsecret.c
tests: Rename 'qemuxml2argvtest' to 'qemuxmlconftest'
2024-01-17 17:31:12 +01:00
virsecret.h
…
virsecureerase.c
…
virsecureerase.h
…
virsocket.c
virsocket: Simplify virSocketSendFD()
2024-02-07 12:34:54 +01:00
virsocket.h
virSocketSendMsgWithFDs: Introduce @payload_len argument
2024-02-07 11:01:30 +01:00
virsocketaddr.c
util: Introduce virSocketAddrBytes
2024-02-07 14:19:42 +01:00
virsocketaddr.h
util: Introduce virSocketAddrBytes
2024-02-07 14:19:42 +01:00
virstoragefile.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virstoragefile.h
…
virstring.c
lib: Replace qsort() with g_qsort_with_data()
2023-11-24 09:53:14 +01:00
virstring.h
lib: Replace qsort() with g_qsort_with_data()
2023-11-24 09:53:14 +01:00
virsysinfo.c
virsysinfo: Try reading DMI table
2024-04-02 16:58:47 -06:00
virsysinfo.h
…
virsysinfopriv.h
…
virsystemd.c
util: Introduce virSystemdResolvedRegisterNameServer
2024-02-07 14:19:42 +01:00
virsystemd.h
util: Introduce virSystemdResolvedRegisterNameServer
2024-02-07 14:19:42 +01:00
virsystemdpriv.h
util: Introduce virSystemdHasResolved
2024-02-07 14:19:42 +01:00
virthread.c
…
virthread.h
…
virthreadjob.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virthreadjob.h
…
virthreadpool.c
virthreadpool: create threads from the newly expanded workers
2024-03-18 15:12:46 +01:00
virthreadpool.h
…
virtime.c
…
virtime.h
…
virtpm.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virtpm.h
…
virtypedparam-public.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virtypedparam.c
lib: Replace qsort() with g_qsort_with_data()
2023-11-24 09:53:14 +01:00
virtypedparam.h
virTypedParamsValidate: Allow typed params to be both _UINT and _ULLONG
2023-05-02 14:32:47 +02:00
viruri.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
viruri.h
viruri: Introduce virURIParamsSetIgnore()
2023-02-08 16:50:45 +01:00
virusb.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virusb.h
…
virutil.c
virGetGroupList: Refactor and fix callers
2024-05-23 14:32:24 +02:00
virutil.h
util: add virGetSubUIDs
2023-12-14 17:10:22 +01:00
viruuid.c
Decrease scope of some variables
2023-08-03 16:35:11 +02:00
viruuid.h
…
virvhba.c
util: Update format strings in translated messages (part 3)
2023-04-01 11:40:35 +02:00
virvhba.h
…
virvsock.c
…
virvsock.h
…
virxdrdefs.h
…
virxml.c
util: xml: Return GPtrArray from virXMLNodeGetSubelement
2024-01-08 09:27:31 +01:00
virxml.h
util: xml: Return GPtrArray from virXMLNodeGetSubelement
2024-01-08 09:27:31 +01:00